[PATCH] Staging: slicoss: Fix quoted sting split across the line

[PATCH] Staging: slicoss: Fix quoted sting split across the line

[Ksenija Stanojevic]

This patch fixes the warning issued by checkpatch.pl
by adding split string with '+'.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 42d62ef..5594cbb 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -99,7 +99,7 @@
 #include "slic.h"
 
 static uint slic_first_init = 1;
-static char *slic_banner = "Alacritech SLIC Technology(tm) Server "
+static char *slic_banner = "Alacritech SLIC Technology(tm) Server"+
 		"and Storage Accelerator (Non-Accelerated)";
 
 static char *slic_proc_version = "2.0.351  2006/07/14 12:26:00";
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: slicoss: Fix quoted sting split across the line

[Julia Lawall]

On Mon, 23 Feb 2015, Ksenija Stanojevic wrote:

> This patch fixes the warning issued by checkpatch.pl
> by adding split string with '+'.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 42d62ef..5594cbb 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -99,7 +99,7 @@
>  #include "slic.h"
>
>  static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server "
> +static char *slic_banner = "Alacritech SLIC Technology(tm) Server"+
>  		"and Storage Accelerator (Non-Accelerated)";

+ is not the way of concatenating strings in C.  It will just add the
pointers together.  And if it did work, you would have removed
the space between Server and and.  Checkpatch is suggesting that you just
concatenate the strings to make one big string, even though it will exceed
80 columns.  The idea is that the ability to grep for the string, without
worrying about where it is cut up, is more beneficial than respecting 80
columns in this case.

julia

>
>  static char *slic_proc_version = "2.0.351  2006/07/14 12:26:00";
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424710271-3310-1-git-send-email-ksenija.stanojevic%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>