All of lore.kernel.org
 help / color / mirror / Atom feed
* [Cluster-devel] [PATCH 1/5] fsck.gfs2: Fix memory leaks in pass1_process_rgrp
@ 2015-02-23 18:43 Andrew Price
  2015-02-23 18:43 ` [Cluster-devel] [PATCH 2/5] libgfs2: Use the correct parent for rgrp tree insertion Andrew Price
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Andrew Price @ 2015-02-23 18:43 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Spotted by coverity: "Variable ibuf going out of scope leaks the storage
it points to"

Signed-off-by: Andrew Price <anprice@redhat.com>
---
 gfs2/fsck/pass1.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/gfs2/fsck/pass1.c b/gfs2/fsck/pass1.c
index b516a21..69c88f4 100644
--- a/gfs2/fsck/pass1.c
+++ b/gfs2/fsck/pass1.c
@@ -1625,7 +1625,10 @@ static int pass1_process_rgrp(struct gfs2_sbd *sdp, struct rgrp_tree *rgd)
 {
 	unsigned k, n, i;
 	uint64_t *ibuf = malloc(sdp->bsize * GFS2_NBBY * sizeof(uint64_t));
-	int ret;
+	int ret = 0;
+
+	if (ibuf == NULL)
+		return FSCK_ERROR;
 
 	for (k = 0; k < rgd->ri.ri_length; k++) {
 		n = lgfs2_bm_scan(rgd, k, ibuf, GFS2_BLKST_DINODE);
@@ -1633,11 +1636,11 @@ static int pass1_process_rgrp(struct gfs2_sbd *sdp, struct rgrp_tree *rgd)
 		if (n) {
 			ret = pass1_process_bitmap(sdp, rgd, ibuf, n);
 			if (ret)
-				return ret;
+				goto out;
 		}
 
 		if (fsck_abort)
-			return 0;
+			goto out;
 		/*
 		  For GFS1, we have to count the "free meta" blocks in the
 		  resource group and mark them specially so we can count them
@@ -1650,12 +1653,13 @@ static int pass1_process_rgrp(struct gfs2_sbd *sdp, struct rgrp_tree *rgd)
 		for (i = 0; i < n; i++) {
 			gfs2_blockmap_set(bl, ibuf[i], GFS2_BLKST_UNLINKED);
 			if (fsck_abort)
-				return 0;
+				goto out;
 		}
 	}
 
+out:
 	free(ibuf);
-	return 0;
+	return ret;
 }
 
 /**
-- 
1.9.3



^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-02-23 19:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-23 18:43 [Cluster-devel] [PATCH 1/5] fsck.gfs2: Fix memory leaks in pass1_process_rgrp Andrew Price
2015-02-23 18:43 ` [Cluster-devel] [PATCH 2/5] libgfs2: Use the correct parent for rgrp tree insertion Andrew Price
2015-02-23 18:43 ` [Cluster-devel] [PATCH 3/5] libgfs2: Remove some obsolete function declarations Andrew Price
2015-02-23 18:43 ` [Cluster-devel] [PATCH 4/5] gfs2-utils: Move metafs handling into gfs2/mkfs/ Andrew Price
2015-02-23 18:43 ` [Cluster-devel] [PATCH 5/5] gfs2_grow/jadd: Use a matching context mount option in mount_gfs2_meta Andrew Price
2015-02-23 19:17 ` [Cluster-devel] [PATCH 1/5] fsck.gfs2: Fix memory leaks in pass1_process_rgrp Bob Peterson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.