* [PATCH] Staging: iio: Move export_symbol below its function
@ 2015-02-23 23:18 Melike Yurtoglu
2015-02-24 4:51 ` [Outreachy kernel] " Preeti U Murthy
0 siblings, 1 reply; 2+ messages in thread
From: Melike Yurtoglu @ 2015-02-23 23:18 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Melike Yurtoglu
WARNING: "EXPORT_SYMBOL(foo); should immediately follow its
function/variable"
That was found by running checkpatch.
Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
---
drivers/staging/iio/addac/adt7316.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 5b11b42..18bfbf0 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -2069,6 +2069,7 @@ static struct attribute_group adt7516_event_attribute_group = {
};
#ifdef CONFIG_PM_SLEEP
+EXPORT_SYMBOL_GPL(adt7316_pm_ops);
static int adt7316_disable(struct device *dev)
{
struct iio_dev *dev_info = dev_get_drvdata(dev);
@@ -2086,7 +2087,6 @@ static int adt7316_enable(struct device *dev)
}
SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
-EXPORT_SYMBOL_GPL(adt7316_pm_ops);
#endif
static const struct iio_info adt7316_info = {
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: iio: Move export_symbol below its function
2015-02-23 23:18 [PATCH] Staging: iio: Move export_symbol below its function Melike Yurtoglu
@ 2015-02-24 4:51 ` Preeti U Murthy
0 siblings, 0 replies; 2+ messages in thread
From: Preeti U Murthy @ 2015-02-24 4:51 UTC (permalink / raw)
To: Melike Yurtoglu, outreachy-kernel
Hi Melike,
On 02/24/2015 04:48 AM, Melike Yurtoglu wrote:
> WARNING: "EXPORT_SYMBOL(foo); should immediately follow its
> function/variable"
> That was found by running checkpatch.
>
> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
> ---
> drivers/staging/iio/addac/adt7316.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 5b11b42..18bfbf0 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -2069,6 +2069,7 @@ static struct attribute_group adt7516_event_attribute_group = {
> };
>
> #ifdef CONFIG_PM_SLEEP
> +EXPORT_SYMBOL_GPL(adt7316_pm_ops);
> static int adt7316_disable(struct device *dev)
> {
> struct iio_dev *dev_info = dev_get_drvdata(dev);
> @@ -2086,7 +2087,6 @@ static int adt7316_enable(struct device *dev)
> }
>
> SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
> -EXPORT_SYMBOL_GPL(adt7316_pm_ops);
The EXPORT_SYMBOL() is rightly under the variable definition -
adt7316_pm_ops. So why this cleanup?
Regards
Preeti U Murthy
> #endif
>
> static const struct iio_info adt7316_info = {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-24 4:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-23 23:18 [PATCH] Staging: iio: Move export_symbol below its function Melike Yurtoglu
2015-02-24 4:51 ` [Outreachy kernel] " Preeti U Murthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.