* [PATCH 0/2] backlight: pwm: Add backlight-boot-off property
@ 2015-02-26 3:12 ` huang lin
0 siblings, 0 replies; 12+ messages in thread
From: huang lin @ 2015-02-26 3:12 UTC (permalink / raw)
To: djkurtz
Cc: linux-rockchip, huang lin, devicetree, linux-fbdev,
Thierry Reding, Jingoo Han, Kumar Gala,
Jean-Christophe Plagniol-Villard, linux-kernel, Ian Campbell,
Rob Herring, linux-pwm, Tomi Valkeinen, Pawel Moll, Lee Jones,
Mark Rutland
Add backlight-boot-off property, so we can keeping the
backlight disabled at boot until it is enabled implicitly
by a panel driver, or explicitly by userspace
huang lin (2):
Documentation: devicetree: add backlight-boot-off property in
pwm-backlight
backlight: pwm: Add backlight-boot-off property
Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt | 1 +
drivers/video/backlight/pwm_bl.c | 4 ++++
2 files changed, 5 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] backlight: pwm: Add backlight-boot-off property
@ 2015-02-26 3:12 ` huang lin
0 siblings, 0 replies; 12+ messages in thread
From: huang lin @ 2015-02-26 3:12 UTC (permalink / raw)
To: djkurtz-F7+t8E8rja9g9hUCZPvPmw
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, huang lin,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA, Thierry Reding, Jingoo Han,
Kumar Gala, Jean-Christophe Plagniol-Villard,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Ian Campbell, Rob Herring,
linux-pwm-u79uwXL29TY76Z2rM5mHXA, Tomi Valkeinen, Pawel Moll,
Lee Jones, Mark Rutland
Add backlight-boot-off property, so we can keeping the
backlight disabled at boot until it is enabled implicitly
by a panel driver, or explicitly by userspace
huang lin (2):
Documentation: devicetree: add backlight-boot-off property in
pwm-backlight
backlight: pwm: Add backlight-boot-off property
Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt | 1 +
drivers/video/backlight/pwm_bl.c | 4 ++++
2 files changed, 5 insertions(+)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] backlight: pwm: Add backlight-boot-off property
@ 2015-02-26 3:12 ` huang lin
0 siblings, 0 replies; 12+ messages in thread
From: huang lin @ 2015-02-26 3:12 UTC (permalink / raw)
To: djkurtz-F7+t8E8rja9g9hUCZPvPmw
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, huang lin,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA, Thierry Reding, Jingoo Han,
Kumar Gala, Jean-Christophe Plagniol-Villard,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Ian Campbell, Rob Herring,
linux-pwm-u79uwXL29TY76Z2rM5mHXA, Tomi Valkeinen, Pawel Moll,
Lee Jones, Mark Rutland
Add backlight-boot-off property, so we can keeping the
backlight disabled at boot until it is enabled implicitly
by a panel driver, or explicitly by userspace
huang lin (2):
Documentation: devicetree: add backlight-boot-off property in
pwm-backlight
backlight: pwm: Add backlight-boot-off property
Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt | 1 +
drivers/video/backlight/pwm_bl.c | 4 ++++
2 files changed, 5 insertions(+)
--
1.9.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] Documentation: devicetree: add backlight-boot-off property in pwm-backlight
2015-02-26 3:12 ` huang lin
(?)
(?)
@ 2015-02-26 3:12 ` huang lin
-1 siblings, 0 replies; 12+ messages in thread
From: huang lin @ 2015-02-26 3:12 UTC (permalink / raw)
To: djkurtz
Cc: linux-rockchip, huang lin, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, devicetree, linux-kernel
Add the backlight-boot-ff property, so we can keeping the backlight
disabled at boot until it is enabled implicitly by a panel driver,
or explicitly by userspace.
Signed-off-by: huang lin <hl@rock-chips.com>
---
Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
index 764db86..28b0b4d 100644
--- a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
+++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
@@ -17,6 +17,7 @@ Optional properties:
"pwms" property (see PWM binding[0])
- enable-gpios: contains a single GPIO specifier for the GPIO which enables
and disables the backlight (see GPIO binding[1])
+ - backlight-boot-off: turn off backlight when pwm backlight probe
[0]: Documentation/devicetree/bindings/pwm/pwm.txt
[1]: Documentation/devicetree/bindings/gpio/gpio.txt
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
2015-02-26 3:12 ` huang lin
@ 2015-02-26 3:39 ` huang lin
-1 siblings, 0 replies; 12+ messages in thread
From: huang lin @ 2015-02-26 3:39 UTC (permalink / raw)
To: djkurtz
Cc: thierry.reding, jg1.han, lee.jones, linux-pwm, linux-fbdev,
linux-rockchip, huang lin
Add backlight-boot-off property, so we can keeping the
backlight disabled at boot until it is enabled implicitly
by a panel driver, or explicitly by userspace
Signed-off-by: huang lin <hl@rock-chips.com>
---
drivers/video/backlight/pwm_bl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 3a145a6..dece351 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
}
bl->props.brightness = data->dft_brightness;
+
+ if (of_find_property(pdev->dev.of_node, "backlight-boot-off", NULL))
+ bl->props.power = FB_BLANK_POWERDOWN;
+
backlight_update_status(bl);
platform_set_drvdata(pdev, bl);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
@ 2015-02-26 3:39 ` huang lin
0 siblings, 0 replies; 12+ messages in thread
From: huang lin @ 2015-02-26 3:39 UTC (permalink / raw)
To: djkurtz
Cc: thierry.reding, jg1.han, lee.jones, linux-pwm, linux-fbdev,
linux-rockchip, huang lin
Add backlight-boot-off property, so we can keeping the
backlight disabled at boot until it is enabled implicitly
by a panel driver, or explicitly by userspace
Signed-off-by: huang lin <hl@rock-chips.com>
---
drivers/video/backlight/pwm_bl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 3a145a6..dece351 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
}
bl->props.brightness = data->dft_brightness;
+
+ if (of_find_property(pdev->dev.of_node, "backlight-boot-off", NULL))
+ bl->props.power = FB_BLANK_POWERDOWN;
+
backlight_update_status(bl);
platform_set_drvdata(pdev, bl);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
2015-02-26 3:39 ` huang lin
@ 2015-02-26 5:59 ` Ajay kumar
-1 siblings, 0 replies; 12+ messages in thread
From: Ajay kumar @ 2015-02-26 5:47 UTC (permalink / raw)
To: huang lin
Cc: Daniel Kurtz, Thierry Reding, Jingoo Han, Lee Jones, linux-pwm,
linux-fbdev, linux-rockchip
Hi Huang,
On Thu, Feb 26, 2015 at 9:09 AM, huang lin <hl@rock-chips.com> wrote:
> Add backlight-boot-off property, so we can keeping the
> backlight disabled at boot until it is enabled implicitly
> by a panel driver, or explicitly by userspace
>
> Signed-off-by: huang lin <hl@rock-chips.com>
>
> ---
>
> drivers/video/backlight/pwm_bl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 3a145a6..dece351 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> }
>
> bl->props.brightness = data->dft_brightness;
> +
> + if (of_find_property(pdev->dev.of_node, "backlight-boot-off", NULL))
> + bl->props.power = FB_BLANK_POWERDOWN;
> +
You need to check this. Originally, Thierry proposed it.
http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
> backlight_update_status(bl);
>
> platform_set_drvdata(pdev, bl);
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
@ 2015-02-26 5:59 ` Ajay kumar
0 siblings, 0 replies; 12+ messages in thread
From: Ajay kumar @ 2015-02-26 5:59 UTC (permalink / raw)
To: huang lin
Cc: Daniel Kurtz, Thierry Reding, Jingoo Han, Lee Jones, linux-pwm,
linux-fbdev, linux-rockchip
Hi Huang,
On Thu, Feb 26, 2015 at 9:09 AM, huang lin <hl@rock-chips.com> wrote:
> Add backlight-boot-off property, so we can keeping the
> backlight disabled at boot until it is enabled implicitly
> by a panel driver, or explicitly by userspace
>
> Signed-off-by: huang lin <hl@rock-chips.com>
>
> ---
>
> drivers/video/backlight/pwm_bl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 3a145a6..dece351 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> }
>
> bl->props.brightness = data->dft_brightness;
> +
> + if (of_find_property(pdev->dev.of_node, "backlight-boot-off", NULL))
> + bl->props.power = FB_BLANK_POWERDOWN;
> +
You need to check this. Originally, Thierry proposed it.
http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
> backlight_update_status(bl);
>
> platform_set_drvdata(pdev, bl);
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
2015-02-26 5:59 ` Ajay kumar
@ 2015-02-26 8:06 ` hl
-1 siblings, 0 replies; 12+ messages in thread
From: hl @ 2015-02-26 8:06 UTC (permalink / raw)
To: Ajay kumar
Cc: Daniel Kurtz, Thierry Reding, Jingoo Han, Lee Jones, linux-pwm,
linux-fbdev, linux-rockchip
On 2015年02月26日 13:47, Ajay kumar wrote:
> Hi Huang,
>
> On Thu, Feb 26, 2015 at 9:09 AM, huang lin <hl@rock-chips.com> wrote:
>> Add backlight-boot-off property, so we can keeping the
>> backlight disabled at boot until it is enabled implicitly
>> by a panel driver, or explicitly by userspace
>>
>> Signed-off-by: huang lin <hl@rock-chips.com>
>>
>> ---
>>
>> drivers/video/backlight/pwm_bl.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
>> index 3a145a6..dece351 100644
>> --- a/drivers/video/backlight/pwm_bl.c
>> +++ b/drivers/video/backlight/pwm_bl.c
>> @@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>> }
>>
>> bl->props.brightness = data->dft_brightness;
>> +
>> + if (of_find_property(pdev->dev.of_node, "backlight-boot-off", NULL))
>> + bl->props.power = FB_BLANK_POWERDOWN;
>> +
> You need to check this. Originally, Thierry proposed it.
> http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
I have applied Thierry patch , and it can work. I think it should be
merged, since i use three type of edp panels,
they have same issue: when the backlight probe, the panel will visual
glitches.
>
>> backlight_update_status(bl);
>>
>> platform_set_drvdata(pdev, bl);
>> --
>> 1.9.1
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
黄林
福州瑞芯微电子有限公司
Fuzhou Rockchip Electronics Co.Ltd
福建省福州市铜盘路软件大道89号软件园A区21号楼(350003)
Addr:No.21 Building, A District, No.89, software Boulevard Fuzhou, Fujian,PRC
Email:hl@rock-chips.com
Tel:+86-591-83991906/07
****************************************************************************************
保密提示:本邮件及其附件含有机密信息,仅发送给本邮件所指特定收件人。若非该特定收件人,请
勿复制、 使用或披露本邮件的任何内容。若误收本邮件,请从系统中永久性删除本邮件及所有附件,
并以回复邮件或其他方式即刻告知发件人。福州瑞芯微电子有限公司拥有本邮件信息的著作权及解释
权,禁止任何未经授权许可的侵权行为。
IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents
of this email and any attachments may contain information that is privileged, confidential
and/or exempt from disclosure under applicable law and relevant NDA. If you are not the
intended recipient, you are hereby notified that any disclosure, copying, distribution,
or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender
as soon as possible and destroy the material in its entirety in any format. Thank you.
********************************************************************************
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
@ 2015-02-26 8:06 ` hl
0 siblings, 0 replies; 12+ messages in thread
From: hl @ 2015-02-26 8:06 UTC (permalink / raw)
To: Ajay kumar
Cc: Daniel Kurtz, Thierry Reding, Jingoo Han, Lee Jones, linux-pwm,
linux-fbdev, linux-rockchip
On 2015年02月26日 13:47, Ajay kumar wrote:
> Hi Huang,
>
> On Thu, Feb 26, 2015 at 9:09 AM, huang lin <hl@rock-chips.com> wrote:
>> Add backlight-boot-off property, so we can keeping the
>> backlight disabled at boot until it is enabled implicitly
>> by a panel driver, or explicitly by userspace
>>
>> Signed-off-by: huang lin <hl@rock-chips.com>
>>
>> ---
>>
>> drivers/video/backlight/pwm_bl.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
>> index 3a145a6..dece351 100644
>> --- a/drivers/video/backlight/pwm_bl.c
>> +++ b/drivers/video/backlight/pwm_bl.c
>> @@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct platform_device *pdev)
>> }
>>
>> bl->props.brightness = data->dft_brightness;
>> +
>> + if (of_find_property(pdev->dev.of_node, "backlight-boot-off", NULL))
>> + bl->props.power = FB_BLANK_POWERDOWN;
>> +
> You need to check this. Originally, Thierry proposed it.
> http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
I have applied Thierry patch , and it can work. I think it should be
merged, since i use three type of edp panels,
they have same issue: when the backlight probe, the panel will visual
glitches.
>
>> backlight_update_status(bl);
>>
>> platform_set_drvdata(pdev, bl);
>> --
>> 1.9.1
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
黄林
福州瑞芯微电子有限公司
Fuzhou Rockchip Electronics Co.Ltd
福建省福州市铜盘路软件大道89号软件园A区21号楼(350003)
Addr:No.21 Building, A District, No.89, software Boulevard Fuzhou, Fujian,PRC
Email:hl@rock-chips.com
Tel:+86-591-83991906/07
****************************************************************************************
保密提示:本邮件及其附件含有机密信息,仅发送给本邮件所指特定收件人。若非该特定收件人,请
勿复制、 使用或披露本邮件的任何内容。若误收本邮件,请从系统中永久性删除本邮件及所有附件,
并以回复邮件或其他方式即刻告知发件人。福州瑞芯微电子有限公司拥有本邮件信息的著作权及解释
权,禁止任何未经授权许可的侵权行为。
IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents
of this email and any attachments may contain information that is privileged, confidential
and/or exempt from disclosure under applicable law and relevant NDA. If you are not the
intended recipient, you are hereby notified that any disclosure, copying, distribution,
or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender
as soon as possible and destroy the material in its entirety in any format. Thank you.
********************************************************************************
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
2015-02-26 8:06 ` hl
@ 2015-02-26 8:25 ` Ajay kumar
-1 siblings, 0 replies; 12+ messages in thread
From: Ajay kumar @ 2015-02-26 8:13 UTC (permalink / raw)
To: hl
Cc: Daniel Kurtz, Thierry Reding, Jingoo Han, Lee Jones, linux-pwm,
linux-fbdev, linux-rockchip
On Thu, Feb 26, 2015 at 1:36 PM, hl <hl@rock-chips.com> wrote:
>
> On 2015年02月26日 13:47, Ajay kumar wrote:
>>
>> Hi Huang,
>>
>> On Thu, Feb 26, 2015 at 9:09 AM, huang lin <hl@rock-chips.com> wrote:
>>>
>>> Add backlight-boot-off property, so we can keeping the
>>> backlight disabled at boot until it is enabled implicitly
>>> by a panel driver, or explicitly by userspace
>>>
>>> Signed-off-by: huang lin <hl@rock-chips.com>
>>>
>>> ---
>>>
>>> drivers/video/backlight/pwm_bl.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/video/backlight/pwm_bl.c
>>> b/drivers/video/backlight/pwm_bl.c
>>> index 3a145a6..dece351 100644
>>> --- a/drivers/video/backlight/pwm_bl.c
>>> +++ b/drivers/video/backlight/pwm_bl.c
>>> @@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct
>>> platform_device *pdev)
>>> }
>>>
>>> bl->props.brightness = data->dft_brightness;
>>> +
>>> + if (of_find_property(pdev->dev.of_node, "backlight-boot-off",
>>> NULL))
>>> + bl->props.power = FB_BLANK_POWERDOWN;
>>> +
>>
>> You need to check this. Originally, Thierry proposed it.
>> http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
>
> I have applied Thierry patch , and it can work. I think it should be merged,
> since i use three type of edp panels,
> they have same issue: when the backlight probe, the panel will visual
> glitches.
Right, the same problem exists on Exynos5800-peach-pi display!
I had tested this long back, and I think its not merged since the DT property
has an issue that "it doesn't really represent h/w property of the device".
>>
>>> backlight_update_status(bl);
>>>
>>> platform_set_drvdata(pdev, bl);
>>> --
>>> 1.9.1
>>>
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>>
>
> --
> 黄林
> 福州瑞芯微电子有限公司
> Fuzhou Rockchip Electronics Co.Ltd
> 福建省福州市铜盘路软件大道89号软件园A区21号楼(350003)
> Addr:No.21 Building, A District, No.89, software Boulevard Fuzhou,
> Fujian,PRC
> Email:hl@rock-chips.com
> Tel:+86-591-83991906/07
>
> ****************************************************************************************
> 保密提示:本邮件及其附件含有机密信息,仅发送给本邮件所指特定收件人。若非该特定收件人,请
> 勿复制、 使用或披露本邮件的任何内容。若误收本邮件,请从系统中永久性删除本邮件及所有附件,
> 并以回复邮件或其他方式即刻告知发件人。福州瑞芯微电子有限公司拥有本邮件信息的著作权及解释
> 权,禁止任何未经授权许可的侵权行为。
> IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd
> .The contents
> of this email and any attachments may contain information that is
> privileged, confidential
> and/or exempt from disclosure under applicable law and relevant NDA. If you
> are not the
> intended recipient, you are hereby notified that any disclosure, copying,
> distribution,
> or use of the information is STRICTLY PROHIBITED. Please immediately contact
> the sender
> as soon as possible and destroy the material in its entirety in any format.
> Thank you.
> ********************************************************************************
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] backlight: pwm: Add backlight-boot-off property
@ 2015-02-26 8:25 ` Ajay kumar
0 siblings, 0 replies; 12+ messages in thread
From: Ajay kumar @ 2015-02-26 8:25 UTC (permalink / raw)
To: hl
Cc: Daniel Kurtz, Thierry Reding, Jingoo Han, Lee Jones, linux-pwm,
linux-fbdev, linux-rockchip
On Thu, Feb 26, 2015 at 1:36 PM, hl <hl@rock-chips.com> wrote:
>
> On 2015年02月26日 13:47, Ajay kumar wrote:
>>
>> Hi Huang,
>>
>> On Thu, Feb 26, 2015 at 9:09 AM, huang lin <hl@rock-chips.com> wrote:
>>>
>>> Add backlight-boot-off property, so we can keeping the
>>> backlight disabled at boot until it is enabled implicitly
>>> by a panel driver, or explicitly by userspace
>>>
>>> Signed-off-by: huang lin <hl@rock-chips.com>
>>>
>>> ---
>>>
>>> drivers/video/backlight/pwm_bl.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/video/backlight/pwm_bl.c
>>> b/drivers/video/backlight/pwm_bl.c
>>> index 3a145a6..dece351 100644
>>> --- a/drivers/video/backlight/pwm_bl.c
>>> +++ b/drivers/video/backlight/pwm_bl.c
>>> @@ -319,6 +319,10 @@ static int pwm_backlight_probe(struct
>>> platform_device *pdev)
>>> }
>>>
>>> bl->props.brightness = data->dft_brightness;
>>> +
>>> + if (of_find_property(pdev->dev.of_node, "backlight-boot-off",
>>> NULL))
>>> + bl->props.power = FB_BLANK_POWERDOWN;
>>> +
>>
>> You need to check this. Originally, Thierry proposed it.
>> http://permalink.gmane.org/gmane.linux.drivers.devicetree/84604
>
> I have applied Thierry patch , and it can work. I think it should be merged,
> since i use three type of edp panels,
> they have same issue: when the backlight probe, the panel will visual
> glitches.
Right, the same problem exists on Exynos5800-peach-pi display!
I had tested this long back, and I think its not merged since the DT property
has an issue that "it doesn't really represent h/w property of the device".
>>
>>> backlight_update_status(bl);
>>>
>>> platform_set_drvdata(pdev, bl);
>>> --
>>> 1.9.1
>>>
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>>
>
> --
> 黄林
> 福州瑞芯微电子有限公司
> Fuzhou Rockchip Electronics Co.Ltd
> 福建省福州市铜盘路软件大道89号软件园A区21号楼(350003)
> Addr:No.21 Building, A District, No.89, software Boulevard Fuzhou,
> Fujian,PRC
> Email:hl@rock-chips.com
> Tel:+86-591-83991906/07
>
> ****************************************************************************************
> 保密提示:本邮件及其附件含有机密信息,仅发送给本邮件所指特定收件人。若非该特定收件人,请
> 勿复制、 使用或披露本邮件的任何内容。若误收本邮件,请从系统中永久性删除本邮件及所有附件,
> 并以回复邮件或其他方式即刻告知发件人。福州瑞芯微电子有限公司拥有本邮件信息的著作权及解释
> 权,禁止任何未经授权许可的侵权行为。
> IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd
> .The contents
> of this email and any attachments may contain information that is
> privileged, confidential
> and/or exempt from disclosure under applicable law and relevant NDA. If you
> are not the
> intended recipient, you are hereby notified that any disclosure, copying,
> distribution,
> or use of the information is STRICTLY PROHIBITED. Please immediately contact
> the sender
> as soon as possible and destroy the material in its entirety in any format.
> Thank you.
> ********************************************************************************
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-02-26 8:25 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-26 3:12 [PATCH 0/2] backlight: pwm: Add backlight-boot-off property huang lin
2015-02-26 3:12 ` huang lin
2015-02-26 3:12 ` huang lin
2015-02-26 3:12 ` [PATCH 1/2] Documentation: devicetree: add backlight-boot-off property in pwm-backlight huang lin
2015-02-26 3:39 ` [PATCH 2/2] backlight: pwm: Add backlight-boot-off property huang lin
2015-02-26 3:39 ` huang lin
2015-02-26 5:47 ` Ajay kumar
2015-02-26 5:59 ` Ajay kumar
2015-02-26 8:06 ` hl
2015-02-26 8:06 ` hl
2015-02-26 8:13 ` Ajay kumar
2015-02-26 8:25 ` Ajay kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.