* [PATCH] Staging: android: uapi: Fix do not add new typedefs
@ 2015-02-26 19:28 Yeliz Taneroglu
2015-02-26 20:00 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Yeliz Taneroglu @ 2015-02-26 19:28 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Yeliz Taneroglu
Fix checkpatch.pl issues with
do not add new typedefs in ion.h
Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
drivers/staging/android/uapi/ion.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 6aa4956..7e7f87e 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -20,7 +20,7 @@
#include <linux/ioctl.h>
#include <linux/types.h>
-typedef int ion_user_handle_t;
+int ion_user_handle_t;
/**
* enum ion_heap_types - list of all possible types of heaps
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: android: uapi: Fix do not add new typedefs
2015-02-26 19:28 [PATCH] Staging: android: uapi: Fix do not add new typedefs Yeliz Taneroglu
@ 2015-02-26 20:00 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-02-26 20:00 UTC (permalink / raw)
To: Yeliz Taneroglu; +Cc: outreachy-kernel
On Thu, Feb 26, 2015 at 09:28:39PM +0200, Yeliz Taneroglu wrote:
> Fix checkpatch.pl issues with
> do not add new typedefs in ion.h
>
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
> drivers/staging/android/uapi/ion.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 6aa4956..7e7f87e 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -20,7 +20,7 @@
> #include <linux/ioctl.h>
> #include <linux/types.h>
>
> -typedef int ion_user_handle_t;
> +int ion_user_handle_t;
I don't think the change you just made, does what you think it does :(
Care to explain what you did here, and why?
Also, did you build-test this change?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-26 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-26 19:28 [PATCH] Staging: android: uapi: Fix do not add new typedefs Yeliz Taneroglu
2015-02-26 20:00 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.