From: Antti Palosaari <crope@iki.fi>
To: linux-media@vger.kernel.org
Cc: Jurgen Kramer <gtmkramer@xs4all.nl>, <stable@vger.kernel.org>
Subject: [PATCH] Si2168: increase timeout to fix firmware loading
Date: Thu, 26 Feb 2015 23:28:53 +0200 [thread overview]
Message-ID: <1424986133-5105-1-git-send-email-crope@iki.fi> (raw)
From: Jurgen Kramer <gtmkramer@xs4all.nl>
Increase si2168 cmd execute timeout to prevent firmware load failures. Tests
shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware.
Increase timeout to a safe value of 70ms.
Cc: <stable@vger.kernel.org> # v3.16+
Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
Reviewed-by: Antti Palosaari <crope@iki.fi>
---
Patch for stable 3.16+
That patch is already applied to master as commit 551c33e729f654ecfaed00ad399f5d2a631b72cb
There was some mistake and Cc stable tag I added to patchwork [1] was lost.
[1] https://patchwork.linuxtv.org/patch/27382/
---
drivers/media/dvb-frontends/si2168.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 2e3cdcf..fbc1fa8 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, struct si2168_cmd *cmd)
if (cmd->rlen) {
/* wait cmd execution terminate */
- #define TIMEOUT 50
+ #define TIMEOUT 70
timeout = jiffies + msecs_to_jiffies(TIMEOUT);
while (!time_after(jiffies, timeout)) {
ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
--
http://palosaari.fi/
next reply other threads:[~2015-02-26 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 21:28 Antti Palosaari [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-08 8:30 [PATCH] Si2168: increase timeout to fix firmware loading Jurgen Kramer
2014-12-08 17:52 ` Antti Palosaari
2014-12-14 11:29 ` Antti Palosaari
2015-01-22 10:04 ` Antti Palosaari
2015-01-22 13:37 ` Jurgen Kramer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424986133-5105-1-git-send-email-crope@iki.fi \
--to=crope@iki.fi \
--cc=gtmkramer@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.