From: Antti Palosaari <crope@iki.fi>
To: Jurgen Kramer <gtmkramer@xs4all.nl>, linux-media@vger.kernel.org
Cc: Olli Salonen <olli.salonen@iki.fi>
Subject: Re: [PATCH] Si2168: increase timeout to fix firmware loading
Date: Mon, 08 Dec 2014 19:52:50 +0200 [thread overview]
Message-ID: <5485E572.9010801@iki.fi> (raw)
In-Reply-To: <1418027444-4718-1-git-send-email-gtmkramer@xs4all.nl>
On 12/08/2014 10:30 AM, Jurgen Kramer wrote:
> Increase si2168 cmd execute timeout to prevent firmware load failures. Tests
> shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware.
> Increase timeout to a safe value of 70ms.
>
> Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Cc: <stable@vger.kernel.org> # v3.17+
That must go stable 3.17.
Antti
> ---
> drivers/media/dvb-frontends/si2168.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> index ce9ab44..d2f1a3e 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, struct si2168_cmd *cmd)
>
> if (cmd->rlen) {
> /* wait cmd execution terminate */
> - #define TIMEOUT 50
> + #define TIMEOUT 70
> timeout = jiffies + msecs_to_jiffies(TIMEOUT);
> while (!time_after(jiffies, timeout)) {
> ret = i2c_master_recv(s->client, cmd->args, cmd->rlen);
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-12-08 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 8:30 [PATCH] Si2168: increase timeout to fix firmware loading Jurgen Kramer
2014-12-08 17:52 ` Antti Palosaari [this message]
2014-12-14 11:29 ` Antti Palosaari
2015-01-22 10:04 ` Antti Palosaari
2015-01-22 13:37 ` Jurgen Kramer
2015-02-26 21:28 Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5485E572.9010801@iki.fi \
--to=crope@iki.fi \
--cc=gtmkramer@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.