* [PATCH 1/1] Staging: fbtft: fb_ssd1331: replaced C99 comments with C89
@ 2015-02-28 5:44 Tolga Ceylan
2015-03-02 1:18 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Tolga Ceylan @ 2015-02-28 5:44 UTC (permalink / raw)
To: Thomas Petazzoni, Noralf Trønnes, Greg Kroah-Hartman, devel,
linux-kernel, tolga.ceylan
Replaced C99 '//' comments with C89 '/**/'
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/fbtft/fb_ssd1331.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
index da7464f..c4e1dd7 100644
--- a/drivers/staging/fbtft/fb_ssd1331.c
+++ b/drivers/staging/fbtft/fb_ssd1331.c
@@ -29,24 +29,24 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xae); /* Display Off */
write_reg(par, 0xa0, 0x70 | (par->bgr << 2)); /* Set Colour Depth */
- write_reg(par, 0x72); // RGB colour
+ write_reg(par, 0x72); /* RGB colour */
write_reg(par, 0xa1, 0x00); /* Set Display Start Line */
write_reg(par, 0xa2, 0x00); /* Set Display Offset */
write_reg(par, 0xa4); /* NORMALDISPLAY */
- write_reg(par, 0xa8, 0x3f); // Set multiplex
- write_reg(par, 0xad, 0x8e); // Set master
- // write_reg(par, 0xb0, 0x0b); // Set power mode
- write_reg(par, 0xb1, 0x31); // Precharge
- write_reg(par, 0xb3, 0xf0); // Clock div
- write_reg(par, 0x8a, 0x64); // Precharge A
- write_reg(par, 0x8b, 0x78); // Precharge B
- write_reg(par, 0x8c, 0x64); // Precharge C
- write_reg(par, 0xbb, 0x3a); // Precharge level
- write_reg(par, 0xbe, 0x3e); // vcomh
- write_reg(par, 0x87, 0x06); // Master current
- write_reg(par, 0x81, 0x91); // Contrast A
- write_reg(par, 0x82, 0x50); // Contrast B
- write_reg(par, 0x83, 0x7d); // Contrast C
+ write_reg(par, 0xa8, 0x3f); /* Set multiplex */
+ write_reg(par, 0xad, 0x8e); /* Set master */
+ /* write_reg(par, 0xb0, 0x0b); */ /* Set power mode */
+ write_reg(par, 0xb1, 0x31); /* Precharge */
+ write_reg(par, 0xb3, 0xf0); /* Clock div */
+ write_reg(par, 0x8a, 0x64); /* Precharge A */
+ write_reg(par, 0x8b, 0x78); /* Precharge B */
+ write_reg(par, 0x8c, 0x64); /* Precharge C */
+ write_reg(par, 0xbb, 0x3a); /* Precharge level */
+ write_reg(par, 0xbe, 0x3e); /* vcomh */
+ write_reg(par, 0x87, 0x06); /* Master current */
+ write_reg(par, 0x81, 0x91); /* Contrast A */
+ write_reg(par, 0x82, 0x50); /* Contrast B */
+ write_reg(par, 0x83, 0x7d); /* Contrast C */
write_reg(par, 0xaf); /* Set Sleep Mode Display On */
return 0;
--
2.3.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Staging: fbtft: fb_ssd1331: replaced C99 comments with C89
2015-02-28 5:44 [PATCH 1/1] Staging: fbtft: fb_ssd1331: replaced C99 comments with C89 Tolga Ceylan
@ 2015-03-02 1:18 ` Greg Kroah-Hartman
2015-03-02 3:46 ` Tolga Ceylan
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-03-02 1:18 UTC (permalink / raw)
To: Tolga Ceylan; +Cc: Thomas Petazzoni, Noralf Trønnes, devel, linux-kernel
On Fri, Feb 27, 2015 at 09:44:42PM -0800, Tolga Ceylan wrote:
> Replaced C99 '//' comments with C89 '/**/'
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/fbtft/fb_ssd1331.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
Doesn't apply to my tree :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Staging: fbtft: fb_ssd1331: replaced C99 comments with C89
2015-03-02 1:18 ` Greg Kroah-Hartman
@ 2015-03-02 3:46 ` Tolga Ceylan
0 siblings, 0 replies; 5+ messages in thread
From: Tolga Ceylan @ 2015-03-02 3:46 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Thomas Petazzoni, Noralf Trønnes, devel, linux-kernel
On Sun, Mar 1, 2015 at 5:18 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Feb 27, 2015 at 09:44:42PM -0800, Tolga Ceylan wrote:
>> Replaced C99 '//' comments with C89 '/**/'
>>
>> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
>> ---
>> drivers/staging/fbtft/fb_ssd1331.c | 30 +++++++++++++++---------------
>> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> Doesn't apply to my tree :(
Ahh, I see it in staging. It's already patched. :-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Staging: fbtft: fb_ssd1331: replaced C99 comments with C89
2015-02-28 5:37 Tolga Ceylan
@ 2015-02-28 5:40 ` Tolga Ceylan
0 siblings, 0 replies; 5+ messages in thread
From: Tolga Ceylan @ 2015-02-28 5:40 UTC (permalink / raw)
To: Thomas Petazzoni, Noralf Trønnes, Greg Kroah-Hartman, devel,
linux-kernel, Tolga Ceylan
On Fri, Feb 27, 2015 at 9:37 PM, Tolga Ceylan <tolga.ceylan@gmail.com> wrote:
> Replaced C99 '//' comments with C89 '/**/'
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/fbtft/fb_ssd1331.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
> index da7464f..5cbd763 100644
> --- a/drivers/staging/fbtft/fb_ssd1331.c
> +++ b/drivers/staging/fbtft/fb_ssd1331.c
> @@ -29,24 +29,24 @@ static int init_display(struct fbtft_par *par)
>
> write_reg(par, 0xae); /* Display Off */
> write_reg(par, 0xa0, 0x70 | (par->bgr << 2)); /* Set Colour Depth */
> - write_reg(par, 0x72); // RGB colour
> + write_reg(par, 0x72); /* RGB colour */
> write_reg(par, 0xa1, 0x00); /* Set Display Start Line */
> write_reg(par, 0xa2, 0x00); /* Set Display Offset */
> write_reg(par, 0xa4); /* NORMALDISPLAY */
> - write_reg(par, 0xa8, 0x3f); // Set multiplex
> - write_reg(par, 0xad, 0x8e); // Set master
> - // write_reg(par, 0xb0, 0x0b); // Set power mode
> - write_reg(par, 0xb1, 0x31); // Precharge
> - write_reg(par, 0xb3, 0xf0); // Clock div
> - write_reg(par, 0x8a, 0x64); // Precharge A
> - write_reg(par, 0x8b, 0x78); // Precharge B
> - write_reg(par, 0x8c, 0x64); // Precharge C
> - write_reg(par, 0xbb, 0x3a); // Precharge level
> - write_reg(par, 0xbe, 0x3e); // vcomh
> - write_reg(par, 0x87, 0x06); // Master current
> - write_reg(par, 0x81, 0x91); // Contrast A
> - write_reg(par, 0x82, 0x50); // Contrast B
> - write_reg(par, 0x83, 0x7d); // Contrast C
> + write_reg(par, 0xa8, 0x3f); /* Set multiplex
> + write_reg(par, 0xad, 0x8e); /* Set master
> + /* write_reg(par, 0xb0, 0x0b); */ /* Set power mode */
> + write_reg(par, 0xb1, 0x31); /* Precharge */
> + write_reg(par, 0xb3, 0xf0); /* Clock div */
> + write_reg(par, 0x8a, 0x64); /* Precharge A */
> + write_reg(par, 0x8b, 0x78); /* Precharge B */
> + write_reg(par, 0x8c, 0x64); /* Precharge C */
> + write_reg(par, 0xbb, 0x3a); /* Precharge level */
> + write_reg(par, 0xbe, 0x3e); /* vcomh */
> + write_reg(par, 0x87, 0x06); /* Master current */
> + write_reg(par, 0x81, 0x91); /* Contrast A */
> + write_reg(par, 0x82, 0x50); /* Contrast B */
> + write_reg(par, 0x83, 0x7d); /* Contrast C */
> write_reg(par, 0xaf); /* Set Sleep Mode Display On */
>
> return 0;
> --
> 2.3.0
>
Apologies, please ignore this patch. It is faulty.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] Staging: fbtft: fb_ssd1331: replaced C99 comments with C89
@ 2015-02-28 5:37 Tolga Ceylan
2015-02-28 5:40 ` Tolga Ceylan
0 siblings, 1 reply; 5+ messages in thread
From: Tolga Ceylan @ 2015-02-28 5:37 UTC (permalink / raw)
To: Thomas Petazzoni, Noralf Trønnes, Greg Kroah-Hartman, devel,
linux-kernel, tolga.ceylan
Replaced C99 '//' comments with C89 '/**/'
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/fbtft/fb_ssd1331.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
index da7464f..5cbd763 100644
--- a/drivers/staging/fbtft/fb_ssd1331.c
+++ b/drivers/staging/fbtft/fb_ssd1331.c
@@ -29,24 +29,24 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xae); /* Display Off */
write_reg(par, 0xa0, 0x70 | (par->bgr << 2)); /* Set Colour Depth */
- write_reg(par, 0x72); // RGB colour
+ write_reg(par, 0x72); /* RGB colour */
write_reg(par, 0xa1, 0x00); /* Set Display Start Line */
write_reg(par, 0xa2, 0x00); /* Set Display Offset */
write_reg(par, 0xa4); /* NORMALDISPLAY */
- write_reg(par, 0xa8, 0x3f); // Set multiplex
- write_reg(par, 0xad, 0x8e); // Set master
- // write_reg(par, 0xb0, 0x0b); // Set power mode
- write_reg(par, 0xb1, 0x31); // Precharge
- write_reg(par, 0xb3, 0xf0); // Clock div
- write_reg(par, 0x8a, 0x64); // Precharge A
- write_reg(par, 0x8b, 0x78); // Precharge B
- write_reg(par, 0x8c, 0x64); // Precharge C
- write_reg(par, 0xbb, 0x3a); // Precharge level
- write_reg(par, 0xbe, 0x3e); // vcomh
- write_reg(par, 0x87, 0x06); // Master current
- write_reg(par, 0x81, 0x91); // Contrast A
- write_reg(par, 0x82, 0x50); // Contrast B
- write_reg(par, 0x83, 0x7d); // Contrast C
+ write_reg(par, 0xa8, 0x3f); /* Set multiplex
+ write_reg(par, 0xad, 0x8e); /* Set master
+ /* write_reg(par, 0xb0, 0x0b); */ /* Set power mode */
+ write_reg(par, 0xb1, 0x31); /* Precharge */
+ write_reg(par, 0xb3, 0xf0); /* Clock div */
+ write_reg(par, 0x8a, 0x64); /* Precharge A */
+ write_reg(par, 0x8b, 0x78); /* Precharge B */
+ write_reg(par, 0x8c, 0x64); /* Precharge C */
+ write_reg(par, 0xbb, 0x3a); /* Precharge level */
+ write_reg(par, 0xbe, 0x3e); /* vcomh */
+ write_reg(par, 0x87, 0x06); /* Master current */
+ write_reg(par, 0x81, 0x91); /* Contrast A */
+ write_reg(par, 0x82, 0x50); /* Contrast B */
+ write_reg(par, 0x83, 0x7d); /* Contrast C */
write_reg(par, 0xaf); /* Set Sleep Mode Display On */
return 0;
--
2.3.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-02 3:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-28 5:44 [PATCH 1/1] Staging: fbtft: fb_ssd1331: replaced C99 comments with C89 Tolga Ceylan
2015-03-02 1:18 ` Greg Kroah-Hartman
2015-03-02 3:46 ` Tolga Ceylan
-- strict thread matches above, loose matches on Subject: below --
2015-02-28 5:37 Tolga Ceylan
2015-02-28 5:40 ` Tolga Ceylan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.