* [PATCH] Staging: dgnc: replace printk
@ 2015-03-01 8:31 Matteo Semenzato
2015-03-01 16:41 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Matteo Semenzato @ 2015-03-01 8:31 UTC (permalink / raw)
To: lidza.louina, markh, gregkh
Cc: driverdev-devel, linux-kernel, Matteo Semenzato
From: Matteo Semenzato <mattew8898@gmail.com>
This patch fixes the following warning:
Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev,
... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
---
drivers/staging/dgnc/dgnc_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
index 2fd34ca..0fa2388 100644
--- a/drivers/staging/dgnc/dgnc_sysfs.c
+++ b/drivers/staging/dgnc/dgnc_sysfs.c
@@ -91,7 +91,7 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver)
rc |= driver_create_file(driverfs, &driver_attr_maxboards);
rc |= driver_create_file(driverfs, &driver_attr_pollrate);
if (rc)
- printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n");
+ pr_err("DGNC: sysfs driver_create_file failed!\n");
}
@@ -360,7 +360,7 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd);
rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number);
if (rc)
- printk(KERN_ERR "DGNC: sysfs device_create_file failed!\n");
+ pr_err("DGNC: sysfs device_create_file failed!\n");
}
--
2.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: dgnc: replace printk
2015-03-01 8:31 [PATCH] Staging: dgnc: replace printk Matteo Semenzato
@ 2015-03-01 16:41 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-03-01 16:41 UTC (permalink / raw)
To: Matteo Semenzato; +Cc: lidza.louina, markh, driverdev-devel, linux-kernel
On Sun, Mar 01, 2015 at 09:31:41AM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> This patch fixes the following warning:
> Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev,
> ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
> index 2fd34ca..0fa2388 100644
> --- a/drivers/staging/dgnc/dgnc_sysfs.c
> +++ b/drivers/staging/dgnc/dgnc_sysfs.c
> @@ -91,7 +91,7 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver)
> rc |= driver_create_file(driverfs, &driver_attr_maxboards);
> rc |= driver_create_file(driverfs, &driver_attr_pollrate);
> if (rc)
> - printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n");
> + pr_err("DGNC: sysfs driver_create_file failed!\n");
> }
>
>
> @@ -360,7 +360,7 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
> rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd);
> rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number);
> if (rc)
> - printk(KERN_ERR "DGNC: sysfs device_create_file failed!\n");
> + pr_err("DGNC: sysfs device_create_file failed!\n");
Why can't you use dev_err() here?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: dgnc: replace printk
@ 2015-03-01 16:41 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-03-01 16:41 UTC (permalink / raw)
To: Matteo Semenzato; +Cc: lidza.louina, driverdev-devel, linux-kernel
On Sun, Mar 01, 2015 at 09:31:41AM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato <mattew8898@gmail.com>
>
> This patch fixes the following warning:
> Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev,
> ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: Matteo Semenzato <mattew8898@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c
> index 2fd34ca..0fa2388 100644
> --- a/drivers/staging/dgnc/dgnc_sysfs.c
> +++ b/drivers/staging/dgnc/dgnc_sysfs.c
> @@ -91,7 +91,7 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver)
> rc |= driver_create_file(driverfs, &driver_attr_maxboards);
> rc |= driver_create_file(driverfs, &driver_attr_pollrate);
> if (rc)
> - printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n");
> + pr_err("DGNC: sysfs driver_create_file failed!\n");
> }
>
>
> @@ -360,7 +360,7 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd)
> rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd);
> rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number);
> if (rc)
> - printk(KERN_ERR "DGNC: sysfs device_create_file failed!\n");
> + pr_err("DGNC: sysfs device_create_file failed!\n");
Why can't you use dev_err() here?
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-01 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-01 8:31 [PATCH] Staging: dgnc: replace printk Matteo Semenzato
2015-03-01 16:41 ` Greg KH
2015-03-01 16:41 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.