* [PATCH 1/2] Staging: rtl8192u: Fix quoted string split across lines
@ 2015-03-02 21:56 Dilek Uzulmez
2015-03-02 21:56 ` [PATCH 2/2] " Dilek Uzulmez
0 siblings, 1 reply; 3+ messages in thread
From: Dilek Uzulmez @ 2015-03-02 21:56 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
This patch fixes checkpatch.pl warning in file ieee80211_crypt.c
WARNING: "quoted string split across lines warning"
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index f80dd08..3995620 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -65,8 +65,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
spin_lock_irqsave(&ieee->lock, flags);
ieee80211_crypt_deinit_entries(ieee, 0);
if (!list_empty(&ieee->crypt_deinit_list)) {
- netdev_dbg(ieee->dev, "%s: entries remaining in delayed crypt "
- "deletion list\n", ieee->dev->name);
+ netdev_dbg(ieee->dev, "%s: entries remaining in delayed crypt deletion list\n",
+ ieee->dev->name);
ieee->crypt_deinit_timer.expires = jiffies + HZ;
add_timer(&ieee->crypt_deinit_timer);
}
@@ -145,8 +145,8 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops)
spin_unlock_irqrestore(&hcrypt->lock, flags);
if (del_alg) {
- pr_debug("ieee80211_crypt: unregistered algorithm "
- "'%s'\n", ops->name);
+ pr_debug("ieee80211_crypt: unregistered algorithm '%s'\n",
+ ops->name);
kfree(del_alg);
}
@@ -231,8 +231,8 @@ void __exit ieee80211_crypto_deinit(void)
struct ieee80211_crypto_alg *alg =
(struct ieee80211_crypto_alg *) ptr;
list_del(ptr);
- pr_debug("ieee80211_crypt: unregistered algorithm "
- "'%s' (deinit)\n", alg->ops->name);
+ pr_debug("ieee80211_crypt: unregistered algorithm '%s' (deinit)\n",
+ alg->ops->name);
kfree(alg);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] Staging: rtl8192u: Fix quoted string split across lines
2015-03-02 21:56 [PATCH 1/2] Staging: rtl8192u: Fix quoted string split across lines Dilek Uzulmez
@ 2015-03-02 21:56 ` Dilek Uzulmez
2015-03-04 6:28 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dilek Uzulmez @ 2015-03-02 21:56 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
This patch fixes checkpatch.pl warning in file ieee80211_crypt_ccmp.c
WARNING: "quoted string split across lines warning"
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
.../staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
index 95f5fc7..344de83 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
@@ -73,8 +73,8 @@ static void *ieee80211_ccmp_init(int key_idx)
priv->tfm = (void *)crypto_alloc_cipher("aes", 0, CRYPTO_ALG_ASYNC);
if (IS_ERR(priv->tfm)) {
- printk(KERN_DEBUG "ieee80211_crypt_ccmp: could not allocate "
- "crypto API aes\n");
+ printk(KERN_DEBUG "ieee80211_crypt_ccmp: could not allocate
+ crypto API aes\n");
priv->tfm = NULL;
goto fail;
}
@@ -284,16 +284,16 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
keyidx = pos[3];
if (!(keyidx & (1 << 5))) {
if (net_ratelimit()) {
- printk(KERN_DEBUG "CCMP: received packet without ExtIV"
- " flag from %pM\n", hdr->addr2);
+ printk(KERN_DEBUG "CCMP: received packet without ExtIV flag from %pM\n",
+ hdr->addr2);
}
key->dot11RSNAStatsCCMPFormatErrors++;
return -2;
}
keyidx >>= 6;
if (key->key_idx != keyidx) {
- printk(KERN_DEBUG "CCMP: RX tkey->key_idx=%d frame "
- "keyidx=%d priv=%p\n", key->key_idx, keyidx, priv);
+ printk(KERN_DEBUG "CCMP: RX tkey->key_idx=%d frame keyidx=%d priv=%p\n",
+ key->key_idx, keyidx, priv);
return -6;
}
if (!key->key_set) {
@@ -353,8 +353,8 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
if (memcmp(mic, a, CCMP_MIC_LEN) != 0) {
if (net_ratelimit()) {
- printk(KERN_DEBUG "CCMP: decrypt failed: STA="
- "%pM\n", hdr->addr2);
+ printk(KERN_DEBUG "CCMP: decrypt failed: STA= %pM\n",
+ hdr->addr2);
}
key->dot11RSNAStatsCCMPDecryptErrors++;
return -5;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] Staging: rtl8192u: Fix quoted string split across lines
2015-03-02 21:56 ` [PATCH 2/2] " Dilek Uzulmez
@ 2015-03-04 6:28 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-03-04 6:28 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Mon, Mar 02, 2015 at 11:56:55PM +0200, Dilek Uzulmez wrote:
> This patch fixes checkpatch.pl warning in file ieee80211_crypt_ccmp.c
> WARNING: "quoted string split across lines warning"
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> .../staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
> index 95f5fc7..344de83 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
> @@ -73,8 +73,8 @@ static void *ieee80211_ccmp_init(int key_idx)
>
> priv->tfm = (void *)crypto_alloc_cipher("aes", 0, CRYPTO_ALG_ASYNC);
> if (IS_ERR(priv->tfm)) {
> - printk(KERN_DEBUG "ieee80211_crypt_ccmp: could not allocate "
> - "crypto API aes\n");
> + printk(KERN_DEBUG "ieee80211_crypt_ccmp: could not allocate
> + crypto API aes\n");
Um, I don't think you did the correct thing here :(
And this patch breaks the build, proving you didn't even test build it
:(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-04 6:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-02 21:56 [PATCH 1/2] Staging: rtl8192u: Fix quoted string split across lines Dilek Uzulmez
2015-03-02 21:56 ` [PATCH 2/2] " Dilek Uzulmez
2015-03-04 6:28 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.