From: Paul Bolle <pebolle@tiscali.nl> To: Nishanth Menon <nm@ti.com> Cc: Tony Lindgren <tony@atomide.com>, Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lokesh Vutla <lokeshvutla@ti.com> Subject: Re: [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver Date: Wed, 04 Mar 2015 23:58:46 +0100 [thread overview] Message-ID: <1425509926.2090.56.camel@tiscali.nl> (raw) In-Reply-To: <1425427237-11511-3-git-send-email-nm@ti.com> Nishanth Menon schreef op di 03-03-2015 om 18:00 [-0600]: > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index ee9f44ad7f02..8e463d75fbb2 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -160,6 +160,17 @@ config PINCTRL_TEGRA_XUSB > select PINCONF > select PINMUX > > +config PINCTRL_TI_IODELAY > + bool "TI IODelay Module pinconf driver" This adds a boolean Kconfig symbol. > + depends on OF > + select PINCONF > + select GENERIC_PINCONF > + select REGMAP_MMIO > + help > + Say Y here to support Texas Instruments' IODelay pinconf driver. > + IODelay module is used for the DRA7 SoC family. This driver is in > + addition to PINCTRL_SINGLE which controls the mux. > + > config PINCTRL_TZ1090 > bool "Toumaz Xenif TZ1090 pin control driver" > depends on SOC_TZ1090 > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > index 0475206dd600..e441cd71aedf 100644 > --- a/drivers/pinctrl/Makefile > +++ b/drivers/pinctrl/Makefile > @@ -28,6 +28,7 @@ obj-$(CONFIG_PINCTRL_TEGRA30) += pinctrl-tegra30.o > obj-$(CONFIG_PINCTRL_TEGRA114) += pinctrl-tegra114.o > obj-$(CONFIG_PINCTRL_TEGRA124) += pinctrl-tegra124.o > obj-$(CONFIG_PINCTRL_TEGRA_XUSB) += pinctrl-tegra-xusb.o > +obj-$(CONFIG_PINCTRL_TI_IODELAY) += pinctrl-ti-iodelay.o So this objectfile will either be built-in or not be built at all. > obj-$(CONFIG_PINCTRL_TZ1090) += pinctrl-tz1090.o > obj-$(CONFIG_PINCTRL_TZ1090_PDC) += pinctrl-tz1090-pdc.o > obj-$(CONFIG_PINCTRL_U300) += pinctrl-u300.o > diff --git a/drivers/pinctrl/pinctrl-ti-iodelay.c b/drivers/pinctrl/pinctrl-ti-iodelay.c > new file mode 100644 > index 000000000000..e4c6e25a781c > --- /dev/null > +++ b/drivers/pinctrl/pinctrl-ti-iodelay.c > @@ -0,0 +1,963 @@ >[...] > +#include <linux/err.h> > +#include <linux/init.h> > +#include <linux/io.h> > +#include <linux/list.h> > +#include <linux/module.h> This is, I think, a bit of a red flag. > +#include <linux/of_device.h> > +#include <linux/of.h> > +#include <linux/pinctrl/pinconf-generic.h> > +#include <linux/pinctrl/pinconf.h> > +#include <linux/pinctrl/pinctrl.h> > +#include <linux/regmap.h> > +#include <linux/slab.h> [...] > +static const struct of_device_id ti_iodelay_of_match[] = { > + {.compatible = "ti,dra7-iodelay", .data = &dra7_iodelay_data}, > + { /* Hopefully no more.. */ }, > +}; > +MODULE_DEVICE_TABLE(of, ti_iodelay_of_match); > + > +static struct platform_driver ti_iodelay_driver = { > + .probe = ti_iodelay_probe, > + .remove = ti_iodelay_remove, > + .driver = { > + .owner = THIS_MODULE, So THIS_MODULE will, basically, be NULL. > + .name = DRIVER_NAME, > + .of_match_table = ti_iodelay_of_match, > + }, > +}; > +module_platform_driver(ti_iodelay_driver); > + > +MODULE_AUTHOR("Texas Instruments, Inc."); > +MODULE_DESCRIPTION("Pinconf driver for TI's IO Delay module"); > +MODULE_LICENSE("GPL v2"); And these three macros will be preprocessed away. (Perhaps there are non-modular alternatives to MODULE_DEVICE_TABLE and module_platform_driver, but I'm not sure how those two macros actually work.) Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver Date: Wed, 04 Mar 2015 23:58:46 +0100 [thread overview] Message-ID: <1425509926.2090.56.camel@tiscali.nl> (raw) In-Reply-To: <1425427237-11511-3-git-send-email-nm@ti.com> Nishanth Menon schreef op di 03-03-2015 om 18:00 [-0600]: > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index ee9f44ad7f02..8e463d75fbb2 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -160,6 +160,17 @@ config PINCTRL_TEGRA_XUSB > select PINCONF > select PINMUX > > +config PINCTRL_TI_IODELAY > + bool "TI IODelay Module pinconf driver" This adds a boolean Kconfig symbol. > + depends on OF > + select PINCONF > + select GENERIC_PINCONF > + select REGMAP_MMIO > + help > + Say Y here to support Texas Instruments' IODelay pinconf driver. > + IODelay module is used for the DRA7 SoC family. This driver is in > + addition to PINCTRL_SINGLE which controls the mux. > + > config PINCTRL_TZ1090 > bool "Toumaz Xenif TZ1090 pin control driver" > depends on SOC_TZ1090 > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > index 0475206dd600..e441cd71aedf 100644 > --- a/drivers/pinctrl/Makefile > +++ b/drivers/pinctrl/Makefile > @@ -28,6 +28,7 @@ obj-$(CONFIG_PINCTRL_TEGRA30) += pinctrl-tegra30.o > obj-$(CONFIG_PINCTRL_TEGRA114) += pinctrl-tegra114.o > obj-$(CONFIG_PINCTRL_TEGRA124) += pinctrl-tegra124.o > obj-$(CONFIG_PINCTRL_TEGRA_XUSB) += pinctrl-tegra-xusb.o > +obj-$(CONFIG_PINCTRL_TI_IODELAY) += pinctrl-ti-iodelay.o So this objectfile will either be built-in or not be built at all. > obj-$(CONFIG_PINCTRL_TZ1090) += pinctrl-tz1090.o > obj-$(CONFIG_PINCTRL_TZ1090_PDC) += pinctrl-tz1090-pdc.o > obj-$(CONFIG_PINCTRL_U300) += pinctrl-u300.o > diff --git a/drivers/pinctrl/pinctrl-ti-iodelay.c b/drivers/pinctrl/pinctrl-ti-iodelay.c > new file mode 100644 > index 000000000000..e4c6e25a781c > --- /dev/null > +++ b/drivers/pinctrl/pinctrl-ti-iodelay.c > @@ -0,0 +1,963 @@ >[...] > +#include <linux/err.h> > +#include <linux/init.h> > +#include <linux/io.h> > +#include <linux/list.h> > +#include <linux/module.h> This is, I think, a bit of a red flag. > +#include <linux/of_device.h> > +#include <linux/of.h> > +#include <linux/pinctrl/pinconf-generic.h> > +#include <linux/pinctrl/pinconf.h> > +#include <linux/pinctrl/pinctrl.h> > +#include <linux/regmap.h> > +#include <linux/slab.h> [...] > +static const struct of_device_id ti_iodelay_of_match[] = { > + {.compatible = "ti,dra7-iodelay", .data = &dra7_iodelay_data}, > + { /* Hopefully no more.. */ }, > +}; > +MODULE_DEVICE_TABLE(of, ti_iodelay_of_match); > + > +static struct platform_driver ti_iodelay_driver = { > + .probe = ti_iodelay_probe, > + .remove = ti_iodelay_remove, > + .driver = { > + .owner = THIS_MODULE, So THIS_MODULE will, basically, be NULL. > + .name = DRIVER_NAME, > + .of_match_table = ti_iodelay_of_match, > + }, > +}; > +module_platform_driver(ti_iodelay_driver); > + > +MODULE_AUTHOR("Texas Instruments, Inc."); > +MODULE_DESCRIPTION("Pinconf driver for TI's IO Delay module"); > +MODULE_LICENSE("GPL v2"); And these three macros will be preprocessed away. (Perhaps there are non-modular alternatives to MODULE_DEVICE_TABLE and module_platform_driver, but I'm not sure how those two macros actually work.) Paul Bolle
next prev parent reply other threads:[~2015-03-04 22:58 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-04 0:00 [PATCH 0/2] pinctrl: Introduce support for iodelay module in TI SoCs Nishanth Menon 2015-03-04 0:00 ` Nishanth Menon 2015-03-04 0:00 ` Nishanth Menon 2015-03-04 0:00 ` [PATCH 1/2] pinctrl: bindings: pinctrl: Add support for TI's IODelay configuration Nishanth Menon 2015-03-04 0:00 ` Nishanth Menon 2015-03-04 0:00 ` Nishanth Menon 2015-03-10 10:39 ` Linus Walleij 2015-03-10 10:39 ` Linus Walleij 2015-03-10 10:39 ` Linus Walleij 2015-03-10 15:06 ` Nishanth Menon 2015-03-10 15:06 ` Nishanth Menon 2015-03-10 15:06 ` Nishanth Menon 2015-03-10 15:33 ` Tony Lindgren 2015-03-10 15:33 ` Tony Lindgren 2015-03-10 15:33 ` Tony Lindgren 2015-03-10 17:25 ` Nishanth Menon 2015-03-10 17:25 ` Nishanth Menon 2015-03-10 17:25 ` Nishanth Menon 2015-03-10 17:31 ` Tony Lindgren 2015-03-10 17:31 ` Tony Lindgren 2015-03-10 17:31 ` Tony Lindgren 2015-03-10 18:33 ` Nishanth Menon 2015-03-10 18:33 ` Nishanth Menon 2015-03-10 18:33 ` Nishanth Menon 2015-03-10 19:20 ` Nishanth Menon 2015-03-10 19:20 ` Nishanth Menon 2015-03-10 19:20 ` Nishanth Menon 2015-03-18 1:30 ` Linus Walleij 2015-03-18 1:30 ` Linus Walleij 2015-03-18 1:30 ` Linus Walleij 2015-03-18 1:41 ` Tony Lindgren 2015-03-18 1:41 ` Tony Lindgren 2015-03-18 1:41 ` Tony Lindgren 2015-04-15 1:29 ` Lennart Sorensen 2015-04-15 1:29 ` Lennart Sorensen 2015-04-15 1:29 ` Lennart Sorensen [not found] ` <20150415012910.GA29560-1wCw9BSqJbv44Nm34jS7GywD8/FfD2ys@public.gmane.org> 2015-04-15 16:51 ` Nishanth Menon 2015-04-15 16:51 ` Nishanth Menon 2015-04-15 16:51 ` Nishanth Menon 2015-04-15 18:44 ` Lennart Sorensen 2015-04-15 18:44 ` Lennart Sorensen 2015-04-15 18:44 ` Lennart Sorensen 2015-04-15 18:53 ` Nishanth Menon 2015-04-15 18:53 ` Nishanth Menon 2015-04-15 18:53 ` Nishanth Menon 2015-03-04 0:00 ` [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver Nishanth Menon 2015-03-04 0:00 ` Nishanth Menon 2015-03-04 0:00 ` Nishanth Menon 2015-03-04 22:58 ` Paul Bolle [this message] 2015-03-04 22:58 ` Paul Bolle 2015-03-04 22:58 ` Tony Lindgren 2015-03-04 22:58 ` Tony Lindgren 2015-03-05 2:22 ` Nishanth Menon 2015-03-05 2:22 ` Nishanth Menon 2015-03-05 2:22 ` Nishanth Menon 2015-03-10 11:03 ` Linus Walleij 2015-03-10 11:03 ` Linus Walleij 2015-03-10 11:03 ` Linus Walleij 2015-03-11 12:39 ` Nishanth Menon 2015-03-11 12:39 ` Nishanth Menon 2015-03-11 12:39 ` Nishanth Menon 2016-12-30 18:37 [PATCH 0/2] Add TI iodelay driver using #pinctrl-cells Tony Lindgren 2016-12-30 18:37 ` [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver Tony Lindgren [not found] ` <20161230183732.5595-3-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2016-12-31 22:52 ` kbuild test robot [not found] ` <201701010645.EBjk2p8Y%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2017-01-02 18:04 ` Tony Lindgren 2017-01-01 2:02 ` kbuild test robot 2017-01-02 22:12 ` Tony Lindgren 2017-01-04 13:32 ` Rob Herring 2017-01-04 15:38 ` Nishanth Menon [not found] ` <63a8a1ec-343a-8c96-a0d2-21d81f7ad10e-l0cyMroinI0@public.gmane.org> 2017-01-04 16:05 ` Tony Lindgren [not found] ` <20170104160511.GF25222-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-01-04 16:51 ` Nishanth Menon [not found] ` <20170102221228.GH9325-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-01-04 17:57 ` Nishanth Menon 2017-01-05 18:50 ` Tony Lindgren 2017-01-05 18:54 [PATCHv3 0/2] Add TI iodelay driver using #pinctrl-cells Tony Lindgren [not found] ` <20170105185414.27247-1-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2017-01-05 18:54 ` [PATCH 2/2] pinctrl: Introduce TI IOdelay configuration driver Tony Lindgren 2017-01-09 18:46 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1425509926.2090.56.camel@tiscali.nl \ --to=pebolle@tiscali.nl \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=lokeshvutla@ti.com \ --cc=nm@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.