* [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse
@ 2015-03-08 18:14 Stefan Weil
2015-03-10 6:04 ` Michael Tokarev
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2015-03-08 18:14 UTC (permalink / raw)
To: QEMU Trivial; +Cc: Stefan Weil, QEMU Developer
Sparse report:
backends/tpm.c:39:5: warning: returning void-valued expression
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
backends/tpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/tpm.c b/backends/tpm.c
index 01860c4..4efe367 100644
--- a/backends/tpm.c
+++ b/backends/tpm.c
@@ -36,7 +36,7 @@ void tpm_backend_destroy(TPMBackend *s)
{
TPMBackendClass *k = TPM_BACKEND_GET_CLASS(s);
- return k->ops->destroy(s);
+ k->ops->destroy(s);
}
int tpm_backend_init(TPMBackend *s, TPMState *state,
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse
2015-03-08 18:14 [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse Stefan Weil
@ 2015-03-10 6:04 ` Michael Tokarev
2015-03-10 6:22 ` Stefan Weil
0 siblings, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2015-03-10 6:04 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial; +Cc: QEMU Developer
Applied all 7 to -trivial.
Is it intentional that there's no cover letter for the series?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse
2015-03-10 6:04 ` Michael Tokarev
@ 2015-03-10 6:22 ` Stefan Weil
2015-03-10 6:41 ` Michael Tokarev
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Weil @ 2015-03-10 6:22 UTC (permalink / raw)
To: Michael Tokarev, QEMU Trivial; +Cc: QEMU Developer
Am 10.03.2015 um 07:04 schrieb Michael Tokarev:
> Applied all 7 to -trivial.
>
> Is it intentional that there's no cover letter for the series?
>
> Thanks,
>
> /mjt
No, that was my mistake. Please excuse also the cris patch which I sent
twice.
I did not notice that it already had caused trouble, nor did I notice
that I had already sent it.
In my local patch queue (~ 50 patches) there was even a 2nd cris patch
which removed the unused variables...
Regards
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse
2015-03-10 6:22 ` Stefan Weil
@ 2015-03-10 6:41 ` Michael Tokarev
0 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2015-03-10 6:41 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial; +Cc: QEMU Developer
10.03.2015 09:22, Stefan Weil wrote:
> No, that was my mistake. Please excuse also the cris patch which I sent twice.
> I did not notice that it already had caused trouble, nor did I notice that I had already sent it.
> In my local patch queue (~ 50 patches) there was even a 2nd cris patch
> which removed the unused variables...
No problems with that (except that we bothered Peter twice
with this cris thing already, and I really mean "we", since
it escaped my testing and accurate review too, and it was
twice too, so I'm as guilty if not more).
And this situation suggests that I should process and submit
patches a) more carefully and b) faster. So it is, again,
good portion of my fault. Not doing trivial-patches merging
for 3 weeks and rushing a whole lot in one go without that
good review isn't going to work well.
Thank you for the good work! And it really is good, while
boring...
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-10 6:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-08 18:14 [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse Stefan Weil
2015-03-10 6:04 ` Michael Tokarev
2015-03-10 6:22 ` Stefan Weil
2015-03-10 6:41 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.