* [PATCH] ibmveth: enable interrupts after napi_complete()
@ 2015-03-09 6:13 Yongbae Park
2015-03-09 14:52 ` Brian King
0 siblings, 1 reply; 8+ messages in thread
From: Yongbae Park @ 2015-03-09 6:13 UTC (permalink / raw)
To: anton, larson1, santil, brking, rcj; +Cc: ebiederm, davem, linux-kernel
The interrupt is enabled before napi_complete(). A network timeout
occurs if the interrupt handler is called before napi_complete().
Fix the bug by enabling the interrupt after napi_complete().
Signed-off-by: Yongbae Park <yongbae2@gmail.com>
---
drivers/net/ethernet/ibm/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 21978cc..edcb4c7 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1136,6 +1136,8 @@ restart_poll:
ibmveth_replenish_task(adapter);
if (frames_processed < budget) {
+ napi_complete(napi);
+
/* We think we are done - reenable interrupts,
* then check once more to make sure we are done.
*/
@@ -1144,8 +1146,6 @@ restart_poll:
BUG_ON(lpar_rc != H_SUCCESS);
- napi_complete(napi);
-
if (ibmveth_rxq_pending_buffer(adapter) &&
napi_reschedule(napi)) {
lpar_rc = h_vio_signal(adapter->vdev->unit_address,
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ibmveth: enable interrupts after napi_complete()
2015-03-09 6:13 [PATCH] ibmveth: enable interrupts after napi_complete() Yongbae Park
@ 2015-03-09 14:52 ` Brian King
0 siblings, 0 replies; 8+ messages in thread
From: Brian King @ 2015-03-09 14:52 UTC (permalink / raw)
To: Yongbae Park, anton, larson1, santil, rcj; +Cc: ebiederm, davem, linux-kernel
Yongbae,
Thank you for submitting the patch for this issue. Issues
with this device driver should be reported via netdev@vger.kernel.org
and also please copy the maintainer of ibmveth, Thomas Falcon <tlfalcon@linux.vnet.ibm.com>.
Thanks!
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ibmveth: enable interrupts after napi_complete()
2015-03-10 2:15 Yongbae Park
2015-03-10 2:38 ` David Miller
@ 2015-03-10 4:23 ` David Miller
1 sibling, 0 replies; 8+ messages in thread
From: David Miller @ 2015-03-10 4:23 UTC (permalink / raw)
To: yongbae2; +Cc: msink, nicolas.ferre, tklauser, wsa, varkabhadram, netdev
From: Yongbae Park <yongbae2@gmail.com>
Date: Tue, 10 Mar 2015 11:15:39 +0900
> The interrupt is enabled before napi_complete(). A network timeout
> occurs if the interrupt handler is called before napi_complete().
>
> Fix the bug by enabling the interrupt after napi_complete().
>
> Signed-off-by: Yongbae Park <yongbae2@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ibmveth: enable interrupts after napi_complete()
2015-03-10 2:15 Yongbae Park
@ 2015-03-10 2:38 ` David Miller
2015-03-10 4:23 ` David Miller
1 sibling, 0 replies; 8+ messages in thread
From: David Miller @ 2015-03-10 2:38 UTC (permalink / raw)
To: yongbae2; +Cc: msink, nicolas.ferre, tklauser, wsa, varkabhadram, netdev
From: Yongbae Park <yongbae2@gmail.com>
Date: Tue, 10 Mar 2015 11:15:39 +0900
> The interrupt is enabled before napi_complete(). A network timeout
> occurs if the interrupt handler is called before napi_complete().
>
> Fix the bug by enabling the interrupt after napi_complete().
>
> Signed-off-by: Yongbae Park <yongbae2@gmail.com>
There is no need to post the patch multiple times, once is
enough.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ibmveth: enable interrupts after napi_complete()
@ 2015-03-10 2:15 Yongbae Park
2015-03-10 2:38 ` David Miller
2015-03-10 4:23 ` David Miller
0 siblings, 2 replies; 8+ messages in thread
From: Yongbae Park @ 2015-03-10 2:15 UTC (permalink / raw)
To: msink; +Cc: davem, nicolas.ferre, tklauser, wsa, varkabhadram, netdev
The interrupt is enabled before napi_complete(). A network timeout
occurs if the interrupt handler is called before napi_complete().
Fix the bug by enabling the interrupt after napi_complete().
Signed-off-by: Yongbae Park <yongbae2@gmail.com>
---
drivers/net/ethernet/ibm/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 21978cc..edcb4c7 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1136,6 +1136,8 @@ restart_poll:
ibmveth_replenish_task(adapter);
if (frames_processed < budget) {
+ napi_complete(napi);
+
/* We think we are done - reenable interrupts,
* then check once more to make sure we are done.
*/
@@ -1144,8 +1146,6 @@ restart_poll:
BUG_ON(lpar_rc != H_SUCCESS);
- napi_complete(napi);
-
if (ibmveth_rxq_pending_buffer(adapter) &&
napi_reschedule(napi)) {
lpar_rc = h_vio_signal(adapter->vdev->unit_address,
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ibmveth: enable interrupts after napi_complete()
@ 2015-03-10 2:15 Yongbae Park
0 siblings, 0 replies; 8+ messages in thread
From: Yongbae Park @ 2015-03-10 2:15 UTC (permalink / raw)
To: anton, larson1, santil, brking, rcj; +Cc: ebiederm, davem, netdev
The interrupt is enabled before napi_complete(). A network timeout
occurs if the interrupt handler is called before napi_complete().
Fix the bug by enabling the interrupt after napi_complete().
Signed-off-by: Yongbae Park <yongbae2@gmail.com>
---
drivers/net/ethernet/ibm/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 21978cc..edcb4c7 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1136,6 +1136,8 @@ restart_poll:
ibmveth_replenish_task(adapter);
if (frames_processed < budget) {
+ napi_complete(napi);
+
/* We think we are done - reenable interrupts,
* then check once more to make sure we are done.
*/
@@ -1144,8 +1146,6 @@ restart_poll:
BUG_ON(lpar_rc != H_SUCCESS);
- napi_complete(napi);
-
if (ibmveth_rxq_pending_buffer(adapter) &&
napi_reschedule(napi)) {
lpar_rc = h_vio_signal(adapter->vdev->unit_address,
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ibmveth: enable interrupts after napi_complete()
@ 2015-03-09 6:13 Yongbae Park
0 siblings, 0 replies; 8+ messages in thread
From: Yongbae Park @ 2015-03-09 6:13 UTC (permalink / raw)
To: msink; +Cc: davem, nicolas.ferre, tklauser, wsa, varkabhadram, linux-kernel
The interrupt is enabled before napi_complete(). A network timeout
occurs if the interrupt handler is called before napi_complete().
Fix the bug by enabling the interrupt after napi_complete().
Signed-off-by: Yongbae Park <yongbae2@gmail.com>
---
drivers/net/ethernet/ibm/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 21978cc..edcb4c7 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1136,6 +1136,8 @@ restart_poll:
ibmveth_replenish_task(adapter);
if (frames_processed < budget) {
+ napi_complete(napi);
+
/* We think we are done - reenable interrupts,
* then check once more to make sure we are done.
*/
@@ -1144,8 +1146,6 @@ restart_poll:
BUG_ON(lpar_rc != H_SUCCESS);
- napi_complete(napi);
-
if (ibmveth_rxq_pending_buffer(adapter) &&
napi_reschedule(napi)) {
lpar_rc = h_vio_signal(adapter->vdev->unit_address,
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ibmveth: enable interrupts after napi_complete()
@ 2015-03-09 6:00 Yongbae Park
0 siblings, 0 replies; 8+ messages in thread
From: Yongbae Park @ 2015-03-09 6:00 UTC (permalink / raw)
To: msink; +Cc: davem, nicolas.ferre, tklauser, wsa, varkabhadram, linux-kernel
The interrupt is enabled before napi_complete(). A network timeout
occurs if the interrupt handler is called before napi_complete().
Fix the bug by enabling the interrupt after napi_complete().
Signed-off-by: Yongbae Park <yongbae2@gmail.com>
---
drivers/net/ethernet/ibm/ibmveth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 21978cc..edcb4c7 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1136,6 +1136,8 @@ restart_poll:
ibmveth_replenish_task(adapter);
if (frames_processed < budget) {
+ napi_complete(napi);
+
/* We think we are done - reenable interrupts,
* then check once more to make sure we are done.
*/
@@ -1144,8 +1146,6 @@ restart_poll:
BUG_ON(lpar_rc != H_SUCCESS);
- napi_complete(napi);
-
if (ibmveth_rxq_pending_buffer(adapter) &&
napi_reschedule(napi)) {
lpar_rc = h_vio_signal(adapter->vdev->unit_address,
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-10 4:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-09 6:13 [PATCH] ibmveth: enable interrupts after napi_complete() Yongbae Park
2015-03-09 14:52 ` Brian King
-- strict thread matches above, loose matches on Subject: below --
2015-03-10 2:15 Yongbae Park
2015-03-10 2:38 ` David Miller
2015-03-10 4:23 ` David Miller
2015-03-10 2:15 Yongbae Park
2015-03-09 6:13 Yongbae Park
2015-03-09 6:00 Yongbae Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.