[Buildroot] [PATCH] libdri2: new package

[Buildroot] [PATCH] libdri2: new package

[Jerome Oufella]

From: J?r?me Oufella <jerome.oufella@savoirfairelinux.com>

libdri2 is a library for the DRI2 extension to the X Window System. This
is the split out dri2 client side code from mesa, libva, libvdpau, etc..

It can be used by applications or user-space drivers to provide
accelerated graphics.

Signed-off-by: J?r?me Oufella <jerome.oufella@savoirfairelinux.com>
---
 package/Config.in          |  1 +
 package/libdri2/Config.in  | 13 +++++++++++++
 package/libdri2/libdri2.mk | 18 ++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/libdri2/Config.in
 create mode 100644 package/libdri2/libdri2.mk

diff --git a/package/Config.in b/package/Config.in
index ba45f32..3f344ca 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -707,6 +707,7 @@ menu "Graphics"
 	source "package/lesstif/Config.in"
 	source "package/libart/Config.in"
 	source "package/libdmtx/Config.in"
+	source "package/libdri2/Config.in"
 	source "package/libdrm/Config.in"
 	source "package/libexif/Config.in"
 	source "package/libgail/Config.in"
diff --git a/package/libdri2/Config.in b/package/libdri2/Config.in
new file mode 100644
index 0000000..d739206
--- /dev/null
+++ b/package/libdri2/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBDRI2
+	bool "libdri2"
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBXDAMAGE
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	select BR2_PACKAGE_XPROTO_DRI2PROTO
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
+	depends on BR2_LARGEFILE # libdrm
+	help
+	  Library for the DRI2 extension to the X Window System.
+
+	  https://github.com/robclark/libdri2
diff --git a/package/libdri2/libdri2.mk b/package/libdri2/libdri2.mk
new file mode 100644
index 0000000..71fc53e
--- /dev/null
+++ b/package/libdri2/libdri2.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# libdri2
+#
+################################################################################
+
+LIBDRI2_VERSION = 4f1eef3183df2b270c3d5cbef07343ee5127a6a4
+LIBDRI2_SITE = $(call github,robclark,libdri2,$(LIBDRI2_VERSION))
+LIBDRI2_SITE_METHOD = git
+LIBDRI2_DEPENDENCIES = xlib_libXext xproto_dri2proto xlib_libXdamage libdrm
+LIBDRI2_LICENSE = MIT
+LIBDRI2_LICENSE_FILES = COPYING
+
+LIBDRI2_INSTALL_STAGING = YES
+LIBDRI2_AUTORECONF = YES
+LIBDRI2_CONF_ENV = xorg_cv_malloc0_returns_null=true
+
+$(eval $(autotools-package))
-- 
2.1.0

[Buildroot] [PATCH v2] libdri2: new package

[Jerome Oufella]

From: J?r?me Oufella <jerome.oufella@savoirfairelinux.com>

libdri2 is a library for the DRI2 extension to the X Window System. This
is the split out dri2 client side code from mesa, libva, libvdpau, etc..

It can be used by applications or user-space drivers to provide
accelerated graphics.

Signed-off-by: J?r?me Oufella <jerome.oufella@savoirfairelinux.com>
---
Changes v1 -> v2:
* Fix repository URL as it doesn't hosts archives [oops]
---
 package/Config.in          |  1 +
 package/libdri2/Config.in  | 13 +++++++++++++
 package/libdri2/libdri2.mk | 18 ++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/libdri2/Config.in
 create mode 100644 package/libdri2/libdri2.mk

diff --git a/package/Config.in b/package/Config.in
index ba45f32..3f344ca 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -707,6 +707,7 @@ menu "Graphics"
 	source "package/lesstif/Config.in"
 	source "package/libart/Config.in"
 	source "package/libdmtx/Config.in"
+	source "package/libdri2/Config.in"
 	source "package/libdrm/Config.in"
 	source "package/libexif/Config.in"
 	source "package/libgail/Config.in"
diff --git a/package/libdri2/Config.in b/package/libdri2/Config.in
new file mode 100644
index 0000000..d739206
--- /dev/null
+++ b/package/libdri2/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBDRI2
+	bool "libdri2"
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XLIB_LIBXDAMAGE
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	select BR2_PACKAGE_XPROTO_DRI2PROTO
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
+	depends on BR2_LARGEFILE # libdrm
+	help
+	  Library for the DRI2 extension to the X Window System.
+
+	  https://github.com/robclark/libdri2
diff --git a/package/libdri2/libdri2.mk b/package/libdri2/libdri2.mk
new file mode 100644
index 0000000..66b780f
--- /dev/null
+++ b/package/libdri2/libdri2.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# libdri2
+#
+################################################################################
+
+LIBDRI2_VERSION = 4f1eef3183df2b270c3d5cbef07343ee5127a6a4
+LIBDRI2_SITE = https://github.com/robclark/libdri2.git
+LIBDRI2_SITE_METHOD = git
+LIBDRI2_DEPENDENCIES = xlib_libXext xproto_dri2proto xlib_libXdamage libdrm
+LIBDRI2_LICENSE = MIT
+LIBDRI2_LICENSE_FILES = COPYING
+
+LIBDRI2_INSTALL_STAGING = YES
+LIBDRI2_AUTORECONF = YES
+LIBDRI2_CONF_ENV = xorg_cv_malloc0_returns_null=true
+
+$(eval $(autotools-package))
-- 
2.1.0

[Buildroot] [PATCH v2] libdri2: new package

[Thomas Petazzoni]

Dear Jerome Oufella,

On Mon,  9 Mar 2015 09:23:48 -0400, Jerome Oufella wrote:

> diff --git a/package/libdri2/Config.in b/package/libdri2/Config.in
> new file mode 100644
> index 0000000..d739206
> --- /dev/null
> +++ b/package/libdri2/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBDRI2
> +	bool "libdri2"
> +	select BR2_PACKAGE_LIBDRM
> +	select BR2_PACKAGE_XORG7

We basically never "select" BR2_PACKAGE_XORG7. It should be a depends
on. Users willing to use X.org stuff are expected to understand that
they need to enable the X.org global option (BR2_PACKAGE_XORG7) to see
all X.org related features.

You also need to add a Config.in "comment" about the thread and
largefile dependencies.

> +LIBDRI2_SITE = https://github.com/robclark/libdri2.git

Can you use the 'github' macro instead?

Other than that, the rest of the patch looks good.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] libdri2: new package

[Jérôme Oufella]

Thanks Thomas for taking time for a great review.

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

>> +LIBDRI2_SITE = https://github.com/robclark/libdri2.git
>
> Can you use the 'github' macro instead?

I tried in v1, but the macro would ultimately fail due to lack of
archive on github. Or is there something I missed ?

I will send an updated patch soon.

Best regards,

J?r?me

[Buildroot] [PATCH v2] libdri2: new package

[Thomas Petazzoni]

Dear J?r?me Oufella,

On Mon, 09 Mar 2015 14:52:51 -0400, J?r?me Oufella wrote:

> I tried in v1, but the macro would ultimately fail due to lack of
> archive on github. Or is there something I missed ?

Well, the github macro should work with any commit. See for example:

A10DISP_VERSION = a899cc6dcf909360aac00482ede5369f3656f226
A10DISP_SITE = $(call github,hglm,a10disp,$(A10DISP_VERSION))

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v3] libdri2: new package

[Jerome Oufella]

From: J?r?me Oufella <jerome.oufella@savoirfairelinux.com>

libdri2 is a library for the DRI2 extension to the X Window System. This
is the split out dri2 client side code from mesa, libva, libvdpau, etc..

It can be used by applications or user-space drivers to provide
accelerated graphics.

Signed-off-by: J?r?me Oufella <jerome.oufella@savoirfairelinux.com>
---
Changes v2 -> v3:
* depends on BR2_PACKAGE_XORG7 (instead of select)
* add a config comment to notify user of missing toolchain dependencies
* call the github macro to access the sources
---
 package/Config.in          |  1 +
 package/libdri2/Config.in  | 16 ++++++++++++++++
 package/libdri2/libdri2.mk | 17 +++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 package/libdri2/Config.in
 create mode 100644 package/libdri2/libdri2.mk

diff --git a/package/Config.in b/package/Config.in
index ba45f32..3f344ca 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -707,6 +707,7 @@ menu "Graphics"
 	source "package/lesstif/Config.in"
 	source "package/libart/Config.in"
 	source "package/libdmtx/Config.in"
+	source "package/libdri2/Config.in"
 	source "package/libdrm/Config.in"
 	source "package/libexif/Config.in"
 	source "package/libgail/Config.in"
diff --git a/package/libdri2/Config.in b/package/libdri2/Config.in
new file mode 100644
index 0000000..f016e77
--- /dev/null
+++ b/package/libdri2/Config.in
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_LIBDRI2
+	bool "libdri2"
+	select BR2_PACKAGE_LIBDRM
+	select BR2_PACKAGE_XLIB_LIBXDAMAGE
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	select BR2_PACKAGE_XPROTO_DRI2PROTO
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
+	depends on BR2_LARGEFILE # libdrm
+	depends on BR2_PACKAGE_XORG7
+	help
+	  Library for the DRI2 extension to the X Window System.
+
+	  https://github.com/robclark/libdri2
+
+comment "libdri2 needs a toolchain w/ largefile, threads"
+	depends on !(BR2_LARGEFILE && BR2_TOOLCHAIN_HAS_THREADS)
\ No newline at end of file
diff --git a/package/libdri2/libdri2.mk b/package/libdri2/libdri2.mk
new file mode 100644
index 0000000..22854b5
--- /dev/null
+++ b/package/libdri2/libdri2.mk
@@ -0,0 +1,17 @@
+################################################################################
+#
+# libdri2
+#
+################################################################################
+
+LIBDRI2_VERSION = 4f1eef3183df2b270c3d5cbef07343ee5127a6a4
+LIBDRI2_SITE = $(call github,robclark,libdri2,$(LIBDRI2_VERSION))
+LIBDRI2_DEPENDENCIES = xlib_libXext xproto_dri2proto xlib_libXdamage libdrm
+LIBDRI2_LICENSE = MIT
+LIBDRI2_LICENSE_FILES = COPYING
+
+LIBDRI2_INSTALL_STAGING = YES
+LIBDRI2_AUTORECONF = YES
+LIBDRI2_CONF_ENV = xorg_cv_malloc0_returns_null=true
+
+$(eval $(autotools-package))
-- 
2.1.0

[Buildroot] [PATCH v3] libdri2: new package

[Thomas Petazzoni]

Dear Jerome Oufella,

On Wed, 11 Mar 2015 16:30:22 -0400, Jerome Oufella wrote:

> diff --git a/package/libdri2/Config.in b/package/libdri2/Config.in
> new file mode 100644
> index 0000000..f016e77
> --- /dev/null
> +++ b/package/libdri2/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_LIBDRI2
> +	bool "libdri2"
> +	select BR2_PACKAGE_LIBDRM
> +	select BR2_PACKAGE_XLIB_LIBXDAMAGE
> +	select BR2_PACKAGE_XLIB_LIBXEXT
> +	select BR2_PACKAGE_XPROTO_DRI2PROTO
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm
> +	depends on BR2_LARGEFILE # libdrm
> +	depends on BR2_PACKAGE_XORG7
> +	help
> +	  Library for the DRI2 extension to the X Window System.
> +
> +	  https://github.com/robclark/libdri2
> +
> +comment "libdri2 needs a toolchain w/ largefile, threads"
> +	depends on !(BR2_LARGEFILE && BR2_TOOLCHAIN_HAS_THREADS)
> \ No newline at end of file

There was a missing new line here.

Other than that, I did a quick test build, and it went alright. So:
patch applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com