All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lina Iyer <lina.iyer@linaro.org>
To: daniel.lezcano@linaro.org, khilman@linaro.org,
	sboyd@codeaurora.org, galak@codeaurora.org,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: lorenzo.pieralisi@arm.com, msivasub@codeaurora.org,
	devicetree@vger.kernel.org, Lina Iyer <lina.iyer@linaro.org>
Subject: [RFC PATCH v15 01/11] ARM: cpuidle: Register per cpuidle device
Date: Mon,  9 Mar 2015 09:16:36 -0600	[thread overview]
Message-ID: <1425914206-22295-2-git-send-email-lina.iyer@linaro.org> (raw)
In-Reply-To: <1425914206-22295-1-git-send-email-lina.iyer@linaro.org>

From: Daniel Lezcano <daniel.lezcano@linaro.org>

Some architectures have some cpus which does not support idle states.

Let the underlying low level code to return -ENOSYS when it is not
possible to set an idle state.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
[Minor clean ups and fixes of the per-cpu variable]
---
 drivers/cpuidle/cpuidle-arm.c | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
index 1c94b88..f7cdb73 100644
--- a/drivers/cpuidle/cpuidle-arm.c
+++ b/drivers/cpuidle/cpuidle-arm.c
@@ -17,11 +17,14 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/slab.h>
 
 #include <asm/cpuidle.h>
 
 #include "dt_idle_states.h"
 
+static DEFINE_PER_CPU(struct cpuidle_device, *cpuidle_arm_dev);
+
 /*
  * arm_enter_idle_state - Programs CPU to enter the specified state
  *
@@ -93,6 +96,7 @@ static const struct of_device_id arm_idle_state_match[] __initconst = {
 static int __init arm_idle_init(void)
 {
 	int cpu, ret;
+	struct cpuidle_device *dev;
 	struct cpuidle_driver *drv = &arm_idle_driver;
 
 	/*
@@ -105,18 +109,46 @@ static int __init arm_idle_init(void)
 	if (ret <= 0)
 		return ret ? : -ENODEV;
 
+
+	ret = cpuidle_register_driver(drv);
+	if (ret) {
+		pr_err("Failed to register cpuidle driver\n");
+		return ret;
+	}
+
 	/*
 	 * Call arch CPU operations in order to initialize
 	 * idle states suspend back-end specific data
 	 */
 	for_each_possible_cpu(cpu) {
+
 		ret = arm_cpuidle_init(cpu);
+		/*
+		 * This cpu does not support any idle states
+		 */
+		if (ret == -ENOSYS)
+			continue;
+
 		if (ret) {
 			pr_err("CPU %d failed to init idle CPU ops\n", cpu);
 			return ret;
 		}
+
+		dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+		if (!dev)
+			return -ENOMEM;
+
+		dev->cpu = cpu;
+		ret = cpuidle_register_device(dev);
+		if (ret) {
+			pr_err("Failed to register cpuidle device for CPU %d\n",
+			       cpu);
+			return ret;
+		}
+
+		per_cpu(cpuidle_arm_dev, cpu) = dev;
 	}
 
-	return cpuidle_register(drv, NULL);
+	return 0;
 }
 device_initcall(arm_idle_init);
-- 
2.1.0

WARNING: multiple messages have this Message-ID (diff)
From: lina.iyer@linaro.org (Lina Iyer)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v15 01/11] ARM: cpuidle: Register per cpuidle device
Date: Mon,  9 Mar 2015 09:16:36 -0600	[thread overview]
Message-ID: <1425914206-22295-2-git-send-email-lina.iyer@linaro.org> (raw)
In-Reply-To: <1425914206-22295-1-git-send-email-lina.iyer@linaro.org>

From: Daniel Lezcano <daniel.lezcano@linaro.org>

Some architectures have some cpus which does not support idle states.

Let the underlying low level code to return -ENOSYS when it is not
possible to set an idle state.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
[Minor clean ups and fixes of the per-cpu variable]
---
 drivers/cpuidle/cpuidle-arm.c | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
index 1c94b88..f7cdb73 100644
--- a/drivers/cpuidle/cpuidle-arm.c
+++ b/drivers/cpuidle/cpuidle-arm.c
@@ -17,11 +17,14 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/slab.h>
 
 #include <asm/cpuidle.h>
 
 #include "dt_idle_states.h"
 
+static DEFINE_PER_CPU(struct cpuidle_device, *cpuidle_arm_dev);
+
 /*
  * arm_enter_idle_state - Programs CPU to enter the specified state
  *
@@ -93,6 +96,7 @@ static const struct of_device_id arm_idle_state_match[] __initconst = {
 static int __init arm_idle_init(void)
 {
 	int cpu, ret;
+	struct cpuidle_device *dev;
 	struct cpuidle_driver *drv = &arm_idle_driver;
 
 	/*
@@ -105,18 +109,46 @@ static int __init arm_idle_init(void)
 	if (ret <= 0)
 		return ret ? : -ENODEV;
 
+
+	ret = cpuidle_register_driver(drv);
+	if (ret) {
+		pr_err("Failed to register cpuidle driver\n");
+		return ret;
+	}
+
 	/*
 	 * Call arch CPU operations in order to initialize
 	 * idle states suspend back-end specific data
 	 */
 	for_each_possible_cpu(cpu) {
+
 		ret = arm_cpuidle_init(cpu);
+		/*
+		 * This cpu does not support any idle states
+		 */
+		if (ret == -ENOSYS)
+			continue;
+
 		if (ret) {
 			pr_err("CPU %d failed to init idle CPU ops\n", cpu);
 			return ret;
 		}
+
+		dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+		if (!dev)
+			return -ENOMEM;
+
+		dev->cpu = cpu;
+		ret = cpuidle_register_device(dev);
+		if (ret) {
+			pr_err("Failed to register cpuidle device for CPU %d\n",
+			       cpu);
+			return ret;
+		}
+
+		per_cpu(cpuidle_arm_dev, cpu) = dev;
 	}
 
-	return cpuidle_register(drv, NULL);
+	return 0;
 }
 device_initcall(arm_idle_init);
-- 
2.1.0

  reply	other threads:[~2015-03-09 15:17 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 15:16 [RFC PATCH v15 00/11] ARM: qcom: cpuidle support for 8064, 8074, 8084 Lina Iyer
2015-03-09 15:16 ` Lina Iyer
2015-03-09 15:16 ` Lina Iyer [this message]
2015-03-09 15:16   ` [RFC PATCH v15 01/11] ARM: cpuidle: Register per cpuidle device Lina Iyer
2015-03-09 21:29   ` Andy Gross
2015-03-09 21:29     ` Andy Gross
2015-03-09 21:40     ` Lina Iyer
2015-03-09 21:40       ` Lina Iyer
2015-03-09 22:04       ` Andy Gross
2015-03-09 22:04         ` Andy Gross
2015-03-10 10:37   ` Russell King - ARM Linux
2015-03-10 10:37     ` Russell King - ARM Linux
2015-03-10 14:57     ` Lina Iyer
2015-03-10 14:57       ` Lina Iyer
2015-03-09 15:16 ` [RFC PATCH v15 02/11] ARM: qcom: Add Subsystem Power Manager (SPM) driver Lina Iyer
2015-03-09 15:16   ` Lina Iyer
2015-03-10 17:26   ` Kumar Gala
2015-03-10 17:26     ` Kumar Gala
2015-03-10 18:51     ` Lina Iyer
2015-03-10 18:51       ` Lina Iyer
2015-03-12 22:50   ` Lina Iyer
2015-03-12 22:50     ` Lina Iyer
2015-03-16 21:51   ` Stephen Boyd
2015-03-16 21:51     ` Stephen Boyd
2015-03-16 22:51     ` Lina Iyer
2015-03-16 22:51       ` Lina Iyer
2015-03-09 15:16 ` [RFC PATCH v15 04/11] ARM: cpuidle: Register cpuidle_ops for QCOM cpus Lina Iyer
2015-03-09 15:16   ` Lina Iyer
2015-03-11 18:16   ` Stephen Boyd
2015-03-11 18:16     ` Stephen Boyd
2015-03-12 12:34     ` Daniel Lezcano
2015-03-12 12:34       ` Daniel Lezcano
2015-03-12 15:06       ` Lina Iyer
2015-03-12 15:06         ` Lina Iyer
2015-03-13  9:57         ` Daniel Lezcano
2015-03-13  9:57           ` Daniel Lezcano
2015-03-09 15:16 ` [PATCH v15 05/11] ARM: dts: qcom: Add power-controller device node for 8074 Krait CPUs Lina Iyer
2015-03-09 15:16   ` Lina Iyer
     [not found] ` <1425914206-22295-1-git-send-email-lina.iyer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-03-09 15:16   ` [PATCH v15 03/11] ARM: cpuidle: qcom: Add documentation for qcom cpuidle states Lina Iyer
2015-03-09 15:16     ` Lina Iyer
2015-03-09 15:16   ` [PATCH v15 06/11] ARM: dts: qcom: Add power-controller device node for 8084 Krait CPUs Lina Iyer
2015-03-09 15:16     ` Lina Iyer
2015-03-09 15:16   ` [PATCH v15 09/11] ARM: dts: qcom: Add idle states device nodes for 8084 Lina Iyer
2015-03-09 15:16     ` Lina Iyer
2015-03-09 15:16 ` [PATCH v15 07/11] ARM: dts: qcom: Update power-controller device node for 8064 Krait CPUs Lina Iyer
2015-03-09 15:16   ` Lina Iyer
2015-03-09 15:16 ` [PATCH v15 08/11] ARM: dts: qcom: Add idle states device nodes for 8074 Lina Iyer
2015-03-09 15:16   ` Lina Iyer
2015-03-09 15:16 ` [PATCH v15 10/11] ARM: dts: qcom: Add idle state device nodes for 8064 Lina Iyer
2015-03-09 15:16   ` Lina Iyer
2015-03-09 15:16 ` [PATCH v15 11/11] ARM: qcom: Update defconfig Lina Iyer
2015-03-09 15:16   ` Lina Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425914206-22295-2-git-send-email-lina.iyer@linaro.org \
    --to=lina.iyer@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=msivasub@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.