* [PATCH] spmi: pmic_arb: enable build on arm64 platforms
@ 2015-02-03 13:50 Stanimir Varbanov
2015-02-03 20:42 ` Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Stanimir Varbanov @ 2015-02-03 13:50 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Kumar Gala, Stephen Boyd, linux-kernel, linux-arm-msm, Stanimir Varbanov
This enables pmic arbiter driver to be build on arm64
platforms.
Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
---
drivers/spmi/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
index bf1295e..115348c 100644
--- a/drivers/spmi/Kconfig
+++ b/drivers/spmi/Kconfig
@@ -12,7 +12,7 @@ if SPMI
config SPMI_MSM_PMIC_ARB
tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
- depends on ARM
+ depends on ARM || ARM64
depends on IRQ_DOMAIN
depends on ARCH_QCOM || COMPILE_TEST
default ARCH_QCOM
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-02-03 13:50 [PATCH] spmi: pmic_arb: enable build on arm64 platforms Stanimir Varbanov
@ 2015-02-03 20:42 ` Paul Bolle
2015-02-04 15:05 ` Stanimir Varbanov
0 siblings, 1 reply; 9+ messages in thread
From: Paul Bolle @ 2015-02-03 20:42 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Greg Kroah-Hartman, Kumar Gala, Stephen Boyd, linux-kernel,
linux-arm-msm
On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> This enables pmic arbiter driver to be build on arm64
> platforms.
>
> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
> ---
> drivers/spmi/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> index bf1295e..115348c 100644
> --- a/drivers/spmi/Kconfig
> +++ b/drivers/spmi/Kconfig
> @@ -12,7 +12,7 @@ if SPMI
>
> config SPMI_MSM_PMIC_ARB
> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> - depends on ARM
> + depends on ARM || ARM64
> depends on IRQ_DOMAIN
> depends on ARCH_QCOM || COMPILE_TEST
> default ARCH_QCOM
But only if COMPILE_TEST is set too, isn't it? Is that intended?
Paul Bolle
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-02-03 20:42 ` Paul Bolle
@ 2015-02-04 15:05 ` Stanimir Varbanov
2015-02-04 15:14 ` Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Stanimir Varbanov @ 2015-02-04 15:05 UTC (permalink / raw)
To: Paul Bolle
Cc: Greg Kroah-Hartman, Kumar Gala, Stephen Boyd, linux-kernel,
linux-arm-msm
On 02/03/2015 10:42 PM, Paul Bolle wrote:
> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
>> This enables pmic arbiter driver to be build on arm64
>> platforms.
>>
>> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
>> ---
>> drivers/spmi/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
>> index bf1295e..115348c 100644
>> --- a/drivers/spmi/Kconfig
>> +++ b/drivers/spmi/Kconfig
>> @@ -12,7 +12,7 @@ if SPMI
>>
>> config SPMI_MSM_PMIC_ARB
>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
>> - depends on ARM
>> + depends on ARM || ARM64
>> depends on IRQ_DOMAIN
>> depends on ARCH_QCOM || COMPILE_TEST
>> default ARCH_QCOM
>
> But only if COMPILE_TEST is set too, isn't it? Is that intended?
No, the driver will be used on arm64 qcom platforms, also.
--
regards,
Stan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-02-04 15:05 ` Stanimir Varbanov
@ 2015-02-04 15:14 ` Paul Bolle
2015-02-04 15:27 ` Stanimir Varbanov
0 siblings, 1 reply; 9+ messages in thread
From: Paul Bolle @ 2015-02-04 15:14 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Greg Kroah-Hartman, Kumar Gala, Stephen Boyd, linux-kernel,
linux-arm-msm
On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
> On 02/03/2015 10:42 PM, Paul Bolle wrote:
> > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> >> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> >> index bf1295e..115348c 100644
> >> --- a/drivers/spmi/Kconfig
> >> +++ b/drivers/spmi/Kconfig
> >> @@ -12,7 +12,7 @@ if SPMI
> >>
> >> config SPMI_MSM_PMIC_ARB
> >> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> >> - depends on ARM
> >> + depends on ARM || ARM64
> >> depends on IRQ_DOMAIN
> >> depends on ARCH_QCOM || COMPILE_TEST
> >> default ARCH_QCOM
> >
> > But only if COMPILE_TEST is set too, isn't it? Is that intended?
>
> No, the driver will be used on arm64 qcom platforms, also.
But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
Paul Bolle
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-02-04 15:14 ` Paul Bolle
@ 2015-02-04 15:27 ` Stanimir Varbanov
2015-02-04 18:46 ` Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Stanimir Varbanov @ 2015-02-04 15:27 UTC (permalink / raw)
To: Paul Bolle
Cc: Greg Kroah-Hartman, Kumar Gala, Stephen Boyd, linux-kernel,
linux-arm-msm
On 02/04/2015 05:14 PM, Paul Bolle wrote:
> On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
>> On 02/03/2015 10:42 PM, Paul Bolle wrote:
>>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
>>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
>>>> index bf1295e..115348c 100644
>>>> --- a/drivers/spmi/Kconfig
>>>> +++ b/drivers/spmi/Kconfig
>>>> @@ -12,7 +12,7 @@ if SPMI
>>>>
>>>> config SPMI_MSM_PMIC_ARB
>>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
>>>> - depends on ARM
>>>> + depends on ARM || ARM64
>>>> depends on IRQ_DOMAIN
>>>> depends on ARCH_QCOM || COMPILE_TEST
>>>> default ARCH_QCOM
>>>
>>> But only if COMPILE_TEST is set too, isn't it? Is that intended?
>>
>> No, the driver will be used on arm64 qcom platforms, also.
>
> But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
Currently yes, but we want to be prepared to support PMIC's which will
be used on arm64 platforms, although they are not upstream yet.
--
regards,
Stan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-02-04 15:27 ` Stanimir Varbanov
@ 2015-02-04 18:46 ` Paul Bolle
2015-02-23 12:57 ` Ivan T. Ivanov
0 siblings, 1 reply; 9+ messages in thread
From: Paul Bolle @ 2015-02-04 18:46 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Greg Kroah-Hartman, Kumar Gala, Stephen Boyd, linux-kernel,
linux-arm-msm
On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote:
> On 02/04/2015 05:14 PM, Paul Bolle wrote:
> > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
> >> On 02/03/2015 10:42 PM, Paul Bolle wrote:
> >>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> >>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> >>>> index bf1295e..115348c 100644
> >>>> --- a/drivers/spmi/Kconfig
> >>>> +++ b/drivers/spmi/Kconfig
> >>>> @@ -12,7 +12,7 @@ if SPMI
> >>>>
> >>>> config SPMI_MSM_PMIC_ARB
> >>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> >>>> - depends on ARM
> >>>> + depends on ARM || ARM64
> >>>> depends on IRQ_DOMAIN
> >>>> depends on ARCH_QCOM || COMPILE_TEST
> >>>> default ARCH_QCOM
> >>>
> >>> But only if COMPILE_TEST is set too, isn't it? Is that intended?
> >>
> >> No, the driver will be used on arm64 qcom platforms, also.
> >
> > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
>
> Currently yes, but we want to be prepared to support PMIC's which will
> be used on arm64 platforms, although they are not upstream yet.
Please make the commit summary reflect that, as in:
"spmi: pmic_arb: enable test build on arm64"
Commit explanation likewise.
Paul Bolle
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-02-04 18:46 ` Paul Bolle
@ 2015-02-23 12:57 ` Ivan T. Ivanov
2015-03-09 16:53 ` Stanimir Varbanov
0 siblings, 1 reply; 9+ messages in thread
From: Ivan T. Ivanov @ 2015-02-23 12:57 UTC (permalink / raw)
To: Paul Bolle
Cc: Stanimir Varbanov, Greg Kroah-Hartman, Kumar Gala, Stephen Boyd,
linux-kernel, linux-arm-msm
On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote:
> On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote:
> > On 02/04/2015 05:14 PM, Paul Bolle wrote:
> > > On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
> > > > On 02/03/2015 10:42 PM, Paul Bolle wrote:
> > > > > On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
> > > > > > diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
> > > > > > index bf1295e..115348c 100644
> > > > > > --- a/drivers/spmi/Kconfig
> > > > > > +++ b/drivers/spmi/Kconfig
> > > > > > @@ -12,7 +12,7 @@ if SPMI
> > > > > >
> > > > > > config SPMI_MSM_PMIC_ARB
> > > > > > tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
> > > > > > - depends on ARM
> > > > > > + depends on ARM || ARM64
> > > > > > depends on IRQ_DOMAIN
> > > > > > depends on ARCH_QCOM || COMPILE_TEST
> > > > > > default ARCH_QCOM
> > > > >
> > > > > But only if COMPILE_TEST is set too, isn't it? Is that intended?
> > > >
> > > > No, the driver will be used on arm64 qcom platforms, also.
> > >
> > > But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
> >
> > Currently yes, but we want to be prepared to support PMIC's which will
> > be used on arm64 platforms, although they are not upstream yet.
>
> Please make the commit summary reflect that, as in:
> "spmi: pmic_arb: enable test build on arm64"
>
> Commit explanation likewise.
What if we just drop ARM dependency?
Regards,
Ivan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-02-23 12:57 ` Ivan T. Ivanov
@ 2015-03-09 16:53 ` Stanimir Varbanov
2015-03-09 18:57 ` Paul Bolle
0 siblings, 1 reply; 9+ messages in thread
From: Stanimir Varbanov @ 2015-03-09 16:53 UTC (permalink / raw)
To: Ivan T. Ivanov, Paul Bolle
Cc: Greg Kroah-Hartman, Kumar Gala, Stephen Boyd, linux-kernel,
linux-arm-msm
On 02/23/2015 02:57 PM, Ivan T. Ivanov wrote:
>
> On Wed, 2015-02-04 at 19:46 +0100, Paul Bolle wrote:
>> On Wed, 2015-02-04 at 17:27 +0200, Stanimir Varbanov wrote:
>>> On 02/04/2015 05:14 PM, Paul Bolle wrote:
>>>> On Wed, 2015-02-04 at 17:05 +0200, Stanimir Varbanov wrote:
>>>>> On 02/03/2015 10:42 PM, Paul Bolle wrote:
>>>>>> On Tue, 2015-02-03 at 15:50 +0200, Stanimir Varbanov wrote:
>>>>>>> diff --git a/drivers/spmi/Kconfig b/drivers/spmi/Kconfig
>>>>>>> index bf1295e..115348c 100644
>>>>>>> --- a/drivers/spmi/Kconfig
>>>>>>> +++ b/drivers/spmi/Kconfig
>>>>>>> @@ -12,7 +12,7 @@ if SPMI
>>>>>>>
>>>>>>> config SPMI_MSM_PMIC_ARB
>>>>>>> tristate "Qualcomm MSM SPMI Controller (PMIC Arbiter)"
>>>>>>> - depends on ARM
>>>>>>> + depends on ARM || ARM64
>>>>>>> depends on IRQ_DOMAIN
>>>>>>> depends on ARCH_QCOM || COMPILE_TEST
>>>>>>> default ARCH_QCOM
>>>>>>
>>>>>> But only if COMPILE_TEST is set too, isn't it? Is that intended?
>>>>>
>>>>> No, the driver will be used on arm64 qcom platforms, also.
>>>>
>>>> But ARCH_QCOM currently is (32 bit) arch/arm only, isn't it?
>>>
>>> Currently yes, but we want to be prepared to support PMIC's which will
>>> be used on arm64 platforms, although they are not upstream yet.
>>
>> Please make the commit summary reflect that, as in:
>> "spmi: pmic_arb: enable test build on arm64"
>>
>> Commit explanation likewise.
>
> What if we just drop ARM dependency?
I'm fine with this, Paul?
--
regards,
Stan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms
2015-03-09 16:53 ` Stanimir Varbanov
@ 2015-03-09 18:57 ` Paul Bolle
0 siblings, 0 replies; 9+ messages in thread
From: Paul Bolle @ 2015-03-09 18:57 UTC (permalink / raw)
To: Stanimir Varbanov
Cc: Ivan T. Ivanov, Greg Kroah-Hartman, Kumar Gala, Stephen Boyd,
linux-kernel, linux-arm-msm
Stanimir Varbanov schreef op ma 09-03-2015 om 18:53 [+0200]:
> On 02/23/2015 02:57 PM, Ivan T. Ivanov wrote:
> > What if we just drop ARM dependency?
>
> I'm fine with this, Paul?
Well I'm fine with anything you do, as long as the Kconfig dependencies
make sense and the commit summary and the commit explanation match the
change. In other words: if you submit an updated patch and I don't bark
you may assume I'm fine with the change. This doesn't need an Ack on my
side anyhow (as if anything does).
Thanks,
Paul Bolle
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-03-09 18:57 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-03 13:50 [PATCH] spmi: pmic_arb: enable build on arm64 platforms Stanimir Varbanov
2015-02-03 20:42 ` Paul Bolle
2015-02-04 15:05 ` Stanimir Varbanov
2015-02-04 15:14 ` Paul Bolle
2015-02-04 15:27 ` Stanimir Varbanov
2015-02-04 18:46 ` Paul Bolle
2015-02-23 12:57 ` Ivan T. Ivanov
2015-03-09 16:53 ` Stanimir Varbanov
2015-03-09 18:57 ` Paul Bolle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.