Re: [PATCH 2/2] libxl: introduce gfx_passthru_kind

From: Ian Campbell <ian.campbell@citrix.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Ian.Jackson@eu.citrix.com, Wei Liu <wei.liu2@citrix.com>,
	qemu-devel@nongnu.org, stefano.stabellini@citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] libxl: introduce gfx_passthru_kind
Date: Wed, 11 Mar 2015 11:23:49 +0000	[thread overview]
Message-ID: <1426073029.21353.185.camel__15540.2668322951$1426073142$gmane$org@citrix.com> (raw)
In-Reply-To: <54FD4190.80606@intel.com>

On Mon, 2015-03-09 at 14:45 +0800, Chen, Tiejun wrote:
> On 2015/3/6 20:55, Wei Liu wrote:
> > On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote:
> >> Although we already have 'gfx_passthru' in b_info, this doesn' suffice
                                                                   ^t

> >> after we want to handle IGD specifically. Now we define a new field of
> >> type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually
> >> this means we can benefit this to support other specific devices just
> >> by extending gfx_passthru_kind. And then we can cooperate with
> >> gfx_passthru to address IGD cases as follows:
> >>
> >>      gfx_passthru = 0    => sets build_info.u.gfx_passthru to false
> >>      gfx_passthru = 1    => sets build_info.u.gfx_passthru to false and
> >                                                                 ^^^^^
> >                                                                 true?
> 
> I just simply pick up this from Campbell's comment but I agree you.

Sorry! Wei is right.