All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
	Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org,
	xen-devel@lists.xen.org, stefano.stabellini@citrix.com
Subject: Re: [Qemu-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream
Date: Fri, 6 Mar 2015 12:28:47 +0000	[thread overview]
Message-ID: <20150306122846.GN12103@zion.uk.xensource.com> (raw)
In-Reply-To: <1425632903-5502-1-git-send-email-tiejun.chen@intel.com>

On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote:
> When we're working to support IGD GFX passthrough with qemu
> upstream, instead of "-gfx_passthru" we'd like to make that
> a machine option, "-machine xxx,igd-passthru=on". This need
> to bring a change on tool side.
> 
> After a discussion with Campbell, we'd like to construct a table to record
> all IGD devices we can support. If we hit that table, we should pass that
> option. And so we also introduce a new field of type, 'gfx_passthru_kind',
> to cooperate with 'gfx_passthru' to cover all scenarios like this,
> 
>     gfx_passthru = 0    => sets build_info.u.gfx_passthru to false
>     gfx_passthru = 1    => sets build_info.u.gfx_passthru to false and
>                            build_info.u.gfx_passthru_kind to DEFAULT
>     gfx_passthru = "igd"    => sets build_info.u.gfx_passthru to false
>                                and build_info.u.gfx_passthru_kind to IGD
> 
> ----------------------------------------------------------------
> Tiejun Chen (2):
>       libxl: introduce libxl__is_igd_vga_passthru
>       libxl: introduce gfx_passthru_kind
>  
>  tools/libxl/libxl_dm.c       |  13 +++++++++++++
>  tools/libxl/libxl_internal.h |   2 ++
>  tools/libxl/libxl_pci.c      | 124 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

It might be helpful to use --stat-width=72 or some other options to
limit the width of your diffstat. :-)

Wei.

>  tools/libxl/libxl_types.idl  |   6 ++++++
>  tools/libxl/xl_cmdimpl.c     |  19 +++++++++++++++++--
>  5 files changed, 162 insertions(+), 2 deletions(-)
> 
> Thanks
> Tiejun

WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu2@citrix.com>
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
	Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org,
	xen-devel@lists.xen.org, stefano.stabellini@citrix.com
Subject: Re: [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream
Date: Fri, 6 Mar 2015 12:28:47 +0000	[thread overview]
Message-ID: <20150306122846.GN12103@zion.uk.xensource.com> (raw)
In-Reply-To: <1425632903-5502-1-git-send-email-tiejun.chen@intel.com>

On Fri, Mar 06, 2015 at 05:08:21PM +0800, Tiejun Chen wrote:
> When we're working to support IGD GFX passthrough with qemu
> upstream, instead of "-gfx_passthru" we'd like to make that
> a machine option, "-machine xxx,igd-passthru=on". This need
> to bring a change on tool side.
> 
> After a discussion with Campbell, we'd like to construct a table to record
> all IGD devices we can support. If we hit that table, we should pass that
> option. And so we also introduce a new field of type, 'gfx_passthru_kind',
> to cooperate with 'gfx_passthru' to cover all scenarios like this,
> 
>     gfx_passthru = 0    => sets build_info.u.gfx_passthru to false
>     gfx_passthru = 1    => sets build_info.u.gfx_passthru to false and
>                            build_info.u.gfx_passthru_kind to DEFAULT
>     gfx_passthru = "igd"    => sets build_info.u.gfx_passthru to false
>                                and build_info.u.gfx_passthru_kind to IGD
> 
> ----------------------------------------------------------------
> Tiejun Chen (2):
>       libxl: introduce libxl__is_igd_vga_passthru
>       libxl: introduce gfx_passthru_kind
>  
>  tools/libxl/libxl_dm.c       |  13 +++++++++++++
>  tools/libxl/libxl_internal.h |   2 ++
>  tools/libxl/libxl_pci.c      | 124 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

It might be helpful to use --stat-width=72 or some other options to
limit the width of your diffstat. :-)

Wei.

>  tools/libxl/libxl_types.idl  |   6 ++++++
>  tools/libxl/xl_cmdimpl.c     |  19 +++++++++++++++++--
>  5 files changed, 162 insertions(+), 2 deletions(-)
> 
> Thanks
> Tiejun

  parent reply	other threads:[~2015-03-06 12:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  9:08 [Qemu-devel] [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream Tiejun Chen
2015-03-06  9:08 ` [Qemu-devel] [PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru Tiejun Chen
2015-03-06 12:40   ` Wei Liu
2015-03-06 12:40     ` Wei Liu
2015-03-09  6:27     ` Chen, Tiejun
2015-03-09  6:27     ` [Qemu-devel] " Chen, Tiejun
2015-03-09 10:12       ` Wei Liu
2015-03-09 10:12       ` Wei Liu
2015-03-06  9:08 ` Tiejun Chen
2015-03-06  9:08 ` [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind Tiejun Chen
2015-03-06  9:18   ` Chen, Tiejun
2015-03-06  9:18   ` Chen, Tiejun
2015-03-06 12:59     ` Wei Liu
2015-03-06 12:59     ` Wei Liu
2015-03-09  6:50       ` Chen, Tiejun
2015-03-09 10:13         ` Wei Liu
2015-03-09 10:13         ` Wei Liu
2015-03-09  6:50       ` Chen, Tiejun
2015-03-06 12:55   ` Wei Liu
2015-03-09  6:45     ` Chen, Tiejun
2015-03-09  6:45     ` [Qemu-devel] " Chen, Tiejun
2015-03-09 10:17       ` Wei Liu
2015-03-10  0:28         ` Chen, Tiejun
2015-03-10  0:28         ` [Qemu-devel] " Chen, Tiejun
2015-03-09 10:17       ` Wei Liu
2015-03-11 11:23       ` Ian Campbell
2015-03-11 11:23       ` [Qemu-devel] " Ian Campbell
2015-03-06 12:55   ` Wei Liu
2015-03-06  9:08 ` Tiejun Chen
2015-03-06 12:28 ` Wei Liu [this message]
2015-03-06 12:28   ` [PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream Wei Liu
2015-03-09  5:32   ` Chen, Tiejun
2015-03-09  5:32   ` [Qemu-devel] " Chen, Tiejun
2015-03-06 15:53 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
2015-03-09  6:58   ` Chen, Tiejun
2015-03-09  6:58   ` [Qemu-devel] [Xen-devel] " Chen, Tiejun
2015-03-06 15:53 ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150306122846.GN12103@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tiejun.chen@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.