* [review-request][PATCH] bitbake: toaster: projectconf fix typo of package name
@ 2015-03-11 18:19 Michael Wood
2015-03-12 10:32 ` Damian, Alexandru
2015-03-12 10:42 ` Barros Pena, Belen
0 siblings, 2 replies; 3+ messages in thread
From: Michael Wood @ 2015-03-11 18:19 UTC (permalink / raw)
To: toaster
The package should be deb rather than dev.
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
---
.../toaster/toastergui/templates/projectconf.html | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/bitbake/lib/toaster/toastergui/templates/projectconf.html b/bitbake/lib/toaster/toastergui/templates/projectconf.html
index 774e9ea..12bda67 100644
--- a/bitbake/lib/toaster/toastergui/templates/projectconf.html
+++ b/bitbake/lib/toaster/toastergui/templates/projectconf.html
@@ -79,7 +79,7 @@
<i class="icon-question-sign get-help" title="The package format used to generate the root file system. Options are <code>dev</code>, <code>ipk</code> and <code>rpm</code>"></i>
</label>
<select id="package_classes-select">
- <option>package_dev</option>
+ <option>package_deb</option>
<option>package_ipk</option>
<option>package_rpm</option>
</select>
@@ -88,7 +88,7 @@
<i class="icon-question-sign get-help" title="Extra package formats to build"></i>
</label>
<label class="checkbox" id="package_class_1">
- <input type="checkbox" id="package_class_1_input"> package_dev
+ <input type="checkbox" id="package_class_1_input"> package_deb
</label>
<label class="checkbox" id="package_class_2">
<input type="checkbox" id="package_class_2_input"> package_ipk
@@ -293,16 +293,16 @@
// Preset or reset the Package Class checkbox labels
function updatePackageClassCheckboxes() {
$('#package_class_1, #package_class_2').hide();
- if ($('select').val() == 'package_dev') {
+ if ($('select').val() == 'package_deb') {
$('#package_class_1').html('<input type="checkbox" id="package_class_1_input"> package_ipk');
$('#package_class_2').html('<input type="checkbox" id="package_class_2_input"> package_rpm');
}
if ($('select').val() == 'package_ipk') {
- $('#package_class_1').html('<input type="checkbox" id="package_class_1_input"> package_dev');
+ $('#package_class_1').html('<input type="checkbox" id="package_class_1_input"> package_deb');
$('#package_class_2').html('<input type="checkbox" id="package_class_2_input"> package_rpm');
}
if ($('select').val() == 'package_rpm') {
- $('#package_class_1').html('<input type="checkbox" id="package_class_1_input"> package_dev');
+ $('#package_class_1').html('<input type="checkbox" id="package_class_1_input"> package_deb');
$('#package_class_2').html('<input type="checkbox" id="package_class_2_input"> package_ipk');
}
$('#package_class_1, #package_class_2').fadeIn(1500);
@@ -639,7 +639,7 @@
// initialize the pulldown and checkboxes
var value = document.getElementById("package_classes").innerHTML;
- if (0 == value.indexOf("package_dev")) {
+ if (0 == value.indexOf("package_deb")) {
$('select').selectedIndex = 0;
updatePackageClassCheckboxes();
if (0 < value.indexOf("package_ipk")) {document.getElementById("package_class_1_input").checked = true};
@@ -648,13 +648,13 @@
if (0 == value.indexOf("package_ipk")) {
$('select').selectedIndex = 1;
updatePackageClassCheckboxes();
- if (0 < value.indexOf("package_dev")) {document.getElementById("package_class_1_input").checked = true;};
+ if (0 < value.indexOf("package_deb")) {document.getElementById("package_class_1_input").checked = true;};
if (0 < value.indexOf("package_rpm")) {document.getElementById("package_class_2_input").checked = true;};
}
if (0 == value.indexOf("package_rpm")) {
$('select').selectedIndex = 2;
updatePackageClassCheckboxes();
- if (0 < value.indexOf("package_dev")) {document.getElementById("#package_class_1_input").checked = true;};
+ if (0 < value.indexOf("package_deb")) {document.getElementById("#package_class_1_input").checked = true;};
if (0 < value.indexOf("package_ipk")) {document.getElementById("#package_class_2_input").checked = true;};
}
});
@@ -675,16 +675,16 @@
pc1_checked = document.getElementById("package_class_1_input").checked;
pc2_checked = document.getElementById("package_class_2_input").checked;
- if (val == "package_dev") {
+ if (val == "package_deb") {
if (pc1_checked) val = val + " package_ipk";
if (pc2_checked) val = val + " package_rpm";
}
if (val == "package_ipk") {
- if (pc1_checked) val = val + " package_dev";
+ if (pc1_checked) val = val + " package_deb";
if (pc2_checked) val = val + " package_rpm";
}
if (val == "package_rpm") {
- if (pc1_checked) val = val + " package_dev";
+ if (pc1_checked) val = val + " package_deb";
if (pc2_checked) val = val + " package_ipk";
}
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: projectconf fix typo of package name
2015-03-11 18:19 [review-request][PATCH] bitbake: toaster: projectconf fix typo of package name Michael Wood
@ 2015-03-12 10:32 ` Damian, Alexandru
2015-03-12 10:42 ` Barros Pena, Belen
1 sibling, 0 replies; 3+ messages in thread
From: Damian, Alexandru @ 2015-03-12 10:32 UTC (permalink / raw)
To: Michael Wood; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 6440 bytes --]
Taken for submission,
Thank you,
Alex
On Wed, Mar 11, 2015 at 6:19 PM, Michael Wood <michael.g.wood@intel.com>
wrote:
> The package should be deb rather than dev.
>
> Signed-off-by: Michael Wood <michael.g.wood@intel.com>
> ---
> .../toaster/toastergui/templates/projectconf.html | 22
> +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/projectconf.html
> b/bitbake/lib/toaster/toastergui/templates/projectconf.html
> index 774e9ea..12bda67 100644
> --- a/bitbake/lib/toaster/toastergui/templates/projectconf.html
> +++ b/bitbake/lib/toaster/toastergui/templates/projectconf.html
> @@ -79,7 +79,7 @@
> <i class="icon-question-sign get-help" title="The
> package format used to generate the root file system. Options are
> <code>dev</code>, <code>ipk</code> and <code>rpm</code>"></i>
> </label>
> <select id="package_classes-select">
> - <option>package_dev</option>
> + <option>package_deb</option>
> <option>package_ipk</option>
> <option>package_rpm</option>
> </select>
> @@ -88,7 +88,7 @@
> <i class="icon-question-sign get-help"
> title="Extra package formats to build"></i>
> </label>
> <label class="checkbox" id="package_class_1">
> - <input type="checkbox"
> id="package_class_1_input"> package_dev
> + <input type="checkbox"
> id="package_class_1_input"> package_deb
> </label>
> <label class="checkbox" id="package_class_2">
> <input type="checkbox"
> id="package_class_2_input"> package_ipk
> @@ -293,16 +293,16 @@
> // Preset or reset the Package Class checkbox labels
> function updatePackageClassCheckboxes() {
> $('#package_class_1, #package_class_2').hide();
> - if ($('select').val() == 'package_dev') {
> + if ($('select').val() == 'package_deb') {
> $('#package_class_1').html('<input type="checkbox"
> id="package_class_1_input"> package_ipk');
> $('#package_class_2').html('<input type="checkbox"
> id="package_class_2_input"> package_rpm');
> }
> if ($('select').val() == 'package_ipk') {
> - $('#package_class_1').html('<input type="checkbox"
> id="package_class_1_input"> package_dev');
> + $('#package_class_1').html('<input type="checkbox"
> id="package_class_1_input"> package_deb');
> $('#package_class_2').html('<input type="checkbox"
> id="package_class_2_input"> package_rpm');
> }
> if ($('select').val() == 'package_rpm') {
> - $('#package_class_1').html('<input type="checkbox"
> id="package_class_1_input"> package_dev');
> + $('#package_class_1').html('<input type="checkbox"
> id="package_class_1_input"> package_deb');
> $('#package_class_2').html('<input type="checkbox"
> id="package_class_2_input"> package_ipk');
> }
> $('#package_class_1, #package_class_2').fadeIn(1500);
> @@ -639,7 +639,7 @@
>
> // initialize the pulldown and checkboxes
> var value =
> document.getElementById("package_classes").innerHTML;
> - if (0 == value.indexOf("package_dev")) {
> + if (0 == value.indexOf("package_deb")) {
> $('select').selectedIndex = 0;
> updatePackageClassCheckboxes();
> if (0 < value.indexOf("package_ipk"))
> {document.getElementById("package_class_1_input").checked = true};
> @@ -648,13 +648,13 @@
> if (0 == value.indexOf("package_ipk")) {
> $('select').selectedIndex = 1;
> updatePackageClassCheckboxes();
> - if (0 < value.indexOf("package_dev"))
> {document.getElementById("package_class_1_input").checked = true;};
> + if (0 < value.indexOf("package_deb"))
> {document.getElementById("package_class_1_input").checked = true;};
> if (0 < value.indexOf("package_rpm"))
> {document.getElementById("package_class_2_input").checked = true;};
> }
> if (0 == value.indexOf("package_rpm")) {
> $('select').selectedIndex = 2;
> updatePackageClassCheckboxes();
> - if (0 < value.indexOf("package_dev"))
> {document.getElementById("#package_class_1_input").checked = true;};
> + if (0 < value.indexOf("package_deb"))
> {document.getElementById("#package_class_1_input").checked = true;};
> if (0 < value.indexOf("package_ipk"))
> {document.getElementById("#package_class_2_input").checked = true;};
> }
> });
> @@ -675,16 +675,16 @@
>
> pc1_checked =
> document.getElementById("package_class_1_input").checked;
> pc2_checked =
> document.getElementById("package_class_2_input").checked;
> - if (val == "package_dev") {
> + if (val == "package_deb") {
> if (pc1_checked) val = val + " package_ipk";
> if (pc2_checked) val = val + " package_rpm";
> }
> if (val == "package_ipk") {
> - if (pc1_checked) val = val + " package_dev";
> + if (pc1_checked) val = val + " package_deb";
> if (pc2_checked) val = val + " package_rpm";
> }
> if (val == "package_rpm") {
> - if (pc1_checked) val = val + " package_dev";
> + if (pc1_checked) val = val + " package_deb";
> if (pc2_checked) val = val + " package_ipk";
> }
>
> --
> 2.1.0
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
--
Alex Damian
Yocto Project
SSG / OTC
[-- Attachment #2: Type: text/html, Size: 9235 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [review-request][PATCH] bitbake: toaster: projectconf fix typo of package name
2015-03-11 18:19 [review-request][PATCH] bitbake: toaster: projectconf fix typo of package name Michael Wood
2015-03-12 10:32 ` Damian, Alexandru
@ 2015-03-12 10:42 ` Barros Pena, Belen
1 sibling, 0 replies; 3+ messages in thread
From: Barros Pena, Belen @ 2015-03-12 10:42 UTC (permalink / raw)
To: Wood, Michael G, toaster
Gave this a quick go, and seems to be working fine.
Thanks!
Belén
On 11/03/2015 18:19, "Michael Wood" <michael.g.wood@intel.com> wrote:
>The package should be deb rather than dev.
>
>Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>---
> .../toaster/toastergui/templates/projectconf.html | 22
>+++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/bitbake/lib/toaster/toastergui/templates/projectconf.html
>b/bitbake/lib/toaster/toastergui/templates/projectconf.html
>index 774e9ea..12bda67 100644
>--- a/bitbake/lib/toaster/toastergui/templates/projectconf.html
>+++ b/bitbake/lib/toaster/toastergui/templates/projectconf.html
>@@ -79,7 +79,7 @@
> <i class="icon-question-sign get-help"
>title="The package format used to generate the root file system. Options
>are <code>dev</code>, <code>ipk</code> and <code>rpm</code>"></i>
> </label>
> <select id="package_classes-select">
>- <option>package_dev</option>
>+ <option>package_deb</option>
> <option>package_ipk</option>
> <option>package_rpm</option>
> </select>
>@@ -88,7 +88,7 @@
> <i class="icon-question-sign get-help"
>title="Extra package formats to build"></i>
> </label>
> <label class="checkbox" id="package_class_1">
>- <input type="checkbox"
>id="package_class_1_input"> package_dev
>+ <input type="checkbox"
>id="package_class_1_input"> package_deb
> </label>
> <label class="checkbox" id="package_class_2">
> <input type="checkbox"
>id="package_class_2_input"> package_ipk
>@@ -293,16 +293,16 @@
> // Preset or reset the Package Class checkbox labels
> function updatePackageClassCheckboxes() {
> $('#package_class_1, #package_class_2').hide();
>- if ($('select').val() == 'package_dev') {
>+ if ($('select').val() == 'package_deb') {
> $('#package_class_1').html('<input type="checkbox"
>id="package_class_1_input"> package_ipk');
> $('#package_class_2').html('<input type="checkbox"
>id="package_class_2_input"> package_rpm');
> }
> if ($('select').val() == 'package_ipk') {
>- $('#package_class_1').html('<input type="checkbox"
>id="package_class_1_input"> package_dev');
>+ $('#package_class_1').html('<input type="checkbox"
>id="package_class_1_input"> package_deb');
> $('#package_class_2').html('<input type="checkbox"
>id="package_class_2_input"> package_rpm');
> }
> if ($('select').val() == 'package_rpm') {
>- $('#package_class_1').html('<input type="checkbox"
>id="package_class_1_input"> package_dev');
>+ $('#package_class_1').html('<input type="checkbox"
>id="package_class_1_input"> package_deb');
> $('#package_class_2').html('<input type="checkbox"
>id="package_class_2_input"> package_ipk');
> }
> $('#package_class_1, #package_class_2').fadeIn(1500);
>@@ -639,7 +639,7 @@
>
> // initialize the pulldown and checkboxes
> var value =
>document.getElementById("package_classes").innerHTML;
>- if (0 == value.indexOf("package_dev")) {
>+ if (0 == value.indexOf("package_deb")) {
> $('select').selectedIndex = 0;
> updatePackageClassCheckboxes();
> if (0 < value.indexOf("package_ipk"))
>{document.getElementById("package_class_1_input").checked = true};
>@@ -648,13 +648,13 @@
> if (0 == value.indexOf("package_ipk")) {
> $('select').selectedIndex = 1;
> updatePackageClassCheckboxes();
>- if (0 < value.indexOf("package_dev"))
>{document.getElementById("package_class_1_input").checked = true;};
>+ if (0 < value.indexOf("package_deb"))
>{document.getElementById("package_class_1_input").checked = true;};
> if (0 < value.indexOf("package_rpm"))
>{document.getElementById("package_class_2_input").checked = true;};
> }
> if (0 == value.indexOf("package_rpm")) {
> $('select').selectedIndex = 2;
> updatePackageClassCheckboxes();
>- if (0 < value.indexOf("package_dev"))
>{document.getElementById("#package_class_1_input").checked = true;};
>+ if (0 < value.indexOf("package_deb"))
>{document.getElementById("#package_class_1_input").checked = true;};
> if (0 < value.indexOf("package_ipk"))
>{document.getElementById("#package_class_2_input").checked = true;};
> }
> });
>@@ -675,16 +675,16 @@
>
> pc1_checked =
>document.getElementById("package_class_1_input").checked;
> pc2_checked =
>document.getElementById("package_class_2_input").checked;
>- if (val == "package_dev") {
>+ if (val == "package_deb") {
> if (pc1_checked) val = val + " package_ipk";
> if (pc2_checked) val = val + " package_rpm";
> }
> if (val == "package_ipk") {
>- if (pc1_checked) val = val + " package_dev";
>+ if (pc1_checked) val = val + " package_deb";
> if (pc2_checked) val = val + " package_rpm";
> }
> if (val == "package_rpm") {
>- if (pc1_checked) val = val + " package_dev";
>+ if (pc1_checked) val = val + " package_deb";
> if (pc2_checked) val = val + " package_ipk";
> }
>
>--
>2.1.0
>
>--
>_______________________________________________
>toaster mailing list
>toaster@yoctoproject.org
>https://lists.yoctoproject.org/listinfo/toaster
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-12 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-11 18:19 [review-request][PATCH] bitbake: toaster: projectconf fix typo of package name Michael Wood
2015-03-12 10:32 ` Damian, Alexandru
2015-03-12 10:42 ` Barros Pena, Belen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.