* [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
@ 2015-03-12 3:55 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 3:55 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
this short series corrects the SYSCIER value used on the r9a7790 and
r8a7791 SoCs.
I am not aware of any run-time effect of these changes.
This series is based on renesas-devel-20150312-v4.0-rc3
Simon Horman (2):
ARM: shmobile: r8a7790: Correct SYSCIER value
ARM: shmobile: r8a7791: Correct SYSCIER value
arch/arm/mach-shmobile/pm-r8a7790.c | 2 +-
arch/arm/mach-shmobile/pm-r8a7791.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.1.4
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
@ 2015-03-12 3:55 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 3:55 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
this short series corrects the SYSCIER value used on the r9a7790 and
r8a7791 SoCs.
I am not aware of any run-time effect of these changes.
This series is based on renesas-devel-20150312-v4.0-rc3
Simon Horman (2):
ARM: shmobile: r8a7790: Correct SYSCIER value
ARM: shmobile: r8a7791: Correct SYSCIER value
arch/arm/mach-shmobile/pm-r8a7790.c | 2 +-
arch/arm/mach-shmobile/pm-r8a7791.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.1.4
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] ARM: shmobile: r8a7790: Correct SYSCIER value
2015-03-12 3:55 ` Simon Horman
@ 2015-03-12 3:55 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 3:55 UTC (permalink / raw)
To: linux-arm-kernel
Set the SYSCIER as per the values indicated in the documentation.
The value previously used appears to been copied from the r8a7779
implementation but on closer inspection is not correct for the r8a7790.
Fixes: a48f165509c1 ("ARM: shmobile: r8a7790 SYSC setup code")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/pm-r8a7790.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/pm-r8a7790.c b/arch/arm/mach-shmobile/pm-r8a7790.c
index 80e8d95..23b61f1 100644
--- a/arch/arm/mach-shmobile/pm-r8a7790.c
+++ b/arch/arm/mach-shmobile/pm-r8a7790.c
@@ -38,7 +38,7 @@ static void __init r8a7790_sysc_init(void)
void __iomem *base = rcar_sysc_init(0xe6180000);
/* enable all interrupt sources, but do not use interrupt handler */
- iowrite32(0x0131000e, base + SYSCIER);
+ iowrite32(0x013111ef, base + SYSCIER);
iowrite32(0, base + SYSCIMR);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] ARM: shmobile: r8a7790: Correct SYSCIER value
@ 2015-03-12 3:55 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 3:55 UTC (permalink / raw)
To: linux-arm-kernel
Set the SYSCIER as per the values indicated in the documentation.
The value previously used appears to been copied from the r8a7779
implementation but on closer inspection is not correct for the r8a7790.
Fixes: a48f165509c1 ("ARM: shmobile: r8a7790 SYSC setup code")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/pm-r8a7790.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/pm-r8a7790.c b/arch/arm/mach-shmobile/pm-r8a7790.c
index 80e8d95..23b61f1 100644
--- a/arch/arm/mach-shmobile/pm-r8a7790.c
+++ b/arch/arm/mach-shmobile/pm-r8a7790.c
@@ -38,7 +38,7 @@ static void __init r8a7790_sysc_init(void)
void __iomem *base = rcar_sysc_init(0xe6180000);
/* enable all interrupt sources, but do not use interrupt handler */
- iowrite32(0x0131000e, base + SYSCIER);
+ iowrite32(0x013111ef, base + SYSCIER);
iowrite32(0, base + SYSCIMR);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7791: Correct SYSCIER value
2015-03-12 3:55 ` Simon Horman
@ 2015-03-12 3:55 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 3:55 UTC (permalink / raw)
To: linux-arm-kernel
Set the SYSCIER as per the values indicated in the documentation.
The value previously used appears to been copied from the r8a7779
implementation but on closer inspection is not correct for the r8a7791.
Fixes: 5f6108bb9643 ("ARM: shmobile: r8a7791 SYSC setup code")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/pm-r8a7791.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/pm-r8a7791.c b/arch/arm/mach-shmobile/pm-r8a7791.c
index 25f107b..f7cfb3b 100644
--- a/arch/arm/mach-shmobile/pm-r8a7791.c
+++ b/arch/arm/mach-shmobile/pm-r8a7791.c
@@ -33,7 +33,7 @@ static void __init r8a7791_sysc_init(void)
void __iomem *base = rcar_sysc_init(0xe6180000);
/* enable all interrupt sources, but do not use interrupt handler */
- iowrite32(0x0131000e, base + SYSCIER);
+ iowrite32(0x00111003, base + SYSCIER);
iowrite32(0, base + SYSCIMR);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7791: Correct SYSCIER value
@ 2015-03-12 3:55 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 3:55 UTC (permalink / raw)
To: linux-arm-kernel
Set the SYSCIER as per the values indicated in the documentation.
The value previously used appears to been copied from the r8a7779
implementation but on closer inspection is not correct for the r8a7791.
Fixes: 5f6108bb9643 ("ARM: shmobile: r8a7791 SYSC setup code")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/pm-r8a7791.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/pm-r8a7791.c b/arch/arm/mach-shmobile/pm-r8a7791.c
index 25f107b..f7cfb3b 100644
--- a/arch/arm/mach-shmobile/pm-r8a7791.c
+++ b/arch/arm/mach-shmobile/pm-r8a7791.c
@@ -33,7 +33,7 @@ static void __init r8a7791_sysc_init(void)
void __iomem *base = rcar_sysc_init(0xe6180000);
/* enable all interrupt sources, but do not use interrupt handler */
- iowrite32(0x0131000e, base + SYSCIER);
+ iowrite32(0x00111003, base + SYSCIER);
iowrite32(0, base + SYSCIMR);
}
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
2015-03-12 3:55 ` Simon Horman
@ 2015-03-12 8:03 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2015-03-12 8:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Thu, Mar 12, 2015 at 4:55 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> this short series corrects the SYSCIER value used on the r9a7790 and
> r8a7791 SoCs.
Thanks!
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> I am not aware of any run-time effect of these changes.
They only matter when powering up/down SYSC PM Domains, which is not
yet implemented for R-Car Gen2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
@ 2015-03-12 8:03 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2015-03-12 8:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Thu, Mar 12, 2015 at 4:55 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> this short series corrects the SYSCIER value used on the r9a7790 and
> r8a7791 SoCs.
Thanks!
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> I am not aware of any run-time effect of these changes.
They only matter when powering up/down SYSC PM Domains, which is not
yet implemented for R-Car Gen2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
2015-03-12 8:03 ` Geert Uytterhoeven
@ 2015-03-12 8:14 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 8:14 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 12, 2015 at 09:03:04AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Thu, Mar 12, 2015 at 4:55 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > this short series corrects the SYSCIER value used on the r9a7790 and
> > r8a7791 SoCs.
>
> Thanks!
>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > I am not aware of any run-time effect of these changes.
>
> They only matter when powering up/down SYSC PM Domains, which is not
> yet implemented for R-Car Gen2.
Thanks, good to know.
FWIW the values in these patches are the ones that
you supplied in another email thread. However, I did
verify them against (my reading of) the documentation.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
@ 2015-03-12 8:14 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2015-03-12 8:14 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 12, 2015 at 09:03:04AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Thu, Mar 12, 2015 at 4:55 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > this short series corrects the SYSCIER value used on the r9a7790 and
> > r8a7791 SoCs.
>
> Thanks!
>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > I am not aware of any run-time effect of these changes.
>
> They only matter when powering up/down SYSC PM Domains, which is not
> yet implemented for R-Car Gen2.
Thanks, good to know.
FWIW the values in these patches are the ones that
you supplied in another email thread. However, I did
verify them against (my reading of) the documentation.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
2015-03-12 8:14 ` Simon Horman
@ 2015-03-12 8:21 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2015-03-12 8:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Thu, Mar 12, 2015 at 9:14 AM, Simon Horman <horms@verge.net.au> wrote:
> FWIW the values in these patches are the ones that
> you supplied in another email thread. However, I did
> verify them against (my reading of) the documentation.
We could introduce symbols for them. I don't think it's worth doing that at
this point, as ideally these values should come from DT.
If you disagree, feel free to use what I was carrying in my local tree
to get a better understanding (needs some consolidation):
/* SYSC Interrupt Status/Status Clear/Enable/Mask Register */
/* R-Car H1 */
#define SYSCI_IMP BIT(24) /* IMP-X3 */
#define SYSCI_VDP BIT(21) /* VDP1 */
#define SYSCI_SGX BIT(20) /* SGX543 MP2 */
#define SYSCI_SH4A BIT(16) /* SH-4A (Not documented on H1) */
#define SYSCI_ARM3 BIT(3) /* ARM3 */
#define SYSCI_ARM2 BIT(2) /* ARM2 */
#define SYSCI_ARM1 BIT(1) /* ARM1 */
/* R-Car H2 */
#define SYSCI_IMP BIT(24) /* IMP-X4 */
#define SYSCI_CA7_SCU BIT(21) /* CA7-SCU */
#define SYSCI_RGX BIT(20) /* RGX */
#define SYSCI_SH4A BIT(16) /* SH-4A */
#define SYSCI_CA15_SCU BIT(12) /* CA15-SCU */
#define SYSCI_CA7_CPU(i) BIT(5 + (i)) /* CA7-CPUi */
#define SYSCI_CA15_CPU(i) BIT(i) /* CA15-CPUi */
/* R-Car M2-W/M2-N */
#define SYSCI_SGX BIT(20) /* SGX */
#define SYSCI_SH4A BIT(16) /* SH-4A */
#define SYSCI_CA15_SCU BIT(12) /* CA15-SCU */
#define SYSCI_CA15_CPU(i) BIT(i) /* CA15-CPUi */
/* R-Car V2H */
#define SYSCI_IMP BIT(24) /* IMP-X4 */
#define SYSCI_SGX BIT(20) /* SGX */
#define SYSCI_CA15_SCU BIT(12) /* CA15-SCU */
#define SYSCI_CA15_CPU(i) BIT(i) /* CA15-CPUi */
/* R-Car E2 */
#define SYSCI_CA7_SCU BIT(21) /* CA7-SCU */
#define SYSCI_SGX BIT(20) /* SGX */
#define SYSCI_SH4A BIT(16) /* SH-4A */
#define SYSCI_CA7_CPU(i) BIT(5 + (i)) /* CA7-CPUi */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] ARM: shmobile: Correct SYSCIER values
@ 2015-03-12 8:21 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2015-03-12 8:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Thu, Mar 12, 2015 at 9:14 AM, Simon Horman <horms@verge.net.au> wrote:
> FWIW the values in these patches are the ones that
> you supplied in another email thread. However, I did
> verify them against (my reading of) the documentation.
We could introduce symbols for them. I don't think it's worth doing that at
this point, as ideally these values should come from DT.
If you disagree, feel free to use what I was carrying in my local tree
to get a better understanding (needs some consolidation):
/* SYSC Interrupt Status/Status Clear/Enable/Mask Register */
/* R-Car H1 */
#define SYSCI_IMP BIT(24) /* IMP-X3 */
#define SYSCI_VDP BIT(21) /* VDP1 */
#define SYSCI_SGX BIT(20) /* SGX543 MP2 */
#define SYSCI_SH4A BIT(16) /* SH-4A (Not documented on H1) */
#define SYSCI_ARM3 BIT(3) /* ARM3 */
#define SYSCI_ARM2 BIT(2) /* ARM2 */
#define SYSCI_ARM1 BIT(1) /* ARM1 */
/* R-Car H2 */
#define SYSCI_IMP BIT(24) /* IMP-X4 */
#define SYSCI_CA7_SCU BIT(21) /* CA7-SCU */
#define SYSCI_RGX BIT(20) /* RGX */
#define SYSCI_SH4A BIT(16) /* SH-4A */
#define SYSCI_CA15_SCU BIT(12) /* CA15-SCU */
#define SYSCI_CA7_CPU(i) BIT(5 + (i)) /* CA7-CPUi */
#define SYSCI_CA15_CPU(i) BIT(i) /* CA15-CPUi */
/* R-Car M2-W/M2-N */
#define SYSCI_SGX BIT(20) /* SGX */
#define SYSCI_SH4A BIT(16) /* SH-4A */
#define SYSCI_CA15_SCU BIT(12) /* CA15-SCU */
#define SYSCI_CA15_CPU(i) BIT(i) /* CA15-CPUi */
/* R-Car V2H */
#define SYSCI_IMP BIT(24) /* IMP-X4 */
#define SYSCI_SGX BIT(20) /* SGX */
#define SYSCI_CA15_SCU BIT(12) /* CA15-SCU */
#define SYSCI_CA15_CPU(i) BIT(i) /* CA15-CPUi */
/* R-Car E2 */
#define SYSCI_CA7_SCU BIT(21) /* CA7-SCU */
#define SYSCI_SGX BIT(20) /* SGX */
#define SYSCI_SH4A BIT(16) /* SH-4A */
#define SYSCI_CA7_CPU(i) BIT(5 + (i)) /* CA7-CPUi */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-03-12 8:21 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12 3:55 [PATCH 0/2] ARM: shmobile: Correct SYSCIER values Simon Horman
2015-03-12 3:55 ` Simon Horman
2015-03-12 3:55 ` [PATCH 1/2] ARM: shmobile: r8a7790: Correct SYSCIER value Simon Horman
2015-03-12 3:55 ` Simon Horman
2015-03-12 3:55 ` [PATCH 2/2] ARM: shmobile: r8a7791: " Simon Horman
2015-03-12 3:55 ` Simon Horman
2015-03-12 8:03 ` [PATCH 0/2] ARM: shmobile: Correct SYSCIER values Geert Uytterhoeven
2015-03-12 8:03 ` Geert Uytterhoeven
2015-03-12 8:14 ` Simon Horman
2015-03-12 8:14 ` Simon Horman
2015-03-12 8:21 ` Geert Uytterhoeven
2015-03-12 8:21 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.