All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] meta/lib/oe/package.py: Fix for bug 7428
@ 2015-03-12  7:57 Fabrice Coulon
  2015-03-12 12:08 ` Burton, Ross
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Coulon @ 2015-03-12  7:57 UTC (permalink / raw)
  To: openembedded-core; +Cc: Fabrice Coulon

This fix solves the problem with the ownership of files in packages.
The do_install task was producing correct and expected output but when
the files were being put in, e.g. a rpm package, the ownership could
be different than that in the do_install task.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Fabrice Coulon <fabrice.coulon@axis.com>
---
 meta/lib/oe/package.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 7c728fc..8bc56c6 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -31,7 +31,7 @@ def runstrip(arg):
         extraflags = "--remove-section=.comment --remove-section=.note"
 
     # Use mv to break hardlinks
-    stripcmd = "'%s' %s '%s' -o '%s.tmp' && mv '%s.tmp' '%s'" % (strip, extraflags, file, file, file, file)
+    stripcmd = "'%s' %s '%s' -o '%s.tmp' && chown --reference='%s' '%s.tmp' && mv '%s.tmp' '%s'" % (strip, extraflags, file, file, file, file, file, file)
     bb.debug(1, "runstrip: %s" % stripcmd)
 
     ret = subprocess.call(stripcmd, shell=True)
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] meta/lib/oe/package.py: Fix for bug 7428
  2015-03-12  7:57 [PATCH] meta/lib/oe/package.py: Fix for bug 7428 Fabrice Coulon
@ 2015-03-12 12:08 ` Burton, Ross
  0 siblings, 0 replies; 2+ messages in thread
From: Burton, Ross @ 2015-03-12 12:08 UTC (permalink / raw)
  To: Fabrice Coulon; +Cc: Fabrice Coulon, OE-core

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Please change the commit summary to describe what the problem/fix is,
instead of just linking to the bug number.  Then at the end of the commit
message, refer to the bug like [YOCTO #7428].

Ross

On 12 March 2015 at 07:57, Fabrice Coulon <fabrice.coulon@axis.com> wrote:

> This fix solves the problem with the ownership of files in packages.
> The do_install task was producing correct and expected output but when
> the files were being put in, e.g. a rpm package, the ownership could
> be different than that in the do_install task.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Signed-off-by: Fabrice Coulon <fabrice.coulon@axis.com>
> ---
>  meta/lib/oe/package.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
> index 7c728fc..8bc56c6 100644
> --- a/meta/lib/oe/package.py
> +++ b/meta/lib/oe/package.py
> @@ -31,7 +31,7 @@ def runstrip(arg):
>          extraflags = "--remove-section=.comment --remove-section=.note"
>
>      # Use mv to break hardlinks
> -    stripcmd = "'%s' %s '%s' -o '%s.tmp' && mv '%s.tmp' '%s'" % (strip,
> extraflags, file, file, file, file)
> +    stripcmd = "'%s' %s '%s' -o '%s.tmp' && chown --reference='%s'
> '%s.tmp' && mv '%s.tmp' '%s'" % (strip, extraflags, file, file, file, file,
> file, file)
>      bb.debug(1, "runstrip: %s" % stripcmd)
>
>      ret = subprocess.call(stripcmd, shell=True)
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2566 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-12 12:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12  7:57 [PATCH] meta/lib/oe/package.py: Fix for bug 7428 Fabrice Coulon
2015-03-12 12:08 ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.