* [PATCH 1/3] mwifiex: fix a bug in Rx multiport aggregation logic
@ 2015-03-12 8:29 Amitkumar Karwar
2015-03-16 16:04 ` [1/3] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Amitkumar Karwar @ 2015-03-12 8:29 UTC (permalink / raw)
To: linux-wireless; +Cc: Cathy Luo, Avinash Patil, Amitkumar Karwar
From: Cathy Luo <cluo@marvell.com>
It's been observed Rx aggregated packets are always followed
by a single Rx packet. This patch improves our logic to add
that extra packet in next aggregation.
Signed-off-by: Cathy Luo <cluo@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
---
drivers/net/wireless/mwifiex/sdio.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c
index 57d85ab..9ef010b 100644
--- a/drivers/net/wireless/mwifiex/sdio.c
+++ b/drivers/net/wireless/mwifiex/sdio.c
@@ -1133,6 +1133,7 @@ static int mwifiex_sdio_card_to_host_mp_aggr(struct mwifiex_adapter *adapter,
s32 f_do_rx_aggr = 0;
s32 f_do_rx_cur = 0;
s32 f_aggr_cur = 0;
+ s32 f_post_aggr_cur = 0;
struct sk_buff *skb_deaggr;
u32 pind;
u32 pkt_len, pkt_type, mport;
@@ -1169,7 +1170,7 @@ static int mwifiex_sdio_card_to_host_mp_aggr(struct mwifiex_adapter *adapter,
} else {
/* No room in Aggr buf, do rx aggr now */
f_do_rx_aggr = 1;
- f_do_rx_cur = 1;
+ f_post_aggr_cur = 1;
}
} else {
/* Rx aggr not in progress */
@@ -1280,9 +1281,13 @@ rx_curr_single:
mwifiex_decode_rx_packet(adapter, skb, pkt_type);
}
+ if (f_post_aggr_cur) {
+ dev_dbg(adapter->dev, "info: current packet aggregation\n");
+ /* Curr pkt can be aggregated */
+ mp_rx_aggr_setup(card, skb, port);
+ }
return 0;
-
error:
if (MP_RX_AGGR_IN_PROGRESS(card)) {
/* Multiport-aggregation transfer failed - cleanup */
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [1/3] mwifiex: fix a bug in Rx multiport aggregation logic
2015-03-12 8:29 [PATCH 1/3] mwifiex: fix a bug in Rx multiport aggregation logic Amitkumar Karwar
@ 2015-03-16 16:04 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-03-16 16:04 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: linux-wireless, Cathy Luo, Avinash Patil, Amitkumar Karwar
> From: Cathy Luo <cluo@marvell.com>
>
> It's been observed Rx aggregated packets are always followed
> by a single Rx packet. This patch improves our logic to add
> that extra packet in next aggregation.
>
> Signed-off-by: Cathy Luo <cluo@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-16 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12 8:29 [PATCH 1/3] mwifiex: fix a bug in Rx multiport aggregation logic Amitkumar Karwar
2015-03-16 16:04 ` [1/3] " Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.