[Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags.

[Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags.

[Johan Oudinet]

Adding this flag when BR2_ENABLE_DEBUG is activated make several
packages to produce binaries that do not work as expected (e.g., dhcp,
lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not
say it is adding this flag. It is supposed to build packages with
debugging symbols enabled. So, let it do that only.

* package/Makefile.in: Do not add --{enable,disable}-debug flags.
* package/pkg-autotools.mk: Remove ENABLE_DEBUG as it is not set
  anymore.

Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
Changes v1 -> v2:
  - Do not pass --disable-debug neither.
---
 package/Makefile.in      | 6 ------
 package/pkg-autotools.mk | 1 -
 2 files changed, 7 deletions(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index 803b162..049c89b 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -387,12 +387,6 @@ ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
 TARGET_CONFIGURE_OPTS += CXX=false
 endif
 
-ifeq ($(BR2_ENABLE_DEBUG),y)
-ENABLE_DEBUG := --enable-debug
-else
-ENABLE_DEBUG := --disable-debug
-endif
-
 ifeq ($(BR2_STATIC_LIBS),y)
 SHARED_STATIC_LIBS_OPTS = --enable-static --disable-shared
 TARGET_CFLAGS += -static
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index d2f15fa..11bc643 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -203,7 +203,6 @@ define $(2)_CONFIGURE_CMDS
 		$$(DISABLE_NLS) \
 		$$(DISABLE_LARGEFILE) \
 		$$(DISABLE_IPV6) \
-		$$(ENABLE_DEBUG) \
 		$$(SHARED_STATIC_LIBS_OPTS) \
 		$$(QUIET) $$($$(PKG)_CONF_OPTS) \
 	)
-- 
2.1.0

[Buildroot] [PATCH v2 2/3] lame: Remove --enable-debug workaround.

[Johan Oudinet]

This is not needed since BR2_ENABLE_DEBUG does not set this flag
anymore.

Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
 package/lame/lame.mk | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/package/lame/lame.mk b/package/lame/lame.mk
index e47e0af..dcd155f 100644
--- a/package/lame/lame.mk
+++ b/package/lame/lame.mk
@@ -14,13 +14,6 @@ LAME_CONF_OPTS = --enable-dynamic-frontends
 LAME_LICENSE = LGPLv2+
 LAME_LICENSE_FILES = COPYING
 
-# Building lame with debug symbols needs the following macros to be
-# defined: _FPU_MASK_IM, _FPU_MASK_ZM, _FPU_MASK_OM.
-# So, if BR2_ENABLE_DEBUG is selected, then we have force lame to be
-# built without debug symbols because a number of architectures don't
-# have those macros defined.
-LAME_CONF_OPTS += --disable-debug
-
 ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
 LAME_DEPENDENCIES += libsndfile
 LAME_CONF_OPTS += --with-fileio=sndfile
-- 
2.1.0

[Buildroot] [PATCH v2 3/3] mp4v2: Remove --disable-debug workaround.

[Johan Oudinet]

This is not needed since BR2_ENABLE_DEBUG does not set this flag
anymore.

Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
 package/mp4v2/mp4v2.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/mp4v2/mp4v2.mk b/package/mp4v2/mp4v2.mk
index 5d38116..1da5bc3 100644
--- a/package/mp4v2/mp4v2.mk
+++ b/package/mp4v2/mp4v2.mk
@@ -16,12 +16,6 @@ MP4V2_LICENSE_FILES = COPYING
 # disable it
 MP4V2_CONF_ENV = ac_cv_prog_FOUND_HELP2MAN=no
 
-# infrastructure passes --disable-debug if !BR2_ENABLE_DEBUG. With
-# mpv42 the only thing this option does is that it tries to strip any
-# -g* options from CFLAGS/CXXFLAGS. The logic to do so is
-# unfortunately buggy, so just pass --enable-debug to disable this
-MP4V2_CONF_OPTS = --enable-debug
-
 ifeq ($(BR2_LARGEFILE),y)
 MP4V2_CONF_OPTS += --enable-largefile
 else
-- 
2.1.0

[Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags.

[Thomas Petazzoni]

Hello all,

On Thu, 12 Mar 2015 16:12:25 +0100, Johan Oudinet wrote:
> Adding this flag when BR2_ENABLE_DEBUG is activated make several
> packages to produce binaries that do not work as expected (e.g., dhcp,
> lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not
> say it is adding this flag. It is supposed to build packages with
> debugging symbols enabled. So, let it do that only.
> 
> * package/Makefile.in: Do not add --{enable,disable}-debug flags.
> * package/pkg-autotools.mk: Remove ENABLE_DEBUG as it is not set
>   anymore.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>

Unless someone opposes to this change, I will apply it soon. So if you
don't agree, speak up. If you agree, give your Acked-by/Reviewed-by.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags.

[Yann E. MORIN]

Johan, All,

On 2015-03-12 16:12 +0100, Johan Oudinet spake thusly:
> Adding this flag when BR2_ENABLE_DEBUG is activated make several
> packages to produce binaries that do not work as expected (e.g., dhcp,
> lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not
> say it is adding this flag. It is supposed to build packages with
> debugging symbols enabled. So, let it do that only.
> 
> * package/Makefile.in: Do not add --{enable,disable}-debug flags.
> * package/pkg-autotools.mk: Remove ENABLE_DEBUG as it is not set
>   anymore.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
>   - Do not pass --disable-debug neither.
> ---
>  package/Makefile.in      | 6 ------
>  package/pkg-autotools.mk | 1 -
>  2 files changed, 7 deletions(-)
> 
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 803b162..049c89b 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -387,12 +387,6 @@ ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
>  TARGET_CONFIGURE_OPTS += CXX=false
>  endif
>  
> -ifeq ($(BR2_ENABLE_DEBUG),y)
> -ENABLE_DEBUG := --enable-debug
> -else
> -ENABLE_DEBUG := --disable-debug
> -endif
> -
>  ifeq ($(BR2_STATIC_LIBS),y)
>  SHARED_STATIC_LIBS_OPTS = --enable-static --disable-shared
>  TARGET_CFLAGS += -static
> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index d2f15fa..11bc643 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -203,7 +203,6 @@ define $(2)_CONFIGURE_CMDS
>  		$$(DISABLE_NLS) \
>  		$$(DISABLE_LARGEFILE) \
>  		$$(DISABLE_IPV6) \
> -		$$(ENABLE_DEBUG) \
>  		$$(SHARED_STATIC_LIBS_OPTS) \
>  		$$(QUIET) $$($$(PKG)_CONF_OPTS) \
>  	)
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2 2/3] lame: Remove --enable-debug workaround.

[Yann E. MORIN]

Johan, All,

On 2015-03-12 16:12 +0100, Johan Oudinet spake thusly:
> This is not needed since BR2_ENABLE_DEBUG does not set this flag
> anymore.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/lame/lame.mk | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/package/lame/lame.mk b/package/lame/lame.mk
> index e47e0af..dcd155f 100644
> --- a/package/lame/lame.mk
> +++ b/package/lame/lame.mk
> @@ -14,13 +14,6 @@ LAME_CONF_OPTS = --enable-dynamic-frontends
>  LAME_LICENSE = LGPLv2+
>  LAME_LICENSE_FILES = COPYING
>  
> -# Building lame with debug symbols needs the following macros to be
> -# defined: _FPU_MASK_IM, _FPU_MASK_ZM, _FPU_MASK_OM.
> -# So, if BR2_ENABLE_DEBUG is selected, then we have force lame to be
> -# built without debug symbols because a number of architectures don't
> -# have those macros defined.
> -LAME_CONF_OPTS += --disable-debug
> -
>  ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
>  LAME_DEPENDENCIES += libsndfile
>  LAME_CONF_OPTS += --with-fileio=sndfile
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2 3/3] mp4v2: Remove --disable-debug workaround.

[Yann E. MORIN]

Johan, All,

On 2015-03-12 16:12 +0100, Johan Oudinet spake thusly:
> This is not needed since BR2_ENABLE_DEBUG does not set this flag
> anymore.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/mp4v2/mp4v2.mk | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/package/mp4v2/mp4v2.mk b/package/mp4v2/mp4v2.mk
> index 5d38116..1da5bc3 100644
> --- a/package/mp4v2/mp4v2.mk
> +++ b/package/mp4v2/mp4v2.mk
> @@ -16,12 +16,6 @@ MP4V2_LICENSE_FILES = COPYING
>  # disable it
>  MP4V2_CONF_ENV = ac_cv_prog_FOUND_HELP2MAN=no
>  
> -# infrastructure passes --disable-debug if !BR2_ENABLE_DEBUG. With
> -# mpv42 the only thing this option does is that it tries to strip any
> -# -g* options from CFLAGS/CXXFLAGS. The logic to do so is
> -# unfortunately buggy, so just pass --enable-debug to disable this
> -MP4V2_CONF_OPTS = --enable-debug
> -
>  ifeq ($(BR2_LARGEFILE),y)
>  MP4V2_CONF_OPTS += --enable-largefile
>  else
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags.

[Thomas Petazzoni]

Dear Johan Oudinet,

On Thu, 12 Mar 2015 16:12:25 +0100, Johan Oudinet wrote:
> Adding this flag when BR2_ENABLE_DEBUG is activated make several
> packages to produce binaries that do not work as expected (e.g., dhcp,
> lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not
> say it is adding this flag. It is supposed to build packages with
> debugging symbols enabled. So, let it do that only.
> 
> * package/Makefile.in: Do not add --{enable,disable}-debug flags.
> * package/pkg-autotools.mk: Remove ENABLE_DEBUG as it is not set
>   anymore.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
> ---
> Changes v1 -> v2:
>   - Do not pass --disable-debug neither.
> ---
>  package/Makefile.in      | 6 ------
>  package/pkg-autotools.mk | 1 -
>  2 files changed, 7 deletions(-)

Applied the three patches of this series, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com