* [PATCH] Staging: media: Compile driver as a module
@ 2015-03-12 20:49 Ksenija Stanojevic
2015-03-16 15:19 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Ksenija Stanojevic @ 2015-03-12 20:49 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
This patch changes Kconfig file so that driver could be compiled as
a module. Changes have also been made in TODO list by removing this
task.
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
drivers/staging/media/omap4iss/Kconfig | 2 +-
drivers/staging/media/omap4iss/TODO | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig
index b78643f..32403cc 100644
--- a/drivers/staging/media/omap4iss/Kconfig
+++ b/drivers/staging/media/omap4iss/Kconfig
@@ -1,5 +1,5 @@
config VIDEO_OMAP4
- bool "OMAP 4 Camera support"
+ tristate "OMAP 4 Camera support"
depends on VIDEO_V4L2=y && VIDEO_V4L2_SUBDEV_API && I2C=y && ARCH_OMAP4
depends on HAS_DMA
select VIDEOBUF2_DMA_CONTIG
diff --git a/drivers/staging/media/omap4iss/TODO b/drivers/staging/media/omap4iss/TODO
index fcde888..4d220ef 100644
--- a/drivers/staging/media/omap4iss/TODO
+++ b/drivers/staging/media/omap4iss/TODO
@@ -1,4 +1,3 @@
-* Make the driver compile as a module
* Fix FIFO/buffer overflows and underflows
* Replace dummy resizer code with a real implementation
* Fix checkpatch errors and warnings
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: media: Compile driver as a module
2015-03-12 20:49 [PATCH] Staging: media: Compile driver as a module Ksenija Stanojevic
@ 2015-03-16 15:19 ` Greg KH
2015-03-16 16:16 ` Ksenija Stanojević
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2015-03-16 15:19 UTC (permalink / raw)
To: Ksenija Stanojevic; +Cc: outreachy-kernel
On Thu, Mar 12, 2015 at 09:49:41PM +0100, Ksenija Stanojevic wrote:
> This patch changes Kconfig file so that driver could be compiled as
> a module. Changes have also been made in TODO list by removing this
> task.
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> drivers/staging/media/omap4iss/Kconfig | 2 +-
> drivers/staging/media/omap4iss/TODO | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig
> index b78643f..32403cc 100644
> --- a/drivers/staging/media/omap4iss/Kconfig
> +++ b/drivers/staging/media/omap4iss/Kconfig
> @@ -1,5 +1,5 @@
> config VIDEO_OMAP4
> - bool "OMAP 4 Camera support"
> + tristate "OMAP 4 Camera support"
> depends on VIDEO_V4L2=y && VIDEO_V4L2_SUBDEV_API && I2C=y && ARCH_OMAP4
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> diff --git a/drivers/staging/media/omap4iss/TODO b/drivers/staging/media/omap4iss/TODO
> index fcde888..4d220ef 100644
> --- a/drivers/staging/media/omap4iss/TODO
> +++ b/drivers/staging/media/omap4iss/TODO
> @@ -1,4 +1,3 @@
> -* Make the driver compile as a module
> * Fix FIFO/buffer overflows and underflows
> * Replace dummy resizer code with a real implementation
> * Fix checkpatch errors and warnings
How did you test that this worked? Did you cross-build for the omap
platform?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: media: Compile driver as a module
2015-03-16 15:19 ` [Outreachy kernel] " Greg KH
@ 2015-03-16 16:16 ` Ksenija Stanojević
2015-03-16 17:05 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Ksenija Stanojević @ 2015-03-16 16:16 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
On Mon, Mar 16, 2015 at 4:19 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Mar 12, 2015 at 09:49:41PM +0100, Ksenija Stanojevic wrote:
>> This patch changes Kconfig file so that driver could be compiled as
>> a module. Changes have also been made in TODO list by removing this
>> task.
>>
>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> ---
>> drivers/staging/media/omap4iss/Kconfig | 2 +-
>> drivers/staging/media/omap4iss/TODO | 1 -
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig
>> index b78643f..32403cc 100644
>> --- a/drivers/staging/media/omap4iss/Kconfig
>> +++ b/drivers/staging/media/omap4iss/Kconfig
>> @@ -1,5 +1,5 @@
>> config VIDEO_OMAP4
>> - bool "OMAP 4 Camera support"
>> + tristate "OMAP 4 Camera support"
>> depends on VIDEO_V4L2=y && VIDEO_V4L2_SUBDEV_API && I2C=y && ARCH_OMAP4
>> depends on HAS_DMA
>> select VIDEOBUF2_DMA_CONTIG
>> diff --git a/drivers/staging/media/omap4iss/TODO b/drivers/staging/media/omap4iss/TODO
>> index fcde888..4d220ef 100644
>> --- a/drivers/staging/media/omap4iss/TODO
>> +++ b/drivers/staging/media/omap4iss/TODO
>> @@ -1,4 +1,3 @@
>> -* Make the driver compile as a module
>> * Fix FIFO/buffer overflows and underflows
>> * Replace dummy resizer code with a real implementation
>> * Fix checkpatch errors and warnings
>
> How did you test that this worked? Did you cross-build for the omap
> platform?
No, I didn't. I don't have the hardware.
Ksenija
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: media: Compile driver as a module
2015-03-16 16:16 ` Ksenija Stanojević
@ 2015-03-16 17:05 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-03-16 17:05 UTC (permalink / raw)
To: Ksenija Stanojević; +Cc: outreachy-kernel
On Mon, Mar 16, 2015 at 05:16:22PM +0100, Ksenija Stanojević wrote:
> On Mon, Mar 16, 2015 at 4:19 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Mar 12, 2015 at 09:49:41PM +0100, Ksenija Stanojevic wrote:
> >> This patch changes Kconfig file so that driver could be compiled as
> >> a module. Changes have also been made in TODO list by removing this
> >> task.
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> ---
> >> drivers/staging/media/omap4iss/Kconfig | 2 +-
> >> drivers/staging/media/omap4iss/TODO | 1 -
> >> 2 files changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig
> >> index b78643f..32403cc 100644
> >> --- a/drivers/staging/media/omap4iss/Kconfig
> >> +++ b/drivers/staging/media/omap4iss/Kconfig
> >> @@ -1,5 +1,5 @@
> >> config VIDEO_OMAP4
> >> - bool "OMAP 4 Camera support"
> >> + tristate "OMAP 4 Camera support"
> >> depends on VIDEO_V4L2=y && VIDEO_V4L2_SUBDEV_API && I2C=y && ARCH_OMAP4
> >> depends on HAS_DMA
> >> select VIDEOBUF2_DMA_CONTIG
> >> diff --git a/drivers/staging/media/omap4iss/TODO b/drivers/staging/media/omap4iss/TODO
> >> index fcde888..4d220ef 100644
> >> --- a/drivers/staging/media/omap4iss/TODO
> >> +++ b/drivers/staging/media/omap4iss/TODO
> >> @@ -1,4 +1,3 @@
> >> -* Make the driver compile as a module
> >> * Fix FIFO/buffer overflows and underflows
> >> * Replace dummy resizer code with a real implementation
> >> * Fix checkpatch errors and warnings
> >
> > How did you test that this worked? Did you cross-build for the omap
> > platform?
>
> No, I didn't. I don't have the hardware.
You don't need the hardware to be able to build it.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-16 17:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12 20:49 [PATCH] Staging: media: Compile driver as a module Ksenija Stanojevic
2015-03-16 15:19 ` [Outreachy kernel] " Greg KH
2015-03-16 16:16 ` Ksenija Stanojević
2015-03-16 17:05 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.