* [Mini-os] Fix accidentally removed brace causing a build error.
@ 2015-03-12 18:08 Sander Eikelenboom
2015-03-13 10:23 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Sander Eikelenboom @ 2015-03-12 18:08 UTC (permalink / raw)
To: Ian Campbell; +Cc: Sander Eikelenboom, Olaf Hering, xen-devel
Introduced in:
commit bd5920cb92e6799bfd64957284a9e2cfe7699039
"mini-os: sort objects in binary archives"
Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 3e5d95e..2cb5e51 100644
--- a/Makefile
+++ b/Makefile
@@ -148,7 +148,7 @@ ifeq ($(CONFIG_LWIP),y)
# lwIP library
LWC := $(sort $(shell find $(LWIPDIR)/src -type f -name '*.c'))
LWC := $(filter-out %6.c %ip6_addr.c %ethernetif.c, $(LWC))
-LWO := $(patsubst %.c,%.o,$(LWC)
+LWO := $(patsubst %.c,%.o,$(LWC))
LWO += $(OBJ_DIR)/lwip-arch.o
ifeq ($(CONFIG_NETFRONT),y)
LWO += $(OBJ_DIR)/lwip-net.o
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Mini-os] Fix accidentally removed brace causing a build error.
2015-03-12 18:08 [Mini-os] Fix accidentally removed brace causing a build error Sander Eikelenboom
@ 2015-03-13 10:23 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-03-13 10:23 UTC (permalink / raw)
To: Sander Eikelenboom; +Cc: xen-devel, Olaf Hering
On Thu, 2015-03-12 at 19:08 +0100, Sander Eikelenboom wrote:
> Introduced in:
> commit bd5920cb92e6799bfd64957284a9e2cfe7699039
> "mini-os: sort objects in binary archives"
Damn, I was supposed to fix that on commit and I forgot.
Strange/suspicious that my local pre-push build didn't catch the issue,
it seems it wasn't properly updating the extra/mini-os checkout due to a
coding error in my script. I believe I've now fixed that.
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
Acked + applied, plus MINIOS_UPSTREAM_REVISION updated.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 3e5d95e..2cb5e51 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -148,7 +148,7 @@ ifeq ($(CONFIG_LWIP),y)
> # lwIP library
> LWC := $(sort $(shell find $(LWIPDIR)/src -type f -name '*.c'))
> LWC := $(filter-out %6.c %ip6_addr.c %ethernetif.c, $(LWC))
> -LWO := $(patsubst %.c,%.o,$(LWC)
> +LWO := $(patsubst %.c,%.o,$(LWC))
> LWO += $(OBJ_DIR)/lwip-arch.o
> ifeq ($(CONFIG_NETFRONT),y)
> LWO += $(OBJ_DIR)/lwip-net.o
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-13 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12 18:08 [Mini-os] Fix accidentally removed brace causing a build error Sander Eikelenboom
2015-03-13 10:23 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.