From: Heiko Stuebner <heiko@sntech.de>
To: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Cc: Robin Murphy <robin.murphy@arm.com>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs
Date: Wed, 27 Mar 2019 13:00:16 +0100 [thread overview]
Message-ID: <14265087.Gbs4YZABJo@phil> (raw)
In-Reply-To: <e7bcf8b9-123e-eb30-f47d-7f8855f30ccb@katsuster.net>
Hi,
Am Dienstag, 26. März 2019, 14:49:16 CET schrieb Katsuhiro Suzuki:
> Hello Robin,
>
> Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs,
> please revert my patch if you need.
I've dropped the patch from my queue now.
> BTW, there are DMA properties in RK3328 device-tree like as this patch.
> RK3328 UART DMA could not work correctly too...??
I remember Rockcihip dma-controllers having issues with burst-sizes
and flushing (there is a no-flushp option in pl330), so it's
possible that all share the same error up to rk3399 and rk3328
But so far no-one has shouted regarding the rk3328.
Heiko
> On 2019/03/26 20:48, Robin Murphy wrote:
> > On 25/03/2019 12:34, Heiko Stuebner wrote:
> >> Am Donnerstag, 21. März 2019, 17:22:44 CET schrieb Katsuhiro Suzuki:
> >>> Add UART dma channels as specified by the rk3399 TRM.
> >>>
> >>> Refer:
> >>> RK3399 TRM V1.4: Chapter 12 DMA Controller
> >>>
> >>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> >>
> >> applied for 5.2
> >
> > As a heads-up, I did manage to try my board with this patch applied over
> > the weekend, and it makes probing the bluetooth adapter fail with
> > communication errors, so I'm not sure the 8250 and pl330 drivers are
> > really cooperating well enough :(
> >
> > Robin.
> >
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Cc: linux-rockchip@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs
Date: Wed, 27 Mar 2019 13:00:16 +0100 [thread overview]
Message-ID: <14265087.Gbs4YZABJo@phil> (raw)
In-Reply-To: <e7bcf8b9-123e-eb30-f47d-7f8855f30ccb@katsuster.net>
Hi,
Am Dienstag, 26. März 2019, 14:49:16 CET schrieb Katsuhiro Suzuki:
> Hello Robin,
>
> Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs,
> please revert my patch if you need.
I've dropped the patch from my queue now.
> BTW, there are DMA properties in RK3328 device-tree like as this patch.
> RK3328 UART DMA could not work correctly too...??
I remember Rockcihip dma-controllers having issues with burst-sizes
and flushing (there is a no-flushp option in pl330), so it's
possible that all share the same error up to rk3399 and rk3328
But so far no-one has shouted regarding the rk3328.
Heiko
> On 2019/03/26 20:48, Robin Murphy wrote:
> > On 25/03/2019 12:34, Heiko Stuebner wrote:
> >> Am Donnerstag, 21. März 2019, 17:22:44 CET schrieb Katsuhiro Suzuki:
> >>> Add UART dma channels as specified by the rk3399 TRM.
> >>>
> >>> Refer:
> >>> RK3399 TRM V1.4: Chapter 12 DMA Controller
> >>>
> >>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> >>
> >> applied for 5.2
> >
> > As a heads-up, I did manage to try my board with this patch applied over
> > the weekend, and it makes probing the bluetooth adapter fail with
> > communication errors, so I'm not sure the 8250 and pl330 drivers are
> > really cooperating well enough :(
> >
> > Robin.
> >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-27 12:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 16:22 [PATCH v2] arm64: dts: rockchip: add rk3399 UART DMAs Katsuhiro Suzuki
2019-03-21 16:22 ` Katsuhiro Suzuki
2019-03-21 16:22 ` Katsuhiro Suzuki
2019-03-25 12:34 ` Heiko Stuebner
2019-03-25 12:34 ` Heiko Stuebner
2019-03-25 12:34 ` Heiko Stuebner
2019-03-26 11:48 ` Robin Murphy
2019-03-26 11:48 ` Robin Murphy
2019-03-26 13:49 ` Katsuhiro Suzuki
2019-03-26 13:49 ` Katsuhiro Suzuki
2019-03-27 12:00 ` Heiko Stuebner [this message]
2019-03-27 12:00 ` Heiko Stuebner
2019-03-29 23:24 ` Robin Murphy
2019-03-29 23:24 ` Robin Murphy
2019-04-11 12:46 ` Heiko Stuebner
2019-04-11 12:46 ` Heiko Stuebner
2019-04-11 13:48 ` Robin Murphy
2019-04-11 13:48 ` Robin Murphy
2019-04-11 19:17 ` Robin Murphy
2019-04-11 19:17 ` Robin Murphy
2019-03-27 12:10 ` Robin Murphy
2019-03-27 12:10 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14265087.Gbs4YZABJo@phil \
--to=heiko@sntech.de \
--cc=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.