* [PATCH 1/2] drm/i915: Remove unused variable in i915_gem_obj_ggtt_offset_view
@ 2015-03-17 14:45 Tvrtko Ursulin
2015-03-17 14:45 ` [PATCH 2/2] drm/i915: Log view type when printing warnings Tvrtko Ursulin
0 siblings, 1 reply; 4+ messages in thread
From: Tvrtko Ursulin @ 2015-03-17 14:45 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index e2876bf..cc8672a 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -5260,7 +5260,6 @@ unsigned long
i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
enum i915_ggtt_view_type view)
{
- struct drm_i915_private *dev_priv = o->base.dev->dev_private;
struct i915_address_space *ggtt = i915_obj_to_ggtt(o);
struct i915_vma *vma;
--
2.3.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] drm/i915: Log view type when printing warnings
2015-03-17 14:45 [PATCH 1/2] drm/i915: Remove unused variable in i915_gem_obj_ggtt_offset_view Tvrtko Ursulin
@ 2015-03-17 14:45 ` Tvrtko Ursulin
2015-03-18 13:01 ` shuang.he
2015-04-15 12:01 ` Joonas Lahtinen
0 siblings, 2 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2015-03-17 14:45 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
It may save someone a bit of debugging time one day.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index cc8672a..e150038 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -5267,7 +5267,7 @@ i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
if (vma->vm == ggtt && vma->ggtt_view.type == view)
return vma->node.start;
- WARN(1, "global vma for this object not found.\n");
+ WARN(1, "global vma for this object not found. (view=%u)\n", view);
return -1;
}
--
2.3.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] drm/i915: Log view type when printing warnings
2015-03-17 14:45 ` [PATCH 2/2] drm/i915: Log view type when printing warnings Tvrtko Ursulin
@ 2015-03-18 13:01 ` shuang.he
2015-04-15 12:01 ` Joonas Lahtinen
1 sibling, 0 replies; 4+ messages in thread
From: shuang.he @ 2015-03-18 13:01 UTC (permalink / raw)
To: shuang.he, ethan.gao, intel-gfx, tvrtko.ursulin
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 5984
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV -1 268/268 267/268
ILK 303/303 303/303
SNB 283/283 283/283
IVB 343/343 343/343
BYT 287/287 287/287
HSW 363/363 363/363
BDW 308/308 308/308
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*PNV igt_gem_userptr_blits_minor-sync-interruptible PASS(2) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] drm/i915: Log view type when printing warnings
2015-03-17 14:45 ` [PATCH 2/2] drm/i915: Log view type when printing warnings Tvrtko Ursulin
2015-03-18 13:01 ` shuang.he
@ 2015-04-15 12:01 ` Joonas Lahtinen
1 sibling, 0 replies; 4+ messages in thread
From: Joonas Lahtinen @ 2015-04-15 12:01 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Intel-gfx
I ended up needing this bit too, so maybe better have it committed.
On ti, 2015-03-17 at 14:45 +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It may save someone a bit of debugging time one day.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index cc8672a..e150038 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -5267,7 +5267,7 @@ i915_gem_obj_ggtt_offset_view(struct drm_i915_gem_object *o,
> if (vma->vm == ggtt && vma->ggtt_view.type == view)
> return vma->node.start;
>
> - WARN(1, "global vma for this object not found.\n");
> + WARN(1, "global vma for this object not found. (view=%u)\n", view);
> return -1;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-15 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-17 14:45 [PATCH 1/2] drm/i915: Remove unused variable in i915_gem_obj_ggtt_offset_view Tvrtko Ursulin
2015-03-17 14:45 ` [PATCH 2/2] drm/i915: Log view type when printing warnings Tvrtko Ursulin
2015-03-18 13:01 ` shuang.he
2015-04-15 12:01 ` Joonas Lahtinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.