* [PATCH] libxlu: avoid having two definitions of XLU_ConfigList
@ 2015-03-18 21:33 Wei Liu
2015-03-19 0:28 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2015-03-18 21:33 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, ian.campbell
There is already a typedef in libxlutil.h. Remove the one in
libxlu_internal.h.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxlu_internal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxlu_internal.h b/tools/libxl/libxlu_internal.h
index 3451cfe..0acdde3 100644
--- a/tools/libxl/libxlu_internal.h
+++ b/tools/libxl/libxlu_internal.h
@@ -25,11 +25,11 @@
#include "libxlutil.h"
-typedef struct XLU_ConfigList {
+struct XLU_ConfigList {
int avalues; /* available slots */
int nvalues; /* actual occupied slots */
XLU_ConfigValue **values;
-} XLU_ConfigList;
+};
typedef struct YYLTYPE
{
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxlu: avoid having two definitions of XLU_ConfigList
2015-03-18 21:33 [PATCH] libxlu: avoid having two definitions of XLU_ConfigList Wei Liu
@ 2015-03-19 0:28 ` Konrad Rzeszutek Wilk
2015-03-19 11:03 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2015-03-19 0:28 UTC (permalink / raw)
To: Wei Liu; +Cc: ian.campbell, xen-devel
On Wed, Mar 18, 2015 at 09:33:58PM +0000, Wei Liu wrote:
> There is already a typedef in libxlutil.h. Remove the one in
> libxlu_internal.h.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Missing the 'Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>'
> ---
> tools/libxl/libxlu_internal.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxlu_internal.h b/tools/libxl/libxlu_internal.h
> index 3451cfe..0acdde3 100644
> --- a/tools/libxl/libxlu_internal.h
> +++ b/tools/libxl/libxlu_internal.h
> @@ -25,11 +25,11 @@
>
> #include "libxlutil.h"
>
> -typedef struct XLU_ConfigList {
> +struct XLU_ConfigList {
> int avalues; /* available slots */
> int nvalues; /* actual occupied slots */
> XLU_ConfigValue **values;
> -} XLU_ConfigList;
> +};
>
> typedef struct YYLTYPE
> {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxlu: avoid having two definitions of XLU_ConfigList
2015-03-19 0:28 ` Konrad Rzeszutek Wilk
@ 2015-03-19 11:03 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-03-19 11:03 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Wei Liu, xen-devel
On Wed, 2015-03-18 at 20:28 -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 18, 2015 at 09:33:58PM +0000, Wei Liu wrote:
> > There is already a typedef in libxlutil.h. Remove the one in
> > libxlu_internal.h.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Missing the 'Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>'
I added this and acked + applied the patch.
Ian, who is surprised newer gcc is more lenient on this matter...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-19 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-18 21:33 [PATCH] libxlu: avoid having two definitions of XLU_ConfigList Wei Liu
2015-03-19 0:28 ` Konrad Rzeszutek Wilk
2015-03-19 11:03 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.