* [Buildroot] [PATCH v2] package/perf: fix build failures with high 'make -j' values
@ 2015-03-19 7:19 Steven Noonan
2015-03-19 12:37 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Steven Noonan @ 2015-03-19 7:19 UTC (permalink / raw)
To: buildroot
The 'perf' Makefile is flaky on some kernel versions. It will still parallelize
the build even with 'make -j1' because it explicitly invokes a sub-make with
the correct flags. But the top-level make is not smart enough to handle large
'-j' values.
Signed-off-by: Steven Noonan <steven@uplinklabs.net>
---
v2:
- Use $(MAKE1) instead of appending '-j1' to PERF_MAKE_FLAGS.
package/perf/perf.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/perf/perf.mk b/package/perf/perf.mk
index 1fcc258..bbdcc5a 100644
--- a/package/perf/perf.mk
+++ b/package/perf/perf.mk
@@ -53,14 +53,14 @@ define PERF_BUILD_CMDS
fi \
fi \
fi
- $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/perf \
+ $(TARGET_MAKE_ENV) $(MAKE1) -C $(LINUX_DIR)/tools/perf \
$(PERF_MAKE_FLAGS) O=$(@D)
endef
# After installation, we remove the Perl and Python scripts from the
# target.
define PERF_INSTALL_TARGET_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/perf \
+ $(TARGET_MAKE_ENV) $(MAKE1) -C $(LINUX_DIR)/tools/perf \
$(PERF_MAKE_FLAGS) O=$(@D) install
$(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/scripts/
endef
--
2.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH v2] package/perf: fix build failures with high 'make -j' values
2015-03-19 7:19 [Buildroot] [PATCH v2] package/perf: fix build failures with high 'make -j' values Steven Noonan
@ 2015-03-19 12:37 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-03-19 12:37 UTC (permalink / raw)
To: buildroot
Dear Steven Noonan,
On Thu, 19 Mar 2015 00:19:25 -0700, Steven Noonan wrote:
> The 'perf' Makefile is flaky on some kernel versions. It will still parallelize
> the build even with 'make -j1' because it explicitly invokes a sub-make with
> the correct flags. But the top-level make is not smart enough to handle large
> '-j' values.
>
> Signed-off-by: Steven Noonan <steven@uplinklabs.net>
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-19 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-19 7:19 [Buildroot] [PATCH v2] package/perf: fix build failures with high 'make -j' values Steven Noonan
2015-03-19 12:37 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.