All of lore.kernel.org
 help / color / mirror / Atom feed
* [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-05 22:12 ` Steven Rostedt
  0 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-05 22:12 UTC (permalink / raw)
  To: LKML
  Cc: Benjamin Herrenschmidt, Grant Likely, Rob Herring,
	Olof Johansson, linuxppc-dev


A bug in ftrace was reported to me that affects ARM and ARM64 but not
x86. Looking at the code it appears to affect PowerPC as well. So I
booted up my old PA Semi, to give it a try. The last time I booted it
was for a 3.17 kernel. Unfortunately, for 4.0-rc2 it crashed with:

Unable to handle kernel paging request for data at address 0x00000000
Faulting instruction address: 0xc0000000005cef88
Oops: Kernel access of bad area, sig: 11 [#1]
SMP NR_CPUS=2 PA Semi PWRficient
Modules linked in:
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.0.0-rc2-test #50
task: c00000003816cb60 ti: c0000000381a4000 task.ti: c0000000381a4000
NIP: c0000000005cef88 LR: c00000000007c1a0 CTR: c00000000007c184
REGS: c0000000381a7a00 TRAP: 0300   Not tainted  (4.0.0-rc2-test)
MSR: 9000000000009032 <SF,HV,EE,ME,IR,DR,RI>  CR: 22000028  XER: 00000000
DAR: 0000000000000000 DSISR: 40000000 SOFTE: 0 
GPR00: c00000000007c1a0 c0000000381a7c80 c000000000af4b98 0000000000000001 
GPR04: 0000000000000000 0000000000000000 00000000000004ba 000000003d6de000 
GPR08: 0100000000000000 0000000000000000 c0000000381a4080 0000000000000000 
GPR12: 0000000024044042 c00000000ffff300 ffffffffffffffed 0000000000000000 
GPR16: c000000000afb920 c0000000381a4000 c0000000009ad648 c0000000009ae580 
GPR20: c0000000381a4080 c0000000381a4000 c0000000381a4080 c0000000381a4000 
GPR24: c0000000381a4000 c0000000381a4000 c000000000afb880 c0000000381a4000 
GPR28: c0000000009f8790 0000000000000000 c0000000381a4000 c000000000b02168 
NIP [c0000000005cef88] .check_astate+0x28/0x50
LR [c00000000007c1a0] sleep_common+0x14/0x74
Call Trace:
[c0000000381a7c80] [c000000000afb880] 0xc000000000afb880 (unreliable)
[c0000000381a7cf0] [c00000000007c1a0] sleep_common+0x14/0x74
[c0000000381a7d30] [c0000000000130f0] .arch_cpu_idle+0x70/0x160
[c0000000381a7db0] [c0000000000d6660] .cpu_startup_entry+0x320/0x5a0
[c0000000381a7ee0] [c000000000034570] .start_secondary+0x290/0x2c0
[c0000000381a7f90] [c000000000008bfc] start_secondary_prolog+0x10/0x14
Instruction dump:
60000000 60000000 7c0802a6 f8010010 f821ff91 60000000 60000000 3d220003 
39296870 a86d0038 e9290010 7c0004ac <7c004c2c> 0c000000 4c00012c 5463103a 
---[ end trace 40e864a431826b26 ]---

I kicked off a ktest bisect, and it came down to this commit:

commit 746c9e9f92dde2789908e51a354ba90a1962a2eb
Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date:   Fri Nov 14 17:55:03 2014 +1100

    of/base: Fix PowerPC address parsing hack

When I revert this from v4.0-rc2, I can successfully boot my PA Semi
again.

-- Steve


^ permalink raw reply	[flat|nested] 27+ messages in thread

* [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-05 22:12 ` Steven Rostedt
  0 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-05 22:12 UTC (permalink / raw)
  To: LKML; +Cc: Grant Likely, Olof Johansson, linuxppc-dev, Rob Herring


A bug in ftrace was reported to me that affects ARM and ARM64 but not
x86. Looking at the code it appears to affect PowerPC as well. So I
booted up my old PA Semi, to give it a try. The last time I booted it
was for a 3.17 kernel. Unfortunately, for 4.0-rc2 it crashed with:

Unable to handle kernel paging request for data at address 0x00000000
Faulting instruction address: 0xc0000000005cef88
Oops: Kernel access of bad area, sig: 11 [#1]
SMP NR_CPUS=2 PA Semi PWRficient
Modules linked in:
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.0.0-rc2-test #50
task: c00000003816cb60 ti: c0000000381a4000 task.ti: c0000000381a4000
NIP: c0000000005cef88 LR: c00000000007c1a0 CTR: c00000000007c184
REGS: c0000000381a7a00 TRAP: 0300   Not tainted  (4.0.0-rc2-test)
MSR: 9000000000009032 <SF,HV,EE,ME,IR,DR,RI>  CR: 22000028  XER: 00000000
DAR: 0000000000000000 DSISR: 40000000 SOFTE: 0 
GPR00: c00000000007c1a0 c0000000381a7c80 c000000000af4b98 0000000000000001 
GPR04: 0000000000000000 0000000000000000 00000000000004ba 000000003d6de000 
GPR08: 0100000000000000 0000000000000000 c0000000381a4080 0000000000000000 
GPR12: 0000000024044042 c00000000ffff300 ffffffffffffffed 0000000000000000 
GPR16: c000000000afb920 c0000000381a4000 c0000000009ad648 c0000000009ae580 
GPR20: c0000000381a4080 c0000000381a4000 c0000000381a4080 c0000000381a4000 
GPR24: c0000000381a4000 c0000000381a4000 c000000000afb880 c0000000381a4000 
GPR28: c0000000009f8790 0000000000000000 c0000000381a4000 c000000000b02168 
NIP [c0000000005cef88] .check_astate+0x28/0x50
LR [c00000000007c1a0] sleep_common+0x14/0x74
Call Trace:
[c0000000381a7c80] [c000000000afb880] 0xc000000000afb880 (unreliable)
[c0000000381a7cf0] [c00000000007c1a0] sleep_common+0x14/0x74
[c0000000381a7d30] [c0000000000130f0] .arch_cpu_idle+0x70/0x160
[c0000000381a7db0] [c0000000000d6660] .cpu_startup_entry+0x320/0x5a0
[c0000000381a7ee0] [c000000000034570] .start_secondary+0x290/0x2c0
[c0000000381a7f90] [c000000000008bfc] start_secondary_prolog+0x10/0x14
Instruction dump:
60000000 60000000 7c0802a6 f8010010 f821ff91 60000000 60000000 3d220003 
39296870 a86d0038 e9290010 7c0004ac <7c004c2c> 0c000000 4c00012c 5463103a 
---[ end trace 40e864a431826b26 ]---

I kicked off a ktest bisect, and it came down to this commit:

commit 746c9e9f92dde2789908e51a354ba90a1962a2eb
Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date:   Fri Nov 14 17:55:03 2014 +1100

    of/base: Fix PowerPC address parsing hack

When I revert this from v4.0-rc2, I can successfully boot my PA Semi
again.

-- Steve

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-05 22:12 ` Steven Rostedt
@ 2015-03-06  4:18   ` Benjamin Herrenschmidt
  -1 siblings, 0 replies; 27+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-06  4:18 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: LKML, Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev

On Thu, 2015-03-05 at 17:12 -0500, Steven Rostedt wrote:
> A bug in ftrace was reported to me that affects ARM and ARM64 but not
> x86. Looking at the code it appears to affect PowerPC as well. So I
> booted up my old PA Semi, to give it a try. The last time I booted it
> was for a 3.17 kernel. Unfortunately, for 4.0-rc2 it crashed with:

Argh. Well, we have one of these here but Michael who owns it is off til
Tuesday. 

Can you shoot me the DT (/proc/device-tree in a tarball) ? Olof, can the
DT be updated on this thing or should we add workarounds to Linux if
something is really missing ?

Cheers,
Ben.

> Unable to handle kernel paging request for data at address 0x00000000
> Faulting instruction address: 0xc0000000005cef88
> Oops: Kernel access of bad area, sig: 11 [#1]
> SMP NR_CPUS=2 PA Semi PWRficient
> Modules linked in:
> CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.0.0-rc2-test #50
> task: c00000003816cb60 ti: c0000000381a4000 task.ti: c0000000381a4000
> NIP: c0000000005cef88 LR: c00000000007c1a0 CTR: c00000000007c184
> REGS: c0000000381a7a00 TRAP: 0300   Not tainted  (4.0.0-rc2-test)
> MSR: 9000000000009032 <SF,HV,EE,ME,IR,DR,RI>  CR: 22000028  XER: 00000000
> DAR: 0000000000000000 DSISR: 40000000 SOFTE: 0 
> GPR00: c00000000007c1a0 c0000000381a7c80 c000000000af4b98 0000000000000001 
> GPR04: 0000000000000000 0000000000000000 00000000000004ba 000000003d6de000 
> GPR08: 0100000000000000 0000000000000000 c0000000381a4080 0000000000000000 
> GPR12: 0000000024044042 c00000000ffff300 ffffffffffffffed 0000000000000000 
> GPR16: c000000000afb920 c0000000381a4000 c0000000009ad648 c0000000009ae580 
> GPR20: c0000000381a4080 c0000000381a4000 c0000000381a4080 c0000000381a4000 
> GPR24: c0000000381a4000 c0000000381a4000 c000000000afb880 c0000000381a4000 
> GPR28: c0000000009f8790 0000000000000000 c0000000381a4000 c000000000b02168 
> NIP [c0000000005cef88] .check_astate+0x28/0x50
> LR [c00000000007c1a0] sleep_common+0x14/0x74
> Call Trace:
> [c0000000381a7c80] [c000000000afb880] 0xc000000000afb880 (unreliable)
> [c0000000381a7cf0] [c00000000007c1a0] sleep_common+0x14/0x74
> [c0000000381a7d30] [c0000000000130f0] .arch_cpu_idle+0x70/0x160
> [c0000000381a7db0] [c0000000000d6660] .cpu_startup_entry+0x320/0x5a0
> [c0000000381a7ee0] [c000000000034570] .start_secondary+0x290/0x2c0
> [c0000000381a7f90] [c000000000008bfc] start_secondary_prolog+0x10/0x14
> Instruction dump:
> 60000000 60000000 7c0802a6 f8010010 f821ff91 60000000 60000000 3d220003 
> 39296870 a86d0038 e9290010 7c0004ac <7c004c2c> 0c000000 4c00012c 5463103a 
> ---[ end trace 40e864a431826b26 ]---
> 
> I kicked off a ktest bisect, and it came down to this commit:
> 
> commit 746c9e9f92dde2789908e51a354ba90a1962a2eb
> Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date:   Fri Nov 14 17:55:03 2014 +1100
> 
>     of/base: Fix PowerPC address parsing hack
> 
> When I revert this from v4.0-rc2, I can successfully boot my PA Semi
> again.
> 
> -- Steve



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-06  4:18   ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 27+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-06  4:18 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev, LKML

On Thu, 2015-03-05 at 17:12 -0500, Steven Rostedt wrote:
> A bug in ftrace was reported to me that affects ARM and ARM64 but not
> x86. Looking at the code it appears to affect PowerPC as well. So I
> booted up my old PA Semi, to give it a try. The last time I booted it
> was for a 3.17 kernel. Unfortunately, for 4.0-rc2 it crashed with:

Argh. Well, we have one of these here but Michael who owns it is off til
Tuesday. 

Can you shoot me the DT (/proc/device-tree in a tarball) ? Olof, can the
DT be updated on this thing or should we add workarounds to Linux if
something is really missing ?

Cheers,
Ben.

> Unable to handle kernel paging request for data at address 0x00000000
> Faulting instruction address: 0xc0000000005cef88
> Oops: Kernel access of bad area, sig: 11 [#1]
> SMP NR_CPUS=2 PA Semi PWRficient
> Modules linked in:
> CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.0.0-rc2-test #50
> task: c00000003816cb60 ti: c0000000381a4000 task.ti: c0000000381a4000
> NIP: c0000000005cef88 LR: c00000000007c1a0 CTR: c00000000007c184
> REGS: c0000000381a7a00 TRAP: 0300   Not tainted  (4.0.0-rc2-test)
> MSR: 9000000000009032 <SF,HV,EE,ME,IR,DR,RI>  CR: 22000028  XER: 00000000
> DAR: 0000000000000000 DSISR: 40000000 SOFTE: 0 
> GPR00: c00000000007c1a0 c0000000381a7c80 c000000000af4b98 0000000000000001 
> GPR04: 0000000000000000 0000000000000000 00000000000004ba 000000003d6de000 
> GPR08: 0100000000000000 0000000000000000 c0000000381a4080 0000000000000000 
> GPR12: 0000000024044042 c00000000ffff300 ffffffffffffffed 0000000000000000 
> GPR16: c000000000afb920 c0000000381a4000 c0000000009ad648 c0000000009ae580 
> GPR20: c0000000381a4080 c0000000381a4000 c0000000381a4080 c0000000381a4000 
> GPR24: c0000000381a4000 c0000000381a4000 c000000000afb880 c0000000381a4000 
> GPR28: c0000000009f8790 0000000000000000 c0000000381a4000 c000000000b02168 
> NIP [c0000000005cef88] .check_astate+0x28/0x50
> LR [c00000000007c1a0] sleep_common+0x14/0x74
> Call Trace:
> [c0000000381a7c80] [c000000000afb880] 0xc000000000afb880 (unreliable)
> [c0000000381a7cf0] [c00000000007c1a0] sleep_common+0x14/0x74
> [c0000000381a7d30] [c0000000000130f0] .arch_cpu_idle+0x70/0x160
> [c0000000381a7db0] [c0000000000d6660] .cpu_startup_entry+0x320/0x5a0
> [c0000000381a7ee0] [c000000000034570] .start_secondary+0x290/0x2c0
> [c0000000381a7f90] [c000000000008bfc] start_secondary_prolog+0x10/0x14
> Instruction dump:
> 60000000 60000000 7c0802a6 f8010010 f821ff91 60000000 60000000 3d220003 
> 39296870 a86d0038 e9290010 7c0004ac <7c004c2c> 0c000000 4c00012c 5463103a 
> ---[ end trace 40e864a431826b26 ]---
> 
> I kicked off a ktest bisect, and it came down to this commit:
> 
> commit 746c9e9f92dde2789908e51a354ba90a1962a2eb
> Author: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date:   Fri Nov 14 17:55:03 2014 +1100
> 
>     of/base: Fix PowerPC address parsing hack
> 
> When I revert this from v4.0-rc2, I can successfully boot my PA Semi
> again.
> 
> -- Steve

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-06  4:18   ` Benjamin Herrenschmidt
@ 2015-03-06 15:00     ` Steven Rostedt
  -1 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-06 15:00 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: LKML, Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On Fri, 06 Mar 2015 15:18:42 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

 
> Can you shoot me the DT (/proc/device-tree in a tarball) ?

Attached.

-- Steve


[-- Attachment #2: device-tree.tar.bz2 --]
[-- Type: application/x-bzip, Size: 6488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-06 15:00     ` Steven Rostedt
  0 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-06 15:00 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev, LKML

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On Fri, 06 Mar 2015 15:18:42 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

 
> Can you shoot me the DT (/proc/device-tree in a tarball) ?

Attached.

-- Steve


[-- Attachment #2: device-tree.tar.bz2 --]
[-- Type: application/x-bzip, Size: 6488 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-06 15:00     ` Steven Rostedt
@ 2015-03-06 22:56       ` Benjamin Herrenschmidt
  -1 siblings, 0 replies; 27+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-06 22:56 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: LKML, Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev

On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> On Fri, 06 Mar 2015 15:18:42 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
>  
> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> 
> Attached.

This is indeed a bug in their DT. We might want to add quirks for
that unless it can be fixed (or has been via FW update). Olof ?

In the meantime, try that patch:

diff --git a/drivers/of/address.c b/drivers/of/address.c
index ad29069..78a7dcb 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -450,12 +450,17 @@ static struct of_bus *of_match_bus(struct device_node *np)
 	return NULL;
 }
 
-static int of_empty_ranges_quirk(void)
+static int of_empty_ranges_quirk(struct device_node *np)
 {
 	if (IS_ENABLED(CONFIG_PPC)) {
-		/* To save cycles, we cache the result */
+		/* To save cycles, we cache the result for global "Mac" setting */
 		static int quirk_state = -1;
 
+		/* PA-SEMI sdc DT bug */
+		if (of_device_is_compatible(np, "1682m-sdc"))
+			return true;
+
+		/* Make quirk cached */
 		if (quirk_state < 0)
 			quirk_state =
 				of_machine_is_compatible("Power Macintosh") ||
@@ -490,7 +495,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
 	 * This code is only enabled on powerpc. --gcl
 	 */
 	ranges = of_get_property(parent, rprop, &rlen);
-	if (ranges == NULL && !of_empty_ranges_quirk()) {
+	if (ranges == NULL && !of_empty_ranges_quirk(parent)) {
 		pr_debug("OF: no ranges; cannot translate\n");
 		return 1;
 	}



^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-06 22:56       ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 27+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-06 22:56 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev, LKML

On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> On Fri, 06 Mar 2015 15:18:42 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
>  
> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> 
> Attached.

This is indeed a bug in their DT. We might want to add quirks for
that unless it can be fixed (or has been via FW update). Olof ?

In the meantime, try that patch:

diff --git a/drivers/of/address.c b/drivers/of/address.c
index ad29069..78a7dcb 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -450,12 +450,17 @@ static struct of_bus *of_match_bus(struct device_node *np)
 	return NULL;
 }
 
-static int of_empty_ranges_quirk(void)
+static int of_empty_ranges_quirk(struct device_node *np)
 {
 	if (IS_ENABLED(CONFIG_PPC)) {
-		/* To save cycles, we cache the result */
+		/* To save cycles, we cache the result for global "Mac" setting */
 		static int quirk_state = -1;
 
+		/* PA-SEMI sdc DT bug */
+		if (of_device_is_compatible(np, "1682m-sdc"))
+			return true;
+
+		/* Make quirk cached */
 		if (quirk_state < 0)
 			quirk_state =
 				of_machine_is_compatible("Power Macintosh") ||
@@ -490,7 +495,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus,
 	 * This code is only enabled on powerpc. --gcl
 	 */
 	ranges = of_get_property(parent, rprop, &rlen);
-	if (ranges == NULL && !of_empty_ranges_quirk()) {
+	if (ranges == NULL && !of_empty_ranges_quirk(parent)) {
 		pr_debug("OF: no ranges; cannot translate\n");
 		return 1;
 	}

^ permalink raw reply related	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-06 22:56       ` Benjamin Herrenschmidt
@ 2015-03-06 23:07         ` Steven Rostedt
  -1 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-06 23:07 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: LKML, Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev

On Sat, 07 Mar 2015 09:56:22 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:


> In the meantime, try that patch:
> 

It boots for me.

Tested-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-06 23:07         ` Steven Rostedt
  0 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-06 23:07 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Grant Likely, Rob Herring, Olof Johansson, linuxppc-dev, LKML

On Sat, 07 Mar 2015 09:56:22 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:


> In the meantime, try that patch:
> 

It boots for me.

Tested-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-06 22:56       ` Benjamin Herrenschmidt
@ 2015-03-06 23:50         ` Olof Johansson
  -1 siblings, 0 replies; 27+ messages in thread
From: Olof Johansson @ 2015-03-06 23:50 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Steven Rostedt, LKML, Grant Likely, Rob Herring, linuxppc-dev

On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
>> On Fri, 06 Mar 2015 15:18:42 +1100
>> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>>
>>
>> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
>>
>> Attached.
>
> This is indeed a bug in their DT. We might want to add quirks for
> that unless it can be fixed (or has been via FW update). Olof ?

FW updates on this platform are highly unlikely. Quirk it is.


-Olof

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-06 23:50         ` Olof Johansson
  0 siblings, 0 replies; 27+ messages in thread
From: Olof Johansson @ 2015-03-06 23:50 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Grant Likely, Rob Herring, linuxppc-dev, LKML, Steven Rostedt

On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
>> On Fri, 06 Mar 2015 15:18:42 +1100
>> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>>
>>
>> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
>>
>> Attached.
>
> This is indeed a bug in their DT. We might want to add quirks for
> that unless it can be fixed (or has been via FW update). Olof ?

FW updates on this platform are highly unlikely. Quirk it is.


-Olof

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-06 23:50         ` Olof Johansson
@ 2015-03-07  4:02           ` Benjamin Herrenschmidt
  -1 siblings, 0 replies; 27+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-07  4:02 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Steven Rostedt, LKML, Grant Likely, Rob Herring, linuxppc-dev

On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
> On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> >> On Fri, 06 Mar 2015 15:18:42 +1100
> >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >>
> >>
> >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> >>
> >> Attached.
> >
> > This is indeed a bug in their DT. We might want to add quirks for
> > that unless it can be fixed (or has been via FW update). Olof ?
> 
> FW updates on this platform are highly unlikely. Quirk it is.

Oh I was not expecting a new FW, I was mostly wondering whether Steven
had the latest one since I *think* Michael has been testing with the
PA board we got here and didn't see that problem ... anyway, I'll check
with him early next week and clean up / submit that patch.

Cheers,
Ben.

> 
> -Olof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-07  4:02           ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 27+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-07  4:02 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Grant Likely, Rob Herring, linuxppc-dev, LKML, Steven Rostedt

On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
> On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> >> On Fri, 06 Mar 2015 15:18:42 +1100
> >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >>
> >>
> >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> >>
> >> Attached.
> >
> > This is indeed a bug in their DT. We might want to add quirks for
> > that unless it can be fixed (or has been via FW update). Olof ?
> 
> FW updates on this platform are highly unlikely. Quirk it is.

Oh I was not expecting a new FW, I was mostly wondering whether Steven
had the latest one since I *think* Michael has been testing with the
PA board we got here and didn't see that problem ... anyway, I'll check
with him early next week and clean up / submit that patch.

Cheers,
Ben.

> 
> -Olof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-07  4:02           ` Benjamin Herrenschmidt
@ 2015-03-10  0:28             ` Michael Ellerman
  -1 siblings, 0 replies; 27+ messages in thread
From: Michael Ellerman @ 2015-03-10  0:28 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Olof Johansson, Grant Likely, Rob Herring, linuxppc-dev, LKML,
	Benjamin Herrenschmidt

On Sat, 2015-03-07 at 15:02 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
> > On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
> > <benh@kernel.crashing.org> wrote:
> > > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> > >> On Fri, 06 Mar 2015 15:18:42 +1100
> > >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > >>
> > >>
> > >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> > >>
> > >> Attached.
> > >
> > > This is indeed a bug in their DT. We might want to add quirks for
> > > that unless it can be fixed (or has been via FW update). Olof ?
> > 
> > FW updates on this platform are highly unlikely. Quirk it is.
> 
> Oh I was not expecting a new FW, I was mostly wondering whether Steven
> had the latest one since I *think* Michael has been testing with the
> PA board we got here and didn't see that problem ... anyway, I'll check
> with him early next week and clean up / submit that patch.

Yeah I have been testing semi-regularly.

4.0-rc2 boots fine on mine.

But mine is an Athena, Steve's is an Electra. So they're not identical.

Mine is running:

  CFE version PAS-2.0.29 for ATHENA (64bit,MP,BE,PPC)
  Build Date: Mon Jun 30 11:47:25 PDT 2008 (mpl@mitch-1)

Steve is your CFE older than that?

Olof do you remember if that version or something newer is available for
Electra?

cheers



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-10  0:28             ` Michael Ellerman
  0 siblings, 0 replies; 27+ messages in thread
From: Michael Ellerman @ 2015-03-10  0:28 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Rob Herring, LKML, Grant Likely, Olof Johansson, linuxppc-dev

On Sat, 2015-03-07 at 15:02 +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
> > On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
> > <benh@kernel.crashing.org> wrote:
> > > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> > >> On Fri, 06 Mar 2015 15:18:42 +1100
> > >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > >>
> > >>
> > >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> > >>
> > >> Attached.
> > >
> > > This is indeed a bug in their DT. We might want to add quirks for
> > > that unless it can be fixed (or has been via FW update). Olof ?
> > 
> > FW updates on this platform are highly unlikely. Quirk it is.
> 
> Oh I was not expecting a new FW, I was mostly wondering whether Steven
> had the latest one since I *think* Michael has been testing with the
> PA board we got here and didn't see that problem ... anyway, I'll check
> with him early next week and clean up / submit that patch.

Yeah I have been testing semi-regularly.

4.0-rc2 boots fine on mine.

But mine is an Athena, Steve's is an Electra. So they're not identical.

Mine is running:

  CFE version PAS-2.0.29 for ATHENA (64bit,MP,BE,PPC)
  Build Date: Mon Jun 30 11:47:25 PDT 2008 (mpl@mitch-1)

Steve is your CFE older than that?

Olof do you remember if that version or something newer is available for
Electra?

cheers

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-10  0:28             ` Michael Ellerman
@ 2015-03-10  0:33               ` Olof Johansson
  -1 siblings, 0 replies; 27+ messages in thread
From: Olof Johansson @ 2015-03-10  0:33 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Steven Rostedt, Grant Likely, Rob Herring, linuxppc-dev, LKML,
	Benjamin Herrenschmidt

On Mon, Mar 9, 2015 at 5:28 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Sat, 2015-03-07 at 15:02 +1100, Benjamin Herrenschmidt wrote:
>> On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
>> > On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
>> > <benh@kernel.crashing.org> wrote:
>> > > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
>> > >> On Fri, 06 Mar 2015 15:18:42 +1100
>> > >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> > >>
>> > >>
>> > >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
>> > >>
>> > >> Attached.
>> > >
>> > > This is indeed a bug in their DT. We might want to add quirks for
>> > > that unless it can be fixed (or has been via FW update). Olof ?
>> >
>> > FW updates on this platform are highly unlikely. Quirk it is.
>>
>> Oh I was not expecting a new FW, I was mostly wondering whether Steven
>> had the latest one since I *think* Michael has been testing with the
>> PA board we got here and didn't see that problem ... anyway, I'll check
>> with him early next week and clean up / submit that patch.
>
> Yeah I have been testing semi-regularly.
>
> 4.0-rc2 boots fine on mine.
>
> But mine is an Athena, Steve's is an Electra. So they're not identical.

I have a chitra in my boot farm, so I run every build I do on it. I
have not hit it either, which confused me.

Turns out that Steven's machine boots with idle=doze, which is the
part that makes all the difference.


FWIW, the three machines have roughly these diffs:

* Electra: First development/eval board. Funky USB on localbus, plenty
of PCI-e. Two GigE, one 10GigE XAUI. CompactFlash and IDE on localbus
too. Usually shipped with a PCI-e SATA card and a USB card.

* Chitra: Second edition dev/eval board. Moved SATA and USB on-board,
and removed some of the localbus hardware. Might have routed three
GigE out instead of 2, can't remember.

* Athena: Never released board with a smaller package chip, there's
only a few of these around. Can't comment too much on the specifics,
but it's similar to Chitra, and the silicon is the same.

> Mine is running:
>
>   CFE version PAS-2.0.29 for ATHENA (64bit,MP,BE,PPC)
>   Build Date: Mon Jun 30 11:47:25 PDT 2008 (mpl@mitch-1)
>
> Steve is your CFE older than that?
>
> Olof do you remember if that version or something newer is available for
> Electra?

That looks about as new as they come. My board runs a .29 too.


-Olof

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-10  0:33               ` Olof Johansson
  0 siblings, 0 replies; 27+ messages in thread
From: Olof Johansson @ 2015-03-10  0:33 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Rob Herring, LKML, Steven Rostedt, Grant Likely, linuxppc-dev

On Mon, Mar 9, 2015 at 5:28 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Sat, 2015-03-07 at 15:02 +1100, Benjamin Herrenschmidt wrote:
>> On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
>> > On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
>> > <benh@kernel.crashing.org> wrote:
>> > > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
>> > >> On Fri, 06 Mar 2015 15:18:42 +1100
>> > >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> > >>
>> > >>
>> > >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
>> > >>
>> > >> Attached.
>> > >
>> > > This is indeed a bug in their DT. We might want to add quirks for
>> > > that unless it can be fixed (or has been via FW update). Olof ?
>> >
>> > FW updates on this platform are highly unlikely. Quirk it is.
>>
>> Oh I was not expecting a new FW, I was mostly wondering whether Steven
>> had the latest one since I *think* Michael has been testing with the
>> PA board we got here and didn't see that problem ... anyway, I'll check
>> with him early next week and clean up / submit that patch.
>
> Yeah I have been testing semi-regularly.
>
> 4.0-rc2 boots fine on mine.
>
> But mine is an Athena, Steve's is an Electra. So they're not identical.

I have a chitra in my boot farm, so I run every build I do on it. I
have not hit it either, which confused me.

Turns out that Steven's machine boots with idle=doze, which is the
part that makes all the difference.


FWIW, the three machines have roughly these diffs:

* Electra: First development/eval board. Funky USB on localbus, plenty
of PCI-e. Two GigE, one 10GigE XAUI. CompactFlash and IDE on localbus
too. Usually shipped with a PCI-e SATA card and a USB card.

* Chitra: Second edition dev/eval board. Moved SATA and USB on-board,
and removed some of the localbus hardware. Might have routed three
GigE out instead of 2, can't remember.

* Athena: Never released board with a smaller package chip, there's
only a few of these around. Can't comment too much on the specifics,
but it's similar to Chitra, and the silicon is the same.

> Mine is running:
>
>   CFE version PAS-2.0.29 for ATHENA (64bit,MP,BE,PPC)
>   Build Date: Mon Jun 30 11:47:25 PDT 2008 (mpl@mitch-1)
>
> Steve is your CFE older than that?
>
> Olof do you remember if that version or something newer is available for
> Electra?

That looks about as new as they come. My board runs a .29 too.


-Olof

^ permalink raw reply	[flat|nested] 27+ messages in thread

* [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-10  0:33               ` Olof Johansson
  (?)
@ 2015-03-10  6:57               ` Christian Zigotzky
  -1 siblings, 0 replies; 27+ messages in thread
From: Christian Zigotzky @ 2015-03-10  6:57 UTC (permalink / raw)
  To: linuxppc-dev

On 10/03/2015 01:33 a.m., Olof Johansson wrote:

* Electra: First development/eval board. Funky USB on localbus, plenty
of PCI-e. Two GigE, one 10GigE XAUI. CompactFlash and IDE on localbus
too. Usually shipped with a PCI-e SATA card and a USB card.

* Chitra: Second edition dev/eval board. Moved SATA and USB on-board,
and removed some of the localbus hardware. Might have routed three
GigE out instead of 2, can't remember.

* Athena: Never released board with a smaller package chip, there's
only a few of these around. Can't comment too much on the specifics,
but it's similar to Chitra, and the silicon is the same.

----

@All

FYI:

* Nemo: Released as AmigaONE X1000. With co-processor: "Xena" 500 MHz 
XCore XS1-L2 124 SDS
and SB600 southbridge.

Linux support:

http://forum.hyperion-entertainment.biz/viewforum.php?f=35&sid=7849bde9bae455730f3b95ad207bb6e9
http://www.supertuxkart-amiga.de/amiga/x1000.html

Is still in stock: http://amigakit.leamancomputing.com/x1000/?webpage=buy.

It means you could buy a new PA6T system with active Linux support. It 
runs the latest kernel 4.0-rc3
and the new ubuntu MATE 15.04 PowerPC on this board.

>> Mine is running:
>>
>>    CFE version PAS-2.0.29 for ATHENA (64bit,MP,BE,PPC)
>>    Build Date: Mon Jun 30 11:47:25 PDT 2008 (mpl@mitch-1)
>>
>>
FYI: Nemo: CFE version PAS-2.0.30

Rgds,

Christian

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-10  0:28             ` Michael Ellerman
@ 2015-03-10 17:03               ` Steven Rostedt
  -1 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-10 17:03 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Olof Johansson, Grant Likely, Rob Herring, linuxppc-dev, LKML,
	Benjamin Herrenschmidt

On Tue, 10 Mar 2015 11:28:03 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:

> 
> Mine is running:
> 
>   CFE version PAS-2.0.29 for ATHENA (64bit,MP,BE,PPC)
>   Build Date: Mon Jun 30 11:47:25 PDT 2008 (mpl@mitch-1)
> 
> Steve is your CFE older than that?

Seems so:

CFE version PAS-2.0.20 for ELECTRA (64bit,MP,BE,PPC)
Build Date: Tue Nov  6 22:35:48 PST 2007 (mpl@mitch-1)

-- Steve

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-10 17:03               ` Steven Rostedt
  0 siblings, 0 replies; 27+ messages in thread
From: Steven Rostedt @ 2015-03-10 17:03 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Rob Herring, LKML, Grant Likely, Olof Johansson, linuxppc-dev

On Tue, 10 Mar 2015 11:28:03 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:

> 
> Mine is running:
> 
>   CFE version PAS-2.0.29 for ATHENA (64bit,MP,BE,PPC)
>   Build Date: Mon Jun 30 11:47:25 PDT 2008 (mpl@mitch-1)
> 
> Steve is your CFE older than that?

Seems so:

CFE version PAS-2.0.20 for ELECTRA (64bit,MP,BE,PPC)
Build Date: Tue Nov  6 22:35:48 PST 2007 (mpl@mitch-1)

-- Steve

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-10  0:33               ` Olof Johansson
@ 2015-03-22 23:52                 ` Michael Ellerman
  -1 siblings, 0 replies; 27+ messages in thread
From: Michael Ellerman @ 2015-03-22 23:52 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Steven Rostedt, Grant Likely, Rob Herring, linuxppc-dev, LKML,
	Benjamin Herrenschmidt

On Mon, 2015-03-09 at 17:33 -0700, Olof Johansson wrote:
> On Mon, Mar 9, 2015 at 5:28 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > On Sat, 2015-03-07 at 15:02 +1100, Benjamin Herrenschmidt wrote:
> >> On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
> >> > On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
> >> > <benh@kernel.crashing.org> wrote:
> >> > > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> >> > >> On Fri, 06 Mar 2015 15:18:42 +1100
> >> > >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >> > >>
> >> > >>
> >> > >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> >> > >>
> >> > >> Attached.
> >> > >
> >> > > This is indeed a bug in their DT. We might want to add quirks for
> >> > > that unless it can be fixed (or has been via FW update). Olof ?
> >> >
> >> > FW updates on this platform are highly unlikely. Quirk it is.
> >>
> >> Oh I was not expecting a new FW, I was mostly wondering whether Steven
> >> had the latest one since I *think* Michael has been testing with the
> >> PA board we got here and didn't see that problem ... anyway, I'll check
> >> with him early next week and clean up / submit that patch.
> >
> > Yeah I have been testing semi-regularly.
> >
> > 4.0-rc2 boots fine on mine.
> >
> > But mine is an Athena, Steve's is an Electra. So they're not identical.
> 
> I have a chitra in my boot farm, so I run every build I do on it. I
> have not hit it either, which confused me.
> 
> Turns out that Steven's machine boots with idle=doze, which is the
> part that makes all the difference.

Aha, that is the key.

So mine also crashes with idle=doze, even with the newer firmware.

So we'll have to fix this with the quirk in the kernel.

cheers



^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
@ 2015-03-22 23:52                 ` Michael Ellerman
  0 siblings, 0 replies; 27+ messages in thread
From: Michael Ellerman @ 2015-03-22 23:52 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Rob Herring, LKML, Steven Rostedt, Grant Likely, linuxppc-dev

On Mon, 2015-03-09 at 17:33 -0700, Olof Johansson wrote:
> On Mon, Mar 9, 2015 at 5:28 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > On Sat, 2015-03-07 at 15:02 +1100, Benjamin Herrenschmidt wrote:
> >> On Fri, 2015-03-06 at 15:50 -0800, Olof Johansson wrote:
> >> > On Fri, Mar 6, 2015 at 2:56 PM, Benjamin Herrenschmidt
> >> > <benh@kernel.crashing.org> wrote:
> >> > > On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
> >> > >> On Fri, 06 Mar 2015 15:18:42 +1100
> >> > >> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >> > >>
> >> > >>
> >> > >> > Can you shoot me the DT (/proc/device-tree in a tarball) ?
> >> > >>
> >> > >> Attached.
> >> > >
> >> > > This is indeed a bug in their DT. We might want to add quirks for
> >> > > that unless it can be fixed (or has been via FW update). Olof ?
> >> >
> >> > FW updates on this platform are highly unlikely. Quirk it is.
> >>
> >> Oh I was not expecting a new FW, I was mostly wondering whether Steven
> >> had the latest one since I *think* Michael has been testing with the
> >> PA board we got here and didn't see that problem ... anyway, I'll check
> >> with him early next week and clean up / submit that patch.
> >
> > Yeah I have been testing semi-regularly.
> >
> > 4.0-rc2 boots fine on mine.
> >
> > But mine is an Athena, Steve's is an Electra. So they're not identical.
> 
> I have a chitra in my boot farm, so I run every build I do on it. I
> have not hit it either, which confused me.
> 
> Turns out that Steven's machine boots with idle=doze, which is the
> part that makes all the difference.

Aha, that is the key.

So mine also crashes with idle=doze, even with the newer firmware.

So we'll have to fix this with the quirk in the kernel.

cheers

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-07  8:27   ` Benjamin Herrenschmidt
@ 2015-03-08 20:19     ` Olof Johansson
  0 siblings, 0 replies; 27+ messages in thread
From: Olof Johansson @ 2015-03-08 20:19 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Alex Perez, Christian Zigotzky

On Sat, Mar 7, 2015 at 12:27 AM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Fri, 2015-03-06 at 16:16 -0800, Alex Perez wrote:
>
>> I will of course ultimately defer to Olof, but PASemi hasn=E2=80=99t exi=
sted
>> for years, and there is no entity which could possibly update the DT
>> for these reference PASemi development boards, unless Olof has source,
>> which I=E2=80=99m pretty sure he does not :)
>
> As I mentioned earlier, that's not what I had in mind :-) I was simply
> wondering whether an existing newer FW with a fix already existed but
> in any case, I'll submit the quirk next week, it doesn't hurt and is
> pretty simple and localized.

I doubt it -- it has definitely been a while but I have no memory of
having made any fixes to DT contents around there.

As far as access to FW sources, etc: I can't really do much on that
front either.


-Olof

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-07  0:16 ` Alex Perez
  2015-03-07  8:27   ` Benjamin Herrenschmidt
@ 2015-03-07  9:12   ` Christian Zigotzky
  1 sibling, 0 replies; 27+ messages in thread
From: Christian Zigotzky @ 2015-03-07  9:12 UTC (permalink / raw)
  To: Alex Perez, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 3230 bytes --]

Hi All,

I have a patch for it (Kernel 4.0-rc2):

diff -rupN linux-4.0/drivers/of/address.c 
linux-4.0-nemo/drivers/of/address.c
--- linux-4.0/drivers/of/address.c    2015-03-03 18:04:59.000000000 +0100
+++ linux-4.0-nemo/drivers/of/address.c    2015-03-03 22:34:00.037500744 
+0100
@@ -450,21 +450,6 @@ static struct of_bus *of_match_bus(struc
      return NULL;
  }

-static int of_empty_ranges_quirk(void)
-{
-    if (IS_ENABLED(CONFIG_PPC)) {
-        /* To save cycles, we cache the result */
-        static int quirk_state = -1;
-
-        if (quirk_state < 0)
-            quirk_state =
-                of_machine_is_compatible("Power Macintosh") ||
-                of_machine_is_compatible("MacRISC");
-        return quirk_state;
-    }
-    return false;
-}
-
  static int of_translate_one(struct device_node *parent, struct of_bus 
*bus,
                  struct of_bus *pbus, __be32 *addr,
                  int na, int ns, int pna, const char *rprop)
@@ -490,10 +475,12 @@ static int of_translate_one(struct devic
       * This code is only enabled on powerpc. --gcl
       */
      ranges = of_get_property(parent, rprop, &rlen);
-    if (ranges == NULL && !of_empty_ranges_quirk()) {
+#if !defined(CONFIG_PPC)
+       if (ranges == NULL) {
          pr_debug("OF: no ranges; cannot translate\n");
          return 1;
      }
+#endif /* !defined(CONFIG_PPC) */
      if (ranges == NULL || rlen == 0) {
          offset = of_read_number(addr, na);
          memset(addr, 0, pna * 4);

Rgds,

Christian

On 07/03/2015 01:16 a.m., Alex Perez wrote:
> On Mar 6, 2015, at 3:07 PM, linuxppc-dev-request@lists.ozlabs.org 
> <mailto:linuxppc-dev-request@lists.ozlabs.org> wrote:
>
>> Date: Sat, 07 Mar 2015 09:56:22 +1100
>> From: Benjamin Herrenschmidt <benh@kernel.crashing.org 
>> <mailto:benh@kernel.crashing.org>>
>> To: Steven Rostedt <rostedt@goodmis.org <mailto:rostedt@goodmis.org>>
>> Cc: Grant Likely <grant.likely@linaro.org 
>> <mailto:grant.likely@linaro.org>>, Rob Herring
>> <robh@kernel.org <mailto:robh@kernel.org>>, Olof Johansson 
>> <olof@lixom.net <mailto:olof@lixom.net>>,
>> linuxppc-dev@lists.ozlabs.org <mailto:linuxppc-dev@lists.ozlabs.org>, 
>> LKML <linux-kernel@vger.kernel.org <mailto:linux-kernel@vger.kernel.org>>
>> Subject: Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after:
>> of/base: Fix PowerPC address parsing hack
>> Message-ID: <1425682582.4636.197.camel@kernel.crashing.org 
>> <mailto:1425682582.4636.197.camel@kernel.crashing.org>>
>> Content-Type: text/plain; charset="UTF-8"
>>
>> On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
>>> On Fri, 06 Mar 2015 15:18:42 +1100
>>> Benjamin Herrenschmidt <benh@kernel.crashing.org 
>>> <mailto:benh@kernel.crashing.org>> wrote:
>>>
>>>
>>>> Can you shoot me the DT (/proc/device-tree in a tarball) ?
>>>
>>> Attached.
>>
>> This is indeed a bug in their DT. We might want to add quirks for
>> that unless it can be fixed (or has been via FW update). Olof ?
>
> I will of course ultimately defer to Olof, but PASemi hasn’t existed 
> for years, and there is no entity which could possibly update the DT 
> for these reference PASemi development boards, unless Olof has source, 
> which I’m pretty sure he does not :)


[-- Attachment #2: Type: text/html, Size: 24326 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
  2015-03-07  0:16 ` Alex Perez
@ 2015-03-07  8:27   ` Benjamin Herrenschmidt
  2015-03-08 20:19     ` Olof Johansson
  2015-03-07  9:12   ` Christian Zigotzky
  1 sibling, 1 reply; 27+ messages in thread
From: Benjamin Herrenschmidt @ 2015-03-07  8:27 UTC (permalink / raw)
  To: Alex Perez; +Cc: linuxppc-dev, Christian Zigotzky

On Fri, 2015-03-06 at 16:16 -0800, Alex Perez wrote:

> I will of course ultimately defer to Olof, but PASemi hasn’t existed
> for years, and there is no entity which could possibly update the DT
> for these reference PASemi development boards, unless Olof has source,
> which I’m pretty sure he does not :)

As I mentioned earlier, that's not what I had in mind :-) I was simply
wondering whether an existing newer FW with a fix already existed but
in any case, I'll submit the quirk next week, it doesn't hurt and is
pretty simple and localized.

Cheers,
Ben.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack
       [not found] <mailman.412.1425683254.7605.linuxppc-dev@lists.ozlabs.org>
@ 2015-03-07  0:16 ` Alex Perez
  2015-03-07  8:27   ` Benjamin Herrenschmidt
  2015-03-07  9:12   ` Christian Zigotzky
  0 siblings, 2 replies; 27+ messages in thread
From: Alex Perez @ 2015-03-07  0:16 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Christian Zigotzky

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

On Mar 6, 2015, at 3:07 PM, linuxppc-dev-request@lists.ozlabs.org wrote:

> Date: Sat, 07 Mar 2015 09:56:22 +1100
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> To: Steven Rostedt <rostedt@goodmis.org>
> Cc: Grant Likely <grant.likely@linaro.org>, Rob Herring
> 	<robh@kernel.org>, Olof Johansson <olof@lixom.net>,
> 	linuxppc-dev@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>
> Subject: Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after:
> 	of/base: Fix PowerPC address parsing hack
> Message-ID: <1425682582.4636.197.camel@kernel.crashing.org>
> Content-Type: text/plain; charset="UTF-8"
> 
> On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote:
>> On Fri, 06 Mar 2015 15:18:42 +1100
>> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>> 
>> 
>>> Can you shoot me the DT (/proc/device-tree in a tarball) ?
>> 
>> Attached.
> 
> This is indeed a bug in their DT. We might want to add quirks for
> that unless it can be fixed (or has been via FW update). Olof ?

I will of course ultimately defer to Olof, but PASemi hasn’t existed for years, and there is no entity which could possibly update the DT for these reference PASemi development boards, unless Olof has source, which I’m pretty sure he does not :)

[-- Attachment #2: Type: text/html, Size: 17931 bytes --]

^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2015-03-22 23:52 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 22:12 [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack Steven Rostedt
2015-03-05 22:12 ` Steven Rostedt
2015-03-06  4:18 ` Benjamin Herrenschmidt
2015-03-06  4:18   ` Benjamin Herrenschmidt
2015-03-06 15:00   ` Steven Rostedt
2015-03-06 15:00     ` Steven Rostedt
2015-03-06 22:56     ` Benjamin Herrenschmidt
2015-03-06 22:56       ` Benjamin Herrenschmidt
2015-03-06 23:07       ` Steven Rostedt
2015-03-06 23:07         ` Steven Rostedt
2015-03-06 23:50       ` Olof Johansson
2015-03-06 23:50         ` Olof Johansson
2015-03-07  4:02         ` Benjamin Herrenschmidt
2015-03-07  4:02           ` Benjamin Herrenschmidt
2015-03-10  0:28           ` Michael Ellerman
2015-03-10  0:28             ` Michael Ellerman
2015-03-10  0:33             ` Olof Johansson
2015-03-10  0:33               ` Olof Johansson
2015-03-10  6:57               ` Christian Zigotzky
2015-03-22 23:52               ` Michael Ellerman
2015-03-22 23:52                 ` Michael Ellerman
2015-03-10 17:03             ` Steven Rostedt
2015-03-10 17:03               ` Steven Rostedt
     [not found] <mailman.412.1425683254.7605.linuxppc-dev@lists.ozlabs.org>
2015-03-07  0:16 ` Alex Perez
2015-03-07  8:27   ` Benjamin Herrenschmidt
2015-03-08 20:19     ` Olof Johansson
2015-03-07  9:12   ` Christian Zigotzky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.