* [PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback()
@ 2015-03-23 19:07 Larry Finger
2015-03-24 9:43 ` Grumbach, Emmanuel
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2015-03-23 19:07 UTC (permalink / raw)
To: kvalo
Cc: linux-wireless, Larry Finger, Johannes Berg, Emmanuel Grumbach,
Intel Linux Wireless
In this routine, kzalloc allocates a memory block. This allocation is
freed in the error paths, but not in the normal exit, thus the allocation
is leaked.
The kmemleak facility was used to find the leak.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>
---
drivers/net/wireless/iwlwifi/iwl-drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/iwlwifi/iwl-drv.c b/drivers/net/wireless/iwlwifi/iwl-drv.c
index 66ca000..aefdd9b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/iwlwifi/iwl-drv.c
@@ -1319,6 +1319,7 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
op->name, err);
#endif
}
+ kfree(pieces);
return;
try_again:
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback()
2015-03-23 19:07 [PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback() Larry Finger
@ 2015-03-24 9:43 ` Grumbach, Emmanuel
0 siblings, 0 replies; 2+ messages in thread
From: Grumbach, Emmanuel @ 2015-03-24 9:43 UTC (permalink / raw)
To: Larry.Finger; +Cc: linux-wireless, kvalo, ilw, Berg, Johannes
T24gTW9uLCAyMDE1LTAzLTIzIGF0IDE0OjA3IC0wNTAwLCBMYXJyeSBGaW5nZXIgd3JvdGU6DQo+
IEluIHRoaXMgcm91dGluZSwga3phbGxvYyBhbGxvY2F0ZXMgYSBtZW1vcnkgYmxvY2suIFRoaXMg
YWxsb2NhdGlvbiBpcw0KPiBmcmVlZCBpbiB0aGUgZXJyb3IgcGF0aHMsIGJ1dCBub3QgaW4gdGhl
IG5vcm1hbCBleGl0LCB0aHVzIHRoZSBhbGxvY2F0aW9uDQo+IGlzIGxlYWtlZC4NCj4gDQo+IFRo
ZSBrbWVtbGVhayBmYWNpbGl0eSB3YXMgdXNlZCB0byBmaW5kIHRoZSBsZWFrLg0KPiANCg0KUGlj
a2VkIHVwIC0gdGhhbmtzLg0KDQo+IFNpZ25lZC1vZmYtYnk6IExhcnJ5IEZpbmdlciA8TGFycnku
RmluZ2VyQGx3ZmluZ2VyLm5ldD4NCj4gQ2M6IEpvaGFubmVzIEJlcmcgPGpvaGFubmVzLmJlcmdA
aW50ZWwuY29tPg0KPiBDYzogRW1tYW51ZWwgR3J1bWJhY2ggPGVtbWFudWVsLmdydW1iYWNoQGlu
dGVsLmNvbT4NCj4gQ2M6IEludGVsIExpbnV4IFdpcmVsZXNzIDxpbHdAbGludXguaW50ZWwuY29t
Pg0KPiAtLS0NCj4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvaXdsLWRydi5jIHwgMSAr
DQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4gDQo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2l3bC1kcnYuYyBiL2RyaXZlcnMvbmV0L3dpcmVs
ZXNzL2l3bHdpZmkvaXdsLWRydi5jDQo+IGluZGV4IDY2Y2EwMDAuLmFlZmRkOWIgMTAwNjQ0DQo+
IC0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvaXdsLWRydi5jDQo+ICsrKyBiL2Ry
aXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvaXdsLWRydi5jDQo+IEBAIC0xMzE5LDYgKzEzMTks
NyBAQCBzdGF0aWMgdm9pZCBpd2xfcmVxX2Z3X2NhbGxiYWNrKGNvbnN0IHN0cnVjdCBmaXJtd2Fy
ZSAqdWNvZGVfcmF3LCB2b2lkICpjb250ZXh0KQ0KPiAgCQkJCW9wLT5uYW1lLCBlcnIpOw0KPiAg
I2VuZGlmDQo+ICAJfQ0KPiArCWtmcmVlKHBpZWNlcyk7DQo+ICAJcmV0dXJuOw0KPiAgDQo+ICAg
dHJ5X2FnYWluOg0KDQo=
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-24 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-23 19:07 [PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback() Larry Finger
2015-03-24 9:43 ` Grumbach, Emmanuel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.