All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
	virtualization@lists.linux-foundation.org,
	David Herrmann <dh.herrmann@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [virtio-dev] Re: [PATCH v3] Add virtio-input driver.
Date: Tue, 24 Mar 2015 14:37:24 +0100	[thread overview]
Message-ID: <1427204244.18768.21.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20150324135908-mutt-send-email-mst@redhat.com>

  Hi,

> > input layer checks it and ignores events not supported (according to the
> > support bitmaps).
> 
> Right but support bitmaps come from host too, no?

Yes, but the driver will not set invalid bits (bitcount argument for the
virtinput_cfg_bits() function is the number of valid bits of the
specific bitmap).

cheers,
  Gerd





WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Michael S. Tsirkin" <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: virtio-dev-sDuHXQ4OtrM4h7I2RyI4rWD2FQJk+8+b@public.gmane.org,
	virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	David Herrmann
	<dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
	open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"open list:ABI/API"
	<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [virtio-dev] Re: [PATCH v3] Add virtio-input driver.
Date: Tue, 24 Mar 2015 14:37:24 +0100	[thread overview]
Message-ID: <1427204244.18768.21.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <20150324135908-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

  Hi,

> > input layer checks it and ignores events not supported (according to the
> > support bitmaps).
> 
> Right but support bitmaps come from host too, no?

Yes, but the driver will not set invalid bits (bitcount argument for the
virtinput_cfg_bits() function is the number of valid bits of the
specific bitmap).

cheers,
  Gerd

  parent reply	other threads:[~2015-03-24 13:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24  7:32 [PATCH v3] Add virtio-input driver Gerd Hoffmann
2015-03-24  7:32 ` Gerd Hoffmann
2015-03-24 10:26 ` Gerd Hoffmann
2015-03-24 10:26   ` Gerd Hoffmann
2015-03-24 10:40   ` Michael S. Tsirkin
2015-03-24 10:40   ` Michael S. Tsirkin
2015-03-24 10:48   ` Michael S. Tsirkin
2015-03-24 10:48     ` Michael S. Tsirkin
2015-03-24 10:26 ` Gerd Hoffmann
2015-03-24 10:36 ` Michael S. Tsirkin
2015-03-24 11:46   ` [virtio-dev] " Gerd Hoffmann
2015-03-24 11:46   ` Gerd Hoffmann
2015-03-24 13:02     ` Michael S. Tsirkin
2015-03-24 13:02       ` Michael S. Tsirkin
2015-03-24 13:37       ` Gerd Hoffmann
2015-03-24 13:37       ` Gerd Hoffmann [this message]
2015-03-24 13:37         ` Gerd Hoffmann
2015-03-24 14:14         ` Michael S. Tsirkin
2015-03-24 15:25           ` Gerd Hoffmann
2015-03-24 15:25             ` Gerd Hoffmann
2015-03-24 16:05             ` Dmitry Torokhov
2015-03-24 16:05               ` Dmitry Torokhov
2015-03-24 14:14         ` Michael S. Tsirkin
2015-03-24 16:23   ` Dmitry Torokhov
2015-03-24 16:23     ` Dmitry Torokhov
2015-03-24 17:22     ` Michael S. Tsirkin
2015-03-24 17:22       ` Michael S. Tsirkin
2015-03-24 17:28       ` Dmitry Torokhov
2015-03-24 17:28         ` Dmitry Torokhov
2015-03-25  5:36         ` Michael S. Tsirkin
2015-03-25  5:36         ` Michael S. Tsirkin
2015-03-24 10:36 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427204244.18768.21.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=dh.herrmann@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.