All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable
@ 2015-03-24 17:53 Connor Behan
  2015-03-27  0:06 ` Emil Velikov
  2015-04-05 14:32 ` Emil Velikov
  0 siblings, 2 replies; 5+ messages in thread
From: Connor Behan @ 2015-03-24 17:53 UTC (permalink / raw)
  To: dri-devel; +Cc: Connor Behan

This one is a bit harder to notice.

Signed-off-by: Connor Behan <connor.behan@gmail.com>
---
 xf86drm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xf86drm.c b/xf86drm.c
index e73cddd..ffc53b8 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -1719,7 +1719,7 @@ int drmAgpEnable(int fd, unsigned long mode)
 {
     drm_agp_mode_t m;
 
-    memclear(mode);
+    memclear(m);
     m.mode = mode;
     if (drmIoctl(fd, DRM_IOCTL_AGP_ENABLE, &m))
 	return -errno;
-- 
2.3.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable
  2015-03-24 17:53 [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable Connor Behan
@ 2015-03-27  0:06 ` Emil Velikov
  2015-03-27  2:26   ` Connor Behan
  2015-04-05 14:32 ` Emil Velikov
  1 sibling, 1 reply; 5+ messages in thread
From: Emil Velikov @ 2015-03-27  0:06 UTC (permalink / raw)
  To: Connor Behan; +Cc: ML dri-devel

On 24 March 2015 at 17:53, Connor Behan <connor.behan@gmail.com> wrote:
> This one is a bit harder to notice.
>
Plus not so widely used any more :-)

Mildly related - with EXA support for the r128 ddx done for a while
now, do you have any plans on updating the dri module to dri2 ?

> Signed-off-by: Connor Behan <connor.behan@gmail.com>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks !
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable
  2015-03-27  0:06 ` Emil Velikov
@ 2015-03-27  2:26   ` Connor Behan
  2015-03-30 14:14     ` Alex Deucher
  0 siblings, 1 reply; 5+ messages in thread
From: Connor Behan @ 2015-03-27  2:26 UTC (permalink / raw)
  To: Emil Velikov; +Cc: ML dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 694 bytes --]

On 26/03/15 08:06 PM, Emil Velikov wrote:
> On 24 March 2015 at 17:53, Connor Behan <connor.behan@gmail.com> wrote:
>> This one is a bit harder to notice.
>>
> Plus not so widely used any more :-)
>
> Mildly related - with EXA support for the r128 ddx done for a while
> now, do you have any plans on updating the dri module to dri2 ?
>
Yes, that is still the eventual goal. I'm looking at how the radeon
kernel module is setup these days. So I should be able to start porting
r128 to KMS at some point this year.

Thanks for the interest!
>> Signed-off-by: Connor Behan <connor.behan@gmail.com>
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
>
> Thanks !
> Emil



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable
  2015-03-27  2:26   ` Connor Behan
@ 2015-03-30 14:14     ` Alex Deucher
  0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2015-03-30 14:14 UTC (permalink / raw)
  To: Connor Behan; +Cc: Emil Velikov, ML dri-devel

On Thu, Mar 26, 2015 at 10:26 PM, Connor Behan <connor.behan@gmail.com> wrote:
> On 26/03/15 08:06 PM, Emil Velikov wrote:
>> On 24 March 2015 at 17:53, Connor Behan <connor.behan@gmail.com> wrote:
>>> This one is a bit harder to notice.
>>>
>> Plus not so widely used any more :-)
>>
>> Mildly related - with EXA support for the r128 ddx done for a while
>> now, do you have any plans on updating the dri module to dri2 ?
>>
> Yes, that is still the eventual goal. I'm looking at how the radeon
> kernel module is setup these days. So I should be able to start porting
> r128 to KMS at some point this year.

I think it would be easiest to port r128 support to the radeon kernel
module.  You can re-use 90% of the r100 code.

Alex

>
> Thanks for the interest!
>>> Signed-off-by: Connor Behan <connor.behan@gmail.com>
>> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
>>
>> Thanks !
>> Emil
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable
  2015-03-24 17:53 [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable Connor Behan
  2015-03-27  0:06 ` Emil Velikov
@ 2015-04-05 14:32 ` Emil Velikov
  1 sibling, 0 replies; 5+ messages in thread
From: Emil Velikov @ 2015-04-05 14:32 UTC (permalink / raw)
  To: Connor Behan; +Cc: ML dri-devel

On 24 March 2015 at 17:53, Connor Behan <connor.behan@gmail.com> wrote:
> This one is a bit harder to notice.
>
> Signed-off-by: Connor Behan <connor.behan@gmail.com>
Thanks for the patch Connor. Just pushed it to master.

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-05 14:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-24 17:53 [PATCH] xf86drm: Fix ioctl struct clearing in drmAgpEnable Connor Behan
2015-03-27  0:06 ` Emil Velikov
2015-03-27  2:26   ` Connor Behan
2015-03-30 14:14     ` Alex Deucher
2015-04-05 14:32 ` Emil Velikov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.