* [PATCH] uninative-tarball: fix dependency on patchelf
@ 2015-03-24 22:17 Tyler Hall
2015-03-24 22:31 ` Randy Witt
2015-03-25 17:35 ` [PATCH v2] " Tyler Hall
0 siblings, 2 replies; 4+ messages in thread
From: Tyler Hall @ 2015-03-24 22:17 UTC (permalink / raw)
To: openembedded-core
DEPENDS doesn't actually add the dependency on patchelf-native to the
populate_sdk task. SDK_DEPENDS does this, but move the append to after
inheriting the base class so it does not get overwritten.
Without this, uninative-tarball fails to build in a clean workspace on a
system without patchelf.
Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
CC: Richard Purdie <richard.purdie@linuxfoundation.org>
CC: Randy Witt <randy.e.witt@linux.intel.com>
---
meta/recipes-core/meta/uninative-tarball.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb
index 53435f2..62bdde8 100644
--- a/meta/recipes-core/meta/uninative-tarball.bb
+++ b/meta/recipes-core/meta/uninative-tarball.bb
@@ -11,7 +11,6 @@ TOOLCHAIN_HOST_TASK = "\
"
INHIBIT_DEFAULT_DEPS = "1"
-DEPENDS += "patchelf-native"
TOOLCHAIN_OUTPUTNAME ?= "${BUILD_ARCH}-nativesdk-libc"
@@ -25,6 +24,8 @@ inherit populate_sdk
deltask install
deltask package
+SDK_DEPENDS += "patchelf-native"
+
SDK_PACKAGING_FUNC = ""
fakeroot create_sdk_files() {
--
2.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] uninative-tarball: fix dependency on patchelf
2015-03-24 22:17 [PATCH] uninative-tarball: fix dependency on patchelf Tyler Hall
@ 2015-03-24 22:31 ` Randy Witt
2015-03-25 17:35 ` [PATCH v2] " Tyler Hall
1 sibling, 0 replies; 4+ messages in thread
From: Randy Witt @ 2015-03-24 22:31 UTC (permalink / raw)
To: Tyler Hall, openembedded-core
On 03/24/2015 03:17 PM, Tyler Hall wrote:
> DEPENDS doesn't actually add the dependency on patchelf-native to the
> populate_sdk task. SDK_DEPENDS does this, but move the append to after
> inheriting the base class so it does not get overwritten.
>
> Without this, uninative-tarball fails to build in a clean workspace on a
> system without patchelf.
>
> Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
> CC: Richard Purdie <richard.purdie@linuxfoundation.org>
> CC: Randy Witt <randy.e.witt@linux.intel.com>
> ---
> meta/recipes-core/meta/uninative-tarball.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb
> index 53435f2..62bdde8 100644
> --- a/meta/recipes-core/meta/uninative-tarball.bb
> +++ b/meta/recipes-core/meta/uninative-tarball.bb
> @@ -11,7 +11,6 @@ TOOLCHAIN_HOST_TASK = "\
> "
>
> INHIBIT_DEFAULT_DEPS = "1"
> -DEPENDS += "patchelf-native"
>
> TOOLCHAIN_OUTPUTNAME ?= "${BUILD_ARCH}-nativesdk-libc"
>
> @@ -25,6 +24,8 @@ inherit populate_sdk
> deltask install
> deltask package
>
> +SDK_DEPENDS += "patchelf-native"
> +
> SDK_PACKAGING_FUNC = ""
>
> fakeroot create_sdk_files() {
>
This patch is the same as what I had queued up. The only thing is to put the
yocto bug number 7467 in the commit message.
Acked-by: Randy Witt <randy.e.witt@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] uninative-tarball: fix dependency on patchelf
2015-03-24 22:17 [PATCH] uninative-tarball: fix dependency on patchelf Tyler Hall
2015-03-24 22:31 ` Randy Witt
@ 2015-03-25 17:35 ` Tyler Hall
2015-03-25 17:43 ` Tyler Hall
1 sibling, 1 reply; 4+ messages in thread
From: Tyler Hall @ 2015-03-25 17:35 UTC (permalink / raw)
To: openembedded-core
DEPENDS doesn't actually add the dependency on patchelf-native to the
populate_sdk task. SDK_DEPENDS does this, but move the append to after
inheriting the base class so it does not get overwritten.
Without this, uninative-tarball fails to build in a clean workspace on a
system without patchelf.
[Yocto #7467]
Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
Acked-by: Randy Witt <randy.e.witt@linux.intel.com>
CC: Richard Purdie <richard.purdie@linuxfoundation.org>
CC: Randy Witt <randy.e.witt@linux.intel.com>
---
meta/recipes-core/meta/uninative-tarball.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb
index 53435f2..62bdde8 100644
--- a/meta/recipes-core/meta/uninative-tarball.bb
+++ b/meta/recipes-core/meta/uninative-tarball.bb
@@ -11,7 +11,6 @@ TOOLCHAIN_HOST_TASK = "\
"
INHIBIT_DEFAULT_DEPS = "1"
-DEPENDS += "patchelf-native"
TOOLCHAIN_OUTPUTNAME ?= "${BUILD_ARCH}-nativesdk-libc"
@@ -25,6 +24,8 @@ inherit populate_sdk
deltask install
deltask package
+SDK_DEPENDS += "patchelf-native"
+
SDK_PACKAGING_FUNC = ""
fakeroot create_sdk_files() {
--
2.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] uninative-tarball: fix dependency on patchelf
2015-03-25 17:35 ` [PATCH v2] " Tyler Hall
@ 2015-03-25 17:43 ` Tyler Hall
0 siblings, 0 replies; 4+ messages in thread
From: Tyler Hall @ 2015-03-25 17:43 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer, Randy Witt,
Richard Purdie
Randy, Richard,
Disregard. Looks like we raced with each other. Thanks for applying v1.
-Tyler
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-25 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-24 22:17 [PATCH] uninative-tarball: fix dependency on patchelf Tyler Hall
2015-03-24 22:31 ` Randy Witt
2015-03-25 17:35 ` [PATCH v2] " Tyler Hall
2015-03-25 17:43 ` Tyler Hall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.