Re: [oe-commits] Ash Charles : mpd: ship systemd socket file

Re: [oe-commits] Ash Charles : mpd: ship systemd socket file

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1832 bytes --]

On Mon, Jan 12, 2015 at 02:36:29PM +0000, git@git.openembedded.org wrote:
> Module: meta-openembedded.git
> Branch: master
> Commit: c702fc4dfab0c09449bd47a04deecca5946d981f
> URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=c702fc4dfab0c09449bd47a04deecca5946d981f
> 
> Author: Ash Charles <ashcharles@gmail.com>
> Date:   Thu Jan  8 10:58:19 2015 -0800
> 
> mpd: ship systemd socket file
> 
> As of mpd version 19.1, as systemd socket file, mpd.socket, is
> installed. Ship this file as part of the mpd-systemd package.

Can you please fix this issue?
mpd-0.19.1: mpd rdepends on libsmbclient, but it isn't a build dependency? [build-deps]

> 
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> ---
> 
>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> index 04eed0a..feec985 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> @@ -48,7 +48,7 @@ do_install_append() {
>  RPROVIDES_${PN} += "${PN}-systemd"
>  RREPLACES_${PN} += "${PN}-systemd"
>  RCONFLICTS_${PN} += "${PN}-systemd"
> -SYSTEMD_SERVICE_${PN} = "mpd.service"
> +SYSTEMD_SERVICE_${PN} = "mpd.service mpd.socket"
>  
>  USERADD_PACKAGES = "${PN}"
>  USERADD_PARAM_${PN} = " \
> 
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

[PATCH] mpd: Add build dependency on samba

[Ash Charles]

Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
index feec985..b3d88e0 100644
--- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
+++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
@@ -3,7 +3,7 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 HOMEPAGE ="http://www.musicpd.org"
 
-DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib"
+DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib samba"
 
 SRC_URI = " \
     http://www.musicpd.org/download/${BPN}/0.19/${BP}.tar.xz \
-- 
2.1.0

Re: [PATCH] mpd: Add build dependency on samba

[Khem Raj]

On Mon, Mar 23, 2015 at 9:05 AM, Ash Charles <ashcharles@gmail.com> wrote:
> -DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib"
> +DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib samba"

where is this dependency coming from ? some explanation to this would
be nice. Can this be avoided ?

Re: [PATCH] mpd: Add build dependency on samba

[Ash Charles]

Hi Khem,

Sorry--my commit message was rather unhelpful!  I'll confess I was
just trying to resolve a build warning as I don't have detailed
knowledge of the package.  Digging a little deeper, version 0.19
introduces smbclient which looks to be the source of the dependency of
samba.

Sending a v2 with an updated commit message and packageconfig.  Please
let me know if you see any issues.

--Ash


On Mon, Mar 23, 2015 at 10:10 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, Mar 23, 2015 at 9:05 AM, Ash Charles <ashcharles@gmail.com> wrote:
>> -DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib"
>> +DEPENDS = "alsa-lib libsamplerate0 libsndfile1 libvorbis libogg faad2 ffmpeg curl sqlite bzip2 pulseaudio tcp-wrappers openal-soft yajl jack faad2 flac libao fluidsynth libcdio wavpack libopus mpg123 libmms libmodplug boost icu dbus expat zlib samba"
>
> where is this dependency coming from ? some explanation to this would
> be nice. Can this be avoided ?
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[PATCH v2] mpd: Add build dependency on samba

[Ash Charles]

Version 0.19 [1], adds the smbclient plugins for storage and input so
needs samba when building with the --enable-samba option.

[1] http://git.musicpd.org/cgit/master/mpd.git/plain/NEWS?h=v0.19

Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
index feec985..f6152a6 100644
--- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
+++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
@@ -20,6 +20,7 @@ EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[id3tag] = "--enable-id3,--disable-id3,libid3tag"
 PACKAGECONFIG[lame] = "--enable-lame-encoder,--disable-lame-encoder,lame"
+PACKAGECONFIG[smb] = "--enable-smbclient,--disable-smbclient,samba,samba"
 
 do_install_append() {
     install -d ${D}/${localstatedir}/lib/mpd/music
-- 
2.1.0

Re: [PATCH v2] mpd: Add build dependency on samba

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Tue, Mar 24, 2015 at 04:48:43PM -0700, Ash Charles wrote:
> Version 0.19 [1], adds the smbclient plugins for storage and input so
> needs samba when building with the --enable-samba option.
> 
> [1] http://git.musicpd.org/cgit/master/mpd.git/plain/NEWS?h=v0.19
> 
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> index feec985..f6152a6 100644
> --- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> +++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
> @@ -20,6 +20,7 @@ EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds
>  PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
>  PACKAGECONFIG[id3tag] = "--enable-id3,--disable-id3,libid3tag"
>  PACKAGECONFIG[lame] = "--enable-lame-encoder,--disable-lame-encoder,lame"
> +PACKAGECONFIG[smb] = "--enable-smbclient,--disable-smbclient,samba,samba"

You don't need to repeat samba in 4th parameter.

>  
>  do_install_append() {
>      install -d ${D}/${localstatedir}/lib/mpd/music
> -- 
> 2.1.0
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

[PATCH v3] mpd: Add build dependency on samba

[Ash Charles]

Version 0.19 [1], adds the smbclient plugins for storage and input so
needs samba when building with the --enable-samba option.

[1] http://git.musicpd.org/cgit/master/mpd.git/plain/NEWS?h=v0.19

Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
index feec985..a5cd557 100644
--- a/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
+++ b/meta-multimedia/recipes-multimedia/musicpd/mpd_0.19.1.bb
@@ -20,6 +20,7 @@ EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemds
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[id3tag] = "--enable-id3,--disable-id3,libid3tag"
 PACKAGECONFIG[lame] = "--enable-lame-encoder,--disable-lame-encoder,lame"
+PACKAGECONFIG[smb] = "--enable-smbclient,--disable-smbclient,samba"
 
 do_install_append() {
     install -d ${D}/${localstatedir}/lib/mpd/music
-- 
2.1.0