* [Buildroot] [PATCH v2] toolchain-external: fix gdbserver copying for external arc-2014.12 tools
@ 2015-03-25 8:11 Alexey Brodkin
2015-07-11 7:47 ` Romain Naour
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Brodkin @ 2015-03-25 8:11 UTC (permalink / raw)
To: buildroot
Historically in pre-built ARC GNU tools gdbserver is located in
top-level "target-bin" folder.
Because of that fact if BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY is
selected Buildroot won't find gdbserver (it looks within
SYSROOT/ARCH_SYSROOT folder).
Simplest solution is to use TOOLCHAIN_EXTERNAL_FIXUP_CMDS where copy
gdbserver from "target-bin" folder into SYSROOT/usr/bin.
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Changes in v2:
[1] "install" command is used instead of "cp"
[2] copy only "gdbserver" instead of everything from "target_bin" to sysroot
---
toolchain/toolchain-external/toolchain-external.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
index c0429bb..fe709db 100644
--- a/toolchain/toolchain-external/toolchain-external.mk
+++ b/toolchain/toolchain-external/toolchain-external.mk
@@ -396,6 +396,10 @@ else
TOOLCHAIN_EXTERNAL_SYNOPSYS_ENDIANESS = be
endif
TOOLCHAIN_EXTERNAL_SOURCE = arc_gnu_2014.12_prebuilt_uclibc_$(TOOLCHAIN_EXTERNAL_SYNOPSYS_ENDIANESS)_$(TOOLCHAIN_EXTERNAL_SYNOPSYS_CORE)_linux_install.tar.gz
+define TOOLCHAIN_EXTERNAL_FIXUP_CMDS
+ $(Q)SYSROOT_DIR="$(call toolchain_find_sysroot,$(TOOLCHAIN_EXTERNAL_CC))" ; \
+ install -m 0755 -D $(TOOLCHAIN_EXTERNAL_INSTALL_DIR)/target-bin/gdbserver $${SYSROOT_DIR}/usr/bin/gdbserver
+endef
else
# Custom toolchain
TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] toolchain-external: fix gdbserver copying for external arc-2014.12 tools
2015-03-25 8:11 [Buildroot] [PATCH v2] toolchain-external: fix gdbserver copying for external arc-2014.12 tools Alexey Brodkin
@ 2015-07-11 7:47 ` Romain Naour
2015-07-11 8:45 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Romain Naour @ 2015-07-11 7:47 UTC (permalink / raw)
To: buildroot
Hi Alexey,
Le 25/03/2015 09:11, Alexey Brodkin a ?crit :
> Historically in pre-built ARC GNU tools gdbserver is located in
> top-level "target-bin" folder.
>
> Because of that fact if BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY is
> selected Buildroot won't find gdbserver (it looks within
> SYSROOT/ARCH_SYSROOT folder).
>
> Simplest solution is to use TOOLCHAIN_EXTERNAL_FIXUP_CMDS where copy
> gdbserver from "target-bin" folder into SYSROOT/usr/bin.
Since this patch, the arc 2014.12 prebuild toolchain as been marked as broken
[1]. This patch is still needed ?
[1]
http://git.buildroot.net/buildroot/commit/?id=cd3c00fbc01e99496f28276c62182963cada0979
Best regards,
Romain Naour
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Changes in v2:
> [1] "install" command is used instead of "cp"
> [2] copy only "gdbserver" instead of everything from "target_bin" to sysroot
> ---
> toolchain/toolchain-external/toolchain-external.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index c0429bb..fe709db 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -396,6 +396,10 @@ else
> TOOLCHAIN_EXTERNAL_SYNOPSYS_ENDIANESS = be
> endif
> TOOLCHAIN_EXTERNAL_SOURCE = arc_gnu_2014.12_prebuilt_uclibc_$(TOOLCHAIN_EXTERNAL_SYNOPSYS_ENDIANESS)_$(TOOLCHAIN_EXTERNAL_SYNOPSYS_CORE)_linux_install.tar.gz
> +define TOOLCHAIN_EXTERNAL_FIXUP_CMDS
> + $(Q)SYSROOT_DIR="$(call toolchain_find_sysroot,$(TOOLCHAIN_EXTERNAL_CC))" ; \
> + install -m 0755 -D $(TOOLCHAIN_EXTERNAL_INSTALL_DIR)/target-bin/gdbserver $${SYSROOT_DIR}/usr/bin/gdbserver
> +endef
> else
> # Custom toolchain
> TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] toolchain-external: fix gdbserver copying for external arc-2014.12 tools
2015-07-11 7:47 ` Romain Naour
@ 2015-07-11 8:45 ` Thomas Petazzoni
2015-07-29 13:01 ` Alexey Brodkin
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-07-11 8:45 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Sat, 11 Jul 2015 09:47:54 +0200, Romain Naour wrote:
> Le 25/03/2015 09:11, Alexey Brodkin a ?crit :
> > Historically in pre-built ARC GNU tools gdbserver is located in
> > top-level "target-bin" folder.
> >
> > Because of that fact if BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY is
> > selected Buildroot won't find gdbserver (it looks within
> > SYSROOT/ARCH_SYSROOT folder).
> >
> > Simplest solution is to use TOOLCHAIN_EXTERNAL_FIXUP_CMDS where copy
> > gdbserver from "target-bin" folder into SYSROOT/usr/bin.
>
> Since this patch, the arc 2014.12 prebuild toolchain as been marked as broken
> [1]. This patch is still needed ?
I'd say no for the moment, I'll mark the patch as Rejected for now.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] toolchain-external: fix gdbserver copying for external arc-2014.12 tools
2015-07-11 8:45 ` Thomas Petazzoni
@ 2015-07-29 13:01 ` Alexey Brodkin
0 siblings, 0 replies; 4+ messages in thread
From: Alexey Brodkin @ 2015-07-29 13:01 UTC (permalink / raw)
To: buildroot
Thomas, Romain,
On Sat, 2015-07-11 at 10:45 +0200, Thomas Petazzoni wrote:
> Dear Romain Naour,
>
> On Sat, 11 Jul 2015 09:47:54 +0200, Romain Naour wrote:
>
> > Le 25/03/2015 09:11, Alexey Brodkin a ?crit :
> > > Historically in pre-built ARC GNU tools gdbserver is located in
> > > top-level "target-bin" folder.
> > >
> > > Because of that fact if BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY is
> > > selected Buildroot won't find gdbserver (it looks within
> > > SYSROOT/ARCH_SYSROOT folder).
> > >
> > > Simplest solution is to use TOOLCHAIN_EXTERNAL_FIXUP_CMDS where copy
> > > gdbserver from "target-bin" folder into SYSROOT/usr/bin.
> >
> > Since this patch, the arc 2014.12 prebuild toolchain as been marked as broken
> > [1]. This patch is still needed ?
>
> I'd say no for the moment, I'll mark the patch as Rejected for now.
Indeed this patch is no longer required because in arc-2015.06 toolchain
we put gdbserver in proper place "sysroot/usr/bin".
-Alexey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-29 13:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 8:11 [Buildroot] [PATCH v2] toolchain-external: fix gdbserver copying for external arc-2014.12 tools Alexey Brodkin
2015-07-11 7:47 ` Romain Naour
2015-07-11 8:45 ` Thomas Petazzoni
2015-07-29 13:01 ` Alexey Brodkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.