From: Gerd Hoffmann <kraxel@redhat.com> To: Daniel Stone <daniel@fooishbar.org> Cc: virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" <mst@redhat.com>, "open list:ABI/API" <linux-api@vger.kernel.org>, Rusty Russell <rusty@rustcorp.com.au>, open list <linux-kernel@vger.kernel.org>, "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>, "open list:VIRTIO CORE, NET..." <virtualization@lists.linux-foundation.org>, Dave Airlie <airlied@redhat.com> Subject: Re: [PATCH] Add virtio gpu driver. Date: Wed, 25 Mar 2015 16:19:00 +0100 [thread overview] Message-ID: <1427296740.23304.21.camel@nilsson.home.kraxel.org> (raw) In-Reply-To: <CAPj87rN4pXHukDRD-e=ZrO1hcts04cSz1Hr9TNAgicGVWE5_-Q@mail.gmail.com> On Di, 2015-03-24 at 22:50 +0000, Daniel Stone wrote: > Hi, > > On 24 March 2015 at 16:07, Gerd Hoffmann <kraxel@redhat.com> wrote: > > +static int virtio_gpu_crtc_page_flip(struct drm_crtc *crtc, > > + struct drm_framebuffer *fb, > > + struct drm_pending_vblank_event *event, > > + uint32_t flags) > > +{ > > + return -EINVAL; > > +} > > I'm not going to lie, I was really hoping the 5th (?) GPU option for > Qemu would support pageflipping. As Dave already pointed out there is a WIP patch for that, it'll be there. While being at it: - bochsdrm (qemu -vga std driver) supports pageflip since 3.19. - cirrus is more or less a lost case, we mimic existing hardware from the 90ies here and it simply isn't up to todays needs for many reasons. Just stop using it. - qxl -- hmm, not sure, there is this "primary surface" concept in the virtual hardware design, which doesn't mix very well with pageflip I suspect. > Daniel's comment about conversion to > atomic is relevant, but: do you have a mechanism which allows you to > post updates (e.g. 'start displaying this buffer now please') that > allows you to get events back when they have actually been displayed? It's possible to fence the framebuffer update requests, so you'll be notified when the update has reached the qemu ui code. Typically the ui code has queued the update at that point. So with a local display (sdl, gtk) showing up on the screen should be just a pageflip (on the host) away. With a remote display (vnc) it will take a little longer until the user will actually see the update. cheers, Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com> To: Daniel Stone <daniel@fooishbar.org> Cc: virtio-dev@lists.oasis-open.org, "Michael S. Tsirkin" <mst@redhat.com>, "open list:ABI/API" <linux-api@vger.kernel.org>, Rusty Russell <rusty@rustcorp.com.au>, open list <linux-kernel@vger.kernel.org>, "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>, "open list:VIRTIO CORE, NET..." <virtualization@lists.linux-foundation.org>, Dave Airlie <airlied@redhat.com> Subject: Re: [PATCH] Add virtio gpu driver. Date: Wed, 25 Mar 2015 16:19:00 +0100 [thread overview] Message-ID: <1427296740.23304.21.camel@nilsson.home.kraxel.org> (raw) In-Reply-To: <CAPj87rN4pXHukDRD-e=ZrO1hcts04cSz1Hr9TNAgicGVWE5_-Q@mail.gmail.com> On Di, 2015-03-24 at 22:50 +0000, Daniel Stone wrote: > Hi, > > On 24 March 2015 at 16:07, Gerd Hoffmann <kraxel@redhat.com> wrote: > > +static int virtio_gpu_crtc_page_flip(struct drm_crtc *crtc, > > + struct drm_framebuffer *fb, > > + struct drm_pending_vblank_event *event, > > + uint32_t flags) > > +{ > > + return -EINVAL; > > +} > > I'm not going to lie, I was really hoping the 5th (?) GPU option for > Qemu would support pageflipping. As Dave already pointed out there is a WIP patch for that, it'll be there. While being at it: - bochsdrm (qemu -vga std driver) supports pageflip since 3.19. - cirrus is more or less a lost case, we mimic existing hardware from the 90ies here and it simply isn't up to todays needs for many reasons. Just stop using it. - qxl -- hmm, not sure, there is this "primary surface" concept in the virtual hardware design, which doesn't mix very well with pageflip I suspect. > Daniel's comment about conversion to > atomic is relevant, but: do you have a mechanism which allows you to > post updates (e.g. 'start displaying this buffer now please') that > allows you to get events back when they have actually been displayed? It's possible to fence the framebuffer update requests, so you'll be notified when the update has reached the qemu ui code. Typically the ui code has queued the update at that point. So with a local display (sdl, gtk) showing up on the screen should be just a pageflip (on the host) away. With a remote display (vnc) it will take a little longer until the user will actually see the update. cheers, Gerd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-03-25 15:19 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-24 16:07 [PATCH] Add virtio gpu driver Gerd Hoffmann 2015-03-24 16:07 ` Gerd Hoffmann 2015-03-24 16:15 ` Michael S. Tsirkin 2015-03-24 16:15 ` Michael S. Tsirkin 2015-03-24 16:15 ` Michael S. Tsirkin 2015-03-25 14:52 ` Gerd Hoffmann 2015-03-25 14:52 ` Gerd Hoffmann 2015-03-25 14:52 ` Gerd Hoffmann 2015-03-25 15:24 ` Michael S. Tsirkin 2015-03-25 15:24 ` Michael S. Tsirkin 2015-03-25 15:37 ` Gerd Hoffmann 2015-03-25 15:37 ` Gerd Hoffmann 2015-03-25 17:09 ` Michael S. Tsirkin 2015-03-25 17:09 ` Michael S. Tsirkin 2015-03-25 17:09 ` Michael S. Tsirkin 2015-03-26 7:12 ` Gerd Hoffmann 2015-03-26 7:12 ` Gerd Hoffmann 2015-03-26 8:18 ` Michael S. Tsirkin 2015-03-26 8:18 ` Michael S. Tsirkin 2015-03-26 8:18 ` Michael S. Tsirkin 2015-03-26 8:42 ` [virtio-dev] " Gerd Hoffmann 2015-03-26 8:42 ` Gerd Hoffmann 2015-03-26 8:42 ` Gerd Hoffmann 2015-03-26 9:04 ` Michael S. Tsirkin 2015-03-26 9:04 ` Michael S. Tsirkin 2015-03-26 11:38 ` Gerd Hoffmann 2015-03-26 11:38 ` Gerd Hoffmann 2015-03-26 11:53 ` Michael S. Tsirkin 2015-03-26 11:53 ` Michael S. Tsirkin 2015-03-26 15:07 ` Gerd Hoffmann 2015-03-26 15:07 ` Gerd Hoffmann 2015-03-26 16:47 ` Michael S. Tsirkin 2015-03-26 16:47 ` Michael S. Tsirkin 2015-03-26 22:49 ` Alex Elsayed 2015-03-27 8:08 ` Gerd Hoffmann 2015-03-27 8:08 ` Gerd Hoffmann 2015-03-27 8:08 ` Gerd Hoffmann 2015-03-26 16:47 ` Michael S. Tsirkin 2015-03-26 15:07 ` Gerd Hoffmann 2015-03-26 11:53 ` Michael S. Tsirkin 2015-03-26 16:52 ` One Thousand Gnomes 2015-03-26 16:52 ` One Thousand Gnomes 2015-03-26 11:38 ` Gerd Hoffmann 2015-03-26 9:04 ` Michael S. Tsirkin 2015-03-26 7:12 ` Gerd Hoffmann 2015-03-25 15:37 ` Gerd Hoffmann 2015-03-25 15:24 ` Michael S. Tsirkin 2015-03-24 16:50 ` Daniel Vetter 2015-03-24 16:50 ` Daniel Vetter 2015-03-24 16:50 ` Daniel Vetter 2015-03-25 14:53 ` Gerd Hoffmann 2015-03-25 14:53 ` Gerd Hoffmann 2015-03-26 8:53 ` Daniel Vetter 2015-03-26 8:53 ` Daniel Vetter 2015-03-26 8:53 ` Daniel Vetter 2015-03-30 12:23 ` Gerd Hoffmann 2015-03-30 12:23 ` Gerd Hoffmann 2015-03-30 14:49 ` Daniel Vetter 2015-03-30 14:49 ` Daniel Vetter 2015-03-30 14:49 ` Daniel Vetter 2016-05-25 16:40 ` Daniel Vetter 2016-05-25 16:40 ` Daniel Vetter 2016-05-25 16:40 ` Daniel Vetter 2016-05-25 16:44 ` Emil Velikov 2016-05-25 16:44 ` Emil Velikov 2016-05-25 16:44 ` Emil Velikov 2016-05-27 7:48 ` Gerd Hoffmann 2016-05-27 7:48 ` Gerd Hoffmann 2016-05-27 7:48 ` Gerd Hoffmann 2016-05-27 9:03 ` Daniel Vetter 2016-05-27 9:03 ` Daniel Vetter 2016-05-27 9:03 ` Daniel Vetter 2016-05-30 13:50 ` Gerd Hoffmann 2016-05-30 13:50 ` Gerd Hoffmann 2016-05-30 13:50 ` Gerd Hoffmann 2016-05-30 14:47 ` Daniel Vetter 2016-05-30 14:47 ` Daniel Vetter 2016-05-31 6:29 ` Gerd Hoffmann 2016-05-31 6:29 ` Gerd Hoffmann 2016-05-31 6:29 ` Gerd Hoffmann 2016-05-31 6:55 ` Daniel Vetter 2016-05-31 6:55 ` Daniel Vetter 2016-05-31 6:55 ` Daniel Vetter 2016-05-31 7:00 ` Pekka Paalanen 2016-05-31 7:00 ` Pekka Paalanen 2016-05-31 7:00 ` Pekka Paalanen 2016-05-30 14:47 ` Daniel Vetter 2015-03-30 12:23 ` Gerd Hoffmann 2015-03-24 17:04 ` Michael S. Tsirkin 2015-03-24 17:04 ` Michael S. Tsirkin 2015-03-24 17:04 ` Michael S. Tsirkin 2015-03-24 20:47 ` Paul Bolle 2015-03-24 20:47 ` Paul Bolle 2015-03-24 20:47 ` Paul Bolle 2015-03-24 22:50 ` Daniel Stone 2015-03-24 22:50 ` Daniel Stone 2015-03-24 22:50 ` Daniel Stone 2015-03-25 0:00 ` Dave Airlie 2015-03-25 0:00 ` Dave Airlie 2015-03-25 0:00 ` Dave Airlie 2015-03-25 5:47 ` Daniel Stone 2015-03-25 5:47 ` Daniel Stone 2015-03-25 15:19 ` Gerd Hoffmann 2015-03-25 15:19 ` Gerd Hoffmann [this message] 2015-03-25 15:19 ` Gerd Hoffmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1427296740.23304.21.camel@nilsson.home.kraxel.org \ --to=kraxel@redhat.com \ --cc=airlied@redhat.com \ --cc=daniel@fooishbar.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=rusty@rustcorp.com.au \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.