All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
@ 2015-03-25 19:28 Jacob Stiffler
  2015-03-25 19:28 ` [PATCH 2/2] packagegroup-arago-tisdk-graphics-sdk-host: Create for graphics modules Jacob Stiffler
  2015-03-25 20:58 ` [PATCH 1/2] omap3-sgx-modules: Add source to SDK Cooper Jr., Franklin
  0 siblings, 2 replies; 10+ messages in thread
From: Jacob Stiffler @ 2015-03-25 19:28 UTC (permalink / raw)
  To: meta-arago

* omap3-sgx-modules provides out-of-tree drivers which are required for
  graphics.
* These sources need to be provided so that whenever there is a kernel
  modification, the user can easily rebuild these moduels to reenable graphics.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 .../conf/distro/arago-source-ipk.conf              |    3 ++
 .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
 .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
 3 files changed, 42 insertions(+), 1 deletion(-)
 create mode 100644 meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules

diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf b/meta-arago-distro/conf/distro/arago-source-ipk.conf
index b457504..40c7058 100644
--- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
+++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
@@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
 CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
 SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
 
+CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
+SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
+
 CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
 SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
 
diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
new file mode 100644
index 0000000..2bc0ba5
--- /dev/null
+++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
@@ -0,0 +1,29 @@
+omap3-sgx-modules: linux
+	@echo =====================================
+	@echo      Building omap3-sgx-modules
+	@echo =====================================
+	@cd board-support/extra-drivers; \
+	cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
+	make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) BUILD=release TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
+
+omap3-sgx-modules_clean:
+	@echo =====================================
+	@echo      Cleaning omap3-sgx-modules
+	@echo =====================================
+	@cd board-support/extra-drivers; \
+	cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
+	make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
+
+omap3-sgx-modules_install:
+	@echo =====================================
+	@echo      Installing omap3-sgx-modules
+	@echo =====================================
+	@if [ ! -d $(DESTDIR) ] ; then \
+		echo "The extracted target filesystem directory doesn't exist."; \
+		echo "Please run setup.sh in the SDK's root directory and then try again."; \
+		exit 1; \
+	fi
+	@cd board-support/extra-drivers; \
+	cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
+	make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd` INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) modules_install
+
diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
index ffedd4c..a31bb69 100644
--- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
+++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
@@ -34,9 +34,10 @@ SRC_URI = "\
     file://Makefile_dual-camera-demo \
     file://Makefile_image-gallery \
     file://Makefile_cryptodev \
+    file://Makefile_omap3-sgx-modules \
 "
 
-PR = "r41"
+PR = "r42"
 
 MAKEFILES_COMMON = "linux \
                     matrix-gui \
@@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
                            linux-dtbs \
                            wireless \
                            cryptodev \
+                           omap3-sgx-modules \
 "
 MAKEFILES_append_ti43x = " u-boot-spl \
                            ${QUICK_PLAYGROUND} \
@@ -76,6 +78,7 @@ MAKEFILES_append_ti43x = " u-boot-spl \
                            linux-dtbs \
                            wireless \
                            cryptodev \
+                           omap3-sgx-modules \
                            dual-camera-demo \
                            image-gallery \
 "
@@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \
 PLATFORM_ARCH = "armv7-a"
 PLATFORM_ARCH_omapl138 = "armv5te"
 
+PLATFORM_SGX = ""
+PLATFORM_SGX_ti33x = "ti335x"
+PLATFORM_SGX_ti43x = "ti43xx"
+
 KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
 
 KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
@@ -150,6 +157,8 @@ do_install () {
 
     sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" ${D}/Makefile
 
+    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
+
     cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
 
     if [ "$?" == "0" ]
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] packagegroup-arago-tisdk-graphics-sdk-host: Create for graphics modules.
  2015-03-25 19:28 [PATCH 1/2] omap3-sgx-modules: Add source to SDK Jacob Stiffler
@ 2015-03-25 19:28 ` Jacob Stiffler
  2015-03-25 20:58 ` [PATCH 1/2] omap3-sgx-modules: Add source to SDK Cooper Jr., Franklin
  1 sibling, 0 replies; 10+ messages in thread
From: Jacob Stiffler @ 2015-03-25 19:28 UTC (permalink / raw)
  To: meta-arago

* Provides sources for out-of-tree graphics drivers.
* Add to arago-core-tisdk-image.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 .../recipes-core/images/arago-core-tisdk-image.inc |    1 +
 .../packagegroup-arago-tisdk-graphics-sdk-host.bb  |   16 ++++++++++++++++
 2 files changed, 17 insertions(+)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics-sdk-host.bb

diff --git a/meta-arago-distro/recipes-core/images/arago-core-tisdk-image.inc b/meta-arago-distro/recipes-core/images/arago-core-tisdk-image.inc
index 649ef97..efd45e9 100644
--- a/meta-arago-distro/recipes-core/images/arago-core-tisdk-image.inc
+++ b/meta-arago-distro/recipes-core/images/arago-core-tisdk-image.inc
@@ -44,6 +44,7 @@ IMAGE_INSTALL = "\
     packagegroup-arago-tisdk-addons-sdk-host \
     packagegroup-arago-tisdk-connectivity-sdk-host \
     packagegroup-arago-tisdk-crypto-sdk-host \
+    packagegroup-arago-tisdk-graphics-sdk-host \
     packagegroup-arago-tisdk-matrix-sdk-host \
     packagegroup-arago-tisdk-multimedia-sdk-host \
     packagegroup-arago-tisdk-amsdk-sdk-host \
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics-sdk-host.bb
new file mode 100644
index 0000000..1ea3cf6
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-graphics-sdk-host.bb
@@ -0,0 +1,16 @@
+DESCRIPTION = "Task to install graphics sources in SDK"
+LICENSE = "MIT"
+PR = "r0"
+
+inherit packagegroup
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+GRAPHICS_RDEPENDS = ""
+
+GRAPHICS_RDEPENDS_append_ti33x = " omap3-sgx-modules-src"
+GRAPHICS_RDEPENDS_append_ti43x = " omap3-sgx-modules-src"
+
+RDEPENDS_${PN} = "\
+    ${GRAPHICS_RDEPENDS} \
+"
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-25 19:28 [PATCH 1/2] omap3-sgx-modules: Add source to SDK Jacob Stiffler
  2015-03-25 19:28 ` [PATCH 2/2] packagegroup-arago-tisdk-graphics-sdk-host: Create for graphics modules Jacob Stiffler
@ 2015-03-25 20:58 ` Cooper Jr., Franklin
  2015-03-25 21:02   ` Cooper Jr., Franklin
  1 sibling, 1 reply; 10+ messages in thread
From: Cooper Jr., Franklin @ 2015-03-25 20:58 UTC (permalink / raw)
  To: Stiffler, Jacob; +Cc: meta-arago

Overall this needs more testing. additional comments below

> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> * omap3-sgx-modules provides out-of-tree drivers which are required for
>  graphics.
> * These sources need to be provided so that whenever there is a kernel
>  modification, the user can easily rebuild these moduels to reenable graphics.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> .../conf/distro/arago-source-ipk.conf              |    3 ++
> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
> 3 files changed, 42 insertions(+), 1 deletion(-)
> create mode 100644 meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
> 
> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf b/meta-arago-distro/conf/distro/arago-source-ipk.conf
> index b457504..40c7058 100644
> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
> 
> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
> +
We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.

Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.

You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.

> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
> 
> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
> new file mode 100644
> index 0000000..2bc0ba5
> --- /dev/null
> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
> @@ -0,0 +1,29 @@
> +omap3-sgx-modules: linux
> +    @echo =====================================
> +    @echo      Building omap3-sgx-modules
> +    @echo =====================================
> +    @cd board-support/extra-drivers; \
> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) BUILD=release TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.

So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
> +
> +omap3-sgx-modules_clean:
> +    @echo =====================================
> +    @echo      Cleaning omap3-sgx-modules
> +    @echo =====================================
> +    @cd board-support/extra-drivers; \
> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
> +
> +omap3-sgx-modules_install:
> +    @echo =====================================
> +    @echo      Installing omap3-sgx-modules
> +    @echo =====================================
> +    @if [ ! -d $(DESTDIR) ] ; then \
> +        echo "The extracted target filesystem directory doesn't exist."; \
> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
> +        exit 1; \
> +    fi
> +    @cd board-support/extra-drivers; \
> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd` INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) modules_install
This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.

So you will end with two versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.

So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
> +
> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
> index ffedd4c..a31bb69 100644
> --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
> @@ -34,9 +34,10 @@ SRC_URI = "\
>     file://Makefile_dual-camera-demo \
>     file://Makefile_image-gallery \
>     file://Makefile_cryptodev \
> +    file://Makefile_omap3-sgx-modules \
> "
> 
> -PR = "r41"
> +PR = "r42"
> 
> MAKEFILES_COMMON = "linux \
>                     matrix-gui \
> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>                            linux-dtbs \
>                            wireless \
>                            cryptodev \
> +                           omap3-sgx-modules \
> "
> MAKEFILES_append_ti43x = " u-boot-spl \
>                            ${QUICK_PLAYGROUND} \
> @@ -76,6 +78,7 @@ MAKEFILES_append_ti43x = " u-boot-spl \
>                            linux-dtbs \
>                            wireless \
>                            cryptodev \
> +                           omap3-sgx-modules \
>                            dual-camera-demo \
>                            image-gallery \
> "
> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \
> PLATFORM_ARCH = "armv7-a"
> PLATFORM_ARCH_omapl138 = "armv5te"
> 
> +PLATFORM_SGX = ""
> +PLATFORM_SGX_ti33x = "ti335x"
> +PLATFORM_SGX_ti43x = "ti43xx"
> +
> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
> 
> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
> @@ -150,6 +157,8 @@ do_install () {
> 
>     sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" ${D}/Makefile
> 
> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
> +
>     cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
> 
>     if [ "$?" == "0" ]
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-25 20:58 ` [PATCH 1/2] omap3-sgx-modules: Add source to SDK Cooper Jr., Franklin
@ 2015-03-25 21:02   ` Cooper Jr., Franklin
  2015-03-26 11:15     ` Stiffler, Jacob
  0 siblings, 1 reply; 10+ messages in thread
From: Cooper Jr., Franklin @ 2015-03-25 21:02 UTC (permalink / raw)
  To: Stiffler, Jacob; +Cc: meta-arago




> On Mar 25, 2015, at 3:58 PM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
> 
> Overall this needs more testing. additional comments below
> 
>> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>> 
>> * omap3-sgx-modules provides out-of-tree drivers which are required for
>> graphics.
>> * These sources need to be provided so that whenever there is a kernel
>> modification, the user can easily rebuild these moduels to reenable graphics.
>> 
>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>> ---
>> .../conf/distro/arago-source-ipk.conf              |    3 ++
>> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
>> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
>> 3 files changed, 42 insertions(+), 1 deletion(-)
>> create mode 100644 meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
>> 
>> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>> index b457504..40c7058 100644
>> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
>> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
>> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
>> 
>> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
>> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
>> +
> We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.
> 
> Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.
> 
> You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.
> 
>> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
>> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
>> 
>> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
>> new file mode 100644
>> index 0000000..2bc0ba5
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_omap3-sgx-modules
>> @@ -0,0 +1,29 @@
>> +omap3-sgx-modules: linux
>> +    @echo =====================================
>> +    @echo      Building omap3-sgx-modules
>> +    @echo =====================================
>> +    @cd board-support/extra-drivers; \
>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) BUILD=release TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
> Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.
> 
> So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
>> +
>> +omap3-sgx-modules_clean:
>> +    @echo =====================================
>> +    @echo      Cleaning omap3-sgx-modules
>> +    @echo =====================================
>> +    @cd board-support/extra-drivers; \
>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
>> +
>> +omap3-sgx-modules_install:
>> +    @echo =====================================
>> +    @echo      Installing omap3-sgx-modules
>> +    @echo =====================================
>> +    @if [ ! -d $(DESTDIR) ] ; then \
>> +        echo "The extracted target filesystem directory doesn't exist."; \
>> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
>> +        exit 1; \
>> +    fi
>> +    @cd board-support/extra-drivers; \
>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd` INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) modules_install
> This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.
Typing from my phone. *reasons I never liked 
> So you will end with two versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.
> 
> So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
*built and installs things
>> +
>> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
>> index ffedd4c..a31bb69 100644
>> --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb
>> @@ -34,9 +34,10 @@ SRC_URI = "\
>>    file://Makefile_dual-camera-demo \
>>    file://Makefile_image-gallery \
>>    file://Makefile_cryptodev \
>> +    file://Makefile_omap3-sgx-modules \
>> "
>> 
>> -PR = "r41"
>> +PR = "r42"
>> 
>> MAKEFILES_COMMON = "linux \
>>                    matrix-gui \
>> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>>                           linux-dtbs \
>>                           wireless \
>>                           cryptodev \
>> +                           omap3-sgx-modules \
>> "
>> MAKEFILES_append_ti43x = " u-boot-spl \
>>                           ${QUICK_PLAYGROUND} \
>> @@ -76,6 +78,7 @@ MAKEFILES_append_ti43x = " u-boot-spl \
>>                           linux-dtbs \
>>                           wireless \
>>                           cryptodev \
>> +                           omap3-sgx-modules \
>>                           dual-camera-demo \
>>                           image-gallery \
>> "
>> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \
>> PLATFORM_ARCH = "armv7-a"
>> PLATFORM_ARCH_omapl138 = "armv5te"
>> 
>> +PLATFORM_SGX = ""
>> +PLATFORM_SGX_ti33x = "ti335x"
>> +PLATFORM_SGX_ti43x = "ti43xx"
>> +
>> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
>> 
>> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
>> @@ -150,6 +157,8 @@ do_install () {
>> 
>>    sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" ${D}/Makefile
>> 
>> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
>> +
>>    cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
>> 
>>    if [ "$?" == "0" ]
>> -- 
>> 1.7.9.5
>> 
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-25 21:02   ` Cooper Jr., Franklin
@ 2015-03-26 11:15     ` Stiffler, Jacob
  2015-03-26 13:39       ` Cooper Jr., Franklin
  0 siblings, 1 reply; 10+ messages in thread
From: Stiffler, Jacob @ 2015-03-26 11:15 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

I have tested this patch locally and in our nightly builds. 

See my response to your comments below.

-----Original Message-----
From: Cooper Jr., Franklin 
Sent: Wednesday, March 25, 2015 5:02 PM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.




> On Mar 25, 2015, at 3:58 PM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
> 
> Overall this needs more testing. additional comments below
> 
>> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>> 
>> * omap3-sgx-modules provides out-of-tree drivers which are required 
>> for graphics.
>> * These sources need to be provided so that whenever there is a 
>> kernel modification, the user can easily rebuild these moduels to reenable graphics.
>> 
>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>> ---
>> .../conf/distro/arago-source-ipk.conf              |    3 ++
>> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
>> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
>> 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 
>> meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/M
>> akefile_omap3-sgx-modules
>> 
>> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf 
>> b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>> index b457504..40c7058 100644
>> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
>> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
>> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
>> 
>> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
>> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
>> +
> We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.
What would you suggest?
> 
> Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.
> 
> You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.
This is only the module source, as specified in the recipe: 
TI_BIN_UNPK_WDEXT="/Graphics_SDK_${SGXPV}"
S = "${WORKDIR}${TI_BIN_UNPK_WDEXT}/GFX_Linux_KM"
> 
>> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
>> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
>> 
>> diff --git 
>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>> /Makefile_omap3-sgx-modules 
>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>> /Makefile_omap3-sgx-modules
>> new file mode 100644
>> index 0000000..2bc0ba5
>> --- /dev/null
>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-make
>> +++ file/Makefile_omap3-sgx-modules
>> @@ -0,0 +1,29 @@
>> +omap3-sgx-modules: linux
>> +    @echo =====================================
>> +    @echo      Building omap3-sgx-modules
>> +    @echo =====================================
>> +    @cd board-support/extra-drivers; \
>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) BUILD=release 
>> +TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
> Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.
I got the make options directly from the recipe.
> 
> So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
How do you  test this?
>> +
>> +omap3-sgx-modules_clean:
>> +    @echo =====================================
>> +    @echo      Cleaning omap3-sgx-modules
>> +    @echo =====================================
>> +    @cd board-support/extra-drivers; \
>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
>> +
>> +omap3-sgx-modules_install:
>> +    @echo =====================================
>> +    @echo      Installing omap3-sgx-modules
>> +    @echo =====================================
>> +    @if [ ! -d $(DESTDIR) ] ; then \
>> +        echo "The extracted target filesystem directory doesn't exist."; \
>> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
>> +        exit 1; \
>> +    fi
>> +    @cd board-support/extra-drivers; \
>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd` 
>> +INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) 
>> +modules_install
> This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.
> Typing from my phone. *reasons I never liked 
> So you will end with two versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.
> 
> So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
> *built and installs things
It seems that the recipe tries to fake that these modules are not out-of-tree, and I guess yocto can hide this by updating the necessary /lib/modules/<k_ver>/modules.* files. Without installing it like this, then the modules cannot be found by "modprobe".
>> +
>> diff --git 
>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>> _1.0.bb 
>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>> _1.0.bb
>> index ffedd4c..a31bb69 100644
>> --- 
>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>> _1.0.bb
>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-make
>> +++ file_1.0.bb
>> @@ -34,9 +34,10 @@ SRC_URI = "\
>>    file://Makefile_dual-camera-demo \
>>    file://Makefile_image-gallery \
>>    file://Makefile_cryptodev \
>> +    file://Makefile_omap3-sgx-modules \
>> "
>> 
>> -PR = "r41"
>> +PR = "r42"
>> 
>> MAKEFILES_COMMON = "linux \
>>                    matrix-gui \
>> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>>                           linux-dtbs \
>>                           wireless \
>>                           cryptodev \
>> +                           omap3-sgx-modules \
>> "
>> MAKEFILES_append_ti43x = " u-boot-spl \
>>                           ${QUICK_PLAYGROUND} \ @@ -76,6 +78,7 @@ 
>> MAKEFILES_append_ti43x = " u-boot-spl \
>>                           linux-dtbs \
>>                           wireless \
>>                           cryptodev \
>> +                           omap3-sgx-modules \
>>                           dual-camera-demo \
>>                           image-gallery \ "
>> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \ 
>> PLATFORM_ARCH = "armv7-a"
>> PLATFORM_ARCH_omapl138 = "armv5te"
>> 
>> +PLATFORM_SGX = ""
>> +PLATFORM_SGX_ti33x = "ti335x"
>> +PLATFORM_SGX_ti43x = "ti43xx"
>> +
>> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
>> 
>> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
>> @@ -150,6 +157,8 @@ do_install () {
>> 
>>    sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" 
>> ${D}/Makefile
>> 
>> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
>> +
>>    cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
>> 
>>    if [ "$?" == "0" ]
>> --
>> 1.7.9.5
>> 
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-26 11:15     ` Stiffler, Jacob
@ 2015-03-26 13:39       ` Cooper Jr., Franklin
  2015-03-27 12:30         ` Stiffler, Jacob
  0 siblings, 1 reply; 10+ messages in thread
From: Cooper Jr., Franklin @ 2015-03-26 13:39 UTC (permalink / raw)
  To: Stiffler, Jacob; +Cc: meta-arago

From another email I saw are you saying that a user needs to run clean and then compile and install via the top level makefile?

Something isn't right since ANY sources included in the SDK board support shouldn't have anything prebuilt. They should be clean sources that simply needs to be compiled by the user 

more below


> On Mar 26, 2015, at 6:15 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> I have tested this patch locally and in our nightly builds. 
> 
> See my response to your comments below.
> 
> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Wednesday, March 25, 2015 5:02 PM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
> 
> 
> 
> 
>> On Mar 25, 2015, at 3:58 PM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
>> 
>> Overall this needs more testing. additional comments below
>> 
>>> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>>> 
>>> * omap3-sgx-modules provides out-of-tree drivers which are required 
>>> for graphics.
>>> * These sources need to be provided so that whenever there is a 
>>> kernel modification, the user can easily rebuild these moduels to reenable graphics.
>>> 
>>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>>> ---
>>> .../conf/distro/arago-source-ipk.conf              |    3 ++
>>> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
>>> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
>>> 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 
>>> meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/M
>>> akefile_omap3-sgx-modules
>>> 
>>> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf 
>>> b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>> index b457504..40c7058 100644
>>> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
>>> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
>>> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
>>> 
>>> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
>>> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
>>> +
>> We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.
> What would you suggest?
Idk naming it in a way people will recognize wat it is and wat it is for.
>> 
>> Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.
>> 
>> You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.
> This is only the module source, as specified in the recipe: 
> TI_BIN_UNPK_WDEXT="/Graphics_SDK_${SGXPV}"
> S = "${WORKDIR}${TI_BIN_UNPK_WDEXT}/GFX_Linux_KM"
Can u do a grep and confirm no paths are included?
>> 
>>> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
>>> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
>>> 
>>> diff --git 
>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>>> /Makefile_omap3-sgx-modules 
>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>>> /Makefile_omap3-sgx-modules
>>> new file mode 100644
>>> index 0000000..2bc0ba5
>>> --- /dev/null
>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-make
>>> +++ file/Makefile_omap3-sgx-modules
>>> @@ -0,0 +1,29 @@
>>> +omap3-sgx-modules: linux
>>> +    @echo =====================================
>>> +    @echo      Building omap3-sgx-modules
>>> +    @echo =====================================
>>> +    @cd board-support/extra-drivers; \
>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) BUILD=release 
>>> +TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
>> Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.
> I got the make options directly from the recipe.
>> 
>> So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
> How do you  test this?
http://processors.wiki.ti.com/index.php/Linux_Core_Power_Management_User%27s_Guide#Suspend.2FResume
>>> +
>>> +omap3-sgx-modules_clean:
>>> +    @echo =====================================
>>> +    @echo      Cleaning omap3-sgx-modules
>>> +    @echo =====================================
>>> +    @cd board-support/extra-drivers; \
>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
>>> +
>>> +omap3-sgx-modules_install:
>>> +    @echo =====================================
>>> +    @echo      Installing omap3-sgx-modules
>>> +    @echo =====================================
>>> +    @if [ ! -d $(DESTDIR) ] ; then \
>>> +        echo "The extracted target filesystem directory doesn't exist."; \
>>> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
>>> +        exit 1; \
>>> +    fi
>>> +    @cd board-support/extra-drivers; \
>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd` 
>>> +INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) 
>>> +modules_install
>> This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.
>> Typing from my phone. *reasons I never liked 
>> So you will end with two versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.
>> 
>> So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
>> *built and installs things
> It seems that the recipe tries to fake that these modules are not out-of-tree, and I guess yocto can hide this by updating the necessary /lib/modules/<k_ver>/modules.* files. Without installing it like this, then the modules cannot be found by "modprobe".
If this is the case then how did this work for u?
Did you try modifying the kernel and using the rebuilt kernel and modules to verify that this works.
>>> +
>>> diff --git 
>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>>> _1.0.bb 
>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>>> _1.0.bb
>>> index ffedd4c..a31bb69 100644
>>> --- 
>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>>> _1.0.bb
>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-make
>>> +++ file_1.0.bb
>>> @@ -34,9 +34,10 @@ SRC_URI = "\
>>>   file://Makefile_dual-camera-demo \
>>>   file://Makefile_image-gallery \
>>>   file://Makefile_cryptodev \
>>> +    file://Makefile_omap3-sgx-modules \
>>> "
>>> 
>>> -PR = "r41"
>>> +PR = "r42"
>>> 
>>> MAKEFILES_COMMON = "linux \
>>>                   matrix-gui \
>>> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>>>                          linux-dtbs \
>>>                          wireless \
>>>                          cryptodev \
>>> +                           omap3-sgx-modules \
>>> "
>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>                          ${QUICK_PLAYGROUND} \ @@ -76,6 +78,7 @@ 
>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>                          linux-dtbs \
>>>                          wireless \
>>>                          cryptodev \
>>> +                           omap3-sgx-modules \
>>>                          dual-camera-demo \
>>>                          image-gallery \ "
>>> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \ 
>>> PLATFORM_ARCH = "armv7-a"
>>> PLATFORM_ARCH_omapl138 = "armv5te"
>>> 
>>> +PLATFORM_SGX = ""
>>> +PLATFORM_SGX_ti33x = "ti335x"
>>> +PLATFORM_SGX_ti43x = "ti43xx"
>>> +
>>> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
>>> 
>>> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
>>> @@ -150,6 +157,8 @@ do_install () {
>>> 
>>>   sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" 
>>> ${D}/Makefile
>>> 
>>> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
>>> +
>>>   cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
>>> 
>>>   if [ "$?" == "0" ]
>>> --
>>> 1.7.9.5
>>> 
>>> _______________________________________________
>>> meta-arago mailing list
>>> meta-arago@arago-project.org
>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-26 13:39       ` Cooper Jr., Franklin
@ 2015-03-27 12:30         ` Stiffler, Jacob
  2015-03-27 12:49           ` Cooper Jr., Franklin
  0 siblings, 1 reply; 10+ messages in thread
From: Stiffler, Jacob @ 2015-03-27 12:30 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

1) I checked, no prebuilt binaries are provided, and the clean is unnecessary. 
2) No build system paths are included.
3) suspend and resume were functional while running the sgx 3D demos.
4) The kernel is automatically built with a different version due to the creation of a sdk branch in the git repo.


-----Original Message-----
From: Cooper Jr., Franklin 
Sent: Thursday, March 26, 2015 9:40 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.

From another email I saw are you saying that a user needs to run clean and then compile and install via the top level makefile?

Something isn't right since ANY sources included in the SDK board support shouldn't have anything prebuilt. They should be clean sources that simply needs to be compiled by the user 

more below


> On Mar 26, 2015, at 6:15 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> I have tested this patch locally and in our nightly builds. 
> 
> See my response to your comments below.
> 
> -----Original Message-----
> From: Cooper Jr., Franklin
> Sent: Wednesday, March 25, 2015 5:02 PM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
> 
> 
> 
> 
>> On Mar 25, 2015, at 3:58 PM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
>> 
>> Overall this needs more testing. additional comments below
>> 
>>> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>>> 
>>> * omap3-sgx-modules provides out-of-tree drivers which are required 
>>> for graphics.
>>> * These sources need to be provided so that whenever there is a 
>>> kernel modification, the user can easily rebuild these moduels to reenable graphics.
>>> 
>>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>>> ---
>>> .../conf/distro/arago-source-ipk.conf              |    3 ++
>>> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
>>> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
>>> 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 
>>> meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/
>>> M
>>> akefile_omap3-sgx-modules
>>> 
>>> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>> b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>> index b457504..40c7058 100644
>>> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
>>> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
>>> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
>>> 
>>> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
>>> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
>>> +
>> We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.
> What would you suggest?
Idk naming it in a way people will recognize wat it is and wat it is for.
>> 
>> Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.
>> 
>> You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.
> This is only the module source, as specified in the recipe: 
> TI_BIN_UNPK_WDEXT="/Graphics_SDK_${SGXPV}"
> S = "${WORKDIR}${TI_BIN_UNPK_WDEXT}/GFX_Linux_KM"
Can u do a grep and confirm no paths are included?
>> 
>>> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
>>> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
>>> 
>>> diff --git
>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>> e
>>> /Makefile_omap3-sgx-modules
>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>> e
>>> /Makefile_omap3-sgx-modules
>>> new file mode 100644
>>> index 0000000..2bc0ba5
>>> --- /dev/null
>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-mak
>>> +++ e
>>> +++ file/Makefile_omap3-sgx-modules
>>> @@ -0,0 +1,29 @@
>>> +omap3-sgx-modules: linux
>>> +    @echo =====================================
>>> +    @echo      Building omap3-sgx-modules
>>> +    @echo =====================================
>>> +    @cd board-support/extra-drivers; \
>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) 
>>> +BUILD=release TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
>> Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.
> I got the make options directly from the recipe.
>> 
>> So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
> How do you  test this?
http://processors.wiki.ti.com/index.php/Linux_Core_Power_Management_User%27s_Guide#Suspend.2FResume
>>> +
>>> +omap3-sgx-modules_clean:
>>> +    @echo =====================================
>>> +    @echo      Cleaning omap3-sgx-modules
>>> +    @echo =====================================
>>> +    @cd board-support/extra-drivers; \
>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
>>> +
>>> +omap3-sgx-modules_install:
>>> +    @echo =====================================
>>> +    @echo      Installing omap3-sgx-modules
>>> +    @echo =====================================
>>> +    @if [ ! -d $(DESTDIR) ] ; then \
>>> +        echo "The extracted target filesystem directory doesn't exist."; \
>>> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
>>> +        exit 1; \
>>> +    fi
>>> +    @cd board-support/extra-drivers; \
>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd`
>>> +INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) 
>>> +modules_install
>> This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.
>> Typing from my phone. *reasons I never liked So you will end with two 
>> versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.
>> 
>> So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
>> *built and installs things
> It seems that the recipe tries to fake that these modules are not out-of-tree, and I guess yocto can hide this by updating the necessary /lib/modules/<k_ver>/modules.* files. Without installing it like this, then the modules cannot be found by "modprobe".
If this is the case then how did this work for u?
Did you try modifying the kernel and using the rebuilt kernel and modules to verify that this works.
>>> +
>>> diff --git
>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>> e
>>> _1.0.bb
>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>> e
>>> _1.0.bb
>>> index ffedd4c..a31bb69 100644
>>> ---
>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>> e
>>> _1.0.bb
>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-mak
>>> +++ e
>>> +++ file_1.0.bb
>>> @@ -34,9 +34,10 @@ SRC_URI = "\
>>>   file://Makefile_dual-camera-demo \
>>>   file://Makefile_image-gallery \
>>>   file://Makefile_cryptodev \
>>> +    file://Makefile_omap3-sgx-modules \
>>> "
>>> 
>>> -PR = "r41"
>>> +PR = "r42"
>>> 
>>> MAKEFILES_COMMON = "linux \
>>>                   matrix-gui \
>>> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>>>                          linux-dtbs \
>>>                          wireless \
>>>                          cryptodev \
>>> +                           omap3-sgx-modules \
>>> "
>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>                          ${QUICK_PLAYGROUND} \ @@ -76,6 +78,7 @@ 
>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>                          linux-dtbs \
>>>                          wireless \
>>>                          cryptodev \
>>> +                           omap3-sgx-modules \
>>>                          dual-camera-demo \
>>>                          image-gallery \ "
>>> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \ 
>>> PLATFORM_ARCH = "armv7-a"
>>> PLATFORM_ARCH_omapl138 = "armv5te"
>>> 
>>> +PLATFORM_SGX = ""
>>> +PLATFORM_SGX_ti33x = "ti335x"
>>> +PLATFORM_SGX_ti43x = "ti43xx"
>>> +
>>> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
>>> 
>>> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
>>> @@ -150,6 +157,8 @@ do_install () {
>>> 
>>>   sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" 
>>> ${D}/Makefile
>>> 
>>> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
>>> +
>>>   cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
>>> 
>>>   if [ "$?" == "0" ]
>>> --
>>> 1.7.9.5
>>> 
>>> _______________________________________________
>>> meta-arago mailing list
>>> meta-arago@arago-project.org
>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-27 12:30         ` Stiffler, Jacob
@ 2015-03-27 12:49           ` Cooper Jr., Franklin
  2015-03-27 13:15             ` Stiffler, Jacob
  0 siblings, 1 reply; 10+ messages in thread
From: Cooper Jr., Franklin @ 2015-03-27 12:49 UTC (permalink / raw)
  To: Stiffler, Jacob; +Cc: meta-arago




> On Mar 27, 2015, at 7:30 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> 1) I checked, no prebuilt binaries are provided, and the clean is unnecessary. 
> 2) No build system paths are included.
> 3) suspend and resume were functional while running the sgx 3D demos.
> 4) The kernel is automatically built with a different version due to the creation of a sdk branch in the git repo.
> 
Awesome. Just renaming the directory containing the modules is all think that's left. It's the same reason why sitara-linux-ti-staging and linux-ti-staging recipes are simply set to linux-${PV}
> 
> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Thursday, March 26, 2015 9:40 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
> 
> From another email I saw are you saying that a user needs to run clean and then compile and install via the top level makefile?
> 
> Something isn't right since ANY sources included in the SDK board support shouldn't have anything prebuilt. They should be clean sources that simply needs to be compiled by the user 
> 
> more below
> 
> 
>> On Mar 26, 2015, at 6:15 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>> 
>> I have tested this patch locally and in our nightly builds. 
>> 
>> See my response to your comments below.
>> 
>> -----Original Message-----
>> From: Cooper Jr., Franklin
>> Sent: Wednesday, March 25, 2015 5:02 PM
>> To: Stiffler, Jacob
>> Cc: meta-arago@arago-project.org
>> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
>> 
>> 
>> 
>> 
>>> On Mar 25, 2015, at 3:58 PM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
>>> 
>>> Overall this needs more testing. additional comments below
>>> 
>>>> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>>>> 
>>>> * omap3-sgx-modules provides out-of-tree drivers which are required 
>>>> for graphics.
>>>> * These sources need to be provided so that whenever there is a 
>>>> kernel modification, the user can easily rebuild these moduels to reenable graphics.
>>>> 
>>>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>>>> ---
>>>> .../conf/distro/arago-source-ipk.conf              |    3 ++
>>>> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
>>>> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
>>>> 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 
>>>> meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/
>>>> M
>>>> akefile_omap3-sgx-modules
>>>> 
>>>> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> index b457504..40c7058 100644
>>>> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
>>>> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
>>>> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
>>>> 
>>>> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
>>>> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
>>>> +
>>> We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.
>> What would you suggest?
> Idk naming it in a way people will recognize wat it is and wat it is for.
>>> 
>>> Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.
>>> 
>>> You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.
>> This is only the module source, as specified in the recipe: 
>> TI_BIN_UNPK_WDEXT="/Graphics_SDK_${SGXPV}"
>> S = "${WORKDIR}${TI_BIN_UNPK_WDEXT}/GFX_Linux_KM"
> Can u do a grep and confirm no paths are included?
>>> 
>>>> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
>>>> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
>>>> 
>>>> diff --git
>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>>> e
>>>> /Makefile_omap3-sgx-modules
>>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>>> e
>>>> /Makefile_omap3-sgx-modules
>>>> new file mode 100644
>>>> index 0000000..2bc0ba5
>>>> --- /dev/null
>>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-mak
>>>> +++ e
>>>> +++ file/Makefile_omap3-sgx-modules
>>>> @@ -0,0 +1,29 @@
>>>> +omap3-sgx-modules: linux
>>>> +    @echo =====================================
>>>> +    @echo      Building omap3-sgx-modules
>>>> +    @echo =====================================
>>>> +    @cd board-support/extra-drivers; \
>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) 
>>>> +BUILD=release TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
>>> Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.
>> I got the make options directly from the recipe.
>>> 
>>> So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
>> How do you  test this?
> http://processors.wiki.ti.com/index.php/Linux_Core_Power_Management_User%27s_Guide#Suspend.2FResume
>>>> +
>>>> +omap3-sgx-modules_clean:
>>>> +    @echo =====================================
>>>> +    @echo      Cleaning omap3-sgx-modules
>>>> +    @echo =====================================
>>>> +    @cd board-support/extra-drivers; \
>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
>>>> +
>>>> +omap3-sgx-modules_install:
>>>> +    @echo =====================================
>>>> +    @echo      Installing omap3-sgx-modules
>>>> +    @echo =====================================
>>>> +    @if [ ! -d $(DESTDIR) ] ; then \
>>>> +        echo "The extracted target filesystem directory doesn't exist."; \
>>>> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
>>>> +        exit 1; \
>>>> +    fi
>>>> +    @cd board-support/extra-drivers; \
>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd`
>>>> +INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) 
>>>> +modules_install
>>> This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.
>>> Typing from my phone. *reasons I never liked So you will end with two 
>>> versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.
>>> 
>>> So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
>>> *built and installs things
>> It seems that the recipe tries to fake that these modules are not out-of-tree, and I guess yocto can hide this by updating the necessary /lib/modules/<k_ver>/modules.* files. Without installing it like this, then the modules cannot be found by "modprobe".
> If this is the case then how did this work for u?
> Did you try modifying the kernel and using the rebuilt kernel and modules to verify that this works.
>>>> +
>>>> diff --git
>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>>> e
>>>> _1.0.bb
>>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>>> e
>>>> _1.0.bb
>>>> index ffedd4c..a31bb69 100644
>>>> ---
>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefil
>>>> e
>>>> _1.0.bb
>>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-mak
>>>> +++ e
>>>> +++ file_1.0.bb
>>>> @@ -34,9 +34,10 @@ SRC_URI = "\
>>>>  file://Makefile_dual-camera-demo \
>>>>  file://Makefile_image-gallery \
>>>>  file://Makefile_cryptodev \
>>>> +    file://Makefile_omap3-sgx-modules \
>>>> "
>>>> 
>>>> -PR = "r41"
>>>> +PR = "r42"
>>>> 
>>>> MAKEFILES_COMMON = "linux \
>>>>                  matrix-gui \
>>>> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>>>>                         linux-dtbs \
>>>>                         wireless \
>>>>                         cryptodev \
>>>> +                           omap3-sgx-modules \
>>>> "
>>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>>                         ${QUICK_PLAYGROUND} \ @@ -76,6 +78,7 @@ 
>>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>>                         linux-dtbs \
>>>>                         wireless \
>>>>                         cryptodev \
>>>> +                           omap3-sgx-modules \
>>>>                         dual-camera-demo \
>>>>                         image-gallery \ "
>>>> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \ 
>>>> PLATFORM_ARCH = "armv7-a"
>>>> PLATFORM_ARCH_omapl138 = "armv5te"
>>>> 
>>>> +PLATFORM_SGX = ""
>>>> +PLATFORM_SGX_ti33x = "ti335x"
>>>> +PLATFORM_SGX_ti43x = "ti43xx"
>>>> +
>>>> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
>>>> 
>>>> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
>>>> @@ -150,6 +157,8 @@ do_install () {
>>>> 
>>>>  sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" 
>>>> ${D}/Makefile
>>>> 
>>>> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
>>>> +
>>>>  cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
>>>> 
>>>>  if [ "$?" == "0" ]
>>>> --
>>>> 1.7.9.5
>>>> 
>>>> _______________________________________________
>>>> meta-arago mailing list
>>>> meta-arago@arago-project.org
>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>>> _______________________________________________
>>> meta-arago mailing list
>>> meta-arago@arago-project.org
>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-27 12:49           ` Cooper Jr., Franklin
@ 2015-03-27 13:15             ` Stiffler, Jacob
  2015-03-27 13:30               ` Cooper Jr., Franklin
  0 siblings, 1 reply; 10+ messages in thread
From: Stiffler, Jacob @ 2015-03-27 13:15 UTC (permalink / raw)
  To: Cooper Jr., Franklin; +Cc: meta-arago

Before I resubmit this patch, what is your opinion on using "sgx-modules-${PV}" for the directory name nad "sgx-modules" for the Makefile target?

Also, I am currently testing changing the recipe installation to match the makefile, and will prepend this to the patch set once I have verified the change.

Thanks,
Jake 



-----Original Message-----
From: Cooper Jr., Franklin 
Sent: Friday, March 27, 2015 8:49 AM
To: Stiffler, Jacob
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.




> On Mar 27, 2015, at 7:30 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> 1) I checked, no prebuilt binaries are provided, and the clean is unnecessary. 
> 2) No build system paths are included.
> 3) suspend and resume were functional while running the sgx 3D demos.
> 4) The kernel is automatically built with a different version due to the creation of a sdk branch in the git repo.
> 
Awesome. Just renaming the directory containing the modules is all think that's left. It's the same reason why sitara-linux-ti-staging and linux-ti-staging recipes are simply set to linux-${PV}
> 
> -----Original Message-----
> From: Cooper Jr., Franklin
> Sent: Thursday, March 26, 2015 9:40 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
> 
> From another email I saw are you saying that a user needs to run clean and then compile and install via the top level makefile?
> 
> Something isn't right since ANY sources included in the SDK board 
> support shouldn't have anything prebuilt. They should be clean sources 
> that simply needs to be compiled by the user
> 
> more below
> 
> 
>> On Mar 26, 2015, at 6:15 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>> 
>> I have tested this patch locally and in our nightly builds. 
>> 
>> See my response to your comments below.
>> 
>> -----Original Message-----
>> From: Cooper Jr., Franklin
>> Sent: Wednesday, March 25, 2015 5:02 PM
>> To: Stiffler, Jacob
>> Cc: meta-arago@arago-project.org
>> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
>> 
>> 
>> 
>> 
>>> On Mar 25, 2015, at 3:58 PM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
>>> 
>>> Overall this needs more testing. additional comments below
>>> 
>>>> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>>>> 
>>>> * omap3-sgx-modules provides out-of-tree drivers which are required 
>>>> for graphics.
>>>> * These sources need to be provided so that whenever there is a 
>>>> kernel modification, the user can easily rebuild these moduels to reenable graphics.
>>>> 
>>>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>>>> ---
>>>> .../conf/distro/arago-source-ipk.conf              |    3 ++
>>>> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
>>>> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
>>>> 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 
>>>> meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>>>> /
>>>> M
>>>> akefile_omap3-sgx-modules
>>>> 
>>>> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> index b457504..40c7058 100644
>>>> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
>>>> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
>>>> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
>>>> 
>>>> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
>>>> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
>>>> +
>>> We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.
>> What would you suggest?
> Idk naming it in a way people will recognize wat it is and wat it is for.
>>> 
>>> Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.
>>> 
>>> You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.
>> This is only the module source, as specified in the recipe: 
>> TI_BIN_UNPK_WDEXT="/Graphics_SDK_${SGXPV}"
>> S = "${WORKDIR}${TI_BIN_UNPK_WDEXT}/GFX_Linux_KM"
> Can u do a grep and confirm no paths are included?
>>> 
>>>> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
>>>> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
>>>> 
>>>> diff --git
>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>> l
>>>> e
>>>> /Makefile_omap3-sgx-modules
>>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>> l
>>>> e
>>>> /Makefile_omap3-sgx-modules
>>>> new file mode 100644
>>>> index 0000000..2bc0ba5
>>>> --- /dev/null
>>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-ma
>>>> +++ k
>>>> +++ e
>>>> +++ file/Makefile_omap3-sgx-modules
>>>> @@ -0,0 +1,29 @@
>>>> +omap3-sgx-modules: linux
>>>> +    @echo =====================================
>>>> +    @echo      Building omap3-sgx-modules
>>>> +    @echo =====================================
>>>> +    @cd board-support/extra-drivers; \
>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR)
>>>> +BUILD=release TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
>>> Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.
>> I got the make options directly from the recipe.
>>> 
>>> So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
>> How do you  test this?
> http://processors.wiki.ti.com/index.php/Linux_Core_Power_Management_Us
> er%27s_Guide#Suspend.2FResume
>>>> +
>>>> +omap3-sgx-modules_clean:
>>>> +    @echo =====================================
>>>> +    @echo      Cleaning omap3-sgx-modules
>>>> +    @echo =====================================
>>>> +    @cd board-support/extra-drivers; \
>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
>>>> +
>>>> +omap3-sgx-modules_install:
>>>> +    @echo =====================================
>>>> +    @echo      Installing omap3-sgx-modules
>>>> +    @echo =====================================
>>>> +    @if [ ! -d $(DESTDIR) ] ; then \
>>>> +        echo "The extracted target filesystem directory doesn't exist."; \
>>>> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
>>>> +        exit 1; \
>>>> +    fi
>>>> +    @cd board-support/extra-drivers; \
>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd`
>>>> +INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) 
>>>> +modules_install
>>> This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.
>>> Typing from my phone. *reasons I never liked So you will end with 
>>> two versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.
>>> 
>>> So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
>>> *built and installs things
>> It seems that the recipe tries to fake that these modules are not out-of-tree, and I guess yocto can hide this by updating the necessary /lib/modules/<k_ver>/modules.* files. Without installing it like this, then the modules cannot be found by "modprobe".
> If this is the case then how did this work for u?
> Did you try modifying the kernel and using the rebuilt kernel and modules to verify that this works.
>>>> +
>>>> diff --git
>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>> l
>>>> e
>>>> _1.0.bb
>>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>> l
>>>> e
>>>> _1.0.bb
>>>> index ffedd4c..a31bb69 100644
>>>> ---
>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>> l
>>>> e
>>>> _1.0.bb
>>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-ma
>>>> +++ k
>>>> +++ e
>>>> +++ file_1.0.bb
>>>> @@ -34,9 +34,10 @@ SRC_URI = "\
>>>>  file://Makefile_dual-camera-demo \  file://Makefile_image-gallery 
>>>> \  file://Makefile_cryptodev \
>>>> +    file://Makefile_omap3-sgx-modules \
>>>> "
>>>> 
>>>> -PR = "r41"
>>>> +PR = "r42"
>>>> 
>>>> MAKEFILES_COMMON = "linux \
>>>>                  matrix-gui \
>>>> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>>>>                         linux-dtbs \
>>>>                         wireless \
>>>>                         cryptodev \
>>>> +                           omap3-sgx-modules \
>>>> "
>>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>>                         ${QUICK_PLAYGROUND} \ @@ -76,6 +78,7 @@ 
>>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>>                         linux-dtbs \
>>>>                         wireless \
>>>>                         cryptodev \
>>>> +                           omap3-sgx-modules \
>>>>                         dual-camera-demo \
>>>>                         image-gallery \ "
>>>> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \ 
>>>> PLATFORM_ARCH = "armv7-a"
>>>> PLATFORM_ARCH_omapl138 = "armv5te"
>>>> 
>>>> +PLATFORM_SGX = ""
>>>> +PLATFORM_SGX_ti33x = "ti335x"
>>>> +PLATFORM_SGX_ti43x = "ti43xx"
>>>> +
>>>> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
>>>> 
>>>> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
>>>> @@ -150,6 +157,8 @@ do_install () {
>>>> 
>>>>  sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" 
>>>> ${D}/Makefile
>>>> 
>>>> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
>>>> +
>>>>  cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
>>>> 
>>>>  if [ "$?" == "0" ]
>>>> --
>>>> 1.7.9.5
>>>> 
>>>> _______________________________________________
>>>> meta-arago mailing list
>>>> meta-arago@arago-project.org
>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>>> _______________________________________________
>>> meta-arago mailing list
>>> meta-arago@arago-project.org
>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
  2015-03-27 13:15             ` Stiffler, Jacob
@ 2015-03-27 13:30               ` Cooper Jr., Franklin
  0 siblings, 0 replies; 10+ messages in thread
From: Cooper Jr., Franklin @ 2015-03-27 13:30 UTC (permalink / raw)
  To: Stiffler, Jacob; +Cc: meta-arago




> On Mar 27, 2015, at 8:15 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
> 
> Before I resubmit this patch, what is your opinion on using "sgx-modules-${PV}" for the directory name nad "sgx-modules" for the Makefile target?
> 
> Also, I am currently testing changing the recipe installation to match the makefile, and will prepend this to the patch set once I have verified the change.
Sounds good
> 
> Thanks,
> Jake 
> 
> 
> 
> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Friday, March 27, 2015 8:49 AM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
> 
> 
> 
> 
>> On Mar 27, 2015, at 7:30 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>> 
>> 1) I checked, no prebuilt binaries are provided, and the clean is unnecessary. 
>> 2) No build system paths are included.
>> 3) suspend and resume were functional while running the sgx 3D demos.
>> 4) The kernel is automatically built with a different version due to the creation of a sdk branch in the git repo.
> Awesome. Just renaming the directory containing the modules is all think that's left. It's the same reason why sitara-linux-ti-staging and linux-ti-staging recipes are simply set to linux-${PV}
>> 
>> -----Original Message-----
>> From: Cooper Jr., Franklin
>> Sent: Thursday, March 26, 2015 9:40 AM
>> To: Stiffler, Jacob
>> Cc: meta-arago@arago-project.org
>> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
>> 
>> From another email I saw are you saying that a user needs to run clean and then compile and install via the top level makefile?
>> 
>> Something isn't right since ANY sources included in the SDK board 
>> support shouldn't have anything prebuilt. They should be clean sources 
>> that simply needs to be compiled by the user
>> 
>> more below
>> 
>> 
>>> On Mar 26, 2015, at 6:15 AM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>>> 
>>> I have tested this patch locally and in our nightly builds. 
>>> 
>>> See my response to your comments below.
>>> 
>>> -----Original Message-----
>>> From: Cooper Jr., Franklin
>>> Sent: Wednesday, March 25, 2015 5:02 PM
>>> To: Stiffler, Jacob
>>> Cc: meta-arago@arago-project.org
>>> Subject: Re: [meta-arago] [PATCH 1/2] omap3-sgx-modules: Add source to SDK.
>>> 
>>> 
>>> 
>>> 
>>>> On Mar 25, 2015, at 3:58 PM, Cooper Jr., Franklin <fcooper@ti.com> wrote:
>>>> 
>>>> Overall this needs more testing. additional comments below
>>>> 
>>>>> On Mar 25, 2015, at 2:28 PM, Stiffler, Jacob <j-stiffler@ti.com> wrote:
>>>>> 
>>>>> * omap3-sgx-modules provides out-of-tree drivers which are required 
>>>>> for graphics.
>>>>> * These sources need to be provided so that whenever there is a 
>>>>> kernel modification, the user can easily rebuild these moduels to reenable graphics.
>>>>> 
>>>>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>>>>> ---
>>>>> .../conf/distro/arago-source-ipk.conf              |    3 ++
>>>>> .../ti-tisdk-makefile/Makefile_omap3-sgx-modules   |   29 ++++++++++++++++++++
>>>>> .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     |   11 +++++++-
>>>>> 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 
>>>>> meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile
>>>>> /
>>>>> M
>>>>> akefile_omap3-sgx-modules
>>>>> 
>>>>> diff --git a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>>> b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>>> index b457504..40c7058 100644
>>>>> --- a/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>>> +++ b/meta-arago-distro/conf/distro/arago-source-ipk.conf
>>>>> @@ -94,6 +94,9 @@ SRCIPK_INSTALL_DIR_pn-ti-pru-sw-examples = "example-applications/pru-${PV}"
>>>>> CREATE_SRCIPK_pn-ti-ocf-crypto-module = "1"
>>>>> SRCIPK_INSTALL_DIR_pn-ti-ocf-crypto-module = "board-support/extra-drivers/${PN}-${PV}"
>>>>> 
>>>>> +CREATE_SRCIPK_pn-omap3-sgx-modules = "1"
>>>>> +SRCIPK_INSTALL_DIR_pn-omap3-sgx-modules = "board-support/extra-drivers/${PN}-${PV}"
>>>>> +
>>>> We shouldn't call it omap3-sgx-modules since that name has no meaning within the Graphics SDK nor anywhere outside of OE. Plus omap3 part is confusing from an SDK perspective.
>>> What would you suggest?
>> Idk naming it in a way people will recognize wat it is and wat it is for.
>>>> 
>>>> Now when you do sourceipk is it only including a certain portion of the graphics SdK or is it packaging the entire contents of the graphics Sdk.
>>>> 
>>>> You may need to be careful but I though when you installed the graphics SDK that it puts installation paths inside its various make files. This can cause a problem since these paths will be from your build machine.
>>> This is only the module source, as specified in the recipe: 
>>> TI_BIN_UNPK_WDEXT="/Graphics_SDK_${SGXPV}"
>>> S = "${WORKDIR}${TI_BIN_UNPK_WDEXT}/GFX_Linux_KM"
>> Can u do a grep and confirm no paths are included?
>>>> 
>>>>> CREATE_SRCIPK_pn-ti-compat-wireless-wl18xx = "1"
>>>>> SRCIPK_INSTALL_DIR_pn-ti-compat-wireless-wl18xx = "board-support/extra-drivers/${PN}-${PV}"
>>>>> 
>>>>> diff --git
>>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>>> l
>>>>> e
>>>>> /Makefile_omap3-sgx-modules
>>>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>>> l
>>>>> e
>>>>> /Makefile_omap3-sgx-modules
>>>>> new file mode 100644
>>>>> index 0000000..2bc0ba5
>>>>> --- /dev/null
>>>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-ma
>>>>> +++ k
>>>>> +++ e
>>>>> +++ file/Makefile_omap3-sgx-modules
>>>>> @@ -0,0 +1,29 @@
>>>>> +omap3-sgx-modules: linux
>>>>> +    @echo =====================================
>>>>> +    @echo      Building omap3-sgx-modules
>>>>> +    @echo =====================================
>>>>> +    @cd board-support/extra-drivers; \
>>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR)
>>>>> +BUILD=release TI_PLATFORM=__PLATFORM_SGX__ SUPPORT_XORG=0
>>>> Make sure you test this and compare against how we build the recipe in OE. I remembered in the past you needed a special flag passed in to insure PM runtime worked.
>>> I got the make options directly from the recipe.
>>>> 
>>>> So really you need to test this by removing all the sgx modules from the SDK and let the make install run on ur filesystem and see if everything  still works. This includes suspend and resume while an sgx demo is running.
>>> How do you  test this?
>> http://processors.wiki.ti.com/index.php/Linux_Core_Power_Management_Us
>> er%27s_Guide#Suspend.2FResume
>>>>> +
>>>>> +omap3-sgx-modules_clean:
>>>>> +    @echo =====================================
>>>>> +    @echo      Cleaning omap3-sgx-modules
>>>>> +    @echo =====================================
>>>>> +    @cd board-support/extra-drivers; \
>>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>>> +    make ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) clean
>>>>> +
>>>>> +omap3-sgx-modules_install:
>>>>> +    @echo =====================================
>>>>> +    @echo      Installing omap3-sgx-modules
>>>>> +    @echo =====================================
>>>>> +    @if [ ! -d $(DESTDIR) ] ; then \
>>>>> +        echo "The extracted target filesystem directory doesn't exist."; \
>>>>> +        echo "Please run setup.sh in the SDK's root directory and then try again."; \
>>>>> +        exit 1; \
>>>>> +    fi
>>>>> +    @cd board-support/extra-drivers; \
>>>>> +    cd `find . -maxdepth 1 -name "omap3-sgx-modules*"`; \
>>>>> +    make -C $(LINUXKERNEL_INSTALL_DIR) SUBDIRS=`pwd`
>>>>> +INSTALL_MOD_PATH=$(DESTDIR) PREFIX=$(SDK_PATH_TARGET) 
>>>>> +modules_install
>>>> This will cause problems as is. The graphics recipe for reasons I never installs the graphics modules differently then the graphics SDK.
>>>> Typing from my phone. *reasons I never liked So you will end with 
>>>> two versions of the graphics SDK in ur fs and both will try to load and maybe possibly fail.
>>>> 
>>>> So either update the OE recipe to use the makefile install or update this part to mimic the OE way it built things.
>>>> *built and installs things
>>> It seems that the recipe tries to fake that these modules are not out-of-tree, and I guess yocto can hide this by updating the necessary /lib/modules/<k_ver>/modules.* files. Without installing it like this, then the modules cannot be found by "modprobe".
>> If this is the case then how did this work for u?
>> Did you try modifying the kernel and using the rebuilt kernel and modules to verify that this works.
>>>>> +
>>>>> diff --git
>>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>>> l
>>>>> e
>>>>> _1.0.bb
>>>>> b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>>> l
>>>>> e
>>>>> _1.0.bb
>>>>> index ffedd4c..a31bb69 100644
>>>>> ---
>>>>> a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefi
>>>>> l
>>>>> e
>>>>> _1.0.bb
>>>>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-ma
>>>>> +++ k
>>>>> +++ e
>>>>> +++ file_1.0.bb
>>>>> @@ -34,9 +34,10 @@ SRC_URI = "\
>>>>> file://Makefile_dual-camera-demo \  file://Makefile_image-gallery 
>>>>> \  file://Makefile_cryptodev \
>>>>> +    file://Makefile_omap3-sgx-modules \
>>>>> "
>>>>> 
>>>>> -PR = "r41"
>>>>> +PR = "r42"
>>>>> 
>>>>> MAKEFILES_COMMON = "linux \
>>>>>                 matrix-gui \
>>>>> @@ -69,6 +70,7 @@ MAKEFILES_append_ti33x = " u-boot-spl \
>>>>>                        linux-dtbs \
>>>>>                        wireless \
>>>>>                        cryptodev \
>>>>> +                           omap3-sgx-modules \
>>>>> "
>>>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>>>                        ${QUICK_PLAYGROUND} \ @@ -76,6 +78,7 @@ 
>>>>> MAKEFILES_append_ti43x = " u-boot-spl \
>>>>>                        linux-dtbs \
>>>>>                        wireless \
>>>>>                        cryptodev \
>>>>> +                           omap3-sgx-modules \
>>>>>                        dual-camera-demo \
>>>>>                        image-gallery \ "
>>>>> @@ -95,6 +98,10 @@ MAKEFILES_append_am180x-evm = " pru \ 
>>>>> PLATFORM_ARCH = "armv7-a"
>>>>> PLATFORM_ARCH_omapl138 = "armv5te"
>>>>> 
>>>>> +PLATFORM_SGX = ""
>>>>> +PLATFORM_SGX_ti33x = "ti335x"
>>>>> +PLATFORM_SGX_ti43x = "ti43xx"
>>>>> +
>>>>> KERNEL_BUILD_CMDS = "${@base_conditional('KERNEL_IMAGETYPE','uImage','LOADADDR=${UBOOT_LOADADDRESS} uImage','zImage',d)}"
>>>>> 
>>>>> KERNEL_DEVICETREE_ti33x = "am335x-evm.dtb am335x-evmsk.dtb am335x-bone.dtb am335x-boneblack.dtb"
>>>>> @@ -150,6 +157,8 @@ do_install () {
>>>>> 
>>>>> sed -i -e "s/__KERNEL_BUILD_CMDS__/${KERNEL_BUILD_CMDS}/" 
>>>>> ${D}/Makefile
>>>>> 
>>>>> +    sed -i -e "s/__PLATFORM_SGX__/${PLATFORM_SGX}/" ${D}/Makefile
>>>>> +
>>>>> cat ${D}/Makefile | grep "__DTB_DEPEND__" > /dev/null
>>>>> 
>>>>> if [ "$?" == "0" ]
>>>>> --
>>>>> 1.7.9.5
>>>>> 
>>>>> _______________________________________________
>>>>> meta-arago mailing list
>>>>> meta-arago@arago-project.org
>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>>>> _______________________________________________
>>>> meta-arago mailing list
>>>> meta-arago@arago-project.org
>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2015-03-27 13:30 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 19:28 [PATCH 1/2] omap3-sgx-modules: Add source to SDK Jacob Stiffler
2015-03-25 19:28 ` [PATCH 2/2] packagegroup-arago-tisdk-graphics-sdk-host: Create for graphics modules Jacob Stiffler
2015-03-25 20:58 ` [PATCH 1/2] omap3-sgx-modules: Add source to SDK Cooper Jr., Franklin
2015-03-25 21:02   ` Cooper Jr., Franklin
2015-03-26 11:15     ` Stiffler, Jacob
2015-03-26 13:39       ` Cooper Jr., Franklin
2015-03-27 12:30         ` Stiffler, Jacob
2015-03-27 12:49           ` Cooper Jr., Franklin
2015-03-27 13:15             ` Stiffler, Jacob
2015-03-27 13:30               ` Cooper Jr., Franklin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.