All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: vf610: fix missing irqs
@ 2015-03-26  7:24 ` Stefan Agner
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Agner @ 2015-03-26  7:24 UTC (permalink / raw)
  To: shawn.guo, kernel
  Cc: maitysanchayan, devicetree, linux-arm-kernel, linux-kernel, stefan

While adding the MSCM interrupt router, all interrupts have been moved
to vfxxx.dtsi again. However, some properties got lost. Readd the
missing interrupt properties.

Offending commit:
97e6466ab9 ("ARM: dts: vf610: add Miscellaneous System Control Module (MSCM)"
---
 arch/arm/boot/dts/vfxxx.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 899645d..f9bef55 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi
@@ -377,6 +377,7 @@
 			src: src@4006e000 {
 				compatible = "fsl,vf610-src", "syscon";
 				reg = <0x4006e000 0x1000>;
+				interrupts = <96 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
 			gpc: gpc@4006c000 {
@@ -419,6 +420,7 @@
 				snvsrtc: snvs-rtc-lp@34 {
 					compatible = "fsl,sec-v4.0-mon-rtc-lp";
 					reg = <0x34 0x58>;
+					interrupts = <100 IRQ_TYPE_LEVEL_HIGH>;
 					clocks = <&clks VF610_CLK_SNVS>;
 					clock-names = "snvs-rtc";
 				};
-- 
2.3.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: dts: vf610: fix missing irqs
@ 2015-03-26  7:24 ` Stefan Agner
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Agner @ 2015-03-26  7:24 UTC (permalink / raw)
  To: linux-arm-kernel

While adding the MSCM interrupt router, all interrupts have been moved
to vfxxx.dtsi again. However, some properties got lost. Readd the
missing interrupt properties.

Offending commit:
97e6466ab9 ("ARM: dts: vf610: add Miscellaneous System Control Module (MSCM)"
---
 arch/arm/boot/dts/vfxxx.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 899645d..f9bef55 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi
@@ -377,6 +377,7 @@
 			src: src at 4006e000 {
 				compatible = "fsl,vf610-src", "syscon";
 				reg = <0x4006e000 0x1000>;
+				interrupts = <96 IRQ_TYPE_LEVEL_HIGH>;
 			};
 
 			gpc: gpc at 4006c000 {
@@ -419,6 +420,7 @@
 				snvsrtc: snvs-rtc-lp at 34 {
 					compatible = "fsl,sec-v4.0-mon-rtc-lp";
 					reg = <0x34 0x58>;
+					interrupts = <100 IRQ_TYPE_LEVEL_HIGH>;
 					clocks = <&clks VF610_CLK_SNVS>;
 					clock-names = "snvs-rtc";
 				};
-- 
2.3.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: vf610: fix missing irqs
  2015-03-26  7:24 ` Stefan Agner
@ 2015-03-26  8:12   ` Uwe Kleine-König
  -1 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2015-03-26  8:12 UTC (permalink / raw)
  To: Stefan Agner
  Cc: shawn.guo, kernel, maitysanchayan, linux-kernel,
	linux-arm-kernel, devicetree

Hello Stefan,

On Thu, Mar 26, 2015 at 08:24:05AM +0100, Stefan Agner wrote:
> While adding the MSCM interrupt router, all interrupts have been moved
> to vfxxx.dtsi again. However, some properties got lost. Readd the
> missing interrupt properties.
> 
> Offending commit:
> 97e6466ab9 ("ARM: dts: vf610: add Miscellaneous System Control Module (MSCM)"
Usually this is written as:

	Fixes: 97e6466ab9 ("ARM: dts: vf610: add Miscellaneous System Control Module (MSCM)")

and there is no Sign-off.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: dts: vf610: fix missing irqs
@ 2015-03-26  8:12   ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2015-03-26  8:12 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Stefan,

On Thu, Mar 26, 2015 at 08:24:05AM +0100, Stefan Agner wrote:
> While adding the MSCM interrupt router, all interrupts have been moved
> to vfxxx.dtsi again. However, some properties got lost. Readd the
> missing interrupt properties.
> 
> Offending commit:
> 97e6466ab9 ("ARM: dts: vf610: add Miscellaneous System Control Module (MSCM)"
Usually this is written as:

	Fixes: 97e6466ab9 ("ARM: dts: vf610: add Miscellaneous System Control Module (MSCM)")

and there is no Sign-off.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-26  8:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-26  7:24 [PATCH] ARM: dts: vf610: fix missing irqs Stefan Agner
2015-03-26  7:24 ` Stefan Agner
2015-03-26  8:12 ` Uwe Kleine-König
2015-03-26  8:12   ` Uwe Kleine-König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.