* [PATCH] c6x: include: asm: dma-mapping: Add dummy dma_sync_single_range_for_device
@ 2015-03-04 3:09 Chen Gang
2015-03-26 14:57 ` Mark Salter
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2015-03-04 3:09 UTC (permalink / raw)
To: msalter, a-jacquiot; +Cc: linux-c6x-dev, linux-kernel
c6x does not implement get_dma_ops() for dma-mapping-common.h. And in
dma-mapping-common.h, dma_sync_single_range_for_device() may be dummy.
So c6x can just define a dummy function for allmodconfig building.
CC [M] drivers/net/ethernet/micrel/ks8851.o
drivers/net/ethernet/micrel/ks8842.c: In function 'ks8842_tx_frame_dma':
drivers/net/ethernet/micrel/ks8842.c:453:2: error: implicit declaration of function 'dma_sync_single_range_for_device' [-Werror=implicit-function-declaration]
dma_sync_single_range_for_device(adapter->dev,
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
arch/c6x/include/asm/dma-mapping.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/c6x/include/asm/dma-mapping.h b/arch/c6x/include/asm/dma-mapping.h
index 88bd0d8..bbd7774 100644
--- a/arch/c6x/include/asm/dma-mapping.h
+++ b/arch/c6x/include/asm/dma-mapping.h
@@ -17,6 +17,14 @@
#define dma_supported(d, m) 1
+static inline void dma_sync_single_range_for_device(struct device *dev,
+ dma_addr_t addr,
+ unsigned long offset,
+ size_t size,
+ enum dma_data_direction dir)
+{
+}
+
static inline int dma_set_mask(struct device *dev, u64 dma_mask)
{
if (!dev->dma_mask || !dma_supported(dev, dma_mask))
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] c6x: include: asm: dma-mapping: Add dummy dma_sync_single_range_for_device
2015-03-04 3:09 [PATCH] c6x: include: asm: dma-mapping: Add dummy dma_sync_single_range_for_device Chen Gang
@ 2015-03-26 14:57 ` Mark Salter
0 siblings, 0 replies; 2+ messages in thread
From: Mark Salter @ 2015-03-26 14:57 UTC (permalink / raw)
To: Chen Gang; +Cc: a-jacquiot, linux-c6x-dev, linux-kernel
On Wed, 2015-03-04 at 11:09 +0800, Chen Gang wrote:
> c6x does not implement get_dma_ops() for dma-mapping-common.h. And in
> dma-mapping-common.h, dma_sync_single_range_for_device() may be dummy.
> So c6x can just define a dummy function for allmodconfig building.
>
> CC [M] drivers/net/ethernet/micrel/ks8851.o
> drivers/net/ethernet/micrel/ks8842.c: In function 'ks8842_tx_frame_dma':
> drivers/net/ethernet/micrel/ks8842.c:453:2: error: implicit declaration of function 'dma_sync_single_range_for_device' [-Werror=implicit-function-declaration]
> dma_sync_single_range_for_device(adapter->dev,
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
Thanks! I added this to the c6x tree for next merge window.
> arch/c6x/include/asm/dma-mapping.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/c6x/include/asm/dma-mapping.h b/arch/c6x/include/asm/dma-mapping.h
> index 88bd0d8..bbd7774 100644
> --- a/arch/c6x/include/asm/dma-mapping.h
> +++ b/arch/c6x/include/asm/dma-mapping.h
> @@ -17,6 +17,14 @@
>
> #define dma_supported(d, m) 1
>
> +static inline void dma_sync_single_range_for_device(struct device *dev,
> + dma_addr_t addr,
> + unsigned long offset,
> + size_t size,
> + enum dma_data_direction dir)
> +{
> +}
> +
> static inline int dma_set_mask(struct device *dev, u64 dma_mask)
> {
> if (!dev->dma_mask || !dma_supported(dev, dma_mask))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-26 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-04 3:09 [PATCH] c6x: include: asm: dma-mapping: Add dummy dma_sync_single_range_for_device Chen Gang
2015-03-26 14:57 ` Mark Salter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.