[GIT PULL 0/6] perf/core improvements and fixes

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit baa5a7bc5dd069bb37de9c8bdb5ea7f4e2e939e9:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-03-24 17:22:44 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 7c27f78a297b54c3c2f5075cb15d33431b7f6333:

  tools lib traceevent: Zero should not be considered "not found" in eval_flag() (2015-03-26 10:52:29 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Show the first event with an invalid filter (David Ahern, Arnaldo Carvalho de Melo)

- Fix garbage output when intermixing syscalls from different threads in 'perf trace' (Arnaldo Carvalho de Melo)

- Fix 'perf timechart' SIBGUS error on sparc64 (David Ahern)

Infrastructure:

- Set JOBS based on CPU or processor, making it work on SPARC, where
  /proc/cpuinfo has "CPU", not "processor" (David Ahern)

- Zero should not be considered "not found" in libtraceevent's eval_flag() (Steven Rostedt)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
      perf evlist: Return the first evsel with an invalid filter in apply_filters()
      perf trace: Fix syscall enter formatting bug

David Ahern (3):
      perf timechart: Fix SIBGUS error on sparc64
      perf: Bump max number of cpus to 1024
      perf tools: Set JOBS based on CPU or processor

Steven Rostedt (1):
      tools lib traceevent: Zero should not be considered "not found" in eval_flag()

 tools/lib/traceevent/event-parse.c | 10 +++++-----
 tools/perf/Makefile                |  2 +-
 tools/perf/builtin-record.c        |  5 +++--
 tools/perf/builtin-stat.c          |  5 +++--
 tools/perf/builtin-trace.c         |  2 +-
 tools/perf/perf.h                  |  2 +-
 tools/perf/util/evlist.c           |  6 ++++--
 tools/perf/util/evlist.h           |  2 +-
 tools/perf/util/evsel.c            |  2 +-
 9 files changed, 20 insertions(+), 16 deletions(-)

[PATCH 1/6] perf timechart: Fix SIBGUS error on sparc64

[Arnaldo Carvalho de Melo]

From: David Ahern <david.ahern@oracle.com>

perf timechart -T on sparc64 is terminating due to SIGBUS. Backtrace:

Program received signal SIGBUS, Bus error.
0x0000000000173d7c in perf_evsel__intval (evsel=<value optimized out>, sample=0x7feffffda28, name=0x289b28 "prev_state")
    at util/evsel.c:1918
1918	util/evsel.c: No such file or directory.
	in util/evsel.c
Missing separate debuginfos, use: debuginfo-install audit-libs-2.3.7-1.0.1.el6.sparc64 bzip2-libs-1.0.5-7.el6_0.sparc64 elfutils-libelf-0.155-2.0.3.el6.sparc64 elfutils-libs-0.155-2.0.3.el6.sparc64 glibc-2.12-1.132.0.8.el6_5.sparc64 numactl-2.0.7-8.el6.sparc64 python-libs-2.6.6-52.0.2.el6.sparc64 slang-2.2.1-1.el6.sparc64 xz-libs-4.999.9-0.3.beta.20091007git.el6.sparc64 zlib-1.2.3-29.el6.sparc64
(gdb) bt
0  0x0000000000173d7c in perf_evsel__intval (evsel=<value optimized out>, sample=0x7feffffda28,
    name=0x289b28 "prev_state") at util/evsel.c:1918
1  0x0000000000123b94 in process_sample_sched_switch (tchart=0x7feffffe040, evsel=0x4ca850, sample=0x7feffffda28,
    backtrace=0xc39010 "") at builtin-timechart.c:627
2  0x0000000000122828 in process_sample_event (tool=0x7feffffe040, event=<value optimized out>, sample=0x7feffffda28,
    evsel=0x4ca850, machine=0x4c9c88) at builtin-timechart.c:569

Another extended load on unaligned pointer. As before fix by copying to
a temporary variable using memcpy.

Signed-off-by: David Ahern <david.ahern@oracle.com>
Link: http://lkml.kernel.org/r/1427228049-51893-1-git-send-email-david.ahern@oracle.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index bb4eff28869e..358e5954baa8 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -1915,7 +1915,7 @@ u64 perf_evsel__intval(struct perf_evsel *evsel, struct perf_sample *sample,
 		value = *(u32 *)ptr;
 		break;
 	case 8:
-		value = *(u64 *)ptr;
+		memcpy(&value, ptr, sizeof(u64));
 		break;
 	default:
 		return 0;
-- 
1.9.3

[PATCH 2/6] perf evlist: Return the first evsel with an invalid filter in apply_filters()

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Use of a bad filter currently generates the message:
 Error: failed to set filter with 22 (Invalid argument)

Add the event name to make it clear to which event the filter
failed to apply:
  Error: Failed to set filter "foo" on event sched:sg_lb_stats: 22: Invalid argument

To test it use something like:

 # perf record -e sched:sched_switch -e sched:*fork --filter parent_pid==1 -e sched:*wait* --filter bla usleep 1
  Error: failed to set filter "bla" on event sched:sched_stat_iowait with 22 (Invalid argument)
 #

Based-on-a-patch-by: David Ahern <dsahern@gmail.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-d7gq2fjvaecozp9o2i0siifu@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-record.c | 5 +++--
 tools/perf/builtin-stat.c   | 5 +++--
 tools/perf/util/evlist.c    | 6 ++++--
 tools/perf/util/evlist.h    | 2 +-
 4 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 5a2ff510b75b..18aad239b401 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -161,8 +161,9 @@ try_again:
 		}
 	}
 
-	if (perf_evlist__apply_filters(evlist)) {
-		error("failed to set filter with %d (%s)\n", errno,
+	if (perf_evlist__apply_filters(evlist, &pos)) {
+		error("failed to set filter \"%s\" on event %s with %d (%s)\n",
+			pos->filter, perf_evsel__name(pos), errno,
 			strerror_r(errno, msg, sizeof(msg)));
 		rc = -1;
 		goto out;
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index d4d1b77da0bd..f7b8218785f6 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -684,8 +684,9 @@ static int __run_perf_stat(int argc, const char **argv)
 			unit_width = l;
 	}
 
-	if (perf_evlist__apply_filters(evsel_list)) {
-		error("failed to set filter with %d (%s)\n", errno,
+	if (perf_evlist__apply_filters(evsel_list, &counter)) {
+		error("failed to set filter \"%s\" on event %s with %d (%s)\n",
+			counter->filter, perf_evsel__name(counter), errno,
 			strerror_r(errno, msg, sizeof(msg)));
 		return -1;
 	}
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 8d0b62361129..82bf224bbee9 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1050,7 +1050,7 @@ out_delete_threads:
 	return -1;
 }
 
-int perf_evlist__apply_filters(struct perf_evlist *evlist)
+int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **err_evsel)
 {
 	struct perf_evsel *evsel;
 	int err = 0;
@@ -1062,8 +1062,10 @@ int perf_evlist__apply_filters(struct perf_evlist *evlist)
 			continue;
 
 		err = perf_evsel__set_filter(evsel, ncpus, nthreads, evsel->filter);
-		if (err)
+		if (err) {
+			*err_evsel = evsel;
 			break;
+		}
 	}
 
 	return err;
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
index f07c984465f0..fb19c47b8aac 100644
--- a/tools/perf/util/evlist.h
+++ b/tools/perf/util/evlist.h
@@ -152,7 +152,7 @@ static inline void perf_evlist__set_maps(struct perf_evlist *evlist,
 }
 
 int perf_evlist__create_maps(struct perf_evlist *evlist, struct target *target);
-int perf_evlist__apply_filters(struct perf_evlist *evlist);
+int perf_evlist__apply_filters(struct perf_evlist *evlist, struct perf_evsel **err_evsel);
 
 void __perf_evlist__set_leader(struct list_head *list);
 void perf_evlist__set_leader(struct perf_evlist *evlist);
-- 
1.9.3

[PATCH 3/6] perf: Bump max number of cpus to 1024

[Arnaldo Carvalho de Melo]

From: David Ahern <david.ahern@oracle.com>

SPARC based systems currently support up to 1024 cpus (e.g. T5-8).
Allow perf to work on those systems.

Signed-off-by: David Ahern <david.ahern@oracle.com>
Link: http://lkml.kernel.org/r/1427213438-127216-1-git-send-email-david.ahern@oracle.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/perf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/perf.h b/tools/perf/perf.h
index 1caa70a4a9e1..c38a085a5571 100644
--- a/tools/perf/perf.h
+++ b/tools/perf/perf.h
@@ -29,7 +29,7 @@ static inline unsigned long long rdclock(void)
 	return ts.tv_sec * 1000000000ULL + ts.tv_nsec;
 }
 
-#define MAX_NR_CPUS			256
+#define MAX_NR_CPUS			1024
 
 extern const char *input_name;
 extern bool perf_host, perf_guest;
-- 
1.9.3

[PATCH 4/6] perf tools: Set JOBS based on CPU or processor

[Arnaldo Carvalho de Melo]

From: David Ahern <david.ahern@oracle.com>

Number of JOBS to use is set automatically to the number of processors found
in /proc/cpuinfo. SPARC uses 'CPU' lines rather than 'processor'. Update the
check in perf's Makefile to work for SPARC.

Signed-off-by: David Ahern <david.ahern@oracle.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1427213455-127249-1-git-send-email-david.ahern@oracle.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index d5020aeb5626..c699dc35eef9 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -24,7 +24,7 @@ unexport MAKEFLAGS
 # (To override it, run 'make JOBS=1' and similar.)
 #
 ifeq ($(JOBS),)
-  JOBS := $(shell grep -c ^processor /proc/cpuinfo 2>/dev/null)
+  JOBS := $(shell egrep -c '^processor|^CPU' /proc/cpuinfo 2>/dev/null)
   ifeq ($(JOBS),0)
     JOBS := 1
   endif
-- 
1.9.3

[PATCH 5/6] perf trace: Fix syscall enter formatting bug

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

 commit e596663ebb28a068f5cca57f83285b7b293a2c83
 Author: Arnaldo Carvalho de Melo <acme@redhat.com>
 Date:   Fri Feb 13 13:22:21 2015 -0300

    perf trace: Handle multiple threads better wrt syscalls being intermixed

Introduced a bug where it considered the number of bytes output directly
to the output file when formatting the syscall entry buffer that is
stored to be finally printed at syscall exit, ending up leaving garbage
at the start of syscalls that appeared while another syscall was being
processed, in another thread. Fix it.

Example of garbage in the output before this patch:

 4280.102 (  0.000 ms): lsmd/763  ... [continued]: select()) = 0 Timeout
 4280.107 (275.250 ms): tuned/852 select(tvp: 0x7f41f7ffde50        ) ...
 4280.109 (  0.002 ms): lsmd/763 Xl��                                ) = -10
 4639.197 (  0.000 ms): systemd-journa/542  ... [continued]: epoll_wait()) = 1
 4639.202 (359.088 ms): lsmd/763 select(n: 6, inp: 0x7ffff21daad0, tvp: 0x7ffff21daac0) ...
 4639.207 (  0.005 ms): systemd-journa/542 Hn��                      ) = 106
 4639.221 (  0.002 ms): systemd-journa/542 uname(name: 0x7ffdbaed8e00) = 0
 4639.271 (  0.008 ms): systemd-journa/542 ftruncate(fd: 11</run/log/journal/60cd52417cf440a4a80107518bbd3c20/system.journal>, length: 50331648) = 0

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-9ckfe8mvsedgkg6y80gz1ul8@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 001c6ae9a1b1..bcc98ce3e5b8 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1735,7 +1735,7 @@ static int trace__sys_enter(struct trace *trace, struct perf_evsel *evsel,
 	}
 
 	if (!trace->summary_only)
-		printed += trace__printf_interrupted_entry(trace, sample);
+		trace__printf_interrupted_entry(trace, sample);
 
 	ttrace->entry_time = sample->time;
 	msg = ttrace->entry_str;
-- 
1.9.3

[PATCH 6/6] tools lib traceevent: Zero should not be considered "not found" in eval_flag()

[Arnaldo Carvalho de Melo]

From: Steven Rostedt <rostedt@goodmis.org>

Guilherme Cox found that:

 There is, however, a potential bug if there is an item with code zero
 that is not the first one in the symbol list, since eval_flag(..)
 returns 0 when it doesn't find anything.

That is, if you have the following enums:

enum {
  FOO_START = 0,
  FOO_GO    = 1,
  FOO_END   = 2
}

and then have:

  __print_symbolic(foo, FOO_GO, "go", FOO_START, "start",
		        FOO_END, "end")

If none of the enums are known to pevent, then eval_flag() will return
zero, and it will match it to the first item in the list, which would be
FOO_GO, which is not zero.

Luckily, in most cases, the first element would be zero, and the parsing
would match out of sheer luck.

Reported-by: Guilherme Cox <cox@computer.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/20150324145813.0bfe95ba@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/event-parse.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index b6d11eea8a57..6d31b6419d37 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -3615,7 +3615,7 @@ static const struct flag flags[] = {
 	{ "HRTIMER_RESTART", 1 },
 };
 
-static unsigned long long eval_flag(const char *flag)
+static long long eval_flag(const char *flag)
 {
 	int i;
 
@@ -3631,7 +3631,7 @@ static unsigned long long eval_flag(const char *flag)
 		if (strcmp(flags[i].name, flag) == 0)
 			return flags[i].value;
 
-	return 0;
+	return -1LL;
 }
 
 static void print_str_to_seq(struct trace_seq *s, const char *format,
@@ -3705,7 +3705,7 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
 	struct print_flag_sym *flag;
 	struct format_field *field;
 	struct printk_map *printk;
-	unsigned long long val, fval;
+	long long val, fval;
 	unsigned long addr;
 	char *str;
 	unsigned char *hex;
@@ -3764,11 +3764,11 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
 		print = 0;
 		for (flag = arg->flags.flags; flag; flag = flag->next) {
 			fval = eval_flag(flag->value);
-			if (!val && !fval) {
+			if (!val && fval < 0) {
 				print_str_to_seq(s, format, len_arg, flag->str);
 				break;
 			}
-			if (fval && (val & fval) == fval) {
+			if (fval > 0 && (val & fval) == fval) {
 				if (print && arg->flags.delim)
 					trace_seq_puts(s, arg->flags.delim);
 				print_str_to_seq(s, format, len_arg, flag->str);
-- 
1.9.3

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit baa5a7bc5dd069bb37de9c8bdb5ea7f4e2e939e9:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-03-24 17:22:44 +0100)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 7c27f78a297b54c3c2f5075cb15d33431b7f6333:
> 
>   tools lib traceevent: Zero should not be considered "not found" in eval_flag() (2015-03-26 10:52:29 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Show the first event with an invalid filter (David Ahern, Arnaldo Carvalho de Melo)
> 
> - Fix garbage output when intermixing syscalls from different threads in 'perf trace' (Arnaldo Carvalho de Melo)
> 
> - Fix 'perf timechart' SIBGUS error on sparc64 (David Ahern)
> 
> Infrastructure:
> 
> - Set JOBS based on CPU or processor, making it work on SPARC, where
>   /proc/cpuinfo has "CPU", not "processor" (David Ahern)
> 
> - Zero should not be considered "not found" in libtraceevent's eval_flag() (Steven Rostedt)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
>       perf evlist: Return the first evsel with an invalid filter in apply_filters()
>       perf trace: Fix syscall enter formatting bug
> 
> David Ahern (3):
>       perf timechart: Fix SIBGUS error on sparc64
>       perf: Bump max number of cpus to 1024
>       perf tools: Set JOBS based on CPU or processor
> 
> Steven Rostedt (1):
>       tools lib traceevent: Zero should not be considered "not found" in eval_flag()
> 
>  tools/lib/traceevent/event-parse.c | 10 +++++-----
>  tools/perf/Makefile                |  2 +-
>  tools/perf/builtin-record.c        |  5 +++--
>  tools/perf/builtin-stat.c          |  5 +++--
>  tools/perf/builtin-trace.c         |  2 +-
>  tools/perf/perf.h                  |  2 +-
>  tools/perf/util/evlist.c           |  6 ++++--
>  tools/perf/util/evlist.h           |  2 +-
>  tools/perf/util/evsel.c            |  2 +-
>  9 files changed, 20 insertions(+), 16 deletions(-)

Pulled, thanks a lot Arnaldo!

Btw., I still see:

config/Makefile:609: No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev

this annoyance needs to be fixed ASAP, before I can send perf/core to 
Linus.

	Ingo

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

Test results at the end of this message, as usual.

The following changes since commit ffa86c2f1a8862cf58c873f6f14d4b2c3250fb48:

  Merge tag 'perf-core-for-mingo-4.12-20170314' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-03-15 19:27:27 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170316

for you to fetch changes up to 61f35d750683b21e9e3836e309195c79c1daed74:

  uprobes: Default UPROBES_EVENTS to Y (2017-03-16 12:42:02 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

New features:

- Add 'brstackinsn' field in 'perf script' to reuse the x86 instruction
  decoder used in the Intel PT code to study hot paths to samples (Andi Kleen)

Kernel:

- Default UPROBES_EVENTS to Y (Alexei Starovoitov)

- Fix check for kretprobe offset within function entry (Naveen N. Rao)

Infrastructure:

- Introduce util func is_sdt_event() (Ravi Bangoria)

- Make perf_event__synthesize_mmap_events() scale on older kernels where
  reading /proc/pid/maps is way slower than reading /proc/pid/task/pid/maps (Stephane Eranian)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf script: Add 'brstackinsn' for branch stacks

Arnaldo Carvalho de Melo (2):
      tools headers: Sync {tools/,}arch/x86/include/asm/cpufeatures.h
      uprobes: Default UPROBES_EVENTS to Y

Naveen N. Rao (1):
      trace/kprobes: Fix check for kretprobe offset within function entry

Ravi Bangoria (1):
      perf probe: Introduce util func is_sdt_event()

Stephane Eranian (1):
      perf tools: Make perf_event__synthesize_mmap_events() scale

 include/linux/kprobes.h                            |   1 +
 kernel/kprobes.c                                   |  40 ++--
 kernel/trace/Kconfig                               |   2 +-
 kernel/trace/trace_kprobe.c                        |   2 +-
 tools/arch/x86/include/asm/cpufeatures.h           |   5 +-
 tools/perf/Documentation/perf-script.txt           |  13 +-
 tools/perf/builtin-script.c                        | 264 ++++++++++++++++++++-
 tools/perf/util/Build                              |   1 +
 tools/perf/util/dump-insn.c                        |  14 ++
 tools/perf/util/dump-insn.h                        |  22 ++
 tools/perf/util/event.c                            |   4 +-
 .../util/intel-pt-decoder/intel-pt-insn-decoder.c  |  24 ++
 tools/perf/util/parse-events.h                     |  20 ++
 tools/perf/util/probe-event.c                      |   9 +-
 14 files changed, 381 insertions(+), 40 deletions(-)
 create mode 100644 tools/perf/util/dump-insn.c
 create mode 100644 tools/perf/util/dump-insn.h

Test results:

The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.

Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.

The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.

Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.

  # dm
   1 alpine:3.4: Ok
   2 alpine:3.5: Ok
   3 alpine:edge: Ok
   4 android-ndk:r12b-arm: Ok
   5 archlinux:latest: Ok
   6 centos:5: Ok
   7 centos:6: Ok
   8 centos:7: Ok
   9 debian:7: Ok
  10 debian:8: Ok
  11 debian:experimental: Ok
  12 debian:experimental-x-arm64: Ok
  13 debian:experimental-x-mips: Ok
  14 debian:experimental-x-mips64: Ok
  15 debian:experimental-x-mipsel: Ok
  16 fedora:20: Ok
  17 fedora:21: Ok
  18 fedora:22: Ok
  19 fedora:23: Ok
  20 fedora:24: Ok
  21 fedora:24-x-ARC-uClibc: Ok
  22 fedora:25: Ok
  23 fedora:rawhide: Ok
  24 mageia:5: Ok
  25 opensuse:13.2: Ok
  26 opensuse:42.1: Ok
  27 opensuse:tumbleweed: Ok
  28 ubuntu:12.04.5: Ok
  29 ubuntu:14.04.4: Ok
  30 ubuntu:14.04.4-x-linaro-arm64: Ok
  31 ubuntu:15.10: Ok
  32 ubuntu:16.04: Ok
  33 ubuntu:16.04-x-arm: Ok
  34 ubuntu:16.04-x-arm64: Ok
  35 ubuntu:16.04-x-powerpc: Ok
  36 ubuntu:16.04-x-powerpc64: Ok
  37 ubuntu:16.04-x-s390: Ok
  38 ubuntu:16.10: Ok
  39 ubuntu:17.04: Ok

  # uname -a
  Linux zoo 4.9.13-100.fc24.x86_64 #1 SMP Mon Feb 27 16:57:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
  # perf test
   1: vmlinux symtab matches kallsyms            : Ok
   2: Detect openat syscall event                : Ok
   3: Detect openat syscall event on all cpus    : Ok
   4: Read samples using the mmap interface      : Ok
   5: Parse event definition strings             : Ok
   6: PERF_RECORD_* events & perf_sample fields  : Ok
   7: Parse perf pmu format                      : Ok
   8: DSO data read                              : Ok
   9: DSO data cache                             : Ok
  10: DSO data reopen                            : Ok
  11: Roundtrip evsel->name                      : Ok
  12: Parse sched tracepoints fields             : Ok
  13: syscalls:sys_enter_openat event fields     : Ok
  14: Setup struct perf_event_attr               : Ok
  15: Match and link multiple hists              : Ok
  16: 'import perf' in python                    : Ok
  17: Breakpoint overflow signal handler         : Ok
  18: Breakpoint overflow sampling               : Ok
  19: Number of exit events of a simple workload : Ok
  20: Software clock events period values        : Ok
  21: Object code reading                        : Ok
  22: Sample parsing                             : Ok
  23: Use a dummy software event to keep tracking: Ok
  24: Parse with no sample_id_all bit set        : Ok
  25: Filter hist entries                        : Ok
  26: Lookup mmap thread                         : Ok
  27: Share thread mg                            : Ok
  28: Sort output of hist entries                : Ok
  29: Cumulate child hist entries                : Ok
  30: Track with sched_switch                    : Ok
  31: Filter fds with revents mask in a fdarray  : Ok
  32: Add fd to a fdarray, making it autogrow    : Ok
  33: kmod_path__parse                           : Ok
  34: Thread map                                 : Ok
  35: LLVM search and compile                    :
  35.1: Basic BPF llvm compile                    : Ok
  35.2: kbuild searching                          : Ok
  35.3: Compile source for BPF prologue generation: Ok
  35.4: Compile source for BPF relocation         : Ok
  36: Session topology                           : Ok
  37: BPF filter                                 :
  37.1: Basic BPF filtering                      : Ok
  37.2: BPF pinning                              : Ok
  37.3: BPF prologue generation                  : Ok
  37.4: BPF relocation checker                   : Ok
  38: Synthesize thread map                      : Ok
  39: Remove thread map                          : Ok
  40: Synthesize cpu map                         : Ok
  41: Synthesize stat config                     : Ok
  42: Synthesize stat                            : Ok
  43: Synthesize stat round                      : Ok
  44: Synthesize attr update                     : Ok
  45: Event times                                : Ok
  46: Read backward ring buffer                  : Ok
  47: Print cpu map                              : Ok
  48: Probe SDT events                           : Ok
  49: is_printable_array                         : Ok
  50: Print bitmap                               : Ok
  51: perf hooks                                 : Ok
  52: builtin clang support                      : Skip (not compiled in)
  53: unit_number__scnprintf                     : Ok
  54: x86 rdpmc                                  : Ok
  55: Convert perf time to TSC                   : Ok
  56: DWARF unwind                               : Ok
  57: x86 instruction decoder - new instructions : Ok
  58: Intel cqm nmi context read                 : Skip
  # 
  $ make -C tools/perf build-test
  make: Entering directory '/home/acme/git/linux/tools/perf'
  - tarpkg: ./tests/perf-targz-src-pkg .
              make_no_libelf_O: make NO_LIBELF=1
             make_no_libperl_O: make NO_LIBPERL=1
             make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
             make_no_libnuma_O: make NO_LIBNUMA=1
                   make_pure_O: make
                 make_perf_o_O: make perf.o
                make_no_newt_O: make NO_NEWT=1
                   make_help_O: make help
            make_no_libaudit_O: make NO_LIBAUDIT=1
                 make_static_O: make LDFLAGS=-static
                    make_doc_O: make doc
              make_clean_all_O: make clean all
                  make_debug_O: make DEBUG=1
                make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
           make_no_libunwind_O: make NO_LIBUNWIND=1
           make_no_libbionic_O: make NO_LIBBIONIC=1
           make_no_libpython_O: make NO_LIBPYTHON=1
               make_no_slang_O: make NO_SLANG=1
        make_with_babeltrace_O: make LIBBABELTRACE=1
         make_install_prefix_O: make install prefix=/tmp/krava
                  make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
       make_util_pmu_bison_o_O: make util/pmu-bison.o
            make_no_demangle_O: make NO_DEMANGLE=1
   make_install_prefix_slash_O: make install prefix=/tmp/krava/
  make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
            make_no_auxtrace_O: make NO_AUXTRACE=1
            make_install_bin_O: make install-bin
             make_util_map_o_O: make util/map.o
                   make_tags_O: make tags
              make_no_libbpf_O: make NO_LIBBPF=1
                make_install_O: make install
                make_no_gtk2_O: make NO_GTK2=1
           make_no_backtrace_O: make NO_BACKTRACE=1
         make_with_clangllvm_O: make LIBCLANGLLVM=1
  OK
  make: Leaving directory '/home/acme/git/linux/tools/perf'

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> Test results at the end of this message, as usual.
> 
> The following changes since commit ffa86c2f1a8862cf58c873f6f14d4b2c3250fb48:
> 
>   Merge tag 'perf-core-for-mingo-4.12-20170314' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-03-15 19:27:27 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170316
> 
> for you to fetch changes up to 61f35d750683b21e9e3836e309195c79c1daed74:
> 
>   uprobes: Default UPROBES_EVENTS to Y (2017-03-16 12:42:02 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> New features:
> 
> - Add 'brstackinsn' field in 'perf script' to reuse the x86 instruction
>   decoder used in the Intel PT code to study hot paths to samples (Andi Kleen)
> 
> Kernel:
> 
> - Default UPROBES_EVENTS to Y (Alexei Starovoitov)
> 
> - Fix check for kretprobe offset within function entry (Naveen N. Rao)
> 
> Infrastructure:
> 
> - Introduce util func is_sdt_event() (Ravi Bangoria)
> 
> - Make perf_event__synthesize_mmap_events() scale on older kernels where
>   reading /proc/pid/maps is way slower than reading /proc/pid/task/pid/maps (Stephane Eranian)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Andi Kleen (1):
>       perf script: Add 'brstackinsn' for branch stacks
> 
> Arnaldo Carvalho de Melo (2):
>       tools headers: Sync {tools/,}arch/x86/include/asm/cpufeatures.h
>       uprobes: Default UPROBES_EVENTS to Y
> 
> Naveen N. Rao (1):
>       trace/kprobes: Fix check for kretprobe offset within function entry
> 
> Ravi Bangoria (1):
>       perf probe: Introduce util func is_sdt_event()
> 
> Stephane Eranian (1):
>       perf tools: Make perf_event__synthesize_mmap_events() scale
> 
>  include/linux/kprobes.h                            |   1 +
>  kernel/kprobes.c                                   |  40 ++--
>  kernel/trace/Kconfig                               |   2 +-
>  kernel/trace/trace_kprobe.c                        |   2 +-
>  tools/arch/x86/include/asm/cpufeatures.h           |   5 +-
>  tools/perf/Documentation/perf-script.txt           |  13 +-
>  tools/perf/builtin-script.c                        | 264 ++++++++++++++++++++-
>  tools/perf/util/Build                              |   1 +
>  tools/perf/util/dump-insn.c                        |  14 ++
>  tools/perf/util/dump-insn.h                        |  22 ++
>  tools/perf/util/event.c                            |   4 +-
>  .../util/intel-pt-decoder/intel-pt-insn-decoder.c  |  24 ++
>  tools/perf/util/parse-events.h                     |  20 ++
>  tools/perf/util/probe-event.c                      |   9 +-
>  14 files changed, 381 insertions(+), 40 deletions(-)
>  create mode 100644 tools/perf/util/dump-insn.c
>  create mode 100644 tools/perf/util/dump-insn.h

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit bac2e4a96d1c0bcce5e9654dcc902f75576b9b03:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-08-31 10:25:46 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5:

  perf record: Add ability to name registers to record (2015-08-31 18:01:33 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Add ability to specify to select which registers to record,
  to reduce the size of perf.data files, and also allow printing
  the registers in 'perf script': (Stephane Eranian)

    # perf record --intr-regs=AX,SP usleep 1
    [ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 0.016 MB perf.data (8 samples) ]
    # perf script -F ip,sym,iregs | tail -5
     ffffffff8105f42a native_write_msr_safe   AX:0xf    SP:0xffff8802629c3c00
     ffffffff8105f42a native_write_msr_safe   AX:0xf    SP:0xffff8802629c3c00
     ffffffff81761ac0 _raw_spin_lock   AX:0xffff8801bfcf8020    SP:0xffff8802629c3ce8
     ffffffff81202bf8 __vma_adjust_trans_huge   AX:0x7ffc75200000    SP:0xffff8802629c3b30
     ffffffff8122b089 dput   AX:0x101    SP:0xffff8802629c3c78
    #

Infrastructure:

- Open event on evsel cpus and threads (Kan Liang)

- New bpf API to get name from a BPF object (Wang Nan)

Build fixes:

- Fix build on powerpc broken by pt/bts (Adrian Hunter)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Adrian Hunter (1):
      perf tools: Fix build on powerpc broken by pt/bts

Kan Liang (1):
      perf evlist: Open event on evsel cpus and threads

Stephane Eranian (3):
      perf script: Enable printing of interrupted machine state
      perf/x86: Add list of register names
      perf record: Add ability to name registers to record

Wang Nan (1):
      bpf tools: New API to get name from a BPF object

 tools/lib/bpf/libbpf.c                             | 25 +++++++-
 tools/lib/bpf/libbpf.h                             |  4 +-
 tools/perf/Documentation/perf-record.txt           |  6 +-
 tools/perf/Documentation/perf-script.txt           |  2 +-
 tools/perf/arch/x86/util/Build                     |  1 +
 tools/perf/arch/x86/util/perf_regs.c               | 30 +++++++++
 tools/perf/builtin-record.c                        |  9 ++-
 tools/perf/builtin-script.c                        | 31 +++++++++-
 tools/perf/perf.h                                  |  2 +-
 tools/perf/tests/llvm.c                            |  2 +-
 tools/perf/util/Build                              |  2 +
 tools/perf/util/evlist.c                           |  4 ++
 tools/perf/util/evsel.c                            |  2 +-
 .../util/intel-pt-decoder/intel-pt-insn-decoder.c  |  3 +
 tools/perf/util/parse-regs-options.c               | 71 ++++++++++++++++++++++
 tools/perf/util/parse-regs-options.h               |  5 ++
 tools/perf/util/perf_regs.h                        |  7 +++
 17 files changed, 193 insertions(+), 13 deletions(-)
 create mode 100644 tools/perf/arch/x86/util/perf_regs.c
 create mode 100644 tools/perf/util/parse-regs-options.c
 create mode 100644 tools/perf/util/parse-regs-options.h

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit bac2e4a96d1c0bcce5e9654dcc902f75576b9b03:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-08-31 10:25:46 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5:
> 
>   perf record: Add ability to name registers to record (2015-08-31 18:01:33 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Add ability to specify to select which registers to record,
>   to reduce the size of perf.data files, and also allow printing
>   the registers in 'perf script': (Stephane Eranian)
> 
>     # perf record --intr-regs=AX,SP usleep 1
>     [ perf record: Woken up 1 times to write data ]
>     [ perf record: Captured and wrote 0.016 MB perf.data (8 samples) ]
>     # perf script -F ip,sym,iregs | tail -5
>      ffffffff8105f42a native_write_msr_safe   AX:0xf    SP:0xffff8802629c3c00
>      ffffffff8105f42a native_write_msr_safe   AX:0xf    SP:0xffff8802629c3c00
>      ffffffff81761ac0 _raw_spin_lock   AX:0xffff8801bfcf8020    SP:0xffff8802629c3ce8
>      ffffffff81202bf8 __vma_adjust_trans_huge   AX:0x7ffc75200000    SP:0xffff8802629c3b30
>      ffffffff8122b089 dput   AX:0x101    SP:0xffff8802629c3c78
>     #
> 
> Infrastructure:
> 
> - Open event on evsel cpus and threads (Kan Liang)
> 
> - New bpf API to get name from a BPF object (Wang Nan)
> 
> Build fixes:
> 
> - Fix build on powerpc broken by pt/bts (Adrian Hunter)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Adrian Hunter (1):
>       perf tools: Fix build on powerpc broken by pt/bts
> 
> Kan Liang (1):
>       perf evlist: Open event on evsel cpus and threads
> 
> Stephane Eranian (3):
>       perf script: Enable printing of interrupted machine state
>       perf/x86: Add list of register names
>       perf record: Add ability to name registers to record
> 
> Wang Nan (1):
>       bpf tools: New API to get name from a BPF object
> 
>  tools/lib/bpf/libbpf.c                             | 25 +++++++-
>  tools/lib/bpf/libbpf.h                             |  4 +-
>  tools/perf/Documentation/perf-record.txt           |  6 +-
>  tools/perf/Documentation/perf-script.txt           |  2 +-
>  tools/perf/arch/x86/util/Build                     |  1 +
>  tools/perf/arch/x86/util/perf_regs.c               | 30 +++++++++
>  tools/perf/builtin-record.c                        |  9 ++-
>  tools/perf/builtin-script.c                        | 31 +++++++++-
>  tools/perf/perf.h                                  |  2 +-
>  tools/perf/tests/llvm.c                            |  2 +-
>  tools/perf/util/Build                              |  2 +
>  tools/perf/util/evlist.c                           |  4 ++
>  tools/perf/util/evsel.c                            |  2 +-
>  .../util/intel-pt-decoder/intel-pt-insn-decoder.c  |  3 +
>  tools/perf/util/parse-regs-options.c               | 71 ++++++++++++++++++++++
>  tools/perf/util/parse-regs-options.h               |  5 ++
>  tools/perf/util/perf_regs.h                        |  7 +++
>  17 files changed, 193 insertions(+), 13 deletions(-)
>  create mode 100644 tools/perf/arch/x86/util/perf_regs.c
>  create mode 100644 tools/perf/util/parse-regs-options.c
>  create mode 100644 tools/perf/util/parse-regs-options.h

Pulled into tip:perf/urgent, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider applying.

	One of the next requests probably will have the eBPF work by Wang Nan,
but I am still going thru it and want to test it thoroughly.

	BTW: Have you looked at it lately? It is at:

http://lkml.kernel.org/r/1433144296-74992-1-git-send-email-wangnan0@huawei.com

Super summary from the above cover letter:

---------------------
It enables 'perf record' to filter events using eBPF programs like:

 # perf record --event bpf-file.o sleep 1

Events are selected and filtered according to definitions in bpf-file.o.
---------------------

	The first two patches from that series are in this pull req, as
they just move stuff into tools/include/linux/ from tools/perf/include.

Regards,

- Arnaldo

The following changes since commit 5c9b9bc67c684e40b3a5e7e9facde0fb7200cd8c:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-05-29 20:19:02 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 1f121b03d058dd07199d8924373d3c52a207f63b:

  perf tools: Deal with kernel module names in '[]' correctly (2015-06-03 10:02:38 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Fix 'perf probe' segfault when glob matching function without debuginfo (Wang Nan)

- Remove newline char when reading event scale and unit (Madhavan Srinivasan)

- Deal with kernel module names in '[]' correctly (Wang Nan)

Infrastructure:

- Fix the search for the kernel DSO on the unified list (Arnaldo Carvalho de Melo)

- Move tools/perf/util/include/linux/{kernel.h,list.h,poison.h} to tools/include,
  to be used in tools/lib/bpf/ (Wang Nan)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
      perf machine: Fix the search for the kernel DSO on the unified list

Madhavan Srinivasan (1):
      perf tools: Remove newline char when reading event scale and unit

Wang Nan (4):
      perf probe: Fix segfault when glob matching function without debuginfo
      perf tools: Move linux/kernel.h to tools/include
      tools: Move tools/perf/util/include/linux/{list.h,poison.h} to tools/include
      perf tools: Deal with kernel module names in '[]' correctly

 tools/{perf/util => }/include/linux/kernel.h |  4 +-
 tools/{perf/util => }/include/linux/list.h   |  6 +--
 tools/include/linux/poison.h                 |  1 +
 tools/perf/MANIFEST                          |  3 ++
 tools/perf/tests/kmod-path.c                 | 72 ++++++++++++++++++++++++++++
 tools/perf/util/dso.c                        | 47 ++++++++++++++++--
 tools/perf/util/dso.h                        |  2 +-
 tools/perf/util/header.c                     |  8 ++--
 tools/perf/util/include/linux/poison.h       |  1 -
 tools/perf/util/machine.c                    | 22 ++++++++-
 tools/perf/util/pmu.c                        | 11 ++++-
 tools/perf/util/probe-event.c                | 26 ++++++++--
 12 files changed, 179 insertions(+), 24 deletions(-)
 rename tools/{perf/util => }/include/linux/kernel.h (97%)
 rename tools/{perf/util => }/include/linux/list.h (90%)
 create mode 100644 tools/include/linux/poison.h
 delete mode 100644 tools/perf/util/include/linux/poison.h

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider applying.
> 
> 	One of the next requests probably will have the eBPF work by Wang Nan,
> but I am still going thru it and want to test it thoroughly.
> 
> 	BTW: Have you looked at it lately? It is at:
> 
> http://lkml.kernel.org/r/1433144296-74992-1-git-send-email-wangnan0@huawei.com
> 
> Super summary from the above cover letter:
> 
> ---------------------
> It enables 'perf record' to filter events using eBPF programs like:
> 
>  # perf record --event bpf-file.o sleep 1
> 
> Events are selected and filtered according to definitions in bpf-file.o.

Looks useful, but I think the UI needs one more tweak: could you fix it to be able 
to filter based on the eBPF _source_ file, not just the object file?

People want to tweak such filters as they profile, so we should use the eBPF 
source code as the primary interface. We can compile it internally to the .o just 
fine. The .o file is a totally uninteresting intermediate product in itself.

I.e. we need to first think through such profiling workflows from beginning to end 
before allowing them upstream.

> ---------------------
> 
> 	The first two patches from that series are in this pull req, as
> they just move stuff into tools/include/linux/ from tools/perf/include.
> 
> Regards,
> 
> - Arnaldo
> 
> The following changes since commit 5c9b9bc67c684e40b3a5e7e9facde0fb7200cd8c:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-05-29 20:19:02 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 1f121b03d058dd07199d8924373d3c52a207f63b:
> 
>   perf tools: Deal with kernel module names in '[]' correctly (2015-06-03 10:02:38 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Fix 'perf probe' segfault when glob matching function without debuginfo (Wang Nan)
> 
> - Remove newline char when reading event scale and unit (Madhavan Srinivasan)
> 
> - Deal with kernel module names in '[]' correctly (Wang Nan)
> 
> Infrastructure:
> 
> - Fix the search for the kernel DSO on the unified list (Arnaldo Carvalho de Melo)
> 
> - Move tools/perf/util/include/linux/{kernel.h,list.h,poison.h} to tools/include,
>   to be used in tools/lib/bpf/ (Wang Nan)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf machine: Fix the search for the kernel DSO on the unified list
> 
> Madhavan Srinivasan (1):
>       perf tools: Remove newline char when reading event scale and unit
> 
> Wang Nan (4):
>       perf probe: Fix segfault when glob matching function without debuginfo
>       perf tools: Move linux/kernel.h to tools/include
>       tools: Move tools/perf/util/include/linux/{list.h,poison.h} to tools/include
>       perf tools: Deal with kernel module names in '[]' correctly
> 
>  tools/{perf/util => }/include/linux/kernel.h |  4 +-
>  tools/{perf/util => }/include/linux/list.h   |  6 +--
>  tools/include/linux/poison.h                 |  1 +
>  tools/perf/MANIFEST                          |  3 ++
>  tools/perf/tests/kmod-path.c                 | 72 ++++++++++++++++++++++++++++
>  tools/perf/util/dso.c                        | 47 ++++++++++++++++--
>  tools/perf/util/dso.h                        |  2 +-
>  tools/perf/util/header.c                     |  8 ++--
>  tools/perf/util/include/linux/poison.h       |  1 -
>  tools/perf/util/machine.c                    | 22 ++++++++-
>  tools/perf/util/pmu.c                        | 11 ++++-
>  tools/perf/util/probe-event.c                | 26 ++++++++--
>  12 files changed, 179 insertions(+), 24 deletions(-)
>  rename tools/{perf/util => }/include/linux/kernel.h (97%)
>  rename tools/{perf/util => }/include/linux/list.h (90%)
>  create mode 100644 tools/include/linux/poison.h
>  delete mode 100644 tools/perf/util/include/linux/poison.h

Pulled, thanks a lot Arnaldo!

	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Wangnan (F)]

On 2015/6/4 13:48, Ingo Molnar wrote:
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
>> Hi Ingo,
>>
>> 	Please consider applying.
>>
>> 	One of the next requests probably will have the eBPF work by Wang Nan,
>> but I am still going thru it and want to test it thoroughly.
>>
>> 	BTW: Have you looked at it lately? It is at:
>>
>> http://lkml.kernel.org/r/1433144296-74992-1-git-send-email-wangnan0@huawei.com
>>
>> Super summary from the above cover letter:
>>
>> ---------------------
>> It enables 'perf record' to filter events using eBPF programs like:
>>
>>   # perf record --event bpf-file.o sleep 1
>>
>> Events are selected and filtered according to definitions in bpf-file.o.
> Looks useful, but I think the UI needs one more tweak: could you fix it to be able
> to filter based on the eBPF _source_ file, not just the object file?
>
> People want to tweak such filters as they profile, so we should use the eBPF
> source code as the primary interface. We can compile it internally to the .o just
> fine. The .o file is a totally uninteresting intermediate product in itself.
>
> I.e. we need to first think through such profiling workflows from beginning to end
> before allowing them upstream.

In a private mail Alexei Starovoitov disscussed with me about this. He 
said that he is working
on a shared object which can compile C program into BPF bytecode on the 
fly. After he done his
work, I think perf can support dtrace-like profiling that, users will be 
able to feed source
code to perf directly on cmdline. He said he can release it on June. I 
added him to the CC-list.

However I think the '.o' intermediate is still needed. I'd like to share 
a real profiling
experience using eBPF today, please keep an eye on it. In my experience, 
since we are using C
instead of dtrace, the code piece could be relative complex. Therefore, 
even if perf is able
to compile the C source on the fly, I think user still need to transfer 
the profiling scripts
to the target machine. Therefor, for him, precompiling and do some 
debugging on a high-end server
then transfer it into target machine (like a smartphone) is tolerable, 
and useful for me.

Thank you.

>> ---------------------
>>
>> 	The first two patches from that series are in this pull req, as
>> they just move stuff into tools/include/linux/ from tools/perf/include.
>>
>> Regards,
>>
>> - Arnaldo
>>
>> The following changes since commit 5c9b9bc67c684e40b3a5e7e9facde0fb7200cd8c:
>>
>>    Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-05-29 20:19:02 +0200)
>>
>> are available in the git repository at:
>>
>>    git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>>
>> for you to fetch changes up to 1f121b03d058dd07199d8924373d3c52a207f63b:
>>
>>    perf tools: Deal with kernel module names in '[]' correctly (2015-06-03 10:02:38 -0300)
>>
>> ----------------------------------------------------------------
>> perf/core improvements and fixes:
>>
>> User visible:
>>
>> - Fix 'perf probe' segfault when glob matching function without debuginfo (Wang Nan)
>>
>> - Remove newline char when reading event scale and unit (Madhavan Srinivasan)
>>
>> - Deal with kernel module names in '[]' correctly (Wang Nan)
>>
>> Infrastructure:
>>
>> - Fix the search for the kernel DSO on the unified list (Arnaldo Carvalho de Melo)
>>
>> - Move tools/perf/util/include/linux/{kernel.h,list.h,poison.h} to tools/include,
>>    to be used in tools/lib/bpf/ (Wang Nan)
>>
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>
>> ----------------------------------------------------------------
>> Arnaldo Carvalho de Melo (1):
>>        perf machine: Fix the search for the kernel DSO on the unified list
>>
>> Madhavan Srinivasan (1):
>>        perf tools: Remove newline char when reading event scale and unit
>>
>> Wang Nan (4):
>>        perf probe: Fix segfault when glob matching function without debuginfo
>>        perf tools: Move linux/kernel.h to tools/include
>>        tools: Move tools/perf/util/include/linux/{list.h,poison.h} to tools/include
>>        perf tools: Deal with kernel module names in '[]' correctly
>>
>>   tools/{perf/util => }/include/linux/kernel.h |  4 +-
>>   tools/{perf/util => }/include/linux/list.h   |  6 +--
>>   tools/include/linux/poison.h                 |  1 +
>>   tools/perf/MANIFEST                          |  3 ++
>>   tools/perf/tests/kmod-path.c                 | 72 ++++++++++++++++++++++++++++
>>   tools/perf/util/dso.c                        | 47 ++++++++++++++++--
>>   tools/perf/util/dso.h                        |  2 +-
>>   tools/perf/util/header.c                     |  8 ++--
>>   tools/perf/util/include/linux/poison.h       |  1 -
>>   tools/perf/util/machine.c                    | 22 ++++++++-
>>   tools/perf/util/pmu.c                        | 11 ++++-
>>   tools/perf/util/probe-event.c                | 26 ++++++++--
>>   12 files changed, 179 insertions(+), 24 deletions(-)
>>   rename tools/{perf/util => }/include/linux/kernel.h (97%)
>>   rename tools/{perf/util => }/include/linux/list.h (90%)
>>   create mode 100644 tools/include/linux/poison.h
>>   delete mode 100644 tools/perf/util/include/linux/poison.h
> Pulled, thanks a lot Arnaldo!
>
> 	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Wangnan (F) <wangnan0@huawei.com> wrote:

> On 2015/6/4 13:48, Ingo Molnar wrote:
> >* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> >>Hi Ingo,
> >>
> >>	Please consider applying.
> >>
> >>	One of the next requests probably will have the eBPF work by Wang Nan,
> >>but I am still going thru it and want to test it thoroughly.
> >>
> >>	BTW: Have you looked at it lately? It is at:
> >>
> >>http://lkml.kernel.org/r/1433144296-74992-1-git-send-email-wangnan0@huawei.com
> >>
> >>Super summary from the above cover letter:
> >>
> >>---------------------
> >>It enables 'perf record' to filter events using eBPF programs like:
> >>
> >>  # perf record --event bpf-file.o sleep 1
> >>
> >>Events are selected and filtered according to definitions in bpf-file.o.
> >Looks useful, but I think the UI needs one more tweak: could you fix it to be able
> >to filter based on the eBPF _source_ file, not just the object file?
> >
> >People want to tweak such filters as they profile, so we should use the eBPF
> >source code as the primary interface. We can compile it internally to the .o just
> >fine. The .o file is a totally uninteresting intermediate product in itself.
> >
> >I.e. we need to first think through such profiling workflows from beginning to end
> >before allowing them upstream.
> 
> In a private mail Alexei Starovoitov disscussed with me about this. He said that 
> he is working on a shared object which can compile C program into BPF bytecode 
> on the fly. After he done his work, I think perf can support dtrace-like 
> profiling that, users will be able to feed source code to perf directly on 
> cmdline. He said he can release it on June. I added him to the CC-list.
> 
> However I think the '.o' intermediate is still needed. [...]

So how do you generate the .o? Why cannot the tool, if it sees that the filter 
parameter is eBPF source code, do that automatically?

I.e. you are making the user jump through hoops for no good reason - that's a bad 
UI and a bad workflow. Please don't do that!

Thanks,

	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Wangnan (F)]

On 2015/6/4 15:21, Ingo Molnar wrote:
> * Wangnan (F) <wangnan0@huawei.com> wrote:
>
>> On 2015/6/4 13:48, Ingo Molnar wrote:
>>> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>>>
>>>> Hi Ingo,
>>>>
>>>> 	Please consider applying.
>>>>
>>>> 	One of the next requests probably will have the eBPF work by Wang Nan,
>>>> but I am still going thru it and want to test it thoroughly.
>>>>
>>>> 	BTW: Have you looked at it lately? It is at:
>>>>
>>>> http://lkml.kernel.org/r/1433144296-74992-1-git-send-email-wangnan0@huawei.com
>>>>
>>>> Super summary from the above cover letter:
>>>>
>>>> ---------------------
>>>> It enables 'perf record' to filter events using eBPF programs like:
>>>>
>>>>   # perf record --event bpf-file.o sleep 1
>>>>
>>>> Events are selected and filtered according to definitions in bpf-file.o.
>>> Looks useful, but I think the UI needs one more tweak: could you fix it to be able
>>> to filter based on the eBPF _source_ file, not just the object file?
>>>
>>> People want to tweak such filters as they profile, so we should use the eBPF
>>> source code as the primary interface. We can compile it internally to the .o just
>>> fine. The .o file is a totally uninteresting intermediate product in itself.
>>>
>>> I.e. we need to first think through such profiling workflows from beginning to end
>>> before allowing them upstream.
>> In a private mail Alexei Starovoitov disscussed with me about this. He said that
>> he is working on a shared object which can compile C program into BPF bytecode
>> on the fly. After he done his work, I think perf can support dtrace-like
>> profiling that, users will be able to feed source code to perf directly on
>> cmdline. He said he can release it on June. I added him to the CC-list.
>>
>> However I think the '.o' intermediate is still needed. [...]
> So how do you generate the .o? Why cannot the tool, if it sees that the filter
> parameter is eBPF source code, do that automatically?

I think compiling on the fly is our goal, and Alexei is working on it. 
However,
it looks like some limitations are still exist. For example, the BPF 
program may
require the definition of kernel structure for it to derefrernce struct 
pointers.
Therefore, the machine on which compiling occures should have kernel 
header and
configuration installed. However, most of production environment doesn't 
have
them for security and reasons.

I think BPF should be used to profile not only development environment 
but also
production systems. If we only concern development systems, why not 
recompiling
kernel with stub core or using kProbe modules?

What about this:

Give perf the ability to generate the '.o' file (to memory or dump to a 
real file)
on development environment. If we are willing to profiling that system, 
we can make
load the generated object into kernel and start trace by (perf record 
--event bpf_file.c ...).
If we are willing to profile systems on which the compiling environment 
is missing, we can
make perf to create a '.o' file (perf bpf compile bpf_file.c -o 
bpf_file.o) then copy
it onto target environment, use perf record --event bpf_file.o ... to 
filter events.

Thank you.

> I.e. you are making the user jump through hoops for no good reason - that's a bad
> UI and a bad workflow. Please don't do that!
>
> Thanks,
>
> 	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Wangnan (F) <wangnan0@huawei.com> wrote:

> > So how do you generate the .o? Why cannot the tool, if it sees that the filter 
> > parameter is eBPF source code, do that automatically?
> 
> I think compiling on the fly is our goal, and Alexei is working on it.

So what exact command line are you using to create the .o?

What exactly should users type to create a simple eBPF filter profile?

Thanks,

	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[pi3orama]

发自我的 iPhone

> 在 2015年6月4日，下午8:40，Ingo Molnar <mingo@kernel.org> 写道：
> 
> 
> * Wangnan (F) <wangnan0@huawei.com> wrote:
> 
>>> So how do you generate the .o? Why cannot the tool, if it sees that the filter 
>>> parameter is eBPF source code, do that automatically?
>> 
>> I think compiling on the fly is our goal, and Alexei is working on it.
> 
> So what exact command line are you using to create the .o?
> 
> What exactly should users type to create a simple eBPF filter profile?
> 

I have mentioned in previous mail:

Use

 # perf record -e bpf_source.c cmdline 

 to create a eBPF filter from source,

Use

# perf record -e bpf_object.o cmdline 

to create a eBPF filter from object intermedia.

Use

# perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o

to create the .o

I think this should be enough. Currently only the second case has been implemented.

Thanks.

> Thanks,
> 
>    Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* pi3orama <pi3orama@163.com> wrote:

> 
> 
> 发自我的 iPhone
> 
> > 在 2015年6月4日，下午8:40，Ingo Molnar <mingo@kernel.org> 写道：
> > 
> > 
> > * Wangnan (F) <wangnan0@huawei.com> wrote:
> > 
> >>> So how do you generate the .o? Why cannot the tool, if it sees that the filter 
> >>> parameter is eBPF source code, do that automatically?
> >> 
> >> I think compiling on the fly is our goal, and Alexei is working on it.
> > 
> > So what exact command line are you using to create the .o?
> > 
> > What exactly should users type to create a simple eBPF filter profile?
> 
> I have mentioned in previous mail:
> 
> Use
> 
>  # perf record -e bpf_source.c cmdline 
> 
>  to create a eBPF filter from source,
> 
> Use
> 
> # perf record -e bpf_object.o cmdline 
> 
> to create a eBPF filter from object intermedia.
> 
> Use
> 
> # perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o
> 
> to create the .o
> 
> I think this should be enough. Currently only the second case has been implemented.

So if users cannot actually generate .o files then it's premature to merge this in 
such an incomplete form!

It should be possible to use a feature that we are merging.

Thanks,

	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Alexei Starovoitov]

On 6/4/15 7:04 AM, Ingo Molnar wrote:
>> >  # perf record -e bpf_source.c cmdline
>> >
>> >  to create a eBPF filter from source,
>> >
>> >Use
>> >
>> ># perf record -e bpf_object.o cmdline
>> >
>> >to create a eBPF filter from object intermedia.
>> >
>> >Use
>> >
>> ># perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o
>> >
>> >to create the .o
>> >
>> >I think this should be enough. Currently only the second case has been implemented.
> So if users cannot actually generate .o files then it's premature to merge this in
> such an incomplete form!
>
> It should be possible to use a feature that we are merging.

of course it's usable :) There is some confusion here.
To compile .c into .o one can easily use
clang -O2 -emit-llvm -c file.c -o - | llc -march=bpf -o file.o
any version of clang is ok,
llc needs to be fresh with bpf backend.

For a lot of cases kernel headers are not needed, so above
will work fine.
For our TC examples we recommend to use 'bcc' alias:
bcc() {
   clang -O2 -emit-llvm -c $1 -o - | llc -march=bpf -filetype=obj -o 
"`basename $1 .c`.o"
}
then compiling as easy as 'bcc file.c'

What Wang mentioned that we're working on is fully integrated 'bcc'.
It will use clang/llvm as libraries, so no intermediate steps will
be needed, but some folks will always have concerns about
ultra-embedded environments where even 20Mb of libllvm.so is too much.

So I think we need to support both 'perf record -e file.[co]'

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Masami Hiramatsu]

On 2015/06/05 1:22, Alexei Starovoitov wrote:
> On 6/4/15 7:04 AM, Ingo Molnar wrote:
>>>>  # perf record -e bpf_source.c cmdline
>>>>
>>>>  to create a eBPF filter from source,
>>>>
>>>> Use
>>>>
>>>> # perf record -e bpf_object.o cmdline
>>>>
>>>> to create a eBPF filter from object intermedia.
>>>>
>>>> Use
>>>>
>>>> # perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o
>>>>
>>>> to create the .o
>>>>
>>>> I think this should be enough. Currently only the second case has been implemented.
>> So if users cannot actually generate .o files then it's premature to merge this in
>> such an incomplete form!
>>
>> It should be possible to use a feature that we are merging.
> 
> of course it's usable :) There is some confusion here.
> To compile .c into .o one can easily use
> clang -O2 -emit-llvm -c file.c -o - | llc -march=bpf -o file.o
> any version of clang is ok,
> llc needs to be fresh with bpf backend.
> 
> For a lot of cases kernel headers are not needed, so above
> will work fine.
> For our TC examples we recommend to use 'bcc' alias:
> bcc() {
>    clang -O2 -emit-llvm -c $1 -o - | llc -march=bpf -filetype=obj -o 
> "`basename $1 .c`.o"
> }
> then compiling as easy as 'bcc file.c'
> 
> What Wang mentioned that we're working on is fully integrated 'bcc'.
> It will use clang/llvm as libraries, so no intermediate steps will
> be needed, but some folks will always have concerns about
> ultra-embedded environments where even 20Mb of libllvm.so is too much.
> 
> So I think we need to support both 'perf record -e file.[co]'

I think we'd better make 'perf record -e file.c' default and '-e file.o'
should be an option.

Thank you,

> 
> 


-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Alexei Starovoitov]

On 6/4/15 2:48 PM, Masami Hiramatsu wrote:
> On 2015/06/05 1:22, Alexei Starovoitov wrote:
>> On 6/4/15 7:04 AM, Ingo Molnar wrote:
>>>>>   # perf record -e bpf_source.c cmdline
>>>>>
>>>>>   to create a eBPF filter from source,
>>>>>
>>>>> Use
>>>>>
>>>>> # perf record -e bpf_object.o cmdline
>>>>>
>>>>> to create a eBPF filter from object intermedia.
>>>>>
>>>>> Use
>>>>>
>>>>> # perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o
>>>>>
>>>>> to create the .o
>>>>>
>>>>> I think this should be enough. Currently only the second case has been implemented.
>>> So if users cannot actually generate .o files then it's premature to merge this in
>>> such an incomplete form!
>>>
>>> It should be possible to use a feature that we are merging.
>>
>> of course it's usable :) There is some confusion here.
>> To compile .c into .o one can easily use
>> clang -O2 -emit-llvm -c file.c -o - | llc -march=bpf -o file.o
>> any version of clang is ok,
>> llc needs to be fresh with bpf backend.
>>
>> For a lot of cases kernel headers are not needed, so above
>> will work fine.
>> For our TC examples we recommend to use 'bcc' alias:
>> bcc() {
>>     clang -O2 -emit-llvm -c $1 -o - | llc -march=bpf -filetype=obj -o
>> "`basename $1 .c`.o"
>> }
>> then compiling as easy as 'bcc file.c'
>>
>> What Wang mentioned that we're working on is fully integrated 'bcc'.
>> It will use clang/llvm as libraries, so no intermediate steps will
>> be needed, but some folks will always have concerns about
>> ultra-embedded environments where even 20Mb of libllvm.so is too much.
>>
>> So I think we need to support both 'perf record -e file.[co]'
>
> I think we'd better make 'perf record -e file.c' default and '-e file.o'
> should be an option.

what do you mean 'default' ? It's a command line :)
.c is easier to use of course, no question.

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Alexei Starovoitov <ast@plumgrid.com> wrote:

> On 6/4/15 7:04 AM, Ingo Molnar wrote:
> >>>  # perf record -e bpf_source.c cmdline
> >>>
> >>>  to create a eBPF filter from source,
> >>>
> >>>Use
> >>>
> >>># perf record -e bpf_object.o cmdline
> >>>
> >>>to create a eBPF filter from object intermedia.
> >>>
> >>>Use
> >>>
> >>># perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o
> >>>
> >>>to create the .o
> >>>
> >>>I think this should be enough. Currently only the second case has been implemented.
> >
> > So if users cannot actually generate .o files then it's premature to merge 
> > this in such an incomplete form!
> >
> > It should be possible to use a feature that we are merging.
> 
> of course it's usable :) There is some confusion here.
> To compile .c into .o one can easily use
> clang -O2 -emit-llvm -c file.c -o - | llc -march=bpf -o file.o

There's no confusion here: you guys are trying to sell me what at this stage is 
incomplete and hard to use, and I'm resisting it as I should! :-)

We also have different definitions of 'easily'. It might be 'easy' to type:
 
    clang -O2 -emit-llvm -c file.c -o - | llc -march=bpf -o file.o

... for some tooling developer intimate with eBPF, but to the first time user who 
found an interesting looking eBPF scriptlet on the net or in the documentation and 
wants to try his luck? It's absolutely non-obvious!

The current usage to get a _minimal_ eBPF script running is non-obvious and 
obscure to the level of being a show stopper.

I don't understand why you guys are even wasting time arguing about it: it's not 
that hard to auto-build from source code. It's one of the basic features of 
tooling. If you ever built perf you'll know that typing 'make install' will type 
in all those quirky build lines automatically for you, without requiring you to 
perform any other step, no matter how trivial.

Doubly annoying, you seem to have the UI principles wrong, you seem to think that 
a .o is a proper user interface. It absolutely is _not_ okay.

The Linux kernel project and as an extension the perf project deals with source 
code, and I'm 100% suspicious of approaches that somehow think that .o objects are 
the right UI for _anything_ except temporary files that sometimes show up in 
object directories...

Fix the 'newbie user' UI flow as a _first_ priority, not as a second thought!

Every single quirky line or nonsensical option you require a first time user to 
type halves the number of new users we'll get. You need to understand why dtrace 
is so popular:

   - it's bloody easy to use

   - it's a safe environment you can deploy in critical environments

   - it's flexible

   - instrumentation hacks are very easy to share

eBPF based scripting got 3 out of those 4 right, but please don't forget item 1 
either, because without that we have nothing but a bunch of unusable functionality 
in the kernel and in tooling that benefits only very few people. Okay?

> So I think we need to support both 'perf record -e file.[co]'

Why do you even need to ask? Of course!

Think through how users will meet eBPF scripts and how they will interact with 
them:

  - they'll see or download an eBPF scriptlet somewhere and will have a .c file.

  - ideally there will be built-in eBPF scriptlets just like we have tracing 
    plugins, and there's a good UI to query them and see their description and 
    source code.

  - then they will want to use it all with the minimum amount of fuss

  - they don't care how the eBPF scriptlet gets to the kernel: whether the kernel 
    can read and build the .c files, or whether there's some user tooling that
    turns it into bytecode. Most humans don't read bytecode!

  - they will absolutely not download random .o's and we should not encourage that
    in any case - these things should be source code based.

These things compile in an eye blink, there's very little reason to ever deal with 
a .o, except some weird and rare usecases...

In fact I'm NAK-ing the whole .o based interface until the .c interface is made 
the _primary_ one and works well and until I see that you have thought through 
basic usability questions...

Thanks,

	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Wangnan (F)]

On 2015/6/5 14:41, Ingo Molnar wrote:
> * Alexei Starovoitov <ast@plumgrid.com> wrote:
>
>> On 6/4/15 7:04 AM, Ingo Molnar wrote:
>>>>>   # perf record -e bpf_source.c cmdline
>>>>>
>>>>>   to create a eBPF filter from source,
>>>>>
>>>>> Use
>>>>>
>>>>> # perf record -e bpf_object.o cmdline
>>>>>
>>>>> to create a eBPF filter from object intermedia.
>>>>>
>>>>> Use
>>>>>
>>>>> # perf bpf compile bpf_source.c --kbuild=kernel-build-dir -o bpf_object.o
>>>>>
>>>>> to create the .o
>>>>>
>>>>> I think this should be enough. Currently only the second case has been implemented.
>>> So if users cannot actually generate .o files then it's premature to merge
>>> this in such an incomplete form!
>>>
>>> It should be possible to use a feature that we are merging.
>> of course it's usable :) There is some confusion here.
>> To compile .c into .o one can easily use
>> clang -O2 -emit-llvm -c file.c -o - | llc -march=bpf -o file.o
> There's no confusion here: you guys are trying to sell me what at this stage is
> incomplete and hard to use, and I'm resisting it as I should! :-)
>
> We also have different definitions of 'easily'. It might be 'easy' to type:
>   
>      clang -O2 -emit-llvm -c file.c -o - | llc -march=bpf -o file.o
>
> ... for some tooling developer intimate with eBPF, but to the first time user who
> found an interesting looking eBPF scriptlet on the net or in the documentation and
> wants to try his luck? It's absolutely non-obvious!
>
> The current usage to get a _minimal_ eBPF script running is non-obvious and
> obscure to the level of being a show stopper.
>
> I don't understand why you guys are even wasting time arguing about it: it's not
> that hard to auto-build from source code. It's one of the basic features of
> tooling. If you ever built perf you'll know that typing 'make install' will type
> in all those quirky build lines automatically for you, without requiring you to
> perform any other step, no matter how trivial.
>
> Doubly annoying, you seem to have the UI principles wrong, you seem to think that
> a .o is a proper user interface. It absolutely is _not_ okay.
>
> The Linux kernel project and as an extension the perf project deals with source
> code, and I'm 100% suspicious of approaches that somehow think that .o objects are
> the right UI for _anything_ except temporary files that sometimes show up in
> object directories...
>
> Fix the 'newbie user' UI flow as a _first_ priority, not as a second thought!
>
> Every single quirky line or nonsensical option you require a first time user to
> type halves the number of new users we'll get. You need to understand why dtrace
> is so popular:
>
>     - it's bloody easy to use
>
>     - it's a safe environment you can deploy in critical environments
>
>     - it's flexible
>
>     - instrumentation hacks are very easy to share
>
> eBPF based scripting got 3 out of those 4 right, but please don't forget item 1
> either, because without that we have nothing but a bunch of unusable functionality
> in the kernel and in tooling that benefits only very few people. Okay?
>
>> So I think we need to support both 'perf record -e file.[co]'
> Why do you even need to ask? Of course!
>
> Think through how users will meet eBPF scripts and how they will interact with
> them:
>
>    - they'll see or download an eBPF scriptlet somewhere and will have a .c file.
>
>    - ideally there will be built-in eBPF scriptlets just like we have tracing
>      plugins, and there's a good UI to query them and see their description and
>      source code.
>
>    - then they will want to use it all with the minimum amount of fuss
>
>    - they don't care how the eBPF scriptlet gets to the kernel: whether the kernel
>      can read and build the .c files, or whether there's some user tooling that
>      turns it into bytecode. Most humans don't read bytecode!
>
>    - they will absolutely not download random .o's and we should not encourage that
>      in any case - these things should be source code based.
>
> These things compile in an eye blink, there's very little reason to ever deal with
> a .o, except some weird and rare usecases...
>
> In fact I'm NAK-ing the whole .o based interface until the .c interface is made
> the _primary_ one and works well and until I see that you have thought through
> basic usability questions...

OK. Let's start making a nice UI.

At this stage, what about wrapping current clang and llc workflow into perf,
let it call them to compile '.c' scripts? This is the way 'perf 
annotate' using
objdump. I can do this job, but firstly I'd like to know people's opinion on
it, and the value of the wrapper if Alexei Starovoitov's dynamic compiler
shared object is coming.

Following functions will be added:

  - perf searches clang and llc under current $PATH,

  - Users are allowed to pass the position of those programs,
    if perf failed to find the automatically,

  - Users are allowed to pass extra compiling options to clang and llc, like
    include directories,

  - 'perf record' automatically calls them if a '.c' is passed using 
'--event'.

  - 'perf bpf compile' command will be added to compile a '.c' find into 
'.o',

Further, basic header files should be shipped with kernel headers.

User interface update:

  - --llc, --clang, --llc-opt and --clang-opt option will be added to 
'perf record'
    to indicate the position and extra options to them. Ideally they can 
be leave
    blank.

  - 'perf bpf compile' will be added.

One problem I can find is that, the wrapper will make perf depend on 
llvm. I don't
think the compiler will be deployed in production environments... And 
also, the
embedded case...

Any suggestion? Do you think the above idea is on the right way?

Thanks.

> Thanks,
>
> 	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Wangnan (F) <wangnan0@huawei.com> wrote:

> OK. Let's start making a nice UI.

Thanks!

> [...]
>
> One problem I can find is that, the wrapper will make perf depend on llvm. I 
> don't think the compiler will be deployed in production environments... And 
> also, the embedded case...

What dependencies are there?

On the usage side there should be very few outright dependencies: if the llvm 
binary is not available, or doesn't support what you need, or there's no runtime 
environment you can use to build the bytecode, you should display an informative 
error message so that the user knows what is missing and how to install it.

Thanks,

	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Em Fri, Jun 05, 2015 at 02:05:50PM +0200, Ingo Molnar escreveu:
> * Wangnan (F) <wangnan0@huawei.com> wrote:
<SNIP>
> > One problem I can find is that, the wrapper will make perf depend on llvm. I 
> > don't think the compiler will be deployed in production environments... And 
> > also, the embedded case...
 
> What dependencies are there?
 
> On the usage side there should be very few outright dependencies: if the llvm 
> binary is not available, or doesn't support what you need, or there's no runtime 
> environment you can use to build the bytecode, you should display an informative 
> error message so that the user knows what is missing and how to install it.

Right, something like:

[acme@zoo ~]$ perf trace -e nanosleep usleep 1
Error:	No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
Hint:	Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'
[acme@zoo ~]$ sudo mount -o remount,mode=755 /sys/kernel/debug
[sudo] password for acme: 
[acme@zoo ~]$ perf trace -e nanosleep usleep 1
     0.565 ( 0.060 ms): usleep/17648 nanosleep(rqtp: 0x7fff22baebf0) = 0
[acme@zoo ~]$ perf trace --all-cpus
Error:	Operation not permitted.
Hint:	Check /proc/sys/kernel/perf_event_paranoid setting.
Hint:	For system wide tracing it needs to be set to -1.
Hint:	Try: 'sudo sh -c "echo -1 > /proc/sys/kernel/perf_event_paranoid"'
Hint:	The current value is 1.
[acme@zoo ~]$ 
[acme@zoo ~]$ trace -a -e poll usleep 1
[acme@zoo ~]$ trace -a -e poll usleep 1
 0.041 ( 0.000 ms): firefox/1458  ... [continued]: poll()) = 1
 0.267 ( 0.003 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5) = 0 Timeout
 0.275 ( 0.001 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5) = 0 Timeout
 0.283 ( 0.001 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5) = 0 Timeout
 0.979 ( 0.000 ms): gnome-terminal/2572  ... [continued]: poll()) = 1
 1.056 ( 0.768 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5, timeout_msecs: 4294967295) ...
 1.065 ( 0.009 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 1
 1.087 ( 0.007 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 2
 1.132 ( 0.007 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 1
 1.161 ( 0.013 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 1
[acme@zoo ~]$

I.e. Explain the mistake and provide a hint to solve it, as close to the actual
commands needed to perform such corrective/enabling action as possible.

- Arnaldo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Em Fri, Jun 05, 2015 at 02:05:50PM +0200, Ingo Molnar escreveu:
> > * Wangnan (F) <wangnan0@huawei.com> wrote:
> <SNIP>
> > > One problem I can find is that, the wrapper will make perf depend on llvm. I 
> > > don't think the compiler will be deployed in production environments... And 
> > > also, the embedded case...
>  
> > What dependencies are there?
>  
> > On the usage side there should be very few outright dependencies: if the llvm 
> > binary is not available, or doesn't support what you need, or there's no runtime 
> > environment you can use to build the bytecode, you should display an informative 
> > error message so that the user knows what is missing and how to install it.
> 
> Right, something like:
> 
> [acme@zoo ~]$ perf trace -e nanosleep usleep 1
> Error:	No permissions to read /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
> Hint:	Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'

> [acme@zoo ~]$ sudo mount -o remount,mode=755 /sys/kernel/debug
> [sudo] password for acme: 
> [acme@zoo ~]$ perf trace -e nanosleep usleep 1
>      0.565 ( 0.060 ms): usleep/17648 nanosleep(rqtp: 0x7fff22baebf0) = 0
> [acme@zoo ~]$ perf trace --all-cpus
> Error:	Operation not permitted.
> Hint:	Check /proc/sys/kernel/perf_event_paranoid setting.
> Hint:	For system wide tracing it needs to be set to -1.
> Hint:	Try: 'sudo sh -c "echo -1 > /proc/sys/kernel/perf_event_paranoid"'
> Hint:	The current value is 1.
> [acme@zoo ~]$ 
> [acme@zoo ~]$ trace -a -e poll usleep 1
> [acme@zoo ~]$ trace -a -e poll usleep 1
>  0.041 ( 0.000 ms): firefox/1458  ... [continued]: poll()) = 1
>  0.267 ( 0.003 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5) = 0 Timeout
>  0.275 ( 0.001 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5) = 0 Timeout
>  0.283 ( 0.001 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5) = 0 Timeout
>  0.979 ( 0.000 ms): gnome-terminal/2572  ... [continued]: poll()) = 1
>  1.056 ( 0.768 ms): firefox/1458 poll(ufds: 0x7f43d6ea1340, nfds: 5, timeout_msecs: 4294967295) ...
>  1.065 ( 0.009 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 1
>  1.087 ( 0.007 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 2
>  1.132 ( 0.007 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 1
>  1.161 ( 0.013 ms): gnome-terminal/2572 poll(ufds: 0x1934250, nfds: 23, timeout_msecs: 10) = 1
> [acme@zoo ~]$
> 
> I.e. Explain the mistake and provide a hint to solve it, as close to the actual
> commands needed to perform such corrective/enabling action as possible.

Yeah, I absolutely love such tooling hints.

Thanks,

	Ingo

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Em Fri, Jun 05, 2015 at 04:53:03PM +0800, Wangnan (F) escreveu:
> On 2015/6/5 14:41, Ingo Molnar wrote:
> >* Alexei Starovoitov <ast@plumgrid.com> wrote:
> >>On 6/4/15 7:04 AM, Ingo Molnar wrote:
> >In fact I'm NAK-ing the whole .o based interface until the .c interface is made
> >the _primary_ one and works well and until I see that you have thought through
> >basic usability questions...
 
> OK. Let's start making a nice UI.
 
> At this stage, what about wrapping current clang and llc workflow into perf,
> let it call them to compile '.c' scripts? This is the way 'perf annotate'
> using
> objdump. I can do this job, but firstly I'd like to know people's opinion on

Right, no need for, at a first step, to save this into a cache, or use
libraries, etc, just automate the bpf.c into bpf.o, load it and use it
as an event.

> it, and the value of the wrapper if Alexei Starovoitov's dynamic compiler
> shared object is coming.

No need to wait for that, when it comes we can use it, but Ingo
established as the door for this to be accepted is that we could use:

  perf record -e foo.c usleep

Right?
 
> Following functions will be added:
> 
>  - perf searches clang and llc under current $PATH,

Good for a first step
 
>  - Users are allowed to pass the position of those programs,
>    if perf failed to find the automatically,

I would leave all this configurabilty for later, stating that it has to
be in the PATH should be ok for a first step.
 
>  - Users are allowed to pass extra compiling options to clang and llc, like
>    include directories,

For later too?
 
>  - 'perf record' automatically calls them if a '.c' is passed using
> '--event'.

Right.
 
>  - 'perf bpf compile' command will be added to compile a '.c' find into
> '.o',

for later? I.e. 'perf record -e foo.c usleep' could start by generating
the foo.o and not deleting it, so:

   perf record -e foo.c usleep

Followed by:

   perf record -e foo.o usleep

Would work, the later would be like a quick hack so that we could have
access to a pre-compiled foo.o quickly, at this introductory stage.

> Further, basic header files should be shipped with kernel headers.
> 
> User interface update:
> 
>  - --llc, --clang, --llc-opt and --clang-opt option will be added to 'perf
> record'
>    to indicate the position and extra options to them. Ideally they can be
> leave
>    blank.

Couldn't this be left to a section in a .perfconfig file to avoid having
so many command line options? We could have one of those files per
"project", after we add a --config option to 'perf record', to override
whatever it finds in the config file search it already does, i.e.:

[clang]

  path = /a/b/clang
  opt = -a -b -c -d

[llc]

  path = /d/e/llc
  opt = -r -t -y -u

But even this can be left for a second step.
 
>  - 'perf bpf compile' will be added.

> One problem I can find is that, the wrapper will make perf depend on
> llvm. I don't think the compiler will be deployed in production
> environments... And also, the embedded case...

Well, we can always build a subset of perf, using the command line
options to disable certain features.
 
- Arnaldo

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit ccd41c86ad4d464d0ed4e48d80759ff85c2115b0:

  perf: Fix racy group access (2015-03-27 09:49:45 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 9870d7809575515e26194f4b3df1750872a6ee60:

  perf ordered_samples: Remove references to perf_{evlist,tool} and machines (2015-03-31 17:52:32 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Fix 'perf script' pipe mode segfault, by always initializing ordered_events in
  perf_session__new. (Arnaldo Carvalho de Melo)

- Fix ppid for synthesized fork events (David Ahern)

- Fix kernel symbol resolution of callchains in S/390 by remembering the
  cpumode. (David Hildenbrand)

Infrastructure:

- Disable libbabeltrace check by default in the build system (Jiri Olsa)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
      perf session: Always initialize ordered_events
      perf ordered_samples: Remove references to perf_{evlist,tool} and machines

David Ahern (2):
      perf tools: Refactor comm/tgid lookup
      perf tools: Fix ppid for synthesized fork events

David Hildenbrand (1):
      perf callchain: Fix kernel symbol resolution by remembering the cpumode

Jiri Olsa (1):
      perf build: Disable libbabeltrace check by default

 tools/perf/Makefile.perf         |   2 +-
 tools/perf/config/Makefile       |   5 +-
 tools/perf/util/event.c          | 147 ++++++++++++++++++++++++---------------
 tools/perf/util/event.h          |   1 -
 tools/perf/util/machine.c        |  28 ++++----
 tools/perf/util/ordered-events.c |  21 ++----
 tools/perf/util/ordered-events.h |  14 +---
 tools/perf/util/session.c        |  48 ++++++++-----
 tools/perf/util/session.h        |   1 +
 9 files changed, 144 insertions(+), 123 deletions(-)

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit ccd41c86ad4d464d0ed4e48d80759ff85c2115b0:
> 
>   perf: Fix racy group access (2015-03-27 09:49:45 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 9870d7809575515e26194f4b3df1750872a6ee60:
> 
>   perf ordered_samples: Remove references to perf_{evlist,tool} and machines (2015-03-31 17:52:32 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Fix 'perf script' pipe mode segfault, by always initializing ordered_events in
>   perf_session__new. (Arnaldo Carvalho de Melo)
> 
> - Fix ppid for synthesized fork events (David Ahern)
> 
> - Fix kernel symbol resolution of callchains in S/390 by remembering the
>   cpumode. (David Hildenbrand)
> 
> Infrastructure:
> 
> - Disable libbabeltrace check by default in the build system (Jiri Olsa)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
>       perf session: Always initialize ordered_events
>       perf ordered_samples: Remove references to perf_{evlist,tool} and machines
> 
> David Ahern (2):
>       perf tools: Refactor comm/tgid lookup
>       perf tools: Fix ppid for synthesized fork events
> 
> David Hildenbrand (1):
>       perf callchain: Fix kernel symbol resolution by remembering the cpumode
> 
> Jiri Olsa (1):
>       perf build: Disable libbabeltrace check by default
> 
>  tools/perf/Makefile.perf         |   2 +-
>  tools/perf/config/Makefile       |   5 +-
>  tools/perf/util/event.c          | 147 ++++++++++++++++++++++++---------------
>  tools/perf/util/event.h          |   1 -
>  tools/perf/util/machine.c        |  28 ++++----
>  tools/perf/util/ordered-events.c |  21 ++----
>  tools/perf/util/ordered-events.h |  14 +---
>  tools/perf/util/session.c        |  48 ++++++++-----
>  tools/perf/util/session.h        |   1 +
>  9 files changed, 144 insertions(+), 123 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/6] perf/core improvements and fixes

[Jiri Olsa]

hi Ingo,
please consider pulling

thanks,
jirka


The following changes since commit 3e46d21285577a8c9e4c37f9b1002e567c440b28:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-05-05 19:37:51 +0200)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo

for you to fetch changes up to 13ce34df11833482cd698331fdbb3f8ced06340d:

  perf tools: Use tid for finding thread (2014-05-12 11:09:50 +0200)

----------------------------------------------------------------
perf/core improvements and fixes:

. Propagate exit status of a command line workload for
  record command (Namhyung Kim)

. Use tid for finding thread (Namhyung Kim)

. Clarify the output of perf sched map plus small sched
  command fixies (Dongsheng Yang)

Signed-off-by: Jiri Olsa <jolsa@kernel.org>

----------------------------------------------------------------
Dongsheng (3):
      perf tools: Add missing event for perf sched record.
      perf tools: Adapt the TASK_STATE_TO_CHAR_STR to new value in kernel space.
      perf tools: Clarify the output of perf sched map.

Namhyung Kim (3):
      perf record: Propagate exit status of a command line workload
      perf tools: Get rid of on_exit() feature test
      perf tools: Use tid for finding thread

 tools/perf/builtin-inject.c                     |   2 +-
 tools/perf/builtin-kmem.c                       |   2 +-
 tools/perf/builtin-record.c                     | 158 +++++++++---------------
 tools/perf/builtin-sched.c                      |  38 +++---
 tools/perf/config/Makefile                      |   8 --
 tools/perf/config/feature-checks/Makefile       |   4 -
 tools/perf/config/feature-checks/test-all.c     |   5 -
 tools/perf/config/feature-checks/test-on-exit.c |  16 ---
 tools/perf/tests/code-reading.c                 |   2 +-
 tools/perf/tests/hists_filter.c                 |   1 +
 tools/perf/tests/hists_link.c                   |   2 +
 tools/perf/util/build-id.c                      |   2 +-
 tools/perf/util/event.c                         |   2 +-
 13 files changed, 90 insertions(+), 152 deletions(-)
 delete mode 100644 tools/perf/config/feature-checks/test-on-exit.c

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@kernel.org> wrote:

> hi Ingo,
> please consider pulling
> 
> thanks,
> jirka
> 
> 
> The following changes since commit 3e46d21285577a8c9e4c37f9b1002e567c440b28:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-05-05 19:37:51 +0200)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 13ce34df11833482cd698331fdbb3f8ced06340d:
> 
>   perf tools: Use tid for finding thread (2014-05-12 11:09:50 +0200)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> . Propagate exit status of a command line workload for
>   record command (Namhyung Kim)
> 
> . Use tid for finding thread (Namhyung Kim)
> 
> . Clarify the output of perf sched map plus small sched
>   command fixies (Dongsheng Yang)
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> 
> ----------------------------------------------------------------
> Dongsheng (3):
>       perf tools: Add missing event for perf sched record.
>       perf tools: Adapt the TASK_STATE_TO_CHAR_STR to new value in kernel space.
>       perf tools: Clarify the output of perf sched map.
> 
> Namhyung Kim (3):
>       perf record: Propagate exit status of a command line workload
>       perf tools: Get rid of on_exit() feature test
>       perf tools: Use tid for finding thread
> 
>  tools/perf/builtin-inject.c                     |   2 +-
>  tools/perf/builtin-kmem.c                       |   2 +-
>  tools/perf/builtin-record.c                     | 158 +++++++++---------------
>  tools/perf/builtin-sched.c                      |  38 +++---
>  tools/perf/config/Makefile                      |   8 --
>  tools/perf/config/feature-checks/Makefile       |   4 -
>  tools/perf/config/feature-checks/test-all.c     |   5 -
>  tools/perf/config/feature-checks/test-on-exit.c |  16 ---
>  tools/perf/tests/code-reading.c                 |   2 +-
>  tools/perf/tests/hists_filter.c                 |   1 +
>  tools/perf/tests/hists_link.c                   |   2 +
>  tools/perf/util/build-id.c                      |   2 +-
>  tools/perf/util/event.c                         |   2 +-
>  13 files changed, 90 insertions(+), 152 deletions(-)
>  delete mode 100644 tools/perf/config/feature-checks/test-on-exit.c

Pulled, thanks a lot Jiri!

	Ingo

[GIT PULL 0/6] perf/core improvements and fixes

[Jiri Olsa]

hi Ingo,
please consider pulling

resending 0/6.. it got lost somehow from previous post..

thanks,
jirka


The following changes since commit 201131998fbf074b03679afedcc29948e63331ef:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-04-29 08:41:21 +0200)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo

for you to fetch changes up to 8ab596afb97bc9e2f9140dc1d993e81749acff42:

  perf tools ARM64: Wire up perf_regs and unwind support (2014-04-29 15:31:19 +0200)

----------------------------------------------------------------
perf/core improvements and fixes:

. Wire up perf_regs and unwind support for ARM64 (Jean Pihet)

. Move u64_swap union to its single user's header, evsel.h (Borislav Petkov)

. Fix for s390 to properly parse tracepoints plus test code (Alexander Yarygin)

. Handle EINTR error for readn/writen (Namhyung Kim)

Signed-off-by: Jiri Olsa <jolsa@kernel.org>

----------------------------------------------------------------
Alexander Yarygin (3):
      perf tools: Parse tracepoints with '-' in system name
      perf tests: Add numeric identifier to evlist_test
      perf tests: Add a test of kvm-390: trace event

Borislav Petkov (1):
      perf tools: Move u64_swap union

Jean Pihet (1):
      perf tools ARM64: Wire up perf_regs and unwind support

Namhyung Kim (1):
      perf tools: Handle EINTR error for readn/writen

 tools/perf/arch/arm64/Makefile                |   7 ++
 tools/perf/arch/arm64/include/perf_regs.h     |  88 ++++++++++++++++
 tools/perf/arch/arm64/util/dwarf-regs.c       |  80 +++++++++++++++
 tools/perf/arch/arm64/util/unwind-libunwind.c |  82 +++++++++++++++
 tools/perf/config/Makefile                    |   8 +-
 tools/perf/tests/parse-events.c               | 142 ++++++++++++++++++--------
 tools/perf/util/evsel.h                       |   5 +
 tools/perf/util/parse-events.y                |  12 +++
 tools/perf/util/types.h                       |   5 -
 tools/perf/util/util.c                        |   2 +
 10 files changed, 380 insertions(+), 51 deletions(-)
 create mode 100644 tools/perf/arch/arm64/Makefile
 create mode 100644 tools/perf/arch/arm64/include/perf_regs.h
 create mode 100644 tools/perf/arch/arm64/util/dwarf-regs.c
 create mode 100644 tools/perf/arch/arm64/util/unwind-libunwind.c

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@kernel.org> wrote:

> hi Ingo,
> please consider pulling
> 
> resending 0/6.. it got lost somehow from previous post..
> 
> thanks,
> jirka
> 
> 
> The following changes since commit 201131998fbf074b03679afedcc29948e63331ef:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-04-29 08:41:21 +0200)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 8ab596afb97bc9e2f9140dc1d993e81749acff42:
> 
>   perf tools ARM64: Wire up perf_regs and unwind support (2014-04-29 15:31:19 +0200)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> . Wire up perf_regs and unwind support for ARM64 (Jean Pihet)
> 
> . Move u64_swap union to its single user's header, evsel.h (Borislav Petkov)
> 
> . Fix for s390 to properly parse tracepoints plus test code (Alexander Yarygin)
> 
> . Handle EINTR error for readn/writen (Namhyung Kim)
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> 
> ----------------------------------------------------------------
> Alexander Yarygin (3):
>       perf tools: Parse tracepoints with '-' in system name
>       perf tests: Add numeric identifier to evlist_test
>       perf tests: Add a test of kvm-390: trace event
> 
> Borislav Petkov (1):
>       perf tools: Move u64_swap union
> 
> Jean Pihet (1):
>       perf tools ARM64: Wire up perf_regs and unwind support
> 
> Namhyung Kim (1):
>       perf tools: Handle EINTR error for readn/writen
> 
>  tools/perf/arch/arm64/Makefile                |   7 ++
>  tools/perf/arch/arm64/include/perf_regs.h     |  88 ++++++++++++++++
>  tools/perf/arch/arm64/util/dwarf-regs.c       |  80 +++++++++++++++
>  tools/perf/arch/arm64/util/unwind-libunwind.c |  82 +++++++++++++++
>  tools/perf/config/Makefile                    |   8 +-
>  tools/perf/tests/parse-events.c               | 142 ++++++++++++++++++--------
>  tools/perf/util/evsel.h                       |   5 +
>  tools/perf/util/parse-events.y                |  12 +++
>  tools/perf/util/types.h                       |   5 -
>  tools/perf/util/util.c                        |   2 +
>  10 files changed, 380 insertions(+), 51 deletions(-)
>  create mode 100644 tools/perf/arch/arm64/Makefile
>  create mode 100644 tools/perf/arch/arm64/include/perf_regs.h
>  create mode 100644 tools/perf/arch/arm64/util/dwarf-regs.c
>  create mode 100644 tools/perf/arch/arm64/util/unwind-libunwind.c

Pulled, thanks a lot Jiri!

I also merged perf/urgent into perf/core, because a conflict developed 
between the two.

Thanks,

	Ingo

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 95d18aa2b6c05351181934b3bc34ce038cc7b637:

  perf/x86: Fix sparse warnings (2012-10-30 10:10:52 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to ffadcf090d468e9c4938b718649f38dd10cfdb02:

  perf annotate: Handle XBEGIN like a jump (2012-10-31 12:18:26 -0200)

----------------------------------------------------------------
perf/core improvements and fixes

. Handle XBEGIN like a jump in the annotate browser, from Andi Kleen

. Build speedups for --version, from Ingo Molnar.

. Add info about cross compiling for Android ARM, from Joonsoo Kim.

. Warn about missing libelf, from Namhyung Kim.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf annotate: Handle XBEGIN like a jump

Arnaldo Carvalho de Melo (1):
      perf tools: Handle --version string generation on machines without git

Ingo Molnar (2):
      perf tools: Speed up the perf build time by simplifying the perf --version string generation
      perf tools: Further speed up the perf build

Joonsoo Kim (1):
      perf tools: Add info about cross compiling for Android ARM

Namhyung Kim (1):
      perf tools: Warn about missing libelf

 tools/perf/Documentation/android.txt |    5 ++++-
 tools/perf/Makefile                  |    2 ++
 tools/perf/util/PERF-VERSION-GEN     |   14 +++++---------
 tools/perf/util/annotate.c           |    2 ++
 4 files changed, 13 insertions(+), 10 deletions(-)

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (1):
  perf symbols: Give more useful names to 'self' parameters

Arun Sharma (1):
  perf script: Add support for PERF_TYPE_RAW

Michael Witten (4):
  perf tools: Makefile: Clean up `python/perf.so' rule
  perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility
  perf tools: Move `try-cc'
  perf tools: git mv tools/perf/{features-tests.mak,config/}

 tools/perf/Makefile                 |  107 +++++--
 tools/perf/builtin-script.c         |   14 +-
 tools/perf/config/feature-tests.mak |  128 +++++++
 tools/perf/config/utilities.mak     |  188 +++++++++++
 tools/perf/feature-tests.mak        |  130 -------
 tools/perf/util/symbol.c            |  629 ++++++++++++++++++-----------------
 tools/perf/util/symbol.h            |   78 +++--
 7 files changed, 771 insertions(+), 503 deletions(-)
 create mode 100644 tools/perf/config/feature-tests.mak
 create mode 100644 tools/perf/config/utilities.mak
 delete mode 100644 tools/perf/feature-tests.mak

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (1):
>   perf symbols: Give more useful names to 'self' parameters
> 
> Arun Sharma (1):
>   perf script: Add support for PERF_TYPE_RAW
> 
> Michael Witten (4):
>   perf tools: Makefile: Clean up `python/perf.so' rule
>   perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility
>   perf tools: Move `try-cc'
>   perf tools: git mv tools/perf/{features-tests.mak,config/}
> 
>  tools/perf/Makefile                 |  107 +++++--
>  tools/perf/builtin-script.c         |   14 +-
>  tools/perf/config/feature-tests.mak |  128 +++++++
>  tools/perf/config/utilities.mak     |  188 +++++++++++
>  tools/perf/feature-tests.mak        |  130 -------
>  tools/perf/util/symbol.c            |  629 ++++++++++++++++++-----------------
>  tools/perf/util/symbol.h            |   78 +++--
>  7 files changed, 771 insertions(+), 503 deletions(-)
>  create mode 100644 tools/perf/config/feature-tests.mak
>  create mode 100644 tools/perf/config/utilities.mak
>  delete mode 100644 tools/perf/feature-tests.mak

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 0/6] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (3):
  perf ui: Serialize screen updates
  perf annotate: Check if offset is less than symbol size
  perf annotate browser: Use the percent color for the whole line

Jesse Brandeburg (1):
  perf tools: Update Makefile with some help

Masami Hiramatsu (2):
  perf probe: Support function@filename syntax for --line
  perf probe: Show filename which contains target function

 tools/perf/Documentation/Makefile       |   19 ++++++++++---------
 tools/perf/Documentation/perf-probe.txt |    7 ++++---
 tools/perf/Makefile                     |   31 +++++++++++++++++++++++++++++++
 tools/perf/util/annotate.c              |    3 ++-
 tools/perf/util/probe-event.c           |   17 +++++++++++++----
 tools/perf/util/ui/browser.c            |    7 +++++++
 tools/perf/util/ui/browsers/annotate.c  |    5 +++--
 tools/perf/util/ui/helpline.c           |    5 ++++-
 tools/perf/util/ui/setup.c              |    3 +++
 tools/perf/util/ui/ui.h                 |    8 ++++++++
 10 files changed, 85 insertions(+), 20 deletions(-)
 create mode 100644 tools/perf/util/ui/ui.h

Re: [GIT PULL 0/6] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (3):
>   perf ui: Serialize screen updates
>   perf annotate: Check if offset is less than symbol size
>   perf annotate browser: Use the percent color for the whole line
> 
> Jesse Brandeburg (1):
>   perf tools: Update Makefile with some help
> 
> Masami Hiramatsu (2):
>   perf probe: Support function@filename syntax for --line
>   perf probe: Show filename which contains target function
> 
>  tools/perf/Documentation/Makefile       |   19 ++++++++++---------
>  tools/perf/Documentation/perf-probe.txt |    7 ++++---
>  tools/perf/Makefile                     |   31 +++++++++++++++++++++++++++++++
>  tools/perf/util/annotate.c              |    3 ++-
>  tools/perf/util/probe-event.c           |   17 +++++++++++++----
>  tools/perf/util/ui/browser.c            |    7 +++++++
>  tools/perf/util/ui/browsers/annotate.c  |    5 +++--
>  tools/perf/util/ui/helpline.c           |    5 ++++-
>  tools/perf/util/ui/setup.c              |    3 +++
>  tools/perf/util/ui/ui.h                 |    8 ++++++++
>  10 files changed, 85 insertions(+), 20 deletions(-)
>  create mode 100644 tools/perf/util/ui/ui.h

Pulled, thanks a lot Arnaldo!

	Ingo