All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Santiago Gala" <sgala@apache.org>,
	"Yunkang Tang" <yunkang.tang@cn.alps.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ALPS - fix max coordinates for v5 and v7 protocols
Date: Tue, 31 Mar 2015 06:47:31 +0300	[thread overview]
Message-ID: <1427773651.2999.2.camel@coelho.fi> (raw)
In-Reply-To: <20150322033656.GA35352@dtor-ws>

On Sat, 2015-03-21 at 20:36 -0700, Dmitry Torokhov wrote:
> Commit 3296f71cd2fde7a2ad52e66a27eae419f6328066 ("Input: ALPS - consolidate
> setting protocol parameters") inadvertently moved call to
> alps_dolphin_get_device_area() from v5 to v7 protocol, causing both
> protocols report incorrect maximum values for X and Y axes which resulted
> in crash in Synaptics X driver.
> 
> Reported-by: Santiago Gala <sgala@apache.org>
> Reported-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

Tested-by: Luciano Coelho <luca@coelho.fi>

Tested on a Dell E5250.

Are you planning to send this to 4.0-rc*? That would be nice, since this
is a regression from 3.19.

--
Cheers,
Luca.


WARNING: multiple messages have this Message-ID (diff)
From: Luca Coelho <luca@coelho.fi>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Santiago Gala" <sgala@apache.org>,
	"Yunkang Tang" <yunkang.tang@cn.alps.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ALPS - fix max coordinates for v5 and v7 protocols
Date: Tue, 31 Mar 2015 06:47:31 +0300	[thread overview]
Message-ID: <1427773651.2999.2.camel@coelho.fi> (raw)
In-Reply-To: <20150322033656.GA35352@dtor-ws>

On Sat, 2015-03-21 at 20:36 -0700, Dmitry Torokhov wrote:
> Commit 3296f71cd2fde7a2ad52e66a27eae419f6328066 ("Input: ALPS - consolidate
> setting protocol parameters") inadvertently moved call to
> alps_dolphin_get_device_area() from v5 to v7 protocol, causing both
> protocols report incorrect maximum values for X and Y axes which resulted
> in crash in Synaptics X driver.
> 
> Reported-by: Santiago Gala <sgala@apache.org>
> Reported-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

Tested-by: Luciano Coelho <luca@coelho.fi>

Tested on a Dell E5250.

Are you planning to send this to 4.0-rc*? That would be nice, since this
is a regression from 3.19.

--
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-03-31  4:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22  3:36 [PATCH] Input: ALPS - fix max coordinates for v5 and v7 protocols Dmitry Torokhov
2015-03-22  3:36 ` Dmitry Torokhov
2015-03-22 10:48 ` Hans de Goede
2015-03-22 10:48   ` Hans de Goede
2015-03-22 12:33   ` Pali Rohár
2015-03-31  3:47 ` Luca Coelho [this message]
2015-03-31  3:47   ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427773651.2999.2.camel@coelho.fi \
    --to=luca@coelho.fi \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sgala@apache.org \
    --cc=yunkang.tang@cn.alps.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.