From: Paul Bolle <pebolle@tiscali.nl>
To: Andrew Bresticker <abrestic@chromium.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux-MIPS <linux-mips@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
James Hartley <james.hartley@imgtec.com>,
James Hogan <james.hogan@imgtec.com>,
Damien Horsley <Damien.Horsley@imgtec.com>,
Govindraj Raja <govindraj.raja@imgtec.com>,
Kevin Cernekee <cernekee@chromium.org>
Subject: Re: [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver
Date: Tue, 31 Mar 2015 20:55:08 +0200 [thread overview]
Message-ID: <1427828108.2408.73.camel@x220> (raw)
In-Reply-To: <CAL1qeaHg2oLbnxCmk_TaxRMYA6vM8cfgUeLk=i7Q5b1CJfS9LQ@mail.gmail.com>
Hi Andrew,
On Tue, 2015-03-31 at 11:37 -0700, Andrew Bresticker wrote:
> I have no immediate plans to make this a module, but since the changes
> to make it buildable as a module have no overhead (at least I think
> they don't!) I'd prefer to leave them in for consistency and to
> eliminate any need for these changes in the future.
The people reading the code or reviewing the patch might wonder, just
like I did, about the mismatch between the code and the Kconfig symbol.
Dead code - even if it's easily dealt with during the build - shouldn't
be added without a clear benefit. And I don't think consistency or doing
now what might be done in the future bring enough benefits.
> I'll leave it up to LinusW though.
Right, it's Linus decision.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-03-31 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 23:16 [PATCH V2 0/3] pinctrl: Support for IMG Pistachio Andrew Bresticker
2015-03-30 23:16 ` [PATCH V2 1/3] pinctrl: Document "function" + "pins" pinmux binding Andrew Bresticker
2015-04-07 13:20 ` Linus Walleij
2015-03-30 23:16 ` [PATCH V2 2/3] pinctrl: Add Pistachio SoC pin control binding document Andrew Bresticker
2015-03-30 23:16 ` [PATCH V2 3/3] pinctrl: Add Pistachio SoC pin control driver Andrew Bresticker
2015-03-31 8:10 ` Paul Bolle
2015-03-31 16:56 ` Andrew Bresticker
2015-03-31 18:20 ` Paul Bolle
2015-03-31 18:37 ` Andrew Bresticker
2015-03-31 18:55 ` Paul Bolle [this message]
2015-04-07 14:13 ` Linus Walleij
2015-03-31 14:00 ` [PATCH V2 0/3] pinctrl: Support for IMG Pistachio Ralf Baechle
2015-03-31 17:20 ` Andrew Bresticker
2015-04-07 13:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427828108.2408.73.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=Damien.Horsley@imgtec.com \
--cc=abrestic@chromium.org \
--cc=cernekee@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@imgtec.com \
--cc=gnurou@gmail.com \
--cc=govindraj.raja@imgtec.com \
--cc=james.hartley@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.