All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Subject: [PATCH 6/6] drm/i915: Don't use staged config in intel_mst_pre_enable_dp()
Date: Thu,  2 Apr 2015 14:48:01 +0300	[thread overview]
Message-ID: <1427975281-7688-7-git-send-email-ander.conselvan.de.oliveira@intel.com> (raw)
In-Reply-To: <1427975281-7688-1-git-send-email-ander.conselvan.de.oliveira@intel.com>

For the conversion to atomic. The pre_enable() hooks are called as part
of the crtc enable sequence, at which point the staged config was
already made effective. Furthermore, the function actually changes
hardware state, so it should anyway deal with current and not staged
config.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
 drivers/gpu/drm/i915/intel_dp_mst.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
index 5329c85..adcc5e6 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -150,14 +150,14 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder)
 	enum port port = intel_dig_port->port;
 	int ret;
 	uint32_t temp;
-	struct intel_connector *found = NULL, *intel_connector;
+	struct intel_connector *found = NULL, *connector;
 	int slots;
 	struct drm_crtc *crtc = encoder->base.crtc;
 	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
 
-	for_each_intel_connector(dev, intel_connector) {
-		if (intel_connector->new_encoder == encoder) {
-			found = intel_connector;
+	for_each_intel_connector(dev, connector) {
+		if (connector->base.state->best_encoder == &encoder->base) {
+			found = connector;
 			break;
 		}
 	}
-- 
2.1.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-04-02 11:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 11:47 [PATCH 0/6] Remove more staged config usage Ander Conselvan de Oliveira
2015-04-02 11:47 ` [PATCH 1/6] drm/i915: Don't use staged config for VLV cdclk calculations Ander Conselvan de Oliveira
2015-04-07  9:16   ` Daniel Vetter
2015-04-02 11:47 ` [PATCH 2/6] drm/i915: Don't use intel_crtc->new_config in pll calculation code Ander Conselvan de Oliveira
2015-04-07  9:22   ` Daniel Vetter
2015-04-02 11:47 ` [PATCH 3/6] drm/i915: Remove intel_crtc->new_config Ander Conselvan de Oliveira
2015-04-02 11:47 ` [PATCH 4/6] drm/i915: Don't use staged config in check_digital_port_conflicts() Ander Conselvan de Oliveira
2015-04-07  9:25   ` Daniel Vetter
2015-04-02 11:48 ` [PATCH 5/6] drm/i915: Don't use staged config in check_encoder_cloning() Ander Conselvan de Oliveira
2015-04-02 11:48 ` Ander Conselvan de Oliveira [this message]
2015-04-07  9:26 ` [PATCH 0/6] Remove more staged config usage Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427975281-7688-7-git-send-email-ander.conselvan.de.oliveira@intel.com \
    --to=ander.conselvan.de.oliveira@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.