From: Daniel Vetter <daniel@ffwll.ch>
To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/i915: Don't use staged config for VLV cdclk calculations
Date: Tue, 7 Apr 2015 11:16:02 +0200 [thread overview]
Message-ID: <20150407091602.GB6354@phenom.ffwll.local> (raw)
In-Reply-To: <1427975281-7688-2-git-send-email-ander.conselvan.de.oliveira@intel.com>
On Thu, Apr 02, 2015 at 02:47:56PM +0300, Ander Conselvan de Oliveira wrote:
> -static void valleyview_modeset_global_pipes(struct drm_device *dev,
> +static int valleyview_modeset_global_pipes(struct drm_atomic_state *state,
> unsigned *prepare_pipes)
> {
> - struct drm_i915_private *dev_priv = dev->dev_private;
> + struct drm_i915_private *dev_priv = to_i915(state->dev);
> struct intel_crtc *intel_crtc;
> - int max_pixclk = intel_mode_max_pixclk(dev_priv);
> + int max_pixclk = intel_mode_max_pixclk(state);
> +
> + if (max_pixclk < 0)
> + return max_pixclk;
>
> if (valleyview_calc_cdclk(dev_priv, max_pixclk) ==
> dev_priv->vlv_cdclk_freq)
We need to move the current cdclk_freq into the global state like the
shared pll state. But that's for another patch series, can you please make
a note about it to make sure we don't forget?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-07 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 11:47 [PATCH 0/6] Remove more staged config usage Ander Conselvan de Oliveira
2015-04-02 11:47 ` [PATCH 1/6] drm/i915: Don't use staged config for VLV cdclk calculations Ander Conselvan de Oliveira
2015-04-07 9:16 ` Daniel Vetter [this message]
2015-04-02 11:47 ` [PATCH 2/6] drm/i915: Don't use intel_crtc->new_config in pll calculation code Ander Conselvan de Oliveira
2015-04-07 9:22 ` Daniel Vetter
2015-04-02 11:47 ` [PATCH 3/6] drm/i915: Remove intel_crtc->new_config Ander Conselvan de Oliveira
2015-04-02 11:47 ` [PATCH 4/6] drm/i915: Don't use staged config in check_digital_port_conflicts() Ander Conselvan de Oliveira
2015-04-07 9:25 ` Daniel Vetter
2015-04-02 11:48 ` [PATCH 5/6] drm/i915: Don't use staged config in check_encoder_cloning() Ander Conselvan de Oliveira
2015-04-02 11:48 ` [PATCH 6/6] drm/i915: Don't use staged config in intel_mst_pre_enable_dp() Ander Conselvan de Oliveira
2015-04-07 9:26 ` [PATCH 0/6] Remove more staged config usage Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407091602.GB6354@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ander.conselvan.de.oliveira@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.