From: Benjamin Herrenschmidt <benh@kernel.crashing.org> To: Sowmini Varadhan <sowmini.varadhan@oracle.com> Cc: aik@au1.ibm.com, anton@au1.ibm.com, paulus@samba.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Subject: Re: [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Date: Thu, 02 Apr 2015 22:19:36 +0000 [thread overview] Message-ID: <1428013176.20500.285.camel@kernel.crashing.org> (raw) In-Reply-To: <20150402221505.GD15680@oracle.com> On Thu, 2015-04-02 at 18:15 -0400, Sowmini Varadhan wrote: > On (04/03/15 08:57), Benjamin Herrenschmidt wrote: > > > > > > I only just noticed too, you completely dropped the code to honor > > > > the dma mask. Why that ? Some devices rely on this. > > /* Sowmini's comment about this coming from sparc origins.. */ > > > Probably, not that many devices have limits on DMA mask but they do > > exist. It becomes more important if we decide to create a very large > > IOMMU window that spans beyond 4G in order to support devices with > > 32-bit DMA masks. Otherwise it's older devices mostly with <32-bit > > masks. > > > > In any case, for a generic piece of code, this should be supported. > > Basically, assume that if we have something in the powerpc code, we need > > it, if you remove it, we won't be able to use your code generically. > > I see. > > is the mask something that can be stored in the iommu_map_table as > part of the init? > No, the mask is per device and has to be retrieved from the device. Additionally the mask used for dma_map_* can be different from the consistent mask used for alloc_coherent (we have a bug there on powerpc which I'm trying to fix btw). So it should be passed as an argument by the caller. > I can see that the align_order has to be an additional arg to > iommu_tbl_range_alloc, not sure if mask falls in that category > as well. It does. Cheers, Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> To: Sowmini Varadhan <sowmini.varadhan@oracle.com> Cc: aik@au1.ibm.com, anton@au1.ibm.com, paulus@samba.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Subject: Re: [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Date: Fri, 03 Apr 2015 09:19:36 +1100 [thread overview] Message-ID: <1428013176.20500.285.camel@kernel.crashing.org> (raw) In-Reply-To: <20150402221505.GD15680@oracle.com> On Thu, 2015-04-02 at 18:15 -0400, Sowmini Varadhan wrote: > On (04/03/15 08:57), Benjamin Herrenschmidt wrote: > > > > > > I only just noticed too, you completely dropped the code to honor > > > > the dma mask. Why that ? Some devices rely on this. > > /* Sowmini's comment about this coming from sparc origins.. */ > > > Probably, not that many devices have limits on DMA mask but they do > > exist. It becomes more important if we decide to create a very large > > IOMMU window that spans beyond 4G in order to support devices with > > 32-bit DMA masks. Otherwise it's older devices mostly with <32-bit > > masks. > > > > In any case, for a generic piece of code, this should be supported. > > Basically, assume that if we have something in the powerpc code, we need > > it, if you remove it, we won't be able to use your code generically. > > I see. > > is the mask something that can be stored in the iommu_map_table as > part of the init? > No, the mask is per device and has to be retrieved from the device. Additionally the mask used for dma_map_* can be different from the consistent mask used for alloc_coherent (we have a bug there on powerpc which I'm trying to fix btw). So it should be passed as an argument by the caller. > I can see that the align_order has to be an additional arg to > iommu_tbl_range_alloc, not sure if mask falls in that category > as well. It does. Cheers, Ben.
next prev parent reply other threads:[~2015-04-02 22:19 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-31 14:40 [PATCH v8 RFC 0/3] Generic IOMMU pooled allocator Sowmini Varadhan 2015-03-31 14:40 ` Sowmini Varadhan 2015-03-31 14:40 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-03-31 14:40 ` Sowmini Varadhan 2015-03-31 15:15 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l David Laight 2015-03-31 15:15 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock David Laight 2015-03-31 15:25 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Sowmini Varadhan 2015-03-31 15:25 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-04-02 20:54 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Benjamin Herrenschmidt 2015-04-02 20:54 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Benjamin Herrenschmidt 2015-04-02 21:43 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Sowmini Varadhan 2015-04-02 21:43 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-04-02 21:57 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Benjamin Herrenschmidt 2015-04-02 21:57 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Benjamin Herrenschmidt 2015-04-02 22:01 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Benjamin Herrenschmidt 2015-04-02 22:01 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Benjamin Herrenschmidt 2015-04-02 22:02 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Benjamin Herrenschmidt 2015-04-02 22:02 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Benjamin Herrenschmidt 2015-04-02 22:15 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Sowmini Varadhan 2015-04-02 22:15 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-04-02 22:19 ` Benjamin Herrenschmidt [this message] 2015-04-02 22:19 ` Benjamin Herrenschmidt 2015-04-02 21:54 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Sowmini Varadhan 2015-04-02 21:54 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-04-02 22:08 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Benjamin Herrenschmidt 2015-04-02 22:08 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Benjamin Herrenschmidt 2015-04-03 0:42 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l David Miller 2015-04-03 0:42 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock David Miller 2015-04-03 18:28 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Sowmini Varadhan 2015-04-03 18:28 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-04-03 21:06 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Benjamin Herrenschmidt 2015-04-03 21:06 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Benjamin Herrenschmidt 2015-04-03 21:51 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Sowmini Varadhan 2015-04-03 21:51 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-04-04 11:27 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Sowmini Varadhan 2015-04-04 11:27 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan 2015-04-04 13:33 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and l Benjamin Herrenschmidt 2015-04-04 13:33 ` [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Benjamin Herrenschmidt 2015-03-31 14:40 ` [PATCH v8 RFC 2/3] sparc: Make sparc64 use scalable lib/iommu-common.c functions Sowmini Varadhan 2015-03-31 14:40 ` Sowmini Varadhan 2015-03-31 14:40 ` [PATCH v8 RFC 3/3] sparc: Make LDC use common iommu poll management functions Sowmini Varadhan 2015-03-31 14:40 ` Sowmini Varadhan 2015-03-31 18:06 ` [PATCH v8 RFC 0/3] Generic IOMMU pooled allocator Sowmini Varadhan 2015-03-31 18:06 ` Sowmini Varadhan 2015-03-31 18:08 ` David Miller 2015-03-31 18:08 ` David Miller 2015-04-01 1:01 ` Benjamin Herrenschmidt 2015-04-01 1:01 ` Benjamin Herrenschmidt 2015-04-01 1:08 ` Sowmini Varadhan 2015-04-01 1:08 ` Sowmini Varadhan 2015-04-01 3:12 ` David Miller 2015-04-01 3:12 ` David Miller 2015-04-02 12:51 ` Sowmini Varadhan 2015-04-02 12:51 ` Sowmini Varadhan 2015-04-02 16:21 ` David Miller 2015-04-02 16:21 ` David Miller 2015-04-02 20:22 ` Benjamin Herrenschmidt 2015-04-02 20:22 ` Benjamin Herrenschmidt 2015-04-02 20:52 ` Benjamin Herrenschmidt 2015-04-02 20:52 ` Benjamin Herrenschmidt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1428013176.20500.285.camel@kernel.crashing.org \ --to=benh@kernel.crashing.org \ --cc=aik@au1.ibm.com \ --cc=anton@au1.ibm.com \ --cc=davem@davemloft.net \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=paulus@samba.org \ --cc=sowmini.varadhan@oracle.com \ --cc=sparclinux@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.