* [PATCH v2] increase size of irq from uint8_t to uint32_t
@ 2015-04-08 9:29 Iurii Konovalenko
2015-04-08 9:29 ` [PATCH v2] arm: irq: " Iurii Konovalenko
0 siblings, 1 reply; 5+ messages in thread
From: Iurii Konovalenko @ 2015-04-08 9:29 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, ian.campbell, stefano.stabellini
From: Iurii Konovalenko <iurii.konovalenko@globallogic.com>
Changes in v2:
- Commit message edited
- Signed-off is set
Iurii Konovalenko (1):
arm: irq: increase size of irq from uint8_t to uint32_t
tools/libxc/include/xenctrl.h | 10 +++++-----
tools/libxc/xc_domain.c | 10 +++++-----
xen/include/public/domctl.h | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] arm: irq: increase size of irq from uint8_t to uint32_t
2015-04-08 9:29 [PATCH v2] increase size of irq from uint8_t to uint32_t Iurii Konovalenko
@ 2015-04-08 9:29 ` Iurii Konovalenko
2015-04-08 11:26 ` Julien Grall
0 siblings, 1 reply; 5+ messages in thread
From: Iurii Konovalenko @ 2015-04-08 9:29 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, ian.campbell, stefano.stabellini
From: Iurii Konovalenko <iurii.konovalenko@globallogic.com>
Changes are dedicated to XEN_DOMCTL_irq_permission and
IRQ pssthrough API functions.
Signed-off-by: Iurii Konovalenko <iurii.konovalenko@globallogic.com>
---
tools/libxc/include/xenctrl.h | 10 +++++-----
tools/libxc/xc_domain.c | 10 +++++-----
xen/include/public/domctl.h | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
index 44c7ac0..c08c4da 100644
--- a/tools/libxc/include/xenctrl.h
+++ b/tools/libxc/include/xenctrl.h
@@ -1401,7 +1401,7 @@ int xc_domain_ioport_permission(xc_interface *xch,
int xc_domain_irq_permission(xc_interface *xch,
uint32_t domid,
- uint8_t pirq,
+ uint32_t pirq,
uint8_t allow_access);
int xc_domain_iomem_permission(xc_interface *xch,
@@ -2087,7 +2087,7 @@ int xc_domain_unbind_msi_irq(xc_interface *xch,
int xc_domain_bind_pt_irq(xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq,
+ uint32_t machine_irq,
uint8_t irq_type,
uint8_t bus,
uint8_t device,
@@ -2096,7 +2096,7 @@ int xc_domain_bind_pt_irq(xc_interface *xch,
int xc_domain_unbind_pt_irq(xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq,
+ uint32_t machine_irq,
uint8_t irq_type,
uint8_t bus,
uint8_t device,
@@ -2105,14 +2105,14 @@ int xc_domain_unbind_pt_irq(xc_interface *xch,
int xc_domain_bind_pt_pci_irq(xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq,
+ uint32_t machine_irq,
uint8_t bus,
uint8_t device,
uint8_t intx);
int xc_domain_bind_pt_isa_irq(xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq);
+ uint32_t machine_irq);
int xc_domain_set_machine_address_size(xc_interface *xch,
uint32_t domid,
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index 95e3098..3132d19 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -1271,7 +1271,7 @@ int xc_vcpu_setcontext(xc_interface *xch,
int xc_domain_irq_permission(xc_interface *xch,
uint32_t domid,
- uint8_t pirq,
+ uint32_t pirq,
uint8_t allow_access)
{
DECLARE_DOMCTL;
@@ -1775,7 +1775,7 @@ int xc_domain_unbind_msi_irq(
int xc_domain_bind_pt_irq(
xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq,
+ uint32_t machine_irq,
uint8_t irq_type,
uint8_t bus,
uint8_t device,
@@ -1816,7 +1816,7 @@ int xc_domain_bind_pt_irq(
int xc_domain_unbind_pt_irq(
xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq,
+ uint32_t machine_irq,
uint8_t irq_type,
uint8_t bus,
uint8_t device,
@@ -1857,7 +1857,7 @@ int xc_domain_unbind_pt_irq(
int xc_domain_bind_pt_pci_irq(
xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq,
+ uint32_t machine_irq,
uint8_t bus,
uint8_t device,
uint8_t intx)
@@ -1870,7 +1870,7 @@ int xc_domain_bind_pt_pci_irq(
int xc_domain_bind_pt_isa_irq(
xc_interface *xch,
uint32_t domid,
- uint8_t machine_irq)
+ uint32_t machine_irq)
{
return (xc_domain_bind_pt_irq(xch, domid, machine_irq,
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 8803ab2..65fb866 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -400,7 +400,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_domctl_setdebugging_t);
/* XEN_DOMCTL_irq_permission */
struct xen_domctl_irq_permission {
- uint8_t pirq;
+ uint32_t pirq;
uint8_t allow_access; /* flag to specify enable/disable of IRQ access */
};
typedef struct xen_domctl_irq_permission xen_domctl_irq_permission_t;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm: irq: increase size of irq from uint8_t to uint32_t
2015-04-08 9:29 ` [PATCH v2] arm: irq: " Iurii Konovalenko
@ 2015-04-08 11:26 ` Julien Grall
2015-04-08 12:29 ` Iurii Konovalenko
0 siblings, 1 reply; 5+ messages in thread
From: Julien Grall @ 2015-04-08 11:26 UTC (permalink / raw)
To: Iurii Konovalenko, xen-devel
Cc: julien.grall, tim, ian.campbell, stefano.stabellini
Hi Iurii,
On 08/04/15 10:29, Iurii Konovalenko wrote:
> From: Iurii Konovalenko <iurii.konovalenko@globallogic.com>
>
> Changes are dedicated to XEN_DOMCTL_irq_permission and
> IRQ pssthrough API functions.
s/pssthrough/passthrough
It's worth noticing that PHYSDEV_* operations already using 32 bits type
but signed one. Many places in Xen (such as XSM) is using int to
describe IRQ too.
Although, PHYSDEV_* operations are not yet used on ARM and LPIs support
(which are using very high number) are not supported yet. So I think we
don't need to care about theses for now.
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm: irq: increase size of irq from uint8_t to uint32_t
2015-04-08 11:26 ` Julien Grall
@ 2015-04-08 12:29 ` Iurii Konovalenko
2015-04-08 12:32 ` Julien Grall
0 siblings, 1 reply; 5+ messages in thread
From: Iurii Konovalenko @ 2015-04-08 12:29 UTC (permalink / raw)
To: Julien Grall
Cc: Julien Grall, tim, Ian Campbell, Stefano Stabellini, xen-devel
Hi, Julien!
Do you mean I need to add your comment to commit message?
Best regards.
Iurii Konovalenko | Senior Software Engineer
GlobalLogic
On Wed, Apr 8, 2015 at 2:26 PM, Julien Grall <julien.grall@citrix.com> wrote:
>
> Hi Iurii,
>
> On 08/04/15 10:29, Iurii Konovalenko wrote:
> > From: Iurii Konovalenko <iurii.konovalenko@globallogic.com>
> >
> > Changes are dedicated to XEN_DOMCTL_irq_permission and
> > IRQ pssthrough API functions.
>
> s/pssthrough/passthrough
>
> It's worth noticing that PHYSDEV_* operations already using 32 bits type
> but signed one. Many places in Xen (such as XSM) is using int to
> describe IRQ too.
>
> Although, PHYSDEV_* operations are not yet used on ARM and LPIs support
> (which are using very high number) are not supported yet. So I think we
> don't need to care about theses for now.
>
> Regards,
>
> --
> Julien Grall
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm: irq: increase size of irq from uint8_t to uint32_t
2015-04-08 12:29 ` Iurii Konovalenko
@ 2015-04-08 12:32 ` Julien Grall
0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2015-04-08 12:32 UTC (permalink / raw)
To: Iurii Konovalenko
Cc: Julien Grall, tim, Ian Campbell, Stefano Stabellini, xen-devel
On 08/04/15 13:29, Iurii Konovalenko wrote:
> Do you mean I need to add your comment to commit message?
Yes please. It will keep track of why you only changes xc_domctl_*irq*
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-08 12:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-08 9:29 [PATCH v2] increase size of irq from uint8_t to uint32_t Iurii Konovalenko
2015-04-08 9:29 ` [PATCH v2] arm: irq: " Iurii Konovalenko
2015-04-08 11:26 ` Julien Grall
2015-04-08 12:29 ` Iurii Konovalenko
2015-04-08 12:32 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.