From: Krzysztof Opasiak <k.opasiak@samsung.com> To: balbi@ti.com, gregkh@linuxfoundation.org, jlbec@evilplan.org Cc: andrzej.p@samsung.com, m.szyprowski@samsung.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Krzysztof Opasiak <k.opasiak@samsung.com> Subject: [PATCH 0/5] Ensure that lun ids are contiguous Date: Wed, 08 Apr 2015 13:28:43 +0200 [thread overview] Message-ID: <1428492528-11993-1-git-send-email-k.opasiak@samsung.com> (raw) Dear list, This series fix configfs interface for mass storage function. According to mass storage specification[1]: "Logical Unit Numbers on the device shall be numbered contiguously starting from LUN 0 to a maximum LUN of 15 (Fh)." Currently configfs interface allows to create LUNs with arbitrary ids what causes problems with some host side mass storage drivers. This patch extends configfs interface with unlocked version of configfs_depend_item() which should be used only in configfs callbacks. This allows to protect from removing lun directory from the middle of id space. Example: as is: $ mkdir mass_storage.name $ mkdir lun.3 $ mkdir lun.5 $ rmdir lun.3 After this series: $ mkdir mass_storage.name $ mkdir lun.3 mkdir: cannot create directory 'lun.3': Invalid argument $ mkdir lun.1 $ mkdir lun.2 $ rmdir lun.1 rmdir: failed to remove 'lun.1': Device or resource busy $ rmdir lun.2 $ rmdir lun.1 -- Best regards, Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics Krzysztof Opasiak (5): fs: configfs: Fix typo in comment fs: configfs: Add unlocked version of configfs_depend_item() usb: gadget: mass_storage: Store lun_opts in fsg_opts usb: gadget: mass_storage: Ensure that lun ids are contiguous Documentation: ABI: Fix documentation for mass_storage function .../ABI/testing/configfs-usb-gadget-mass-storage | 7 +++- drivers/usb/gadget/function/f_mass_storage.c | 40 ++++++++++++++++++-- drivers/usb/gadget/function/f_mass_storage.h | 1 + fs/configfs/dir.c | 31 ++++++++++++++- include/linux/configfs.h | 9 +++++ 5 files changed, 82 insertions(+), 6 deletions(-) -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Opasiak <k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> To: balbi-l0cyMroinI0@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org Cc: andrzej.p-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Krzysztof Opasiak <k.opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Subject: [PATCH 0/5] Ensure that lun ids are contiguous Date: Wed, 08 Apr 2015 13:28:43 +0200 [thread overview] Message-ID: <1428492528-11993-1-git-send-email-k.opasiak@samsung.com> (raw) Dear list, This series fix configfs interface for mass storage function. According to mass storage specification[1]: "Logical Unit Numbers on the device shall be numbered contiguously starting from LUN 0 to a maximum LUN of 15 (Fh)." Currently configfs interface allows to create LUNs with arbitrary ids what causes problems with some host side mass storage drivers. This patch extends configfs interface with unlocked version of configfs_depend_item() which should be used only in configfs callbacks. This allows to protect from removing lun directory from the middle of id space. Example: as is: $ mkdir mass_storage.name $ mkdir lun.3 $ mkdir lun.5 $ rmdir lun.3 After this series: $ mkdir mass_storage.name $ mkdir lun.3 mkdir: cannot create directory 'lun.3': Invalid argument $ mkdir lun.1 $ mkdir lun.2 $ rmdir lun.1 rmdir: failed to remove 'lun.1': Device or resource busy $ rmdir lun.2 $ rmdir lun.1 -- Best regards, Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics Krzysztof Opasiak (5): fs: configfs: Fix typo in comment fs: configfs: Add unlocked version of configfs_depend_item() usb: gadget: mass_storage: Store lun_opts in fsg_opts usb: gadget: mass_storage: Ensure that lun ids are contiguous Documentation: ABI: Fix documentation for mass_storage function .../ABI/testing/configfs-usb-gadget-mass-storage | 7 +++- drivers/usb/gadget/function/f_mass_storage.c | 40 ++++++++++++++++++-- drivers/usb/gadget/function/f_mass_storage.h | 1 + fs/configfs/dir.c | 31 ++++++++++++++- include/linux/configfs.h | 9 +++++ 5 files changed, 82 insertions(+), 6 deletions(-) -- 1.7.9.5
next reply other threads:[~2015-04-08 11:29 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-08 11:28 Krzysztof Opasiak [this message] 2015-04-08 11:28 ` [PATCH 0/5] Ensure that lun ids are contiguous Krzysztof Opasiak 2015-04-08 11:28 ` [PATCH 1/5] fs: configfs: Fix typo in comment Krzysztof Opasiak 2015-04-09 13:46 ` Felipe Balbi 2015-04-09 13:46 ` Felipe Balbi 2015-04-09 14:50 ` Krzysztof Opasiak 2015-04-08 11:28 ` [PATCH 2/5] fs: configfs: Add unlocked version of configfs_depend_item() Krzysztof Opasiak 2015-04-08 11:28 ` [PATCH 3/5] usb: gadget: mass_storage: Store lun_opts in fsg_opts Krzysztof Opasiak 2015-04-09 13:47 ` Felipe Balbi 2015-04-09 13:47 ` Felipe Balbi 2015-04-08 11:28 ` [PATCH 4/5] usb: gadget: mass_storage: Ensure that lun ids are contiguous Krzysztof Opasiak 2015-04-08 11:28 ` Krzysztof Opasiak 2015-04-09 13:47 ` Felipe Balbi 2015-04-09 13:47 ` Felipe Balbi 2015-04-08 11:28 ` [PATCH 5/5] Documentation: ABI: Fix documentation for mass_storage function Krzysztof Opasiak 2015-04-08 11:28 ` Krzysztof Opasiak
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1428492528-11993-1-git-send-email-k.opasiak@samsung.com \ --to=k.opasiak@samsung.com \ --cc=andrzej.p@samsung.com \ --cc=balbi@ti.com \ --cc=gregkh@linuxfoundation.org \ --cc=jlbec@evilplan.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.