[Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license

[Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license

[Stefan Hajnoczi]

libxseg has changed license to GPLv3.  QEMU includes GPL "v2 only" code
which is not compatible with GPLv3.  This means the resulting binaries
may not be redistributable!

Disable Archipelago (libxseg) by default to prevent accidental license
violations.  Also warn if linking against libxseg is enabled to remind
the user.

Note that this commit does not constitute any advice about software
licensing.  If you have doubts you should consult a lawyer.

Cc: Chrysostomos Nanakos <cnanakos@grnet.gr>
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 configure | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

While libxseg reconsiders its license, let's disable it by default and warn
users that they need to carefully check whether the licenses are compatible.

diff --git a/configure b/configure
index 09c9225..9219ba3 100755
--- a/configure
+++ b/configure
@@ -327,7 +327,7 @@ seccomp=""
 glusterfs=""
 glusterfs_discard="no"
 glusterfs_zerofill="no"
-archipelago=""
+archipelago="no"
 gtk=""
 gtkabi=""
 vte=""
@@ -3173,6 +3173,12 @@ EOF
         archipelago="yes"
         libs_tools="$archipelago_libs $libs_tools"
         libs_softmmu="$archipelago_libs $libs_softmmu"
+
+	echo "WARNING: Please check the licenses of QEMU and libxseg carefully."
+	echo "GPLv3 versions of libxseg may not be compatible with QEMU's "
+	echo "license and therefore prevent redistribution."
+	echo
+	echo "To disable Archipelago, use --disable-archipelago"
     else
       if test "$archipelago" = "yes" ; then
         feature_not_found "Archipelago backend support" "Install libxseg devel"
-- 
2.1.0

Re: [Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license

[Andreas Färber]

Am 09.04.2015 um 15:52 schrieb Stefan Hajnoczi:
> libxseg has changed license to GPLv3.  QEMU includes GPL "v2 only" code
> which is not compatible with GPLv3.  This means the resulting binaries
> may not be redistributable!
> 
> Disable Archipelago (libxseg) by default to prevent accidental license
> violations.  Also warn if linking against libxseg is enabled to remind
> the user.
> 
> Note that this commit does not constitute any advice about software
> licensing.  If you have doubts you should consult a lawyer.

:)

> 
> Cc: Chrysostomos Nanakos <cnanakos@grnet.gr>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  configure | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> While libxseg reconsiders its license, let's disable it by default and warn
> users that they need to carefully check whether the licenses are compatible.
> 
> diff --git a/configure b/configure
> index 09c9225..9219ba3 100755
> --- a/configure
> +++ b/configure
> @@ -327,7 +327,7 @@ seccomp=""
>  glusterfs=""
>  glusterfs_discard="no"
>  glusterfs_zerofill="no"
> -archipelago=""
> +archipelago="no"
>  gtk=""
>  gtkabi=""
>  vte=""
> @@ -3173,6 +3173,12 @@ EOF
>          archipelago="yes"
>          libs_tools="$archipelago_libs $libs_tools"
>          libs_softmmu="$archipelago_libs $libs_softmmu"
> +
> +	echo "WARNING: Please check the licenses of QEMU and libxseg carefully."
> +	echo "GPLv3 versions of libxseg may not be compatible with QEMU's "

FWIW trailing space in argument (in case you send a pull yourself)

> +	echo "license and therefore prevent redistribution."
> +	echo
> +	echo "To disable Archipelago, use --disable-archipelago"

Since you change the default, that's not strictly necessary any more but
not wrong either.

>      else
>        if test "$archipelago" = "yes" ; then
>          feature_not_found "Archipelago backend support" "Install libxseg devel"

Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license

[Andreas Färber]

Am 09.04.2015 um 18:57 schrieb Andreas Färber:
> Am 09.04.2015 um 15:52 schrieb Stefan Hajnoczi:
>> libxseg has changed license to GPLv3.  QEMU includes GPL "v2 only" code
>> which is not compatible with GPLv3.  This means the resulting binaries
>> may not be redistributable!
>>
>> Disable Archipelago (libxseg) by default to prevent accidental license
>> violations.  Also warn if linking against libxseg is enabled to remind
>> the user.
>>
>> Note that this commit does not constitute any advice about software
>> licensing.  If you have doubts you should consult a lawyer.
> 
> :)
> 
>>
>> Cc: Chrysostomos Nanakos <cnanakos@grnet.gr>
>> Suggested-by: Kevin Wolf <kwolf@redhat.com>
>> Reported-by: Andreas Färber <afaerber@suse.de>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
[...]
> Reviewed-by: Andreas Färber <afaerber@suse.de>

Erm, on second thoughts the subject is missing an object and was
probably intended to say "disable Archipelago by default". ;)

> Thanks,
> Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH for-2.3] configure: disable by default and warn about libxseg GPLv3 license

[Peter Maydell]

On 9 April 2015 at 18:03, Andreas Färber <afaerber@suse.de> wrote:
> Am 09.04.2015 um 18:57 schrieb Andreas Färber:
>> Am 09.04.2015 um 15:52 schrieb Stefan Hajnoczi:
>>> libxseg has changed license to GPLv3.  QEMU includes GPL "v2 only" code
>>> which is not compatible with GPLv3.  This means the resulting binaries
>>> may not be redistributable!
>>>
>>> Disable Archipelago (libxseg) by default to prevent accidental license
>>> violations.  Also warn if linking against libxseg is enabled to remind
>>> the user.
>>>
>>> Note that this commit does not constitute any advice about software
>>> licensing.  If you have doubts you should consult a lawyer.
>>
>> :)
>>
>>>
>>> Cc: Chrysostomos Nanakos <cnanakos@grnet.gr>
>>> Suggested-by: Kevin Wolf <kwolf@redhat.com>
>>> Reported-by: Andreas Färber <afaerber@suse.de>
>>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> [...]
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Erm, on second thoughts the subject is missing an object and was
> probably intended to say "disable Archipelago by default". ;)

Thanks, applied to master with the missing object inserted and
the extraneous space removed.

-- PMM