[PATCH 1/2] doc/bindings: Add 'endianess' optional-property for FlexCAN controller

[PATCH 1/2] doc/bindings: Add 'endianess' optional-property for FlexCAN controller

[Bhupesh Sharma]

This patch adds 'endianess' as the optional-property for
describing the FlexCAN controller present on various FSL platforms.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
---
 .../devicetree/bindings/net/can/fsl-flexcan.txt    |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
index 56d6cc3..0d5e668 100644
--- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
+++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
@@ -18,6 +18,10 @@ Optional properties:
 
 - xceiver-supply: Regulator that powers the CAN transceiver
 
+- little-endian: If the FlexCAN IP on this SoC is little-endian, use
+                 this property. By default it is assumed that the IP
+                 is big-endian
+
 Example:
 
 	can at 1c000 {
-- 
1.7.9.5

[PATCH 2/2] arm/dts: Add nodes for flexcan devices present on LS1021A SoC

[Bhupesh Sharma]

From: Sakar Arora <Sakar.Arora@freescale.com>

This patch adds the device nodes for flexcan controller(s) present
on LS1021A SoC.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
---
 arch/arm/boot/dts/ls1021a-qds.dts |    8 ++++++++
 arch/arm/boot/dts/ls1021a.dtsi    |   20 ++++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
index 9c5e16b..1641a04 100644
--- a/arch/arm/boot/dts/ls1021a-qds.dts
+++ b/arch/arm/boot/dts/ls1021a-qds.dts
@@ -238,3 +238,11 @@
 &uart1 {
 	status = "okay";
 };
+
+&can0 {
+	status = "okay";
+};
+
+&can1 {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index c70bb27..c44661b 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -332,6 +332,26 @@
 			status = "disabled";
 		};
 
+		can0: can@2a70000 {
+			compatible = "fsl,ls1021a-flexcan";
+			reg = <0x0 0x2a70000 0x0 0x1000>;
+			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&platform_clk 1>;
+			clock-frequency = <150000000>;
+			clock-names = "per";
+			little-endian;
+		};
+
+		can1: can@2a80000 {
+			compatible = "fsl,ls1021a-flexcan";
+			reg = <0x0 0x2a80000 0x0 0x1000>;
+			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&platform_clk 1>;
+			clock-frequency = <150000000>;
+			clock-names = "per";
+			little-endian;
+		};
+
 		wdog0: watchdog@2ad0000 {
 			compatible = "fsl,imx21-wdt";
 			reg = <0x0 0x2ad0000 0x0 0x10000>;
-- 
1.7.9.5

[PATCH 2/2] arm/dts: Add nodes for flexcan devices present on LS1021A SoC

[Bhupesh Sharma]

From: Sakar Arora <Sakar.Arora@freescale.com>

This patch adds the device nodes for flexcan controller(s) present
on LS1021A SoC.

Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
---
 arch/arm/boot/dts/ls1021a-qds.dts |    8 ++++++++
 arch/arm/boot/dts/ls1021a.dtsi    |   20 ++++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
index 9c5e16b..1641a04 100644
--- a/arch/arm/boot/dts/ls1021a-qds.dts
+++ b/arch/arm/boot/dts/ls1021a-qds.dts
@@ -238,3 +238,11 @@
 &uart1 {
 	status = "okay";
 };
+
+&can0 {
+	status = "okay";
+};
+
+&can1 {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index c70bb27..c44661b 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -332,6 +332,26 @@
 			status = "disabled";
 		};
 
+		can0: can at 2a70000 {
+			compatible = "fsl,ls1021a-flexcan";
+			reg = <0x0 0x2a70000 0x0 0x1000>;
+			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&platform_clk 1>;
+			clock-frequency = <150000000>;
+			clock-names = "per";
+			little-endian;
+		};
+
+		can1: can at 2a80000 {
+			compatible = "fsl,ls1021a-flexcan";
+			reg = <0x0 0x2a80000 0x0 0x1000>;
+			interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&platform_clk 1>;
+			clock-frequency = <150000000>;
+			clock-names = "per";
+			little-endian;
+		};
+
 		wdog0: watchdog at 2ad0000 {
 			compatible = "fsl,imx21-wdt";
 			reg = <0x0 0x2ad0000 0x0 0x10000>;
-- 
1.7.9.5

[PATCH 1/2] doc/bindings: Add 'endianess' optional-property for FlexCAN controller

[Marc Kleine-Budde]

On 04/09/2015 04:51 PM, Bhupesh Sharma wrote:
> This patch adds 'endianess' as the optional-property for
> describing the FlexCAN controller present on various FSL platforms.
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
> ---
>  .../devicetree/bindings/net/can/fsl-flexcan.txt    |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 56d6cc3..0d5e668 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -18,6 +18,10 @@ Optional properties:
>  
>  - xceiver-supply: Regulator that powers the CAN transceiver
>  
> +- little-endian: If the FlexCAN IP on this SoC is little-endian, use
> +                 this property. By default it is assumed that the IP
> +                 is big-endian

Where's the code that's evaluating this property? On ARM little endian
is assumed so far, on powerpc (p1010) it's big endian.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150409/a1e76d34/attachment.sig>

[PATCH 2/2] arm/dts: Add nodes for flexcan devices present on LS1021A SoC

[Marc Kleine-Budde]

On 04/09/2015 04:51 PM, Bhupesh Sharma wrote:
> From: Sakar Arora <Sakar.Arora@freescale.com>
> 
> This patch adds the device nodes for flexcan controller(s) present
> on LS1021A SoC.
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
> ---
>  arch/arm/boot/dts/ls1021a-qds.dts |    8 ++++++++
>  arch/arm/boot/dts/ls1021a.dtsi    |   20 ++++++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
> index 9c5e16b..1641a04 100644
> --- a/arch/arm/boot/dts/ls1021a-qds.dts
> +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> @@ -238,3 +238,11 @@
>  &uart1 {
>  	status = "okay";
>  };
> +
> +&can0 {
> +	status = "okay";
> +};
> +
> +&can1 {
> +	status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index c70bb27..c44661b 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -332,6 +332,26 @@
>  			status = "disabled";
>  		};
>  
> +		can0: can at 2a70000 {
> +			compatible = "fsl,ls1021a-flexcan";
> +			reg = <0x0 0x2a70000 0x0 0x1000>;
> +			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&platform_clk 1>;
> +			clock-frequency = <150000000>;

Please don't use clock-frequency, it's only needed for powerpcs without
proper clock support.

> +			clock-names = "per";

Please provide a per and ipg clock, otherwise the driver will not work
properly.

> +			little-endian;
> +		};

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150409/ad99c47c/attachment.sig>

RE: [PATCH 2/2] arm/dts: Add nodes for flexcan devices present on LS1021A SoC

[bhupesh.sharma]

Hi Marc,

> From: Marc Kleine-Budde [mailto:mkl@pengutronix.de]
> 
> On 04/09/2015 04:51 PM, Bhupesh Sharma wrote:
> > From: Sakar Arora <Sakar.Arora@freescale.com>
> >
> > This patch adds the device nodes for flexcan controller(s) present on
> > LS1021A SoC.
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> > Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
> > ---
> >  arch/arm/boot/dts/ls1021a-qds.dts |    8 ++++++++
> >  arch/arm/boot/dts/ls1021a.dtsi    |   20 ++++++++++++++++++++
> >  2 files changed, 28 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts
> > b/arch/arm/boot/dts/ls1021a-qds.dts
> > index 9c5e16b..1641a04 100644
> > --- a/arch/arm/boot/dts/ls1021a-qds.dts
> > +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> > @@ -238,3 +238,11 @@
> >  &uart1 {
> >  	status = "okay";
> >  };
> > +
> > +&can0 {
> > +	status = "okay";
> > +};
> > +
> > +&can1 {
> > +	status = "okay";
> > +};
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index c70bb27..c44661b 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -332,6 +332,26 @@
> >  			status = "disabled";
> >  		};
> >
> > +		can0: can@2a70000 {
> > +			compatible = "fsl,ls1021a-flexcan";
> > +			reg = <0x0 0x2a70000 0x0 0x1000>;
> > +			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&platform_clk 1>;
> > +			clock-frequency = <150000000>;
> 
> Please don't use clock-frequency, it's only needed for powerpcs without
> proper clock support.

Ok. Will fix in v2.

> 
> > +			clock-names = "per";
> 
> Please provide a per and ipg clock, otherwise the driver will not work
> properly.

Ok. Will fix in v2.

> > +			little-endian;
> > +		};
> 

Regards,
Bhupesh

[PATCH 2/2] arm/dts: Add nodes for flexcan devices present on LS1021A SoC

[bhupesh.sharma at freescale.com]

Hi Marc,

> From: Marc Kleine-Budde [mailto:mkl at pengutronix.de]
> 
> On 04/09/2015 04:51 PM, Bhupesh Sharma wrote:
> > From: Sakar Arora <Sakar.Arora@freescale.com>
> >
> > This patch adds the device nodes for flexcan controller(s) present on
> > LS1021A SoC.
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> > Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
> > ---
> >  arch/arm/boot/dts/ls1021a-qds.dts |    8 ++++++++
> >  arch/arm/boot/dts/ls1021a.dtsi    |   20 ++++++++++++++++++++
> >  2 files changed, 28 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts
> > b/arch/arm/boot/dts/ls1021a-qds.dts
> > index 9c5e16b..1641a04 100644
> > --- a/arch/arm/boot/dts/ls1021a-qds.dts
> > +++ b/arch/arm/boot/dts/ls1021a-qds.dts
> > @@ -238,3 +238,11 @@
> >  &uart1 {
> >  	status = "okay";
> >  };
> > +
> > +&can0 {
> > +	status = "okay";
> > +};
> > +
> > +&can1 {
> > +	status = "okay";
> > +};
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index c70bb27..c44661b 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -332,6 +332,26 @@
> >  			status = "disabled";
> >  		};
> >
> > +		can0: can at 2a70000 {
> > +			compatible = "fsl,ls1021a-flexcan";
> > +			reg = <0x0 0x2a70000 0x0 0x1000>;
> > +			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&platform_clk 1>;
> > +			clock-frequency = <150000000>;
> 
> Please don't use clock-frequency, it's only needed for powerpcs without
> proper clock support.

Ok. Will fix in v2.

> 
> > +			clock-names = "per";
> 
> Please provide a per and ipg clock, otherwise the driver will not work
> properly.

Ok. Will fix in v2.

> > +			little-endian;
> > +		};
> 

Regards,
Bhupesh

[PATCH 1/2] doc/bindings: Add 'endianess' optional-property for FlexCAN controller

[bhupesh.sharma at freescale.com]

Hi Marc,

> From: Marc Kleine-Budde [mailto:mkl at pengutronix.de]
> 
> On 04/09/2015 04:51 PM, Bhupesh Sharma wrote:
> > This patch adds 'endianess' as the optional-property for describing
> > the FlexCAN controller present on various FSL platforms.
> >
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> > Signed-off-by: Sakar Arora <Sakar.Arora@freescale.com>
> > ---
> >  .../devicetree/bindings/net/can/fsl-flexcan.txt    |    4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > index 56d6cc3..0d5e668 100644
> > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > @@ -18,6 +18,10 @@ Optional properties:
> >
> >  - xceiver-supply: Regulator that powers the CAN transceiver
> >
> > +- little-endian: If the FlexCAN IP on this SoC is little-endian, use
> > +                 this property. By default it is assumed that the IP
> > +                 is big-endian
> 
> Where's the code that's evaluating this property? On ARM little endian is
> assumed so far, on powerpc (p1010) it's big endian.
> 

Here: http://thread.gmane.org/gmane.linux.can/7961

On LS1021A SoC, which is an ARM-v7 based SoC, the FlexCAN IP is big-endian.

Regards,
Bhupesh